Joe Li
4b221378cc
fix: Revert " #20095 - fix(database): make to display validation error msg when all … ( #21277 )
2022-08-31 16:56:56 -06:00
smileydev
d568999592
fix(database): make to display validation error msg when all cases ( #20095 )
...
* fix(database): make to display validation error msg when all cases
* fix(db): make to update the alert error condition
* fix(db): make to add error detail display
* fix(db): make to update error alert display by superset error style guide.
* fix(db): make to style modal header title with h4
* fix(db): make to place see more on bottom instead of top
* fix(db): make to fix shortly
* fix(db): make to fix lint issue
Co-authored-by: Evan Rusackas <evan@preset.io>
2022-08-24 11:29:22 -06:00
Hugh A. Miles II
e5e8867394
feat: Visualize SqlLab.Query model data in Explore 📈 ( #20281 )
2022-07-15 19:34:02 -04:00
Holger Bruch
6604a6ab28
chore(translations): Add missing i18n ( #17525 )
...
* Add *.ts to babel.cfg
* Add missing i18n calls
* Update pot file
* Fix lint issues and review comment
* Incorparate review feedback
* Fix missing or non-extractable i18n calls
* Update pot file
* Fix syntax error in CommonParameters.tsx
* Fix introduced issues
2021-11-27 14:50:33 +02:00
Yongjie Zhao
9070b6b19c
refactor(monorepo): stage 1 ( #17427 )
...
* skip geojson in pre-commit
update prettier
* update package.json
update package.json
u package
pkg
pkg2
* lint main repo 2
lint main repo
lint
* lintrc
lintrc 2
lintrc2
lintrc 3
lintrc
* fix import
* refresh lock file
* fix break line make @ts-ignore invalid
* update rat-excludes
rat-excludes
update rat-excludes
* update eslintrc.js
* lint lint lint
2021-11-17 15:31:36 +08:00
Grace Guo
96f4421961
fix: sql lab crash caused by invalid template ( #17133 )
2021-10-18 11:09:23 -07:00
Erik Ritter
153469dba9
fix: error alert levels again ( #17027 )
2021-10-11 12:28:36 -07:00
Geido
42efcdf027
chore(Dashboard): Implement dedicated message for missing dataset ( #16959 )
...
* Implement dedicated message
* Clean up
2021-10-08 17:01:00 +03:00
Erik Ritter
ea700384b3
fix: error alerts again ( #17026 )
2021-10-07 15:30:56 -07:00
Erik Ritter
03cdbac8bb
fix: error alerts js crash ( #17015 )
2021-10-07 13:09:54 -07:00
Evan Rusackas
66fbce9dec
chore: removing use of supersetTheme in favor of ThemeProvider ( #17000 )
2021-10-07 10:36:57 +03:00
John Bodley
4ba17092fa
fix: Ensure SupersetError.extra is always a dict ( #15848 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2021-07-24 10:19:30 +12:00
Phillip Kelley-Dotson
5d86b8dde6
refactor: remove old Icon component ( #15690 )
...
* remove old Icon component
* remove mock fn's
2021-07-14 14:04:56 -07:00
Hugh A. Miles II
d4480f5c9a
feat: Database Connection UI ( #14881 )
2021-07-01 14:40:27 -07:00
Beto Dealmeida
e606477ec1
feat: more SIP-40 errors ( #15482 )
2021-06-30 16:32:59 -07:00
Beto Dealmeida
149c5fd594
feat: add more SIP-40 errors to SQL Lab ( #15436 )
2021-06-29 18:17:16 -07:00
AAfghahi
743d9cc928
feat: Better Errors in SQL Lab ( #15432 )
...
* snowflake errors
* added big query
* added to setup error messages, first test
* all big query testing added
* added snowflake test
* added syntax error
* added syntax errors to most used databases
2021-06-29 16:48:27 -07:00
Beto Dealmeida
21d1fb55c6
feat: more error messages ( #15409 )
2021-06-28 14:51:31 -07:00
Phillip Kelley-Dotson
a3f4e4ad9e
refactor: icon to icons in erroralert component ( #15341 )
...
* initial commit
* initial commit
* lint
2021-06-24 18:05:22 -07:00
Phillip Kelley-Dotson
a477505291
refactor: icon to icons for basicerror componenet ( #15336 )
...
* initial commit
* initial commit
* fix test
* lint fix
* Update superset-frontend/src/components/ErrorMessage/BasicErrorAlert.tsx
Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
* lint
Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
2021-06-24 09:37:13 -07:00
Beto Dealmeida
241ee32f56
feat: custom error SQL Lab timeout ( #15342 )
...
* feat: custom error SQL Lab timeout
* Update test
2021-06-24 08:02:49 -07:00
Beto Dealmeida
4b00c152cc
feat: implement specific errors for SQL Lab ( #15206 )
...
* RESULTS_BACKEND_NOT_CONFIGURED_ERROR
* DML_NOT_ALLOWED_ERROR
* INVALID_CxAS_QUERY_ERROR
* Fix lint
* Add more tests
2021-06-23 07:58:20 -07:00
Beto Dealmeida
3f527c7a45
fix: font regression in SQL Lab ( #14960 )
...
* fix: font regression in SQL Lab
* Fix tests
2021-06-08 15:52:57 -07:00
Beto Dealmeida
31f406a526
feat: API endpoint to validate databases using separate parameters ( #14420 )
...
* feat: new endpoint for validating database parameters
* Rebase
* Remove broken tests
2021-05-12 18:32:10 -07:00
Hugh A. Miles II
392d8a8107
fix: Handle bad permission errors for bigquery test connections ( #14147 )
...
* starter make file
* yea
* move messaging to config
* Delete Makefile
* remove
* checkout
* check for db generic errors
* checkout bad files
* add proper message
* add docs for new permissions codes
* Update superset/errors.py
Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
* Update superset/errors.py
Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
* rename var
* starter regex
* fix
* fix
* fix linting
* update test
* yerp
* fixed test
* added regex
* Apply suggestions from code review
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* address comments
* update docs
* prettier
* fux
* add space
* Update errors.py
* Update types.ts
Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2021-04-20 19:19:36 -04:00
Michael S. Molina
b83ee46d0f
chore: Moves Modal to the components folder ( #14130 )
2021-04-16 15:49:53 -07:00
Beto Dealmeida
c7112d1c48
feat: error messages for Presto connections ( #14172 )
...
* chore: rename connection errors
* feat: error messages for Presto connections
* Add unit tests
* Update docs/src/pages/docs/Miscellaneous/issue_codes.mdx
Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
2021-04-16 15:49:47 -04:00
Beto Dealmeida
21c6efea67
chore: rename connection errors ( #14169 )
2021-04-15 10:57:02 -07:00
AAfghahi
eadff5f41e
feat: invalid DB name error messages (MySQL/Postgres/Redshift) ( #14146 )
...
* initial DB custom errors for mysql
* added redshift and postgres
2021-04-15 08:02:47 -07:00
AAfghahi
b77477a9dd
feat: invalid hostname and password error messages (MySQL) ( #14089 )
...
* custom errors for mySQL
* initial custom errors and tests for MySQL
* revisions
2021-04-13 14:42:31 -07:00
Beto Dealmeida
786dadc836
feat: invalid password error message (Postgres) ( #14038 )
2021-04-12 14:03:21 -07:00
Beto Dealmeida
c60a93db9c
feat: add extract_errors to Postgres ( #13997 )
...
* feat: add extract_errors to Postgres
* Add unit tests
* Fix lint
* Fix unit tests
2021-04-08 13:24:54 -07:00
Beto Dealmeida
a82d72fef6
feat: initial work to make v1 API compatible with SIP-40 and SIP-41 ( #13960 )
...
* WIP
* Use errorhandler
* Add response schema
* Fix status on HTTPException
* s/found/encountered/g
* Fix test
* Fix lint
* Fix lint and test
2021-04-06 22:06:32 -07:00
Beto Dealmeida
db57f90a34
feat: better error message when adding DBs ( #13601 )
...
* WIP
* Adding tests
* Add unit tests
* Show error message
* Fix lint
* Fix after rebase
2021-03-17 20:29:26 -07:00
Geido
7d270bced6
test: ErrorMessage components tests ( #13358 )
...
* Add tests for ErrorAlert
* Add BasicErrorAlert tests
* Add DatabaseErrorMessage tests
* Add useRedux property
* Finalize DatabaseErrorMessage tests
* Add ErrorMessageWithStackTrace tests
* Move getErrorMessageComponentRegistry test to dedicated directory
* Clean up getErrorMessageComponentRegistry
* Add IssueCode tests
* Add tests for ParameterErrorMessage
* Add tests for TimeoutErrorMessage
* Fix linting issue
2021-03-02 16:34:10 -08:00
Beto Dealmeida
3d23adec5e
chore: use shillelagh instead of gsheetsdb ( #13185 )
...
* chore: use shillelagh instead of gsheetsdb
* Fix tests
* Clean up code and remove duplication
* Fix test
* Tighten dep
2021-02-18 09:48:18 -08:00
Agata Stawarz
0c38134e5c
fix(native-filters): Reset column field for removed dataset ( #12519 )
...
* Reset column field for removed dataset
* Fix issue with cleaning exisiting field
* Fix lint error and remove unnecessary import
* Change message text for wrong filter
* Add Basic Error Alert component
* Fix hiding error after filter correction
2021-01-23 13:24:31 +08:00
Michael S. Molina
8532e6d9e1
Apply capitalization guidelines - iteration 2 ( #12343 ) ( #12448 )
2021-01-21 21:45:12 -08:00
Jesse Yang
9acf48fd1e
chore: upgrade eslint, babel, and prettier ( #12393 )
2021-01-10 17:26:35 -08:00
Michael S. Molina
8682c6fc1c
refactor: Fix anchor-is-valid lint warnings ( #12010 )
...
* Fix anchor-is-valid lint warnings
* Change IconTooltip to use named exports
2020-12-21 23:58:05 -08:00
Beto Dealmeida
ce1abc98df
chore: rename variable for clarity ( #12159 )
2020-12-21 13:39:13 -08:00
Beto Dealmeida
fa27ed1147
feat: display suggestions when query has missing parameters ( #12113 )
...
* WIP
* camelCase everything
* Hide 'fix did you mean?'
2020-12-18 16:08:30 -08:00
Beto Dealmeida
6e7f276775
feat: initial custom error messages for SQL Lab ( #12080 )
2020-12-17 22:58:21 -08:00
Beto Dealmeida
8bda6b0bd9
feat: show missing parameters in query ( #12049 )
...
* feat: show missing parameters in query
* Fix lint
* Address comments
* Simplify error message
* Use f-string in helper function
2020-12-15 18:47:40 -08:00
Victor Malai
329dcc314e
fix: Fix style for error modal ( #11996 )
...
* Fix style for error alert
* Revert test code
2020-12-15 00:03:53 -08:00
Kamil Gabryjelski
155b5edec1
refactor: Use Antd Modals instead of react-bootstrap Modals ( #11366 )
...
* Make Modal responsive
* ErrorAlert
* OmniContainer
* dashboard/PropertiesModal
* Fix e2e tests
* Lint fix
* E2E test fix
* Fix test
* Use grid units
* Change padding to padding-left/right
2020-10-27 13:08:04 -07:00
Maxime Beauchemin
b2af0c0e22
style(sqllab): make database errors more clear and render as monospace ( #11075 )
...
* style(sqllab): make database errors more clear and render as monospace
In SQL Lab, when a database error message is returned, generally because
of a user error in the SQL, it's identified as an "Unexpected Error" and
some of the text formatting of the error message (\n, spaces, tabs, ...)
are lost as they are rendered in html.
This PR identifies the error as a "Database Error", and renders like
more like a <pre>, using a monospace font.
* fix the build
* addressing comments
* addressed comments
* lint + removing cruft
* addressing comments
2020-10-06 12:50:38 -07:00
Erik Ritter
fa5dab85c4
feat: more specific presto error messages ( #11099 )
2020-09-29 21:50:58 -07:00
Evan Rusackas
eeeb21077d
feat: adding all icons from the design system to the codebase ( #11033 )
...
* error -> error-solid
* warning -> warning-solid
* all the new icons mixed in!
* card-view -> card_view
* circle-check-solid -> circle_check_solid
* corrected circle-check to new name and correct (stroke) icon
* sort-asc/desc -> sort_asc/desc
* databases -> database
* compass -> nav_explore
* pencil -> edit-alt
* more pencil migrations
* easy list view rename
* star -> favorite (changed in Figma)
* removing deprecated icon
* renaming icon to mach figma
* More -> More Horiz
* forgot to change this when ranming the file
* updating some icon names in use
* adding hella icons
* fixing errant viewboxes
* removing dropdown-arrow in favor of triangle-down
* adding key to storybook map.
* fixing icon component reference
* tweaks to fave star styling to support revised icon
* fixing a bad icon inclusion
* missed a license
* touchup to virtual dataset... will tweak later.
* e2e fix
* linting
2020-09-25 14:49:30 -07:00
Maxime Beauchemin
0870d3ae2b
docs: add back issue code links ( #10903 )
...
* docs: add back issue code links
closes: https://github.com/apache/incubator-superset/issues/10852
* Addressing comments
2020-09-16 09:28:53 -07:00
