Moriah Kreeger
6019113bc6
refactor: use rison for list view filters stateful urls ( #11675 )
2020-11-24 11:19:48 -08:00
Kamil Gabryjelski
3ad65bc163
fix: Dropdown menu not closing on Dashboard view ( #11671 )
2020-11-12 14:48:48 -08:00
ʈᵃᵢ
432e5ab460
feat: Query History CRUD list view ( #11574 )
2020-11-12 11:55:13 -10:00
Elizabeth Thompson
b277f19808
keep placeholder on multiselect ( #11289 )
2020-11-12 11:36:24 -08:00
Grace Guo
a9f9c4bbd5
[fix] handle null value in date filter ( #11655 )
2020-11-11 09:32:26 -08:00
Grace Guo
966a826720
fix: js unit test when save dash ( #11632 )
2020-11-09 17:56:30 -08:00
Grace Guo
b9284d3a3c
fix(dashboard): use server-side lastModifiedTime for co-edit check ( #11614 )
...
* fix: [dashboard][co-edit] Round client-side lastModifiedTime
* another try: server-side returns last_updated_time in save_dash response
2020-11-09 13:30:40 -08:00
Lily Kuang
dda95ed250
feat: annotation delete modal, bulk delete and empty state ( #11540 )
2020-11-09 11:25:16 -10:00
Jesse Yang
6ab03feed8
chore: clean up mountedTab ( #11569 )
2020-11-08 21:09:27 -08:00
Phillip Kelley-Dotson
d8373f2bb9
chore(home-screen): fixes for loading states, flicker issue, and reduction of api calls ( #11557 )
...
* fixes for loading states, flicker issue, api calls
* fix filter bug
* add high res images
* bug fixes for cards and face pile, change imgs to svgs, and address comments
* update from comments
* add stopprop
* fix tests
* add liscenses
* remove unused type
* fix types
* add license
* fix lint
2020-11-06 19:35:13 -08:00
Kamil Gabryjelski
6d5d92a6fe
fix: Issues with filters and metrics popovers ( #11578 )
...
* Fix bugs in AdhocFilterEditPopover
* Fix bugs in AdhocMetricEditPopover
* Remove handleMultiComparatorInputHeightChange function
* Fix tests
2020-11-05 20:00:43 -08:00
Kamil Gabryjelski
1490f3074d
refactor: Replace react-bootstrap MenuItems with Antd Menu ( #11554 )
...
* Refactor SliceHeaderControls
* Refactor DisplayQueryButton
* Fix duplicate keys
* Refactor SliceAdder
* Move css from styles to Emotion
* Fix e2e test
2020-11-05 13:30:03 -08:00
Kamil Gabryjelski
3e35ddd609
refactor: Replace react-bootstrap MenuItems with Antd Menu ( #11555 )
...
* Remove MenuItem from SubMenu
* Fix tests
* Refactor PopoverDropdown
* Refactor Button
* Remove redundant Menu import
2020-11-04 14:32:38 -08:00
Kamil Gabryjelski
128ddfabb6
fix: Pasting text issues in MetricsControl and AdhocFilterControl inputs ( #11445 )
...
* Fix paste not working in Metrics and Filter inputs
* Use noOp instead of empty function
* Use default Select component instead of OnPasteSelect
* Revert onPaste override
2020-11-04 13:48:48 -08:00
Kamil Gabryjelski
ad98981d9d
refactor: Replace react-bootstrap MenuItems with Antd Menu ( #11487 )
...
* Remove MenuItem from CopyToClipboard
* Refactor DateFilterControl
* fixup! Remove MenuItem from CopyToClipboard
* Remove console log
* Refactor LanguagePicker
* Refactor HeaderActionsDropdown
* Remove dir with Menu component
* Add imports to common/components/index
* Fix after rebase
2020-11-04 13:47:25 -08:00
Kamil Gabryjelski
937f9ca277
refactor: Replace react-bootstrap dialogs with Antd dialogs ( #11527 )
...
* Refactor Dialogs in dashboard properties modal
* Refactor Dialogs in explore properties modal
* Refactor dialogs in DatasourceModal
* Refactor dialogs in ExploreResultsButton
* Remove react-bootstrap-dialog from ExploreCtasResultsButton
* Remove react-bootstrap-dialog dependency
* Remove unnecessary functions from Modal
* Bump antd version to fix a bug
* Fix unit tests
* Fix e2e test
* Change antd version to 4.5.4 to fix tests
* Reenable all tests in control
* Another version bump to fix tests
2020-11-03 22:07:21 -08:00
Kamil Gabryjelski
15111db6c5
refactor: Use Antd Menu in Menu component ( #11528 )
...
* Menu dropdown refactored
* MenuObject refactored
* Fix unit tests
* Style menu
* Use theme variables
2020-11-03 16:19:15 -08:00
Moriah Kreeger
536346ff5e
feat: annotation layers delete logic + linking w/ annotation view ( #11530 )
2020-11-03 13:01:20 -08:00
Lily Kuang
eef4809978
feat: annotation edit modal with antd datepicker ( #11500 )
2020-11-03 12:59:13 -08:00
Jesse Yang
fac29f9dff
refactor: rewrite and enhance chart control withVerification ( #11435 )
...
* refactor: rewrite and enhance chart control withVerification
* Add toasts for failed messages; fixes popover render
2020-11-02 15:06:20 -08:00
David Aaron Suddjian
d7aa3d792b
fix(dashboard): multiple lines and indentation when editing json ( #11501 )
...
* multiple lines and indentation when editing json
* fix tests, address pr feedback
* remove json minification
2020-11-02 13:39:04 -08:00
Kamil Gabryjelski
a874b14a8a
refactor: Replace react-bootstrap Tabs with Antd Tabs in DashboardBuilder ( #11160 )
...
* Replace tabs in DashboardBuilder
* Fix tests
* Fix styling of anchor
* Fix
* Fix cypress test
* Fix tests
* Fix e2e tests
* Use data-tests
* Move tabs styles from superset.less to Emotion
* Restyle tabs in DashboardBuilder
* Test fix
* Fix styling
2020-11-02 13:31:55 -08:00
Kamil Gabryjelski
19f2deb27f
refactor: Replace react-bootstrap Modals with Antd in Explore ( #11389 )
...
* VizTypeControl
* SaveModal
* explore/PropertiesModal
* Fix e2e tests
* Remove console logs
* Fix tests
* Fix test
* Fix e2e test
* Remove unnecessary fragment
* Fix e2e tests
* Fix e2e test
2020-11-01 23:04:53 -08:00
Kamil Gabryjelski
55a3404b71
refactor: Replace react-bootstrap tabs with Antd tabs ( #11118 )
...
* Replace tabs in BuilderComponentPane
* Replace tabs in ControlPanelsContainer
* Replace tabs in AdhocMetricEditPopover
* Replace Tabs in DatasourceEditor
* Replace tabs in AdhocFilterEditPopover
* Replace tabs in DateFilterControl
* Bug fix
* Change Tab styles
* Fix tests
* Fix cypress tests
* Lint fix
* Fix tests
* Change Tabs style in ControlPanelsContainer
* Change tabs content height
* Lint fix
* Add data test
* Fix e2e test
* Move Tabs file to separate dir
* Fix after rebase
* Fix e2e tests
* Fix after rebase
2020-10-30 22:05:31 -07:00
Moriah Kreeger
01ddbd0697
feat: annotation layers modal + filters ( #11494 )
2020-10-30 15:51:46 -07:00
Phillip Kelley-Dotson
f7051eaade
feat: home screen mvp ( #11206 )
...
* step 1: broken stuff!
* first steps
* more adding and slicing
* step 1: broken stuff!
* can now filter dashboards/charts for "Edited" tabs (filter by changed_by o_m)
* more updates
* update recent card
* add icon
* Adding Expand Icon to Collapse component
* more updates
* clean up code
* remove lock file
* remove consoles
* fixing subnav button height shift
* lil' ascii arrows
* update branch
* update test part 1
* remove consoles
* fix typescript
* add images and update emptystate
* add changes
* update chart card
* fix css issues from rebase
* add suggestions
* more changes
* update tests and clear typescript errors
* Update superset-frontend/src/views/CRUD/welcome/ActivityTable.tsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* update from comments
* more updates..
* fix rebase
* fix pesky type errors
* test fixes
* lint fix
* Update superset-frontend/spec/javascripts/views/CRUD/welcome/Welcome_spec.tsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* Update superset-frontend/src/views/CRUD/welcome/EmptyState.tsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* Update superset-frontend/src/components/Menu/SubMenu.tsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* Update superset-frontend/src/components/ListViewCard/index.tsx
Co-authored-by: ʈᵃᵢ <tdupreetan@gmail.com>
* Update superset-frontend/src/components/ListViewCard/index.tsx
Co-authored-by: ʈᵃᵢ <tdupreetan@gmail.com>
* add suggestions
* fix lint
* remove unused code
* toast getrecentActivityobjs
* add some suggestions
* remove types for now
* cypress fix
* remove unused type
Co-authored-by: Evan Rusackas <evan@preset.io>
Co-authored-by: ʈᵃᵢ <tdupreetan@gmail.com>
2020-10-29 21:59:31 -07:00
David Aaron Suddjian
18658f45be
feat(dashboards): Filter status indicators ( #10936 )
...
* Initial commit of new filters badge.
* refactor applied/rejected filters code
* finished filter indicators
* filter badge tested
* unnecessary imports
* formatting and types
* fixes
* license
* code quality tweaks
* state management for showing focused filter scope
* clean up filter key extraction code
* remove unnecessary styles
* temp css to demonstrate highlighting
* fix focused filter logic
* no more color badges
* new toys for highlighting dash components (#11144 )
* tweak style for the filter chart when filter is focused
* style: Filters p0 css2 (#11151 )
* nixing background tweak
* src paths
* another quick theme color
* src paths, adjusting pill icon color, changing icons, showing applied/busted counts
* linting stuff
* fixing and tweaking tests
* show filter indicator when filters are not active
* chart title bar cleanup
* open the right panel when popover opens
* unused import
* fix EditableTitle tests
* margin on dashboard header
* show the chart dropdown menu
* fix blur filter breaking dropdowns
* style tweak - no pointer events when irrelevant charts are blurred
* fix box shadow on filter highlight
* it's an array
* attempt fixing e2e
* style: filters p0 icon churn (#11215 )
* new filters icon
* icon styling
* bigger icons in list views
* better sizing of table actions and favStars
* more icon sizing...
* fixing more button size jankiness
* linting
* Filters performance (#11255 )
* fixing time filter "ok" button
* making unset filter menu collapsible
* sort alphabetically
* fix highlighting when removing items
* try a flex layout (for browser render perf)
* more specific transitioning
* temp: comment out some code as a test
* temp: comment out more code
* temp: remove possibly expensive computations from ChartHolder
* Revert "temp: comment out some code as a test"
This reverts commit 309b880e90
.
* Revert "temp: comment out more code"
This reverts commit 64c88b2cba
.
* Revert "temp: remove possibly expensive computations from ChartHolder"
This reverts commit 37ce0214f0
.
* experiment: upgrade react-select to v3
* Revert "experiment: upgrade react-select to v3"
This reverts commit c3972ba486
.
* fix the damn problem
* remove code used for testing purposes
* awful hack to avoid adding a class to a container
* approaching infinity... and not beyond!
* fix ref forwarding
* add theme to tests as necessary
* fix(extra-filters): add logic for identifying applied extra filters (#11325 )
* fix: use dashboard id for stable cache key (#11293 )
* fix: button translations missing (#11187 )
* button translations missing
* blank space before text
* feat: update time_compare description and choices (#11294 )
* feat: update time_compare description and choices
* Update sections.jsx
* fix(extra-filters): add logic for identifying applied extra filters
* lint
Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>
Co-authored-by: rubenSastre <ruben.sastre@decathlon.com>
Co-authored-by: Erik Ritter <erik.ritter@airbnb.com>
* address design feedback
* slight tweak to panel logic, keep panels open that user has opened
* rearrange code to be more graceful
* fix: bump superset-ui/core (#11385 )
* use is_dttm instead of is_temporal
* types, names
* only show unset filter panel if there are unset filters
* fix highlighting the filter control
* fix filterbox layout
* translations
* fix cypress
* actually add the test attribute
* Update superset-frontend/src/dashboard/components/DashboardBuilder.jsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* Update superset-frontend/src/dashboard/components/DashboardBuilder.jsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* formatting
* add link comment to hack
* Update superset-frontend/src/dashboard/components/gridComponents/ChartHolder.jsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* stop importing lodash
* Update superset-frontend/src/dashboard/components/gridComponents/ChartHolder.jsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* skip broken test
* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* adjust colors of titles
* linting
* no indicators when chart is loading
* support all time fields
* fix lock file
Co-authored-by: Natalie Ruhe <natalie@preset.io>
Co-authored-by: Evan Rusackas <evan@preset.io>
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>
Co-authored-by: rubenSastre <ruben.sastre@decathlon.com>
Co-authored-by: Erik Ritter <erik.ritter@airbnb.com>
Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
2020-10-28 15:46:24 -07:00
Moriah Kreeger
e9dba18466
feat: annotation layers CRUD list view ( #11432 )
2020-10-28 15:45:07 -07:00
Kamil Gabryjelski
52294c836a
refactor: Replace react-bootstrap Modals with Antd in Datasource ( #11390 )
...
* ChangeDatasourceModal
* DatasourceModal
* DeleteModal, AddDatasetModal
* Fix tests
* Remove unused file
* Fix e2e tests
* Fix test
* Remove it.only
* Fix after rebase
* Fix e2e tests
* Fix data-test in modal
* Lint fix
2020-10-28 14:42:13 -07:00
Lily Kuang
e5e35634de
feat: annotations list CRUD view ( #11446 )
...
* annotations list CRUD view
* comment out modal
* update test
* fix lint
2020-10-28 12:19:50 -07:00
Kamil Gabryjelski
b2636f01bb
fix: Explore popovers issues ( #11428 )
...
* Fix spaces and comas not working in filter popover
* Fix popup not opening automatically
* Add e2e test
* Remove only from test
* Remove redundant test, add checking label content
* Add comments to e2e test
* Fix unit test
* Use destructuring
* Always open popup for functions and saved metrics, too
* Fix popover for adhoc metrics too
* Small refactor to consistency
* Refactor for consistency
* Remove redundant functions
* Test fix
Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>
2020-10-28 09:38:52 -07:00
Hugh A. Miles II
81f77fd28e
feat: hide datasource legacy based on featureflag ( #11371 )
2020-10-26 17:31:29 -07:00
Kamil Gabryjelski
894ca3c09b
refactor: Use Modals from Antd instead of react-bootstrap ( #11330 )
...
* Refactor ModalTrigger to use antd modal
* Refactor a few components
* dynamic width
* Fix unit tests
* Use i18n for button text
2020-10-26 11:20:10 -07:00
Jesse Yang
8aecffd83b
refactor: typing for explore Control and messageToasts ( #11416 )
2020-10-24 21:40:36 -07:00
Evan Rusackas
efdda8b69e
chore: Button cruft cleanup ( #11342 )
...
* toggleSchedule
* cleaning up run query button
* removing unnecessary (subtle!) style overrides
* bulk action classname to button style prop
* nixing btn-primary
* nixing cancelQuery class
* togglesave
* nixing autocomplete class
* linting
* nixing button classes of 'ok' and 'reset'
* unoing diagnostic test
* begrudgingly adding an m-r-3 class... for now
* this is not a class to worry about
* test fixes for limit control
* updating TODO notes, calling it a day for now.
* gah... copy paste error.
2020-10-23 10:42:29 -07:00
Kamil Gabryjelski
ad88a06d61
refactor: Use Antd Dropdown instead of react-bootstrap in DatasourceControl ( #11395 )
...
* Create Tooltip component
* Refactor DatasourceControl
* Bug fix
* Lint fix
* E2E test fix
* Move menu item keys to constants
* Remove LESS file
* Test fix
* Test fix
* Lint fix
2020-10-23 09:08:35 -07:00
Elizabeth Thompson
43b92b220f
fix: dashboard edit/save errors ( #10834 )
...
* use conditional operator for lookup
* editing dashboard title should update after save
* uncomment test
* fix json metadata save
* json metadata color scheme should overwrite state
* test's functionality is no longer applicable
* add lastModifiedTime to DashboardInfo
2020-10-22 14:33:22 -07:00
Kamil Gabryjelski
30c71fd794
refactor: Replace react-bootstrap tabs with Antd tabs on Profile ( #11211 )
...
* Create styled Antd Tabs and Dropdown
* Replace Tabs in Profile view
* Change some hard coded variables to theme
* Lint fix
2020-10-22 14:19:37 -07:00
Moriah Kreeger
a2a614d760
feat: CSS Templates List Actions ( #11271 )
2020-10-21 20:32:59 -07:00
Maxime Beauchemin
c360413fc2
style(menu): clean up right menu - leaving only "Settings" ( #11227 )
...
* style(menu): clean up right menu - leaving only settings
* bring pre-commit back
* fix frontend tests
* pre-commit
* re-introduce subtle '+'
2020-10-20 21:33:28 -07:00
Lily Kuang
6f3d4c131f
feat: css template add/edit modal ( #11296 )
2020-10-20 12:15:39 -07:00
Kamil Gabryjelski
901a42b1df
refactor: Replace usages of Popover from react-bootstrap with Antd ( #11163 )
...
* New popover component
* LimitControl
* Moar components migrated
* TimeSeriesColumnControl
* Hotkeys
* ColorPicker
* FilterBoxItemCOntrol
* AdhocFilterEditPopover
* AdhocMetric
* AnnotationLayerControl
* DateFilterControl
* Tests fix
* Fix linting issue
* Fix tests
* Bug fix
* Test fix
* Remove Antd global stylesheet
* Fix linting
* Fix test
* Fix test
* Fix test
* Fix test
* Fix test
2020-10-19 20:42:33 -07:00
Kamil Gabryjelski
735123d1f5
refactor: Refactor QueryTable to use react-table ( #11216 )
...
* Refactor QueryTable to use react-table
* Fix lodash import
* Fix tests
* Fix imports and QuerySearch styles
* Update superset-frontend/src/SqlLab/components/QuerySearch.jsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* Update superset-frontend/src/SqlLab/components/QuerySearch.jsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* Lint fix
* Refactored QueryTable into functional component
* Remove calculating content height
* Lint fix
Co-authored-by: Evan Rusackas <evan@preset.io>
2020-10-18 22:32:13 -07:00
Grace Guo
8863c939ad
fix: should update last_modified_time in client-side after save dash ( #11305 )
2020-10-16 10:54:35 -07:00
rubenSastre
4f0a06dda5
fix: button translations missing ( #11187 )
...
* button translations missing
* blank space before text
2020-10-15 21:27:26 -07:00
adam-stasiak-polidea
fc03549299
chore: Added data-test attributes for testing ( #11254 )
...
* Added data-test attributes for testing
* fixed incorrect naming change
* review changes
2020-10-14 16:12:01 -07:00
Erik Ritter
fc74b5d4a2
Revert "fix: keep placeholder in multivalue select when a value exists ( #11181 )" ( #11270 )
...
This reverts commit 31cc4155b7
.
2020-10-14 12:58:58 -07:00
Kamil Gabryjelski
820fa473a7
refactor: Implement TableView component ( #11217 )
2020-10-14 11:15:34 -07:00
Elizabeth Thompson
31cc4155b7
fix: keep placeholder in multivalue select when a value exists ( #11181 )
2020-10-13 13:45:31 -07:00
Grace Guo
88af85ac53
fix: show TIME COLUMN options in dashboard ( #11210 )
...
* fix: show TIME COLUMN options in dashboard
* add unit test
2020-10-12 21:43:30 -07:00