Commit Graph

4774 Commits

Author SHA1 Message Date
Will Barrett adf2cc2039 Re-enable pylint for some model files (#8770)
* Allow id as a valid name for pylint

* Re-enable pylint for superset/models/core.py

* re-enable pylint for superset/models/sql_lab.py

* re-enable pylint for superset/models/schedules.py

* re-enable pylint for superset/models/helpers.py

* re-enable pylint for superset/models/annotations.py

* re-enable pylint on superset/models/tags.py

* a couple more fixes after black formatting...

* Add another inline pylint disable

* Fix black

* Move to inline disables for 'id' attribute on models

* Fix lint disables after black reformatted them
2019-12-10 13:24:45 -08:00
Kim Truong 6c130b32ad
Update sql validator status (#8799)
* fix: update status code for sql validator error

* fix: inspect error

* fix: lint issues

* fix: lint issues 2
2019-12-10 11:55:36 -08:00
Bogdan e6be51953c Avoid circular dependency between superset config and superset package (#8254)
Resolve comments

Avoid circular dependency between superset config and superset package

Resolve comments
2019-12-10 09:17:34 +00:00
Will Barrett 7f8db7ab8d Re-enable pylint for common, connector, and test files (#8774)
* re-enable pylint for superset/common/query_context.py

* Re-enable pylint for superset/connectors/base/views.py

* re-enable pylint for superset/connectors/connector_registry.py

* Re-enable pylint for tests/fixtures/pyodbcRow.py

* re-enable pylint for superset/cli.py

* Fix for mypy

* Improve variable naming

* A few more naming fixes
2019-12-09 22:32:54 -08:00
Maxime Beauchemin 9f16d053e1
fix: don't show filter popover on explore view load (#8729)
* fix: don't show filter popover on explore view load

There's this confusing "feature" that I thought was a bug that shows the
metric popover opened when entering the explore view when the filter
comes from an active dashboard filter, based on the "fromFormData"
attribute of the filter.

The popover is confusing and often shows as misaligned with the actual
element it's supposed to float over when overflowing.

* warn

* fix cypress

* also shut off  metrics
2019-12-09 21:59:53 -08:00
Evan Rusackas 8b1022f66b darker opacity on shadow border for highlighted cards (#8797)
* darker opacity on shadow for highlighted cards

* removing unnecessary LESS fade

* lightening the lightest segment of the shadow again.
2019-12-09 21:58:59 -08:00
John Bodley 2fb95cc2b0
[fix] Adding time grains to DualLine (#8800) 2019-12-10 14:21:07 +13:00
Beto Dealmeida 5477f42740
Limit payload returned when using SQLLAB_BACKEND_PERSISTENCE (#8769)
* Limit queries

* WIP

* Adding unit test

* WIP

* Add unit test

* Fix test

* Try to fix remote unit tests

* Fix unit test

* Fix  for postgres
2019-12-09 16:12:40 -08:00
Daniel Vaz Gaspar 8a00168b63 Bump FAB to 2.2.1 (#8793) 2019-12-09 08:11:21 -08:00
Dinesh Sawant cae0583e0f Support timeFormat extraction function column for Druid in Filter (#8728) 2019-12-07 17:54:37 -08:00
Maxime Beauchemin 6ff086df3a
docs: add copyright notice to conform to ASF requirements (#8761)
This should make things green
here: https://whimsy.apache.org/pods/project/superset
2019-12-07 17:52:30 -08:00
Will Barrett 9c2b27f37a Re-enable Pylint on some celery-related files (#8765)
* Re-enable pylint for superset/tasks/schedules.py

* re-enable pylint for superset/tasks/celery_app.py
2019-12-07 17:52:08 -08:00
Bogdan c3f15b952d Do not delete schema permission on the table deletion (#8768) 2019-12-07 17:50:34 -08:00
Will Barrett cc49aae245 re-enable pylint for database compatibility layer (#8772)
* Re-enable pylint for superset/db_engines/hive.py

* re-enable pylint for superset/db_engine_specs/elasticsearch.py

* Re-enable superset/db_engine_specs/__init__.py

* Re-enable pylint for superset/db_engine_specs/exasol.py
2019-12-07 16:15:12 -08:00
Hossein Torabi d3f7fda778 fix create-admin (#8787) 2019-12-07 16:09:14 -08:00
Hossein Torabi b053d66ea7 fix urlib opener bug (#8788) 2019-12-07 16:07:09 -08:00
Will Barrett ed3944ebef Re-enable pylint for superset/utils folder (#8766)
* re-enable pylint for superset/utils/import_datasource.py

* re-enable pylint for superset/utils/cache.py

* re-enable pylint for superset/utils/log.py
2019-12-06 14:34:58 -08:00
Will Barrett 60892ae45d Re-enable pylint for example-related files (#8771)
* re-enable pylint for superset/examples/energy.py

* re-enable pylint for superset/examples/world_bank.py

* re-enable pylint for superset/examples/tabbed_dashboard.py

* Re-enable pylint for superset/examples/helpers.py
2019-12-06 14:30:50 -08:00
Will Barrett 68aca88c54 Re-enable pylint on some configuration files (#8767)
* re-enable pylint for superset/config.py

* re-enable pylint on superset/migrations/env.py

* re-enable pylint for superset/legacy.py

* re-enable pylint for superset/forms.py

* re-enable pylint for superset/stats_logger.py

* Tweaks to make mypy and pylint happy

* black
2019-12-06 14:30:11 -08:00
Craig Rueda 7dba3f54ee Adding updates to CONTRIBUTING and UPDATING for app factory changes (#8782)
* Adding updates to CONTRIBUTING and UPDATING for app factory changes

* Fixing celery_app:app
2019-12-06 13:15:12 -08:00
Craig Rueda a44635e309 Splitting up some of the Docker build steps (#8775)
* Splitting up some of the Docker build steps

* Adding dev target which includes requirements-extra / Updating docker configs to handle async query running
2019-12-05 16:47:22 -08:00
John Bodley 665e94784c
[fix] Adding time grains to PivotTable (#8764) 2019-12-05 09:55:33 -08:00
Craig Rueda 3bdf764f83 Removing upgrade of pip from Docker build (#8760) 2019-12-04 22:15:18 -08:00
ʈᵃᵢ f7c33680a4 adds react-router to welcome component (#8654)
* adds react-router to welcome component

* prettify

* empty commit
2019-12-04 18:23:53 -08:00
Erik Ritter 737c52541f
Bump viz plugins for bug bash (#8759) 2019-12-04 17:27:21 -08:00
John Bodley e72533506b [fix] Fixing time controls when switching datasource types (#8748)
* [fix] Fixing time controls when switching datasource types

* Update exploreReducer.js

* Update exploreReducer.js

* Fix linting
2019-12-04 16:55:08 -08:00
Maxime Beauchemin e127579fc8
fix: remove unused .js module (#8741)
* fix: remove unused .js module

* fix tests, remove more references

* lints
2019-12-04 16:51:05 -08:00
Evan Rusackas b107cc03bf SHA display touchups (#8614)
* Only showing last 8 chars of SHA

* visual touchups

* Grabbing first 8 rather than last 8

* 10 char SHA rather than 8

* atting config var for SHA length
2019-12-04 13:13:51 -08:00
Craig Rueda e55001b88f Fixing default Dockerfile entrypoint. Gunicorn needed a few tweaks (#8744) 2019-12-04 13:13:15 -08:00
John Bodley 3d2117809f
[fix] Remedying filter-box w/ invalid metrics (#8722) 2019-12-04 11:34:56 -08:00
Beto Dealmeida 5b934bb377
Change column to longtext (#8739)
* Change column to longtext

* Manual merge heads
2019-12-04 11:24:23 -08:00
ʈᵃᵢ a94464b9c9 guard against duplicate columns in datasource save (#8712)
* catch IntegrityError in datasource save

* catch duplicate columns and wrap in exception handling decorators

* use 409

* isort
2019-12-04 11:05:06 -08:00
michellethomas 98a82a0720 Adding error message when there's no partition for a presto table using latest_partition (#8745) 2019-12-04 11:03:50 -08:00
David Aaron Suddjian 0a5e4603c9 Correcting some issues with the Time-Series Table (#8746)
* default timeLag to 0

* correct placeholder

* remove random link default
2019-12-04 10:32:33 -08:00
ʈᵃᵢ c88bb591eb improve performance for filter form selects (#8757) 2019-12-04 10:05:02 -08:00
Daniel Vaz Gaspar 81e45acc43
[docs] Fix, UPDATING had two changes that were not included on 0.35 (#8754) 2019-12-04 17:04:21 +00:00
Daniel Vaz Gaspar 385484eb9d
[config] Enables swagger UI by default (#8732)
* [config] Enables swagger UI by default
2019-12-04 09:50:56 +00:00
John Bodley c74bb6cb9b
[fix] Updating bound filters for PyDruid 0.5.7 (#8742) 2019-12-03 17:44:04 -08:00
John Bodley 38782e260a
[charts] Chart specific time controls (#8674) 2019-12-03 17:41:51 -08:00
Grace Guo 89950440f2
[filter_box] Fix show time column in filter_box (#8740) 2019-12-03 17:02:09 -08:00
David Aaron Suddjian b0b93768bb handle nulls in bar chart series/breakdown (#8724)
* handle nulls in bar chart series/breakdown

* snake_case

* add tests for null groups in bar charts

* black

* comments will save us
2019-12-03 16:11:15 -08:00
ʈᵃᵢ 5e1a6eafe4 bump style-loader to fix FOUC when sourcemaps are enabled (#8738) 2019-12-03 16:07:24 -08:00
Craig Rueda a0b48f0f47 Fixing up Docker installation docs (#8735)
* Fixing up Docker installation docs

* Typo
2019-12-03 15:56:33 -08:00
David Aaron Suddjian f055231e52 require a series on a bar chart in the UI (#8726) 2019-12-03 15:30:12 -08:00
Bogdan 003e98c231 Support schema permissions (#8219)
* Build support for schema access in Superset and SQLab

* Lint
* Test for old and new flask
* Black formatting
* Cleanup modified files
* Support schema permissions
* Add migration
* Make it work for slices as well
* TODO and remove unused field
* Apply schema access check to dashboards as well

Cleaner schema permissions check

Fetch schema permissions in 1 query

Bugfix

Better datasource check

Use security manager for permissions checks and remove dead code

Properly handle anon user

Add database permissions on the database updates

Fix schema filtering

Lint / flake changes

Increase cypress request timeout

Run black

Resolve multiple alembic heads

* Use set comprehensions

* Fixes for the pylint
2019-12-03 14:57:24 -08:00
Erik Ritter 43f637e403
[Explore] Fix annotation layer select box formatting (#8734) 2019-12-03 13:13:42 -08:00
Beto Dealmeida f8e15e1c55
Add protocol to cache warmup (#8721)
* Add protocol to cache warmup

* Update unit tests

* Fix wrong commit

* Update UPDATING.md

* Fix pylint
2019-12-03 10:51:06 -08:00
Craig Rueda fce49680d7 Docker support (#8725)
* Moving Docker stuff around

* docker-compose working as expected

* Updating README

* Addressing comments

* Utilizing requirements-extra
2019-12-03 18:37:18 +00:00
Grace Guo 69dcaca324
[explore] should not triger chart render when overlay is on (#8719) 2019-12-03 10:36:15 -08:00
Beto Dealmeida 606ac3255d
Migrate filter_immune_slice_fields (#8718) 2019-12-03 10:26:54 -08:00