pt
/
superset
mirror of https://github.com/apache/superset.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Adding updates to CONTRIBUTING and UPDATING for app factory changes (#8782) 

* Adding updates to CONTRIBUTING and UPDATING for app factory changes

* Fixing celery_app:app
This commit is contained in:
Craig Rueda 2019-12-06 13:15:12 -08:00 committed by Maxime Beauchemin
parent a44635e309
commit 7dba3f54ee
2 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
CONTRIBUTING.md
View File

@ -370,6 +370,9 @@ superset load_examples
FLASK_ENV=development superset run -p 8088 --with-threads --reload --debugger
```
**Note: the FLASK_APP env var should not need to be set, as it's currently controlled
via `.flaskenv`, however if needed, it should be set to `superset.app:create_app()`**
If you have made changes to the FAB-managed templates, which are not built the same way as the newer, React-powered front-end assets, you need to start the app without the `--with-threads` argument like so:
`FLASK_ENV=development superset run -p 8088 --reload --debugger`
@ -387,7 +390,7 @@ def FLASK_APP_MUTATOR(app):
Then make sure you run your WSGI server using the right worker type:
```bash
FLASK_ENV=development gunicorn superset:app -k "geventwebsocket.gunicorn.workers.GeventWebSocketWorker" -b 127.0.0.1:8088 --reload
FLASK_ENV=development gunicorn "superset.app:create_app()" -k "geventwebsocket.gunicorn.workers.GeventWebSocketWorker" -b 127.0.0.1:8088 --reload
```
You can log anything to the browser console, including objects:
@ -456,7 +459,7 @@ If you run this service from somewhere other than your local machine, you may ne
npm install --global webpack webpack-cli webpack-dev-server
```
#### Docker
#### Docker (docker-compose)
See docs [here](docker/README.md)
@ -835,6 +838,10 @@ To do this, you'll need to:
from werkzeug.contrib.cache import FileSystemCache
RESULTS_BACKEND = FileSystemCache('/tmp/sqllab')
```
* Start up a celery worker
```shell script
celery worker --app=superset.tasks.celery_app:app -Ofair
```
Note that:
* for changes that affect the worker logic, you'll have to

4
UPDATING.md
View File

@ -38,6 +38,10 @@ defaults to False. To enable Druid-API-based functionality, override the
* [8450](https://github.com/apache/incubator-superset/pull/8450): The time range picker
now uses UTC for the tooltips and default placeholder timestamps (sans timezone).
* [8418](https://github.com/apache/incubator-superset/pull/8418): FLASK_APP / Worker App
have changed. FLASK_APP should be updated to `superset.app:create_app()` and Celery Workers
should be started with `--app=superset.tasks.celery_app:app`
## 0.35.0
* [8370](https://github.com/apache/incubator-superset/pull/8370): Deprecates