Commit Graph

4853 Commits

Author SHA1 Message Date
Michael S. Molina
480ee38917
chore: Updates control panels font size in Explore (#20510) 2022-06-28 09:16:59 -03:00
Yongjie Zhao
bbbe102887
feat(standardized form data): keep all columns and metrics (#20377) 2022-06-24 21:46:25 +08:00
Kamil Gabryjelski
c7f1c7d5bd
chore: Restructure explore redux state (#20448)
* chore: Restructure explore redux state

* fixes

* fix tests

* add new tests

* Fix type

* Address comments

* Fix bug

* Fix import

* Add new test

* Move unsaved chart id to a constant

* Add todo
2022-06-24 15:26:07 +02:00
John Bodley
661ab35bd0
fix: Re-add filter-box time granularity/column (#20485)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2022-06-23 12:42:40 -07:00
stevetracvc
a45d011e74
fix: issue with sorting by multiple columns in a table (#19920)
Recent commit to sort alphanumeric columns via case insensitive
comparison broke the multi-column sort option. React-table only sorts
by the second (or third...) column if the first column matches.
Since the alphanumeric sort only returned -1 or 1, it never would move
to the subsequent columns when the earlier column values matched.
2022-06-23 08:39:46 -03:00
Diego Medina
4dc30441b7
fix: alert & reports active toggle optimistic update (#20402) 2022-06-23 08:33:54 -03:00
Eric Briscoe
9f9aae49c9
chore: Convert QueryAutoRefresh to TypeScript functional React component [sc-48362] (#20179)
* git commit -m 'Convert QueryAutoRefresh to functional component [sc-48362]'

* addressing PR comments [sc-48362]

Removes unneeded props and state tracking of offline, adds finally block to simplify clearing pending request, simplifies value comparison in array by using includes in place of indexOf

* Address PR comment to use enum for QueryState [sc-48362]

Original implementation had string literals used in multiple places representing Query.state value options.  This commit creates a formal TypeScript enum for QueryState so we can remove string literals and ensure better consistency

* Address PR comments for object type validation [sc-48362]

This commit resolves an issue why the TypeScript typing for queryList was marked as a Query[] but was actually a Dictionary (associative array) or Queries.  A new type QueryDictionary has been added and the QueryAutoRefresh code was adjusted to use QueryDictionary instead of Query[] in appropriate places as well as unit tests.  Commit also removes QueryAutoRefreshContainer by making the once component using QueryAutoRefresh (which is already redux connected) pass the needed values on props.  this simplifies the code base and reduce files that need unit testing while keeping QueryAutoRefresh out of needing a redux connection directly.

* Addresses PR comment to add QueryState.SCHEDULED to runningQueryStateList [sc-48362]

In previous implementation 'scheduled' was not included int he list of Query States.  Further investigation shows it should be added to as a running state.

* Fix prettier lint error [sc-48362]

* Adjust unit tests for props update hoisting callbacks out of actions wrapper object [sc-48362]

* Update with changes from master [sc-48362]

Merges in updates from master and resolves conflicts from relocation of some of the Query TypeScript definitions into core

* Removes logic setting user offline and relying on results panel error message [sc-48362]

* Fixes bad import after some TypeScript definitions were relocated to core [sc-48362]

* Fixes TypeScript errors [sc-48362]
2022-06-22 13:20:02 -07:00
cccs-Dustin
daded10992
feat(SQL Lab): Make SQL Lab explore use the default viz from the config file (#20056)
* Modified SQL Lab so it uses the default viz to explore a new dataset with

* Added a comment to the config file

* Remove trailing whitespace

* [CLDN-1312] Removed the 'viz_type' variable so that when it is undefinded in the back-end, it gets set to the default viz

* [CLDN-1312] Only sets the 'all_columns' variable if the default viz type is a 'table'

* Will only pop 'selectedColumns' out of 'form_data' if it is present

* [CLDN-1312] Updated files so that the default viz is now being used again in SQL Lab Explore
2022-06-22 11:33:44 -06:00
smileydev
a833674a8d
fix(home): Show home page tabs as pills instead of links (#20257)
* fix(home): make to update the css style of links

* fix(home): make to fix lint issue

* fix(home): make to remove underline when tab is active

* fix(homes): make to fix the issue of tab

* fix(home): make to move styles to a tag
2022-06-21 17:44:48 -06:00
Michael S. Molina
ca526e63c8
feat: Adds support for clearing the Select cache (#20397)
* feat: Adds support for clearing the Select cache

* Fixes lint errors
2022-06-21 15:13:37 -03:00
Cody Leff
44c5e2879b
chore(newchart): update chart creation dataset selection help text, styles (#20369)
* Update dataset selection help text.

* Update 'Create a new chart' flow styles.

* Add support for linking directly to Create Dataset modal via URL hash.

* Add support for linking directly to Create Dataset modal via URL hash.

* Update dataset help text to not include spaces in translated strings and only include an 'Add dataset' link when user has permission to add dataset.

* Clean up test file

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2022-06-21 14:01:43 -03:00
smileydev
1ae935379f
fix(chart & table): make to prevent dates from wrapping (#20384) 2022-06-21 09:58:50 -03:00
Yongjie Zhao
9fad26fa19
fix: suppress translation warning in jest (#20404) 2022-06-21 20:38:58 +08:00
Diego Medina
93774d1860
fix: table viz sort icon bottom aligned (#20447) 2022-06-21 09:10:37 -03:00
Yongjie Zhao
c79b0d62d0
refactor: create echarts query section (#20445) 2022-06-21 11:38:07 +08:00
Sam Firke
b7eb235440
style(typo): occured -> occurred (#20116)
* Occured -> Occurred

* Occured -> Occurred

* Occured -> Occurred

* Occured - > Occurred

* Update FallbackComponent.tsx

* Update FallbackComponent.tsx

Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com>
2022-06-20 08:49:45 -07:00
Yongjie Zhao
111affdb02
chore: move xaxis to superset-ui (#20438) 2022-06-20 22:36:27 +08:00
Diego Medina
c2f01a676c
fix(dashboard): new created chart did not have high lighted effect when using the permalink of chart share in dashboard (#20411) 2022-06-19 08:17:06 -06:00
Lily Kuang
ab9f72f1a1
fix(embedded): CSV download for chart (#20261)
* move postForm to superset client

* lint

* fix lint

* fix type

* update tests

* add tests

* add test for form submit

* add test for request form

* lint

* fix test

* fix tests

* more tests

* more tests

* test

* lint

* more test for postForm

* lint

* Update superset-frontend/packages/superset-ui-core/test/connection/SupersetClientClass.test.ts

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>

* update tests

* remove useless test

* make test cover happy

* make test cover happy

* make test cover happy

* make codecov happy

* make codecov happy

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
2022-06-17 20:01:08 -07:00
Cody Leff
9f74fb7a84
Skip flaky Cypress test. (#20417) 2022-06-17 10:24:58 -06:00
jiAng
f6f93aad37
fix(cosmetic): cannot find m-r-10 class in superset.less (#20276)
* fix(cosmetic): cannot find m-r-10 class in superset.less

* fix: remove .m-r-10 class and use emotion instead

* Update superset-frontend/src/components/Datasource/CollectionTable.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/components/Datasource/DatasourceEditor.jsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2022-06-17 08:54:27 -03:00
Stephen Liu
fa7f144a68
fix: rm eslint-plugin-translation-vars engine requirement (#20420) 2022-06-17 14:29:57 +08:00
Stephen Liu
b32288fddf
fix(bar-chart-v2): remove marker from bar chart V2 (#20409) 2022-06-17 10:52:26 +08:00
Smart-Codi
a8a6b732e9
adding extra metrics after chart configuration (#20410) 2022-06-16 12:55:14 -06:00
Kamil Gabryjelski
c959d92dd1
feat(plugin-chart-echarts): Support stacking negative and positive values (#20408) 2022-06-16 13:58:58 +02:00
Stephen Liu
1665403484
fix(plugin-chart-pivot-table): color weight of Conditional formatting metrics not work (#20396)
* fix(plugin-chart-pivot-table): color weight of Conditional formatting metrics not work

* fix: test
2022-06-16 12:22:09 +08:00
Reese
498987a1a0
Prevent dataset edit modal closing on click-away in edit mode (#20278) 2022-06-15 14:28:13 -06:00
Michael S. Molina
d6f9fb5af1
chore: Removes unused vars (#20194)
* chore: Removes unused vars

* Fixes lint

* Disables no-unused-vars for the operators
2022-06-15 11:01:45 -03:00
Yongjie Zhao
0a50a9b380
feat: setting limit value when Pie chart switches (#20392) 2022-06-15 21:49:00 +08:00
Yongjie Zhao
7c252d7524
feat: adding truncate metric control on timeseries charts (#20373) 2022-06-15 20:55:10 +08:00
smileydev
df8bb46ee2
fix(fonts): Show the all the A's in our workspace correctly, not funky (#20361)
* fix(fonts): make to fix the issue of broking the Inter font char A

* fix(css & fonts): make to install from npmjs.org
2022-06-15 00:28:54 -06:00
Diego Medina
ead10401e7
fix: A newly connected database doesn't appear in the databases list if user connected database using the 'plus' button (#20363)
* fix: A newly connected database doesn't appear in the databases list if user connected database using the 'plus' button

* PR comments
2022-06-14 17:47:37 -06:00
Phillip Kelley-Dotson
160e674b90
fix: update connection modal to use existing catalog (#20372)
* fix: update connection modal to use existing catalog

* remove console
2022-06-14 15:10:01 -04:00
Kamil Gabryjelski
86f146e217
feat(explore): Implement viz switcher redesign (#20248)
* add icons

* Implement fast viz switcher component

* Remove unnecessary keys from ControlsPanelContainer

* Rename icons

* Add unit tests

* Add licenses

* Fix test

* Change BigNumberWithTrendline to BigNumber

* fix test

* fix test

* Add currently rendered viz tile

* Move View all charts to the right side

* Add license

* Fix imports

* Fix e2e test
2022-06-14 15:20:54 +02:00
John Bodley
c3fdd52697
fix(VERSIONED_EXPORTS): Ensure dashboards and charts adher to the VERSIONED_EXPORTS feature flag (#20368)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2022-06-13 18:39:15 -07:00
Diego Medina
e1532f63ac
fix: query execution time is not fully displayed in bubble icon (#20364) 2022-06-13 14:30:00 -06:00
Michael S. Molina
cb2ffa530f
chore: Removes no-use-before-define warnings (#20298) 2022-06-13 07:44:34 -03:00
Diego Medina
8345eb4644
fix: A newly connected database doesn't appear in the databases list if user connected database using the 'plus' button (#19967)
* fix: A newly connected database doesn't appear in the databases list if user connected database using the 'plus' button

* include onDatabaseAdd on successful import
2022-06-12 22:21:30 +08:00
Lyndsi Kay Williams
c842c9e2d8
feat(explore): Dataset Panel Options when Source = Query II (#20299)
* Created/tested query dataset dropdown

* Add isValidDatasourceType to @superset-ui/core and hide query dropdown

* Removed isValidDatasourceType check

* Remove the rest of isValidDatasourceType check
2022-06-10 09:55:52 -07:00
Cody Leff
d0165b617b
chore(dashboard): update Edit Dashboard side panel tabs (#20337)
* Reorder Dashboard Edit tabs and rename 'Components' tab to 'Layout Elements'.

* Add tests for BuilderComponentPane.

* Fix Cypress tests, capitalization, test nesting.
2022-06-10 12:57:32 -03:00
Stephen Liu
07b4a7159d
fix(chart): chart gets cut off on the dashboard (#20315)
* fix(chart): chart gets cut off on the dashboard

* add some failsafe

* address comment
2022-06-09 22:59:58 +08:00
Kamil Gabryjelski
354a89950c
feat(explore): Denormalize form data in echarts, world map and nvd3 bar and line charts (#20313)
* feat(explore): Apply denormalize form data function to echarts and world map

* Denormalize form data in mixed timeseries

* Add dist bar chart
2022-06-09 11:54:09 +02:00
Yongjie Zhao
d04357c47b
fix: superset-ui/core codes coverage (#20324) 2022-06-09 17:43:42 +08:00
Yongjie Zhao
fd129873ce
feat: multiple results pane on explore and dashboard (#20277) 2022-06-09 09:11:34 +08:00
smileydev
1e5cacda8f
fix(explore): make to fix the issue of explore error broken when see more/less (#20282) 2022-06-08 17:00:08 -06:00
Diego Medina
5bfc95e79e
feat: When editing the label/title in the Metrics popover, hitting Enter should save what you've typed (#19898)
* feature: When editing the label/title in the Metrics popover, hitting Enter should save what you've typed

* Apply emotion templating to input/input labels
2022-06-08 16:52:53 -06:00
Stephen Liu
eab0009101
feat(plugin-chart-echarts): [feature-parity] support extra control for the area chart V2 (#16493)
* feat(echarts): [feature-parity] support extra control

* add extra control for plugin

* refactor: extract ExtraControl

* fix: lint

* fix some problems
2022-06-09 00:59:10 +08:00
Hugh A. Miles II
b6c11f2b97
fix: Alpha are unable to perform a second modification to a Dataset when in Explore (#20296)
* handle payload coming back from save

* address concerns
2022-06-08 16:24:36 +02:00
Reese
a57ed76e72
Fix faulty datetime parser regex (#20290) 2022-06-08 22:02:58 +08:00
Stephen Liu
9f02ff656d
fix(plugin-chart-echarts): [feature-parity] apply button of annotation layer doesn't work as expected (#19761)
* fix(plugin-chart-echarts): [feature-parity] apply button of annotation layer does't work

* fix: lint

* fix: test
2022-06-08 17:06:24 +08:00