* remove ENABLE_REACT_CRUD_VIEWS feature flag
* docs
* deal with problematic tests
* empty test suite
* skip test
* test conditions changed
* removing the tests instead of skipping
* make that the comma can be added by removing it from token separators in select component.
* fix(explore comma): add the allowTokenSeperators props into Select
* fix(explore comma): make to allow to customize the token separators in Select.
* fix(explore comma): make to add the unit test and story book.
* fix(explore comma): make to fix the lint
* fix(explore comma): make to fix the spell & add tokenSeparatprs props to PickedSelectProps
* Update Select.tsx
* fix(explore comma): make to run lint fix
* fix: allow to select <NULL> in a native filter single mode
* fix lint issue
* Update superset-frontend/src/components/Select/utils.ts
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* fix
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Empty states updated on result tab and query history tab
* Testing on query history blank state
* Testing on result tab with empty state
* Forgot to remove a comment
* Corrected empty state image size and centered with drag bar
* Centered blank states vertically
* first pass migrating config to ff
* nixing a console log from testing
* adding an entry to `UPDATING.md`
* linting ✨
* Adding ENABLE_JAVASCRIPT_CONTROLS to FEATURE_FLAGS.md
* no longer in need of state!
* Turning the flag back off
* linting... le sigh
* and more linting...
* fix(chartviz): make to allow the custome of x & y axis title margin in chart
* fix(chartviz): add eslint radix error in chart.js
* fix(chartviz): change the transformProps in chart plugin & creat helper.
* fix(chartviz): lint fix & chart.js back
* fix(plugin-chart-echarts): make to allow the custom margin of X & y axis in BoxPlot & Mixedtimeseries charts
* fix(plugin-chart-echarts): make to change changeNumber to changeInteger
* fix(plugin-chart-echarts): make to add license & change file name
* fix(altered-modal): make all text fields wrap
* fix(altered-modal): limit the wrap text in particular column
* fix(altered-modal): make to update the unit test
* fix(altered-modal): make to fix the type of columnsForWrapText
* fix(alerted-modal): make to fix the type of columnsForWrapTest with string type
* fix: display null values in time-series table and sortable
* add unit test
* fix unit test
* Add sortNumericValues with different nan treatment
Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>
* wip
* add force cahce bypass option to alerts
* remove default for alerts to bypass cache
* save for now
* save for now
* fix
* commenting out for now
* fix linting
* remove link
* add back force id test
* add frontend test
* address
* Added in code changes that now properly increment the Untitled Query SQL Lab tab names. All that is left is to add tests to make sure that the function works correctly
* Updated the code so that it adds to the untitled_query_numbers variable only if the character after the string 'Untitled Query ' is a number. This prevents any issues when trying to get the maximum value in the list.
* Refactored part of the mapping code, to make it shorter and easier to read/understand
* Fixed issues in the code that were causing some of the CI tests to fail
* Made code changes based on comments within the PR. Also added a unit test to make sure that the newQueryEditor function in the TabbedSqlEditors component works as intended
* Fixed the failing cypress test in tabs.test.js
* converted file to functional component
* refactor: convert class component to functional component
* refactor: convert class component to functional"
* Working on converting the shouldCheckForQueries test to RTL
* Working on converting first test to RTL
* Working on first test for queryAutoRefresh
* Finished Tests, pushing for review
* Cleaned up comments and console logs
Co-authored-by: Josue Lugaro <josuelugaro15@gmail.com>
* Empty SQL table message on zero tabs
* sql editor no editor tab bug fix
* Revert Error message
* empty state tab state
* added a unit test
* addressed reviews
* kasia feedback
Co-authored-by: Yahya Kayani <yahyakiani1@gmail.com>
* chore: add intersect method from be to font end
* fix lint
* add suggestion
* fix python test
* run precommit
* fix pytlint
* update changes from masters
* more data nav menu
* fix lint and fix nav css
* update test and remove icons
* Update superset-frontend/src/views/components/Menu.test.tsx
Co-authored-by: Hugh A. Miles II <hughmil3s@gmail.com>
* Apply suggestions from code review
* use backend app.link to show new nav changes
* fix lint
* update test
* usetheme and remove chaining
* add more suggestions
* fix lint
* working global db connection
* add allowed extensions to bootstrap and hard code links
* remove backend links
* fix test
* apply stashed gsheets
* fix check for google sheets
* setup gsheets
* add extensions to frontend conf
* fix test and add be changes
* remove package json changes
* test is python test passes
* update python test and reremove app links
* fix tslint issues
* fix other linting tools
* fix pylint
* fix test
* fix
* refactor
* fix lint
* working fixed test
* clean up test
* address concerns
* address concerns
* change to tenarary
Co-authored-by: Phillip Kelley-Dotson <pkelleydotson@yahoo.com>
* fix(15849): Removed the tooltip from CopyToClipboard button in sqllab
* chore(sqllab): added props for tooltip in CopyToClipboard component
* fix(sqllab): Added arg to storybook and refactor the component
* fix(sqllab): added a test case for hideTooltip
* fix(delete-modal): Changed the color of the help text with grayScale.dark1 in DeleteModal
* Update superset-frontend/src/components/DeleteModal/index.tsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* more data nav menu
* fix lint and fix nav css
* update test and remove icons
* Update superset-frontend/src/views/components/Menu.test.tsx
Co-authored-by: Hugh A. Miles II <hughmil3s@gmail.com>
* Apply suggestions from code review
* use backend app.link to show new nav changes
* fix lint
* update test
* usetheme and remove chaining
* add more suggestions
* fix lint
* add allowed extensions to bootstrap and hard code links
* remove backend links
* fix test
* add extensions to frontend conf
* fix test and add be changes
* test is python test passes
* update python test and reremove app links
* fix ts and add t's
Co-authored-by: Hugh A. Miles II <hughmil3s@gmail.com>
* fix errors with rison and useQueryParams
* add test for encode/decode
* add rison link and make test case more readable
Co-authored-by: Corbin Robb <corbin@Corbins-MacBook-Pro.local>
* add sorting for query results grid and add natural order sort
* modify tests for natural/original order state
* clean up setState
Co-authored-by: Corbin Robb <corbin@Corbins-MacBook-Pro.local>
* feat(dashboard): Implement empty states for dashboard
* Add empty state to native filters
* Add missing license
* Remove redundant string types from EmptyState
* chore: fix misspelling of button
* changed QuerySearch/index.jsx to index.tsx
* updated Query type at src/SqlLab/types.ts/Query and extended it into QueryTable
* updated defaultQueryLimit to be optional at ResultSetProps of superset-frontend/src/SqlLab/components/ResultSet/index.tsx
* moved statusAttributes into useMemo hook so that it will not make the dependencies of useMemo Hook change on every render and statusAttributes is only used within useMomo hook
* reset package-lock.json and package.json at frontend
* Acquired redux rootestate type for SqlLab, to be used at useSelector(state)
* updated query to be Query type and added a comment for q.status on line 178
* updated queryTable for typescript conversion
* updated actions type on QueryHistory and QuerySearch
* updated type for actions in SouthPane
* created type for SqlLab redux
Co-authored-by: David Woolner <davidwoolner@gmail.com>
Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
* feat(explore): Allow using time formatter on temporal columns in data table
* Fix data table loading
* Return colnames and coltypes from results request
* Fix types
* Fix tests
* Fix copy button
* Fix df is none
* Fix test
* Address comments
* Move useTimeFormattedColumns out of useTableColumns
* Make reducer more readable
* chore: fix misspelling of button
* Feat: Update ExploreCtasResultsButton to functional component
* Fix pull request
* Fix index.tsx
* Fix prettier issues and actions
* Streamline the onClick so it calls visualize directly
* Update MSP and MDP to arrow functions
* Test destructured props
* Fix props destructuring error
* Simplify with optional chaining on line 94 and clean up buildVizOptions
Co-authored-by: David Woolner <davidwoolner@gmail.com>
Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
* feat(explore): Keep or reset chart config after datasource change
* Update copy
* Remove useDispatch
* fix test
* Fix bugs
* Remove ts ignore
* Scroll top when datasource changes
* Fix crashing when switching viz type
* fix: Explore long URL problem
* Fixes lint problems
* Fixes default value
* Removes duplicated test
* Fixes share menu items
* Fixes tests
* Debounces form_data updates
* Rewrites debounce function
* Moves history update outside the functional component
* Mocks lodash function in tests
* Fixes Cypress test
* Fixes Cypress test #2
* Creating draft PR to address bug
* Still working on solving re rendering bug
* Cleaning up in preparation for push
* Starting conversion to TypeScript
* Working on conversion
* Continued working on typescript conversion, referenced other files for different types, still a rough version of final product
* Added type assertion to actions in props, and added types to some component functions
* Progress on typescript conversion
* Fixed typing issue on collapseStyles
* Fixed styling on div, child of StyledScrollbarContainer
* Attempting to address issues with the actions passed into the TableElement
* Resolved typescript warning on actions of the TableElement component
* Made changes suggested by Arash
* Tested the component without dbId, cleaned up lingering comments
* Made more changes suggested by Arash, removed offline from the SqlEditorLeftBarProps interface
* Made change suggested by Hugh
* Changed the expanded type from any to boolean
* feat(dashboard): embedded dashboard UI configuration (#17175) (#17450)
* setup embedded provider
* update ui configuration
* fix test
* feat: Guest token (for embedded dashboard auth) (#17517)
* generate an embed token
* improve existing tests
* add some auth setup, and rename token
* fix the stuff for compatibility with external request loaders
* docs, standard jwt claims, tweaks
* black
* lint
* tests, and safer token decoding
* linting
* type annotation
* prettier
* add feature flag
* quiet pylint
* apparently typing is a problem again
* Make guest role name configurable
* fake being a non-anonymous user
* just one log entry
* customizable algo
* lint
* lint again
* 403 works now!
* get guest token from header instead of cookie
* Revert "403 works now!"
This reverts commit df2f49a6d4.
* fix tests
* Revert "Revert "403 works now!""
This reverts commit 883dff38f1.
* rename method
* correct import
* feat: entry for embedded dashboard (#17529)
* create entry for embedded dashboard in webpack
* add cookies
* lint
* token message handshake
* guestTokenHeaderName
* use setupClient instead of calling configure
* rename the webpack chunk
* simplified handshake
* embedded entrypoint: render a proper app
* make the embedded page accept anonymous connections
* format
* lint
* fix test
# Conflicts:
# superset-frontend/src/embedded/index.tsx
# superset/views/core.py
* lint
* Update superset-frontend/src/embedded/index.tsx
Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
* comment out origins checks
* move embedded for core to dashboard
* pylint
* isort
Co-authored-by: David Aaron Suddjian <aasuddjian@gmail.com>
Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
* feat: Authorizing guest access to embedded dashboards (#17757)
* helper methods and dashboard access
* guest token dashboard authz
* adjust csrf exempt list
* eums don't work that way
* Remove unnecessary import
* move row level security tests to their own file
* a bit of refactoring
* add guest token security tests
* refactor tests
* clean imports
* variable names can be too long apparently
* missing argument to get_user_roles
* don't redefine builtins
* remove unused imports
* fix test import
* default to global user when getting roles
* missing import
* mock it
* test get_user_roles
* infer g.user for ease of tests
* remove redundant check
* tests for guest user security manager fns
* use algo to get rid of warning messages
* tweaking access checks
* fix guest token security tests
* missing imports
* more tests
* more testing and also some small refactoring
* move validation out of parsing
* fix dashboard access check again
* add more test
Co-authored-by: Lily Kuang <lily@preset.io>
* feat: Row Level Security rules for guest tokens (#17836)
* helper methods and dashboard access
* guest token dashboard authz
* adjust csrf exempt list
* eums don't work that way
* Remove unnecessary import
* move row level security tests to their own file
* a bit of refactoring
* add guest token security tests
* refactor tests
* clean imports
* variable names can be too long apparently
* missing argument to get_user_roles
* don't redefine builtins
* remove unused imports
* fix test import
* default to global user when getting roles
* missing import
* mock it
* test get_user_roles
* infer g.user for ease of tests
* remove redundant check
* tests for guest user security manager fns
* use algo to get rid of warning messages
* tweaking access checks
* fix guest token security tests
* missing imports
* more tests
* more testing and also some small refactoring
* move validation out of parsing
* fix dashboard access check again
* rls rules for guest tokens
* test guest token rls rules
* more flexible rls rules
* lint
* fix tests
* fix test
* defaults
* fix some tests
* fix some tests
* lint
Co-authored-by: Lily Kuang <lily@preset.io>
* SupersetClient guest token test
* Apply suggestions from code review
Co-authored-by: Lily Kuang <lily@preset.io>
Co-authored-by: Lily Kuang <lily@preset.io>
* feat(explore): add toasts feedback when user copies chart url
* Show toast message when updating chart properties
* Change toast type to success when saving chart
* Use success toast from props
* Fix tests
* Use withToasts instead of dispatch
* Use PropertiesModalProps instead of any