Commit Graph

20 Commits

Author SHA1 Message Date
Yongjie Zhao
927d066f70
chore: move isAdhocColumn from controls to core (#20529)
* chore: move isAdhocColumn to superset-ui/core

* ut
2022-06-29 13:09:44 +08:00
Yongjie Zhao
c348a095b9
refactor(standardized form data): refine interface and improve code smells (#20518) 2022-06-28 21:09:42 +08:00
Lyndsi Kay Williams
ba0c37d3df
feat(explore): Frontend implementation of dataset creation from infobox (#19855)
* Frontend implementation of create dataset from infobox

* Fixed sl_dataset type

* Fix test

* Fixed sl_dataset type (forgot to save)

* RTL testing

* Adjusted styling/text on infobox and save dataset modal

* Appease lint

* Make infobox invisible and fix tests

* Remove unnecessary placeholder

* Move types to sql lab

* Moved logic into save dataset modal

* Change DatasourceMeta type to Dataset

* Add ExploreDatasource union type to save dataset modal

* Get user info from redux inside save dataset modal

* Addressed comments

* Adjusting to new query type

* Fixed save dataset in explore and union type

* Added testing

* Defined d for queries

* Remove dataset from SaveDatasetModal

* Clarify useSelector parameter

* Fix dndControls union type

* Fix shared-controls union type

* Fix controlPanel union type

* Move ExploreRootState to explore type file

* Remove unnecessary testing playground

* Move datasource type check in DatasourcePanel to a function

* Make all sqllab Query imports reference @superset-ui/core Query type

* Deconstruct query props in ResultSet

* Fix union type in /legacy-plugin-chart-heatmap/src/controlPanel

* Change SaveDatasetModal tests to RTL

* Cleaned datasourceTypeCheck

* Fix infobox styling

* Fix SaveDatasetModal test

* Fix query fixture in sqllab and Query type in SaveDatasetModal test

* Fix Query type and make test query fixture

* Added columns to Query type, separated results property, created QueryResponse union type, and fixed all types affected

* Fixed a couple missed broken types

* Added ExploreDatasource to SqlLab type file

* Removed unneeded Query import from DatasourcePanel

* Address PR comments

* Fix columnChoices

* Fix all incorrect column property checks

* Fix logic on dndGroupByControl

* Dry up savedMetrics type check

* Fixed TIME_COLUMN_OPTION

* Dried savedMetrics type check even further

* Change savedMetricsTypeCheck to defineSavedMetrics

* Change datasourceTypeCheck to isValidDatasourceType

* Fix Query path in groupByControl

* dnd_granularity_sqla now sorts Query types with is_dttm at the top

* Fixed/cleaned query sort

* Add sortedQueryColumns and proper optional chaining to granularity_sqla

* Move testQuery to core-ui, add test coverage for Queries in columnChoices

* Moved DEFAULT_METRICS to core-ui and wrote a test for defineSavedMetrics

* Add license and clean dataset test object

* Change DatasourceType.Dataset to dataset
2022-06-07 15:03:45 -05:00
Yongjie Zhao
dd4b581fb5
feat: standardized form_data (#20010) 2022-06-05 21:05:01 +08:00
Diego Medina
22b7496d2e
fix: string aggregation is incorrect in PivotTableV2 (#19102)
* fix: string aggregation is incorrect in PivotTableV2

* cleanup

* fix

* updates
2022-05-23 12:39:18 -06:00
Geido
1fe30f1f0e
Add tnum property to tables (#20093) 2022-05-18 16:26:29 +02:00
Michael S. Molina
b7cff8335b
chore: Removes hard-coded colors from the plugins - iteration 1 (#19923)
* chore: Removes hard-coded colors from the plugins - iteration 1

* Fixes lint errors

* Fixes tests
2022-05-09 10:44:13 -03:00
Michael S. Molina
e9032e95ec
chore: Adds theme object to chart properties (#19951) 2022-05-04 09:55:22 -03:00
Michael S. Molina
31095a523d
chore: Removes plugin-chart-pivot-table hard-coded colors (#19439) 2022-03-31 13:30:36 -03:00
Stephen Liu
6f5778273e
chore: add type checking in plugin test directory (#19387) 2022-03-28 10:20:06 +08:00
Kamil Gabryjelski
a8a48af7fa
chore: Make font-weights themable, fix font faces (#19236)
* fix(fonts): Import all necessary font packages

* Make html tags themable

* Set bold font weight to 600, add medium font weight to theme

* Replace hard coded font weights with theme variables

* Change some font weight light elements to normal

* Fix tests

* Fix bug in pivot table

* Address code review comments
2022-03-22 09:36:15 +01:00
Diego Medina
0e0beceac1
fix: Pivot Table Conditional Formatting Doesn't Show All Options (#19071)
* fix: Pivot Table Conditional Formatting Doesn't Show All Options

* PR comments

* PR comments
2022-03-09 15:04:04 -07:00
Yongjie Zhao
e91b9a678f
refactor: move superset-ui dependencies to peerDependencies (#17965)
* chore: add commit message

* update learn

* update superset-ui-demo

* move superset-ui into peerDeps

* add --no-private argument in lerna version

* fix conflicts

* refresh lock file
2022-01-11 13:53:37 +08:00
Yongjie Zhao
cb97e37a92
refactor: import value name from root of superset-ui/core (#17947)
* chart

* index and number-format

* char-composition and color

* connection

* dimension and math-expression

* models

* query

* time-format

* residual modules

* change config of jest and eslint

config

* wip

update package.json

* fix lint

* WithLegend import from superset-ui/core
2022-01-08 09:16:24 +08:00
Kamil Gabryjelski
2c3f39f3f2
feat(plugin-chart-pivot-table): support series limit (#17803)
* feat(plugin-chart-pivot-table): support series limit

* Add a migration

* Use non-legacy series limit controls

* Add a todo comment

* Bug fix
2021-12-21 16:58:54 +01:00
Erik Ritter
6edc183c5f
chore: Refactor localstorage into typesafe version (#17832) 2021-12-20 13:58:59 -08:00
Kamil Gabryjelski
b5dca4ebfe
chore(plugin-chart-pivot-table): swap order of Columns and Rows controls (#17798) 2021-12-17 14:32:49 +01:00
Kamil Gabryjelski
9c9edbe8bc
chore(plugin-chart-pivot-table): migrate react-pivottable into superset codebase (#17769)
* chore(plugin-chart-pivot-table): migrate react-pivottable into superset codebase

* Fix lint errors

* Use named export

* Clean up the code
2021-12-17 12:00:32 +01:00
Kamil Gabryjelski
e8ce8733f7
chore(plugin-chart-pivot-table): Add more descriptive tooltips for sorting [ID-29] (#17634)
* chore(plugin-chart-pivot-table): Add more descriptive tooltips for sorting

* Update superset-frontend/plugins/plugin-chart-pivot-table/src/plugin/controlPanel.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/plugins/plugin-chart-pivot-table/src/plugin/controlPanel.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

Co-authored-by: Evan Rusackas <evan@preset.io>
2021-12-02 12:53:14 -07:00
Yongjie Zhao
3c41ff68a4
refactor(monorepo): move superset-ui to superset(stage 2) (#17552) 2021-11-30 08:29:57 +08:00