Jason Davis
c0bb86d0d6
feat: slack integration for SQL-based alerts ( #10566 )
...
* add slack functionality
* deleted unused variable
* updated test
* black
* fix rebase
* added nits
* added slack no screenshot integration
* isort
* added namedtuple for screenshot
* added test
* fix precommit
Co-authored-by: Jason Davis <@dropbox.com>
2020-08-11 11:15:31 -07:00
Jason Davis
8b9292ed05
fix: add retry to SQL-based alerting celery task ( #10542 )
...
* added retry and minimized sqlalchemy object lives
* pylint
* added try catch
* adjusted naming
* added scoped session
* update tests for dbsession
* added requested changes
* nit todo
Co-authored-by: Jason Davis <@dropbox.com>
2020-08-10 10:20:43 -07:00
Erik Ritter
fd2d1c58c5
Revert "chore: Cleanup database sessions ( #10427 )" ( #10537 )
...
This reverts commit 7645fc85c3
2020-08-06 15:33:48 -07:00
Jason Davis
9c5b0e1c86
fix: refactored SQL-based alerts to not pass sqlalchemy objects as args ( #10506 )
...
* refractored alerting to not pass sqlalchemy obj as args
* updated to pass only alert id as arg
* used object id instead of argument
* updated alerts_tests.py to reflect change
Co-authored-by: Jason Davis <@dropbox.com>
2020-08-04 09:52:32 -07:00
John Bodley
7645fc85c3
chore: Cleanup database sessions ( #10427 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2020-07-30 23:07:56 -07:00
Jason Davis
7a329c25e9
feat: add test email functionality to SQL-based email alerts ( #10476 )
...
* added test email functionality
* formatting changes
* more formatting
* applied requested changes
* mypy
Co-authored-by: Jason Davis <@dropbox.com>
2020-07-30 13:27:22 -07:00
Jason Davis
d065633c81
fix: Implement updates to SQL-based email alerts ( #10454 )
...
* implemented updates to alerting
* fixed imports and teardown
* changed unittest to pytest conventions
* add app_context to tests
Co-authored-by: Jason Davis <@dropbox.com>
2020-07-28 16:48:42 -07:00
