Commit Graph

5520 Commits

Author SHA1 Message Date
Craig Rueda 2aaa4d92d9
chore: Migrating reports to AuthWebdriverProxy (#10567)
* Migrating reports to AuthWebdriverProxy

* Extracting out webdriver proxy / Adding thumbnail tests to CI

* Adding license

* Adding license again

* Empty commit

* Adding thumbnail tests to CI

* Switching thumbnail test to Postgres

* Linting

* Adding mypy:ignore / removing thumbnail tests from CI

* Putting ignore statement back

* Updating docs

* First cut at authprovider

* First cut at authprovider mostly working - still needs more tests

* Auth provider tests added

* Linting

* Linting again...

* Linting again...

* Busting CI cache

* Reverting workflow change

* Fixing dataclasses

* Reverting back to master

* linting?

* Reverting installation.rst

* Reverting package-lock.json

* Addressing feedback

* Blacking

* Lazy logging strings

* UPDATING.md note
2020-08-12 13:28:41 -07:00
John Bodley 8fb304d665
docs: Update engine installation (#10509)
* Update installation.rst

* Update installation.rst

Co-authored-by: John Bodley <john.bodley@airbnb.com>
2020-08-12 09:58:42 -07:00
Ville Brofeldt 85c0cad816
fix: add None checking to cast_to_num (#10584)
* fix: add None checking to cast_to_num

* fix doctest
2020-08-12 19:58:14 +03:00
Erik Ritter a8197976fe
fix: error message modal overflow (#10580) 2020-08-11 17:20:39 -07:00
Erik Ritter a45f28ed2c
Update .asf.yaml (#10581) 2020-08-11 13:17:25 -07:00
Jesse Yang 1b111b677e
feat(table-viz): translation and metric column header align right (#10549) 2020-08-11 12:56:32 -07:00
Stuart Hu 890b3ca489
fix: add translate for dropdown menu (#10573)
* fix: translate dropdown menu

Signed-off-by: Stuart Hu <shijiehu@improbable.io>

* Apply suggestions from code review

Co-authored-by: iriswonderland13 <69527796+iriswonderland13@users.noreply.github.com>

Co-authored-by: Erik Ritter <erik.ritter@airbnb.com>
Co-authored-by: iriswonderland13 <69527796+iriswonderland13@users.noreply.github.com>
2020-08-11 12:26:49 -07:00
Jason Davis c0bb86d0d6
feat: slack integration for SQL-based alerts (#10566)
* add slack functionality

* deleted unused variable

* updated test

* black

* fix rebase

* added nits

* added slack no screenshot integration

* isort

* added namedtuple for screenshot

* added test

* fix precommit

Co-authored-by: Jason Davis <@dropbox.com>
2020-08-11 11:15:31 -07:00
Daniel Vaz Gaspar b7650b9f57
fix: disable false positive error (#10576) 2020-08-11 18:20:57 +01:00
David Aaron Suddjian 83af9d12f8
fix(sqllab): Handle long table names in SQL Lab (#10518)
* widen the autocomplete menu for table names

* display the full table name in a tooltip

* license

* Update superset-frontend/src/SqlLab/components/AceEditorWrapper/index.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* src importing

* move autocomplete width css to main.less

* use html title attribute instead of tooltip

Co-authored-by: Evan Rusackas <evan@preset.io>
2020-08-11 09:50:46 -07:00
Jesse Yang a37b635674
fix(dashboard): add animation state to fix tab switch re-renders (#10475) 2020-08-11 00:57:50 -07:00
Maxime Beauchemin 613dd12fbf
fix: misaligned LimitControl buttons and port jsx->tsx (#10529)
* fix: misaligned LimitControl buttons and port jsx->tsx

* addressed comments
2020-08-10 15:35:39 -07:00
Bogdan 0071d374da
chore: move load examples to the fixture (#10545)
* Move load examples to the fixture

* Update tests/celery_tests.py

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* Address feedback

Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2020-08-10 13:20:19 -07:00
Hossein Torabi 8190dcb61f
fix drill installation (#10558) 2020-08-10 11:39:46 -07:00
Bogdan 101e5b670b
chore: clean up csv tests (#10556)
* Clean up csv tests

* Update tests/base_tests.py

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* Update tests/base_tests.py

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* import optional

* Fix mypy error

Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2020-08-10 11:22:38 -07:00
Jason Davis 8b9292ed05
fix: add retry to SQL-based alerting celery task (#10542)
* added retry and minimized sqlalchemy object lives

* pylint

* added try catch

* adjusted naming

* added scoped session

* update tests for dbsession

* added requested changes

* nit todo

Co-authored-by: Jason Davis <@dropbox.com>
2020-08-10 10:20:43 -07:00
John Bodley 5e944e5730
fix: Resolves #10535 (#10536)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2020-08-10 09:59:34 -07:00
Craig Rueda 5a908d4513
fix: Updating Dockerfile to work with updated python requirements. (#10550)
* Updating Dockerfile to work with updated python requirements.

* Adding a Docker build step to CI workflow

* Trying docker build-push

* Linting Dockerfile-dev

* Switching to dev dockerfile
2020-08-08 18:56:20 -07:00
Bogdan fb051e9a51
Removing trailing space and fix CI (#10557)
Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
2020-08-08 12:33:03 -07:00
David Aaron Suddjian 7f84927504
fix(dashboard): changing the chart title, except not (#10527)
* changing slice names in dashboard should not change chart title

* comprehensions > loops
2020-08-07 18:06:58 -07:00
kxu 3b0676f991
docs: add additional project tags (#10553)
Add additional project tags to improve project discoverability in GitHub
2020-08-07 15:55:53 -07:00
Jesse Yang b6c6b6800a
fix: table viz query mode switch not working (#10552) 2020-08-07 14:15:03 -07:00
Erik Ritter 4765f8b10d
fix: embedded chart height (#10551) 2020-08-07 13:53:18 -07:00
Tanmay Laud a6fa02aaec
chore: Migrate Timer component from jsx to tsx (#10455)
* migrated LanguagePicker.jsx to tsx

* Migrated Menu.jsx to tsx

* migrated MenuObject.jsx to tsx

* migrated NewMenu.jsx to tsx

* Migrated UserMenu.jsx to tsx

* removed unnecessary export from UserMenu

* added language definition in LanguagePicker

* removed unnecessary exports from Menu.tsx

* used typeof guard for childs

* changed LanguageProps to Languages

* removed unnecessary type casting

* fixed linting errors

* migrated Checkbox to tsx

* Migrated Timer component to tsx

* fixed linting errors

* fixed test cases

* removed unused import in timer spec

* reverting changes

* renamed and then modified Timer

* changes for review comments

* fixed incorrect clear

* using stopTimer in stopwatch

* fixed lint issues

* added explicit timer cleanup

* fixed lint issue

* fixed memory leak

* renamed Timer

* added changes after git mv
2020-08-07 09:30:17 -07:00
kxu 90c9417b16
docs: Update and refresh homepage of superset.apache.org (#10477)
* Update and refresh Index

Update and refresh index with additional links to community resources, new links to `Databases' section directly to parts of the tutorial that talk about that database,  connect, align Superset topline features with same language as in GitHub

* Added link to Superset users

* Update with relative links

* Add link to docs repo

Add link to docs repo on the homepage to encourage easy access for community contribution.

* Update index.rst
2020-08-07 09:28:14 -07:00
Ville Brofeldt 08358d623b
fix: handle query exceptions gracefully (#10548)
* fix: handle query exceptions gracefully

* add more recasts

* add test

* disable test for presto

* switch to SQLA error
2020-08-07 17:37:40 +03:00
Jesse Yang ea0db0d195
bugfix: table chart query mode initial value (#10544) 2020-08-07 02:25:48 -07:00
Ville Brofeldt 363abfa1a5
fix: remove unnecessary exception when exploring non-legacy viz plugins (#10538)
* fix: remove unnecessary exception when exploring non-legacy viz plugins

* lint
2020-08-07 08:41:39 +03:00
Maxime Beauchemin 0bad77f0fe
chore: TypeScript <Label /> (#10494)
* chore: TypeScript <Label />

* rebase

* chore: TypeScript <Label />

* rebase

* A bunch o' test fixes. One more to go!

* helper for mountying Emotional components with Enzyme

* asf license

* fixed last test, some linting

* improve the storybook

* Adressing comments

Co-authored-by: Evan Rusackas <evan@preset.io>
2020-08-06 22:33:07 -07:00
Ville Brofeldt 96b9ba3364
ci: bump pre-commit py36 to py37 (#10541)
* ci: bump pre-commit py36 to py37

* add 3rd party for py37

* lint

* yet more lint
2020-08-07 06:54:22 +03:00
Erik Ritter fd2d1c58c5
Revert "chore: Cleanup database sessions (#10427)" (#10537)
This reverts commit 7645fc85c3.
2020-08-06 15:33:48 -07:00
Erik Ritter 2055ecc1ba
feat: refactor error components and add database issue code (#10473)
* feat: refactor error components and add database issue code

* Apply suggestions from code review

Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com>

Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com>
2020-08-06 13:22:24 -07:00
Bogdan 62b873e3da
feat: welcome presto to the suite of tested databases (#10498)
* Add presto to the CI

Sample test data

Datetime conversion

Sample test data

Fix tests

* TODO to switch to timestamps

* Address feedback

* Update requirements

* Add TODOs

Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
2020-08-06 12:07:22 -07:00
Daniel Vaz Gaspar 749581d534
fix(log): don't log exceptions on test connection (#10522)
* fix(log): don't log exceptions on test connection

* fix lint
2020-08-06 07:58:22 +01:00
Maxime Beauchemin ece91928a9
style: use tabs in dashboard edit pane (#10394)
* style: use tabs in dashboard edit pane

* fix tests

* more hackin'

* getting ready to rip cell measurer

* working

* pogress

* Fix cards

* done

* fix jest

* fix cy
2020-08-05 18:53:53 -07:00
Natalie Ruhe 51a88cb19b
feat: Add antd to the codebase (#10508) 2020-08-05 13:50:30 -07:00
Ville Brofeldt 3983fff084
ci: bump tests to 3.7 and add support for 3.8 (#10110) 2020-08-05 13:29:07 +03:00
simchaNielsen 57dc7622b4
fix: show label for filters in filter box in explore (#10412)
* fix: show label for filters in filter box in explore

* test: add test for label in filter box

* test: add test / fix lint

* fix: fix CR notes

* refactor: add label propType to FilterBoxItemControl.jsx
2020-08-05 09:23:11 +03:00
Evan Rusackas 3d74c3ce56
feat: storybook for Icon component (#10515)
* storybook for Icon component

* fixing webpack aliases

* linting 

* Icons are now in a nice little grid.

* lint

* EOF fix for alert.txt. Ugh.
2020-08-04 22:39:14 -07:00
Hossein Torabi 514b29f6df
fix db installaion (#10425) 2020-08-04 21:51:32 -07:00
John Bodley cda764fd4b
chore: Adding pip-compile-multi et al. (#10499)
* chore: Adding pip-compile-multi et al

* Specify requirements.txt path for fossa

* [ci] Fixing CI

Co-authored-by: John Bodley <john.bodley@airbnb.com>
Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>
2020-08-04 19:31:52 -07:00
Jason Davis 72ced53d2a
feat: make screenshot timeout configurable (#10517)
* made screenshot timeout configurable

* added default value to config and refractored use

* black

* updated config comment

* moves config variables to thumbnail section

Co-authored-by: Jason Davis <@dropbox.com>
2020-08-04 17:16:31 -07:00
Moriah Kreeger e040bf7acf
feat: add favorite star to dashboard and chart lists (#10510) 2020-08-04 16:34:50 -07:00
Moriah Kreeger 523c6b77bf
fix: update time range select tooltip (#10458) 2020-08-04 16:34:20 -07:00
Jason Davis 0d91b3ee6e
fix: make SQL-based alert email links user friendly (#10519)
* make urls user friendly

* formatting

Co-authored-by: Jason Davis <@dropbox.com>
2020-08-04 15:45:38 -07:00
Jesse Yang 246add45a0
fix: explore panel missing padding (#10505) 2020-08-04 15:08:28 -07:00
kxu bdfabc23e7
Add link to July community meetup (#10513)
Add link to July community meetup
2020-08-04 13:29:58 -07:00
Jason Davis aa479fb002
feat: updated email format for SQL-based email alerts (#10512)
* added sql statement and link to chart in alert email

* pylint

* updated email to include link to alert

* style changes

* pylint

* added todo and fixed formatting of email

Co-authored-by: Jason Davis <@dropbox.com>
2020-08-04 13:20:02 -07:00
Lily Kuang fa07506d0d
feat: dataset editor improvements (#10444) 2020-08-04 11:52:35 -07:00
Jason Davis 9c5b0e1c86
fix: refactored SQL-based alerts to not pass sqlalchemy objects as args (#10506)
* refractored alerting to not pass sqlalchemy obj as args

* updated to pass only alert id as arg

* used object id instead of argument

* updated alerts_tests.py to reflect change

Co-authored-by: Jason Davis <@dropbox.com>
2020-08-04 09:52:32 -07:00