Commit Graph

4797 Commits

Author SHA1 Message Date
Evan Rusackas
b6639504b6 Removing some dividers to make header dropdown menus more consistent (#8857)
* separators removed, "childs" changed to "children"

* changing `children` back to `childs`... it's baked in somewhere in Fab

* linting

* reverting changes to MenuObject

* adding separator above Druid menu items
2019-12-19 10:17:43 -08:00
Grace Guo
cd8aa92cbb
[explore view] fix: Inline edit chart title cause unintended overwrite original query parameter (#8835)
* [explore view] fix: Inline edit chart title cause unintended overwrite original query parameter

* add more unit tests

* handle new slice case
2019-12-18 16:17:48 -08:00
David Aaron Suddjian
016f202423 Refactor Dashboard and Slice models (#8820)
* refactor dashboard and slice models

* appease various linters

* remove shortcuts & import indirection

* appease mypy

* fix bad imports

* lint

* address various issues

* ignore type issue

* remove unused imports

* lint
2019-12-18 11:40:45 -08:00
ʈᵃᵢ
cbf860074b move cypress into its own directory with package.json (#8627)
* move cypress into it's own directory with package.json

* update contributing and include cypress fixtures dir

* newline

* fix rebase

* add cypress dep

* bump cypress
2019-12-18 09:59:42 -08:00
David Aaron Suddjian
7a68cb7ca0 factor out datasource_access_request model (#8809) 2019-12-17 16:17:49 -08:00
Beto Dealmeida
9ed4b24533
Add toast presenter to Welcome app (#8854)
* Add toast presenter

* Improve message when unauthenticated

* Lint
2019-12-17 15:50:36 -08:00
Will Barrett
025b31c019 Re-enable pylint for superset/connectors/base/models.py (#8824) 2019-12-17 16:42:58 +00:00
Daniel Vaz Gaspar
408196f304 [superset] Core SQLAlchemy query refactor (#8280)
* [superset] Slight performance improvement, remove SQLA first

* [superset] Slight performance improvement, remove SQLA first

* [superset] black it

* [superset] Revert warm up cache change

* [superset] Fix warm up cache slice_id may be none

* [superset] Reverted changes of methods one by get

* [superset] Reverted changes of methods one by get
2019-12-16 23:50:55 -08:00
Evan Rusackas
5780d9d53b Version number and SHA added to user menu (#8850)
* working!

* sigh... linting.

* more linting
2019-12-16 23:48:27 -08:00
Kim Truong
930353286f
fix: add default value to log param in sql_json (#8851)
* fix: add default params to log

* fix: add optional typing

* fix: linting
2019-12-16 23:27:06 -08:00
Kim Truong
2d42272e60
Add user agent logs (#8826)
* feat: add user agent logging

* fix: lint

* fix: address feedback

* fix: formatting
2019-12-16 14:28:00 -08:00
Daniel Vaz Gaspar
2f2ac00a09
[dashboard] feat: REST API (#8694) 2019-12-16 21:10:33 +00:00
serenajiang
1719c4b5a3 [fix][sqllab] nullable booleans in dataframe (#8833)
* [fix] nullable booleans in dataframe

* added comment
2019-12-16 09:59:27 -08:00
Gustavo Brian
f88a55e790 Fix dev-server parameter example (#8836) 2019-12-15 21:51:37 -08:00
Grace Guo
b6f31abcfe
[dashboard] fix duplicated chart fetching when dashboard has default_filters (#8829) 2019-12-13 11:40:27 -08:00
Will Barrett
b87f21fe1f Move function in utils folder to fix circular import issues (#8814)
* Move function in utils folder to fix circular import issues

* CI fixes - black, isort
2019-12-13 16:44:56 +00:00
John Bodley
18fbe56462
[fix] Adding time grains to Table (#8825) 2019-12-13 09:27:20 +13:00
Beto Dealmeida
ec43609820
Fix for when there are no dashboards (#8815) 2019-12-12 11:15:40 -08:00
Grace Guo
1d3c93ccb2
[filter_box] dashboard should carry defaultValue in filter_box (#8812) 2019-12-12 11:01:18 -08:00
Will Barrett
ed54f6ec8d Require the SQLAlchemy URI on the database model (#8720)
* Require the SQLAlchemy URI when creating a database

* Add migration to make dbs.sqlalchemy_uri not-nullable

* Fixes for black, isort, tests

* Alter migration to use current revision from master as downgrade target

* Update tests to support new db constraint

* black
2019-12-11 14:05:23 -08:00
Grace Guo
a96eae46af
[dashboard] fix time granularity display values (#8806)
* [dashboard] fix time granularity display values

* fix review comments
2019-12-11 12:01:11 -08:00
Will Barrett
562aeab1aa Fix a bunch of files with pylint disabled (#8743)
* Re-enable pylint for superset/jinja_context.py

* Re-enable pylint for superset/sql_lab.py

* Re-enable pylint for superset/sql_parse.py

* Re-enable pylint for superset/exceptions.py

* Re-enable lint for superset/translations/utils.py

* Re-enable pylint for superset/views/schedules.py

* Re-enable pylint for superset/views/base.py

* Re-enable pylint for superset/views/log/views.py

* Re-enable pylint for superset/views/annotations.py

* black

* PR feedback, pylint, isort fixes

* Black, one more time...

* Move ungrouped-imports to a global disable
2019-12-11 10:14:24 -08:00
Will Barrett
60914fa76a re-enable Pylint on a number of view files (#8773)
* re-enable pylint for superset/views/tags.py

* Re-enable pylint for superset/views/dashboard.py

* Re-enable pylint for superset/views/sql_lab.py

* Re-enable pylint for superset/views/datasource.py

* Re-enable pylint for superset/views/utils.py

* Re-enable pylint for superset/views/log/__init__.py

* pylint fix

* Improve naming
2019-12-11 09:49:19 -08:00
Will Barrett
adf2cc2039 Re-enable pylint for some model files (#8770)
* Allow id as a valid name for pylint

* Re-enable pylint for superset/models/core.py

* re-enable pylint for superset/models/sql_lab.py

* re-enable pylint for superset/models/schedules.py

* re-enable pylint for superset/models/helpers.py

* re-enable pylint for superset/models/annotations.py

* re-enable pylint on superset/models/tags.py

* a couple more fixes after black formatting...

* Add another inline pylint disable

* Fix black

* Move to inline disables for 'id' attribute on models

* Fix lint disables after black reformatted them
2019-12-10 13:24:45 -08:00
Kim Truong
6c130b32ad
Update sql validator status (#8799)
* fix: update status code for sql validator error

* fix: inspect error

* fix: lint issues

* fix: lint issues 2
2019-12-10 11:55:36 -08:00
Bogdan
e6be51953c Avoid circular dependency between superset config and superset package (#8254)
Resolve comments

Avoid circular dependency between superset config and superset package

Resolve comments
2019-12-10 09:17:34 +00:00
Will Barrett
7f8db7ab8d Re-enable pylint for common, connector, and test files (#8774)
* re-enable pylint for superset/common/query_context.py

* Re-enable pylint for superset/connectors/base/views.py

* re-enable pylint for superset/connectors/connector_registry.py

* Re-enable pylint for tests/fixtures/pyodbcRow.py

* re-enable pylint for superset/cli.py

* Fix for mypy

* Improve variable naming

* A few more naming fixes
2019-12-09 22:32:54 -08:00
Maxime Beauchemin
9f16d053e1
fix: don't show filter popover on explore view load (#8729)
* fix: don't show filter popover on explore view load

There's this confusing "feature" that I thought was a bug that shows the
metric popover opened when entering the explore view when the filter
comes from an active dashboard filter, based on the "fromFormData"
attribute of the filter.

The popover is confusing and often shows as misaligned with the actual
element it's supposed to float over when overflowing.

* warn

* fix cypress

* also shut off  metrics
2019-12-09 21:59:53 -08:00
Evan Rusackas
8b1022f66b darker opacity on shadow border for highlighted cards (#8797)
* darker opacity on shadow for highlighted cards

* removing unnecessary LESS fade

* lightening the lightest segment of the shadow again.
2019-12-09 21:58:59 -08:00
John Bodley
2fb95cc2b0
[fix] Adding time grains to DualLine (#8800) 2019-12-10 14:21:07 +13:00
Beto Dealmeida
5477f42740
Limit payload returned when using SQLLAB_BACKEND_PERSISTENCE (#8769)
* Limit queries

* WIP

* Adding unit test

* WIP

* Add unit test

* Fix test

* Try to fix remote unit tests

* Fix unit test

* Fix  for postgres
2019-12-09 16:12:40 -08:00
Daniel Vaz Gaspar
8a00168b63 Bump FAB to 2.2.1 (#8793) 2019-12-09 08:11:21 -08:00
Dinesh Sawant
cae0583e0f Support timeFormat extraction function column for Druid in Filter (#8728) 2019-12-07 17:54:37 -08:00
Maxime Beauchemin
6ff086df3a
docs: add copyright notice to conform to ASF requirements (#8761)
This should make things green
here: https://whimsy.apache.org/pods/project/superset
2019-12-07 17:52:30 -08:00
Will Barrett
9c2b27f37a Re-enable Pylint on some celery-related files (#8765)
* Re-enable pylint for superset/tasks/schedules.py

* re-enable pylint for superset/tasks/celery_app.py
2019-12-07 17:52:08 -08:00
Bogdan
c3f15b952d Do not delete schema permission on the table deletion (#8768) 2019-12-07 17:50:34 -08:00
Will Barrett
cc49aae245 re-enable pylint for database compatibility layer (#8772)
* Re-enable pylint for superset/db_engines/hive.py

* re-enable pylint for superset/db_engine_specs/elasticsearch.py

* Re-enable superset/db_engine_specs/__init__.py

* Re-enable pylint for superset/db_engine_specs/exasol.py
2019-12-07 16:15:12 -08:00
Hossein Torabi
d3f7fda778 fix create-admin (#8787) 2019-12-07 16:09:14 -08:00
Hossein Torabi
b053d66ea7 fix urlib opener bug (#8788) 2019-12-07 16:07:09 -08:00
Will Barrett
ed3944ebef Re-enable pylint for superset/utils folder (#8766)
* re-enable pylint for superset/utils/import_datasource.py

* re-enable pylint for superset/utils/cache.py

* re-enable pylint for superset/utils/log.py
2019-12-06 14:34:58 -08:00
Will Barrett
60892ae45d Re-enable pylint for example-related files (#8771)
* re-enable pylint for superset/examples/energy.py

* re-enable pylint for superset/examples/world_bank.py

* re-enable pylint for superset/examples/tabbed_dashboard.py

* Re-enable pylint for superset/examples/helpers.py
2019-12-06 14:30:50 -08:00
Will Barrett
68aca88c54 Re-enable pylint on some configuration files (#8767)
* re-enable pylint for superset/config.py

* re-enable pylint on superset/migrations/env.py

* re-enable pylint for superset/legacy.py

* re-enable pylint for superset/forms.py

* re-enable pylint for superset/stats_logger.py

* Tweaks to make mypy and pylint happy

* black
2019-12-06 14:30:11 -08:00
Craig Rueda
7dba3f54ee Adding updates to CONTRIBUTING and UPDATING for app factory changes (#8782)
* Adding updates to CONTRIBUTING and UPDATING for app factory changes

* Fixing celery_app:app
2019-12-06 13:15:12 -08:00
Craig Rueda
a44635e309 Splitting up some of the Docker build steps (#8775)
* Splitting up some of the Docker build steps

* Adding dev target which includes requirements-extra / Updating docker configs to handle async query running
2019-12-05 16:47:22 -08:00
John Bodley
665e94784c
[fix] Adding time grains to PivotTable (#8764) 2019-12-05 09:55:33 -08:00
Craig Rueda
3bdf764f83 Removing upgrade of pip from Docker build (#8760) 2019-12-04 22:15:18 -08:00
ʈᵃᵢ
f7c33680a4 adds react-router to welcome component (#8654)
* adds react-router to welcome component

* prettify

* empty commit
2019-12-04 18:23:53 -08:00
Erik Ritter
737c52541f
Bump viz plugins for bug bash (#8759) 2019-12-04 17:27:21 -08:00
John Bodley
e72533506b [fix] Fixing time controls when switching datasource types (#8748)
* [fix] Fixing time controls when switching datasource types

* Update exploreReducer.js

* Update exploreReducer.js

* Fix linting
2019-12-04 16:55:08 -08:00
Maxime Beauchemin
e127579fc8
fix: remove unused .js module (#8741)
* fix: remove unused .js module

* fix tests, remove more references

* lints
2019-12-04 16:51:05 -08:00