1dbd1e9f02
chore: simplify chart permissions ( #16078 )
2021-08-05 08:18:29 -07:00
490890de23
fix(dashboard): 500 error caused by data_for_slices API ( #16053 )
2021-08-03 19:01:39 -07:00
41e8190575
chore: Use datetime.timedelta for defining durations in config ( #16029 )
...
* chore: use datetime.timedelta for defining durations
* Update config.py
2021-08-03 08:22:30 +12:00
c0615c55df
fix: Ensure table uniqueness on update ( #15909 )
...
* fix: Ensure table uniqueness on update
* Update models.py
* Update slice.py
* Update datasource_tests.py
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2021-08-03 07:45:55 +12:00
3f57ea76db
fix: missing mulitiple metrics on pivot operator ( #16026 )
...
* fix: missing mulitiple metrics on pivot operator
* code smell
2021-08-02 11:37:10 -07:00
5031a67597
feat: Self subscribe reports ( #16027 )
...
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
2021-08-02 09:12:09 -07:00
a786373fff
feat: auto sync table columns when change dataset ( #15887 )
...
* feat: auto sync dataset metadata when change dataset
* diablo sync button when edit mode
* handle undefine schema
* fix py UT
* fix FE UT
* improve test coverage
* fix UT
2021-08-02 16:55:31 +08:00
c01d42fd98
fix: eliminate cartesian product columns in pivot operator ( #15975 )
...
* fix: eliminate cartesian product columns in pivot operator
* wip
* wip
* minor tip
2021-07-31 16:02:04 +08:00
2d61f15153
feat: send post-processed data in reports ( #15953 )
...
* feat: send post-processed data in reports
* Fix tests and lint
* Use enums
* Limit Slack message to 4k chars
2021-07-30 09:37:16 -07:00
f4739f427e
feat: post-processing for pivot table v2 ( #15879 )
...
* feat: add pivot v2 post-processing
* Fix lint
2021-07-29 11:05:56 -07:00
6afa840659
feat: send report data to Slack ( #15806 )
...
* feat: send data embedded in report email
* Change post-processing to use new endpoint
* Show TEXT option only to text-based vizs
* Fix test
* feat: send data embedded in report email
* feat: send report data to Slack
* Add unit test
* trigger tests
2021-07-29 10:13:28 -07:00
bfe7eb9a7b
feat(dbc ui): Adding Google Sheets Dynamic Form ( #15801 )
...
* feat: Make Google Sheets Dyanmic (#15576 )
* first draft
* second draft
* added tests
* first draft
* added table_catalog
* remove console.log
* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* revisions
* save this for now
* working form
* save disable on public sheets
* refactor somethings
* saving this for now
* working edit
* add back query to schema
* working add
* fix styling
* fixing x
* fix linting
* prettier
* fix some type issues
* more lint fixes
* remove unused dependency
* fix linint
* fix validation
* pylint bypass
* pylint bypass
* fix this
* fix mypy
* yerp
* fix test
* fix test
* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* wrap add sheets
* fix linting issues
* fix unit test
* ignore typing
* fix editting and paste issues
* remove query
* fix this
* fix test
* add test back
* fix error messaging
* update url messaging on error
* change error type
* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* add errors for sheets with no name
* fix
* fix messaging for gsheets
* stop pylint
* update line
Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
Co-authored-by: Arash <arash.afghahi@gmail.com>
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2021-07-28 15:00:27 -04:00
3adf8e85cd
feat: send data embedded in report email ( #15805 )
...
* feat: send data embedded in report email
* Prettify table
* Change post-processing to use new endpoint
* Show text option only for text viz
* Show TEXT option only to text-based vizs
* Fix test
* Add email test
* Add unit test
2021-07-28 09:43:04 -07:00
32d2aa0c40
feat: run extra query on QueryObject and add compare operator for post_processing ( #15279 )
...
* rebase master and resolve conflicts
* pylint to makefile
* fix crash when pivot operator
* fix comments
* add precision argument
* query test
* wip
* fix ut
* rename
* set time_offsets to cache key
wip
* refactor get_df_payload
wip
* extra query cache
* cache ut
* normalize df
* fix timeoffset
* fix ut
* make cache key logging sense
* resolve conflicts
* backend follow up iteration 1
wip
* rolling window type
* rebase master
* py lint and minor follow ups
* pylintrc
2021-07-28 22:34:39 +08:00
ea49aa3d2d
feat: add timezones to report cron ( #15849 )
...
* add timezones to report cron
* fix test
2021-07-27 18:28:24 -07:00
2ce676d20d
feat: call screenshot to store `query_context` ( #15846 )
...
* feat: call screenshot to store query_context
* Add unit test
* Move updateQueryContext to ExploreChartPanel
* Add error handling
* Fix code
* Fix logic
2021-07-27 14:02:27 -07:00
62550db385
fix: Update Query Context on Explore loading ( #15865 )
...
* create serialize json function
* saving for now
* saving for now
* lint
* cleanup
* fix network request
* update test
* Update tests/integration_tests/charts/api_tests.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2021-07-26 12:43:25 -07:00
2f95f81be7
feat: apply post processing to chart data ( #15843 )
...
* feat: apply post processing to chart data
* Fix tests and lint
* Fix lint
* trigger tests
2021-07-26 10:58:59 -07:00
6d3e19d857
fix(15403): Re-enable canceling query for Hive and Presto ( #15878 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2021-07-26 08:04:56 -07:00
4ba17092fa
fix: Ensure SupersetError.extra is always a dict ( #15848 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2021-07-24 10:19:30 +12:00
f104fba61d
feat: add `GET /api/v1/chart/{chart_id}/data/?format{format}` API ( #15827 )
...
* feat: add `GET /api/v1/chart/{chart_id}/data/?format{format}` API
* Fix test
2021-07-21 17:03:22 -07:00
3441182630
chore: remove unnecessary deps ( #15787 )
...
* chore: remove unneeded deps
* fix lint
* Run compile
2021-07-21 16:53:45 -07:00
9a79a5775b
feat: store query context when saving charts ( #15824 )
...
* WIP
* Add migration
* Fix tests
2021-07-21 13:54:39 -07:00
ab4e3b9bf9
chore: Enforce Mypy for non-tests ( #15757 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2021-07-22 06:46:43 +12:00
e969edc451
fix: Bust chart cache when metric/column is changed ( #15786 )
2021-07-21 07:46:20 -07:00
3a249a0090
feat: add show columns to Reports model ( #15712 )
...
* added logic for creation_method
* revisions
* added index
* Update superset/migrations/versions/3317e9248280_add_creation_method_to_reports_model.py
* filters
* search columns updated
2021-07-19 11:47:33 -07:00
618a354ca1
Revert "quote column name if db requires ( #15465 )" ( #15752 )
...
This reverts commit 80b8df0673
2021-07-19 10:31:05 -07:00
674f234de6
feat: add logic to creation_method for reports schedule ( #15685 )
...
* migration
* added logic for creation_method
* revisions
* added index
* Update superset/migrations/versions/3317e9248280_add_creation_method_to_reports_model.py
* filters
* Update superset/models/reports.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* Update superset/reports/schemas.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* Update tests/integration_tests/reports/api_tests.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* revisions
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2021-07-15 18:27:54 -07:00
6b790990a8
fix: Add waiting time for chart animation when screenshot ( #15610 )
2021-07-15 18:25:48 -07:00
02032ee8a4
feat: cancel db query on stop ( #15403 )
...
* feat: cancel db query on stop
* fix pylint
* Add unit tests
* Do not bind multiple times
* Stop only running queries
* Postgres to cancel only the required query
* Remove extra log
* Add docstring
* Better types, docstring and naming
* Use python3 format strings
* Update superset/sql_lab.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* Add cancel_query_on_windows_unload option to database
* Return cancel_query as bool
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2021-07-13 12:09:22 -04:00
f39582c900
fix: change sslmode to require for Postgres ( #15642 )
...
* change sslmode to require
* fix test
2021-07-12 15:38:07 -07:00
62a8f2e193
chore(python-testing): move memoized tests to unit tests ( #15507 )
...
* chore: move memoized test into a separated file
create integration test workflow
* chore: create unit test workflow to run purely pytest
* fix: bad reference
* fix: remove pip requirements bc there aren't any yet
* temp: install unit dependencies directly
* fix: --rootdir=
* fix: try to run only unit test
* chore: decouple memoized as separated module
* fix: bring back dependencies bc superset top-level module is coupled to flask and others so no reason no to do it
* fix: reference
* fix: pre-commit
* fix: pylint
2021-07-12 10:00:18 +03:00
4f5f9287fc
feat: validate_parameters for GSheets ( #15578 )
...
* feat: validate_parameters for GSheets
* Move import inside fixture
* Update deps
* Rename parameter
2021-07-08 08:26:39 -07:00
ae160f7f21
chore: add changed_on_delta_humanized field on dashboard schema ( #15542 )
...
* chore: add changed_on_delta_humanized field on dashboard schema
* fix ut
2021-07-07 14:59:49 -07:00
8f92618e46
fix: show all dbs in available endpoint ( #15534 )
2021-07-02 12:58:36 -07:00
80b8df0673
quote column name if db requires ( #15465 )
...
Co-authored-by: hughhhh <hughmil3s@gmail.com>
2021-07-02 12:48:24 -05:00
d4480f5c9a
feat: Database Connection UI ( #14881 )
2021-07-01 14:40:27 -07:00
b5119b8dff
refactor(tests): decouple unittests from integration tests ( #15473 )
...
* refactor move all tests to be under integration_tests package
* refactor decouple unittests from integration tests - commands
* add unit_tests package
* fix celery_tests.py
* fix wrong FIXTURES_DIR value
2021-07-01 18:03:07 +03:00
e606477ec1
feat: more SIP-40 errors ( #15482 )
2021-06-30 16:32:59 -07:00
ffa51753e3
refactor: Moving get_user_datasources to security manager ( #15467 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2021-07-01 04:51:11 +12:00
61e6b7017b
fix: nvd3 bar chart sortby metric ( #15318 )
2021-06-30 19:36:05 +08:00
292bce5862
fix: raise unexpected error when orderby is empty ( #15353 )
...
* fix: raise unexpected error when orderby is empty
* fix ut
2021-06-30 19:34:54 +08:00
743d9cc928
feat: Better Errors in SQL Lab ( #15432 )
...
* snowflake errors
* added big query
* added to setup error messages, first test
* all big query testing added
* added snowflake test
* added syntax error
* added syntax errors to most used databases
2021-06-29 16:48:27 -07:00
ab7f31fd85
Revert "refactor(feature_flags configurations): remove redundant additional configuration for default vales ( #15425 )" ( #15448 )
2021-06-29 16:52:01 +03:00
486b8d911f
refactor(feature_flags configurations): remove redundant additional configuration for default vales ( #15425 )
2021-06-28 16:30:13 +03:00
09c44d05fd
feat(native-filters): Hide non-numeric columns in numeric range filter ( #15385 )
...
* feat(native-filters): Hide non-numeric columns in numeric range filter
* Return true if type_generic undefined
* Code review comments
* Replace any with string
* fix tests
* add missing columns to select
Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
2021-06-27 07:35:17 +03:00
241ee32f56
feat: custom error SQL Lab timeout ( #15342 )
...
* feat: custom error SQL Lab timeout
* Update test
2021-06-24 08:02:49 -07:00
4b00c152cc
feat: implement specific errors for SQL Lab ( #15206 )
...
* RESULTS_BACKEND_NOT_CONFIGURED_ERROR
* DML_NOT_ALLOWED_ERROR
* INVALID_CxAS_QUERY_ERROR
* Fix lint
* Add more tests
2021-06-23 07:58:20 -07:00
216e2b8e8e
fix: datasource payload is incorrect ( #15184 )
...
* fix: datasource payload is incorrect
* Add tests, clean code
2021-06-23 06:59:34 -07:00
58cc78d2c1
fix: return query if it already exists ( #15207 )
...
* check if query exists before saving a new one
* fix test
2021-06-22 13:57:37 -07:00
ab153e66cc
feat: Synchronously return cached charts ( #15157 )
...
* feat: Synchronously return cached charts
* Fix lint issue
* Fix python lint error
* Change getChartDataRequest to return response
* Fix lint errors
* Add test
* explore_json: skip cached data check for forced refresh
Co-authored-by: Rob DiCiuccio <rob.diciuccio@gmail.com>
2021-06-22 10:00:57 -07:00
822eb2e27e
feat(sql): add jinja support to metrics and expressions ( #15247 )
...
* feat(sql): add jinja support to metrics and expressions
* add test
2021-06-19 08:29:04 +03:00
a1027152ba
add ascend engine spec ( #14682 )
2021-06-18 10:35:55 -07:00
1269cc2f88
fix(examples): calendar chart metric should be metrics ( #15173 )
...
* fix(examples): calendar chart metric should be metrics
* fix presto test
2021-06-17 14:55:50 +03:00
83602923f5
feat(api): add featured datatypes to dashboard dataset ep ( #15188 )
2021-06-16 12:36:11 +03:00
75018bf99f
fix: Presto postgres test ( #15163 )
2021-06-15 07:10:50 -07:00
90d9097841
fix: validate DB-specific parameters ( #15155 )
...
* fix: validate DB-specific parameters
* Fix lint
* Update test
* Fix lint/test
* Fix lint
* Update superset/databases/api.py
2021-06-14 18:44:18 -07:00
cc2b4fe3f4
fix: show custom errors in SQL Lab ( #14959 )
...
* fix: show custom errors in SQL Lab
* Fix lint
* Fix test
* Update superset/views/base.py
Co-authored-by: ʈᵃᵢ <tai@apache.org>
* Fix lint
* Debug failing test
* Remove print()
* Debug flaky tests
* Fix test
Co-authored-by: ʈᵃᵢ <tai@apache.org>
2021-06-10 15:20:31 -07:00
42cb5266fa
fix: import metrics with extra ( #15047 )
...
* fix: import metrics with extra
* Fix test
2021-06-08 18:56:55 -07:00
4e998e62fc
feat: add more timeout configuration on screenshots ( #14868 )
...
* feat: more timeout configuration on screenshots
* add tests
2021-06-08 15:33:42 +01:00
8e7f0237ab
fix: apply template_params on external_metadata ( #14996 )
...
* fix: apply template_params on external_metadata
* Fix test
2021-06-04 18:12:22 -07:00
723a67156c
fix: time parser truncate to first day of year/month ( #14945 )
2021-06-02 21:26:37 +08:00
f4de0dcb65
fix: is_temporal should overwrite is_dttm ( #14894 )
...
* fix: is_temporal should overwrite is_dttm
* move up
2021-06-02 18:00:15 +08:00
a85f5c1344
feat(trino): add support for user impersonation ( #14843 )
...
* trino impersonation feature
* Extra options label update
* Update superset/db_engine_specs/trino.py
Co-authored-by: Đặng Minh Dũng <dungdm93@live.com>
Co-authored-by: rijojoseph01 <rijo.joseph@myntra.com>
Co-authored-by: Đặng Minh Dũng <dungdm93@live.com>
2021-05-29 09:54:18 +03:00
8f81fc0ad7
fix: Redshift parameters not rendering ( #14888 )
...
* Update redshift.py
* Update api_tests.py
* fixed test
* add file back
2021-05-28 12:57:15 -04:00
2313e3ef4f
fix: show error on invalid import ( #14851 )
...
* fix: show error on invalid import
* Add unit test
* Remove unused imports
* Fix tests
2021-05-27 14:46:41 -07:00
8febd81baf
feat: validate database parameters ( #14883 )
2021-05-27 14:46:28 -07:00
ae8378a50e
fix: Big Query Edit Form ( #14850 )
...
* fix big quert edit form
* fix test
* fix api test
* fix test
2021-05-26 16:13:26 -04:00
8b1a117d24
feat: return parameters only for DB with default driver ( #14803 )
...
* WIP
* Fix sorting of DBs
2021-05-25 14:46:54 -07:00
c72894725e
fix: Fix Big Query API for POST w/ no parameters ( #14822 )
...
* Update schemas.py
* Update bigquery.py
* Fix tests
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2021-05-25 17:13:17 -04:00
904b60e420
chore: added BasicParametersMixin to Redshift ( #14752 )
...
* redshift basic mixin and tests
* rebased
* forgot prefix
2021-05-24 17:32:53 -04:00
6d33432b58
feat: Create BigQuery Parameters for DatabaseModal ( #14721 )
2021-05-23 12:45:48 -04:00
a06a2f30af
fix: Set g.user to anon user in Celery ( #14742 )
...
* Set g.user to anon user in Celery
* Add test
* Fix bug in logic
2021-05-21 14:33:08 -07:00
d5c008dd99
chore: Perform feature/config condition checks at request time ( #14684 )
...
* chore: conditional Home link rendering
* chore: conditional RowLevelSecurity rendering
* chore: Conditional KV rendering
* chore: Conditional TagView rendering
* chore: Conditional import dashboards link
* chore: Conditional upload csv/excel links
* chore: Conditional log api and view rendering
* chore: Conditionally render email schedules
* chore: Conditionally render alert views
* chore: Conditionally render alerts/reports
* chore: Conditionally render access requests
* chore: Conditionally render druid views
* Remove unnecessary folder
* Consistent naming
* Cleanup
* Remove object from class
* Clean up test file
* Clean up test file
* Fix lint error
* Better naming and follow conventions
* Use assertLess over assertNotEqual
* Assert less than 400
* Fix failing test
2021-05-21 14:29:52 -07:00
590fe20a45
feat: Add a remove filter_flag to jinja filter_values function ( #14507 )
...
Implementation issue 13943
Co-authored-by: cccs-jc <cccs-jc@cyber.gc.ca>
2021-05-21 19:37:09 +03:00
7c17b1a97f
fix(pivot): default missing series to NULL_STRING ( #14748 )
2021-05-21 18:54:15 +03:00
67e373000e
feat: Expanded Parameters for Mysql ( #14680 )
...
* added mysql form
* revisions
* Update superset/db_engine_specs/mysql.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* added ssl and mysql testing
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2021-05-19 08:47:33 -07:00
5e95d4638c
fix: import dataset with extra; Vertica URI ( #14698 )
...
* fix: import dataset with extra; Vertica URI
* Fix lint
2021-05-18 20:51:33 -07:00
90378ed94e
fix(explore): #10098 boolean filter not working ( #14567 )
...
* Restrict operators when column is boolean
* refactor 'isOperatorRelevant' a little bit
* Include 'BOOLEAN' to handle presto
* Update tests
* number column should show bool operators
* fix test - some dbs translate true/false to 1/0
* Fix tests and add linting
* When column type is boolean, show bool operators
* Address PR comments - simplify conditions
* Fix a linting error
* Addressing PR comment - remove unused variables
2021-05-18 14:39:19 -07:00
971f5883f0
feat: add SSL to new DB parameters ( #14673 )
...
* feat: add SSL to new DB parameters
* Fix test
* Raise if cls.encryption_parameters is empty
2021-05-17 21:27:43 -07:00
852842028a
make config method optional ( #14668 )
2021-05-17 17:09:20 -04:00
eb9dafc872
chore: Register dynamic plugins and add feature checks ( #14650 )
...
* chore: Register dynamic plugins and add feature checks
* Disable pylint warning
2021-05-17 11:18:56 -07:00
4f5c537250
feat: Configuration Method and expanded parameters for Database Model ( #14451 )
...
* db migration for dbs
* first draft at logic
* added unit tests
* revisions
* use strings for db values
* lint and revisions to tests
* changed test back
* added revisions for testing
* Update superset/databases/commands/update.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* Update superset/databases/schemas.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* Update superset/models/core.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* Update superset/databases/commands/update.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* got rid of extra imports added new test
* Update superset/databases/schemas.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2021-05-14 18:19:17 -07:00
ba5d66cb0a
fix: DB parameter validation ( #14636 )
2021-05-14 14:07:34 -07:00
6d9d362ca8
chore: use before_request hook for dynamic routes ( #14568 )
...
* chore: use before_request hook for dynamic routes
* Shorten hook names
* Introduce with_feature_flags and update thumbnail tests
* Disable test that fails in CI but not locally
* Add test for reports
2021-05-14 12:49:25 -07:00
3a81e6aee8
change name to Basic instead of Base ( #14625 )
2021-05-13 15:05:37 -04:00
3f6bd1e4a4
feat: add generic type to column payload ( #14547 )
...
* feat: add generic type to column payload
* feat: add generic type to column payload
* xit flaky test
2021-05-13 09:36:09 +03:00
31f406a526
feat: API endpoint to validate databases using separate parameters ( #14420 )
...
* feat: new endpoint for validating database parameters
* Rebase
* Remove broken tests
2021-05-12 18:32:10 -07:00
7a95f8f839
fix: flaky test on reports ( #14544 )
2021-05-10 13:27:12 +01:00
66a4c94a1e
fix(chart-data): handle url_params in csv export and native filters ( #14526 )
2021-05-07 21:07:44 +03:00
d1d98d81b0
feat(dremio): implement convert_dttm method ( #14519 )
2021-05-07 15:31:58 +03:00
21cf12a480
chore(dashboard): Integrate dashboard app into the SPA bundle ( #14356 )
...
* chore(dashboard): Integrate dashboard app into the SPA bundle
* fix url params
* change variable name
* change title correctly
* custom css
* lint
* remove unused file
* remove content assertions from dashboard tests
* fix case with missing bootstrap data
* fix: respect crud views flag
* crud views -> spa
* remove unused dashboard templates
* fix: remove unused variable
* fix: missed a spot with the crudViews -> spa
* router link to dashboard from dashboard list page
* link using the router when in card mode
* lint
* fix tests, add memory router
* remove dashboard app files
* split up the bundle a little more
* use webpack preload
2021-05-04 08:51:17 -07:00
9a22fb00d9
fix: CSV Export permission is not consistent ( #13713 )
2021-05-04 10:19:58 +03:00
e05a70fc82
fix: dashboard changed on calculation ( #14450 )
2021-05-03 13:55:34 -07:00
2f9efb2e23
add migration ( #14446 )
2021-05-03 15:32:48 +03:00
7466595563
fix: fixing mysql error message ( #14416 )
...
* fixing mysql error message
* Update tests/db_engine_specs/mysql_tests.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* Update tests/db_engine_specs/mysql_tests.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* Update tests/db_engine_specs/mysql_tests.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* Update superset/db_engine_specs/mysql.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* fixed broken test
* changed error type
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2021-04-30 15:15:37 -07:00
e507508b48
feat: Logic added to limiting factor column in Query model ( #13521 )
...
* Sqllab limit
* Add migration script
* Set default values
* initial push
* revisions
* Update superset/views/core.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* moving migration to separate PR
* with migration
* revisions
* Fix apply_limit_to_sql
* all but tests
* added unit tests
* revisions
* Update superset/sql_lab.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* Update superset/sql_parse.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* fixed black issue
* Update superset/views/core.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* updated logic
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2021-04-30 15:15:18 -07:00
bc47bc8f66
feat: Add etag caching to dashboard APIs ( #14357 )
2021-04-29 14:14:26 -07:00
6541a03d0b
fix: SQLLab role permissions ( #14372 )
...
* fix: SQLLab role permissions
* add missing perm
* fix tests
* fix security test
* fix security test
* fix tests
2021-04-29 15:58:08 +01:00
e7f5100833
fix: Fix unintended cache misses with async queries ( #14291 )
...
* bug: Fix unintended cache misses with async queries
* Ensure sort order
* Ensure columns are sorted
* Update failing tests
2021-04-28 12:14:55 -07:00
d8bb2d3e62
refactor(db_engine_specs): Removing top-level import of app ( #14366 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2021-04-28 15:47:32 +12:00
2a1235c0c2
fix: Cleanup serialization and hashing code ( #14317 )
2021-04-26 14:04:40 -07:00
45e209d487
fix: flaky test for alerts and reports ( #14347 )
2021-04-26 18:56:48 +01:00
b0f8f6b6ad
fix(hive): Use parquet rather than textfile when uploading CSV files to Hive ( #14240 )
...
* fix(hive): Use parquet rather than textfile when uploading CSV files
* [csv/excel]: Use stream rather than temporary file
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2021-04-24 18:17:30 +12:00
a8781c5313
fix(hive): Update CSV to Hive upload prefix ( #14255 )
...
* fix(hive): Update CSV to Hive upload prefix
* Trigger notification
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2021-04-24 13:20:31 +12:00
e7ad03d44f
feat: add endpoint to fetch available DBs ( #14208 )
...
* feat: add endpoint to fetch available DBs
* Fix lint
2021-04-23 10:51:47 -07:00
ffcacc3393
fix: new import/export CLI ( #13921 )
...
* fix: CLI for import/export
* Add tests
* Remove debug
2021-04-23 10:50:49 -07:00
38a7c537ff
feat: add alerts & reports to docker compose ( #14267 )
...
* feat: add alerts & reports to docker compose
* change to firefox
* add missing package
2021-04-22 17:42:52 +01:00
5d3191bb61
feat: catch errors on do_ping ( #14250 )
2021-04-21 18:43:40 -04:00
2dd20df03d
fix(dashboard): draft dashboards should be viewable ( #14207 )
...
* fix(dashboard): draft dashboards should have open access
* Remove a duplicate test
2021-04-21 09:54:51 -07:00
392d8a8107
fix: Handle bad permission errors for bigquery test connections ( #14147 )
...
* starter make file
* yea
* move messaging to config
* Delete Makefile
* remove
* checkout
* check for db generic errors
* checkout bad files
* add proper message
* add docs for new permissions codes
* Update superset/errors.py
Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
* Update superset/errors.py
Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
* rename var
* starter regex
* fix
* fix
* fix linting
* update test
* yerp
* fixed test
* added regex
* Apply suggestions from code review
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* address comments
* update docs
* prettier
* fux
* add space
* Update errors.py
* Update types.ts
Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2021-04-20 19:19:36 -04:00
55bf72aead
chore(prophet): bump prophet to 1.0.1 ( #14228 )
2021-04-20 15:55:55 +03:00
0807ab44a5
fix(native-filters): merge_extra_form_data extras processing ( #14244 )
...
* fix: merge_extra_form_data extras processing
* move props that are later moved back in viz.py
2021-04-20 14:24:33 +03:00
13bf023100
feat: improve engine spec discoverability ( #14204 )
...
* feat: improve engine spec discoverability
* Address comments
* Fix tests
2021-04-19 17:24:22 -07:00
11e0f4cb2d
feat: TrinoEngineSpec.adjust_database_uri ( #14122 )
...
* feat: TrinoEngine implement adjust_database_uri
Signed-off-by: Đặng Minh Dũng <dungdm93@live.com>
* test: TrinoEngine implement adjust_database_uri
Signed-off-by: Đặng Minh Dũng <dungdm93@live.com>
2021-04-19 13:10:12 +03:00
c7112d1c48
feat: error messages for Presto connections ( #14172 )
...
* chore: rename connection errors
* feat: error messages for Presto connections
* Add unit tests
* Update docs/src/pages/docs/Miscellaneous/issue_codes.mdx
Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
2021-04-16 15:49:47 -04:00
df04c3af21
feat: error messages when connecting to mssql ( #14171 )
...
* database errors for mssql
* revisions
2021-04-16 09:43:42 -07:00
a49e0b2037
feat: Adding encrypted field factory ( #14109 )
...
* First cut at adding enc type factory
* Finalized enc type factory
* Adding unit test
* PyLinting
* Adding license
* Apply suggestions from code review
Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>
* Moving things from enc -> encrypt
* CI commit
* One more fix
* Tweaking config name
* Fixing broken test
* Fixing broken test again
Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>
2021-04-16 09:01:18 -07:00
df7e2b6a8e
feat(alert/report): chart as csv format attachment for email and slack ( #13828 )
...
* add ui for setting report format
* refactor default notification format
* init csv data alert report
* add report format to report_schedule model
* add ALERTS_ATTACH_REPORTS feature flag
* fix lint
* update check image tag
* fix migrations
Co-authored-by: samtfm <sam@preset.io>
2021-04-15 14:07:49 -07:00
21c6efea67
chore: rename connection errors ( #14169 )
2021-04-15 10:57:02 -07:00
eadff5f41e
feat: invalid DB name error messages (MySQL/Postgres/Redshift) ( #14146 )
...
* initial DB custom errors for mysql
* added redshift and postgres
2021-04-15 08:02:47 -07:00
8ef572a412
refactor(native-filters): update dataMask and ExtraFormData schema ( #13983 )
...
* refactor: updates usage of `ownFilters` to `ownState`
* refactor: update dataMask (final)
* lint: fix lint
* refactor: revert feat
* fix: fix missed chart configuration
* add filter set migration
* apply new changes
* fix migration revision
* update migration
* fix jest mock
* js lint
* fix test types
* update tests and types
* remove append_form_data from tests
* fix findExistingFilterSet tests
* add migration test
Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
2021-04-15 17:43:29 +03:00
21f973f0bd
feat: error messages when connecting to MSSQL ( #14093 )
...
* feat: error messages when connecting to MSSQL
* Address comments
2021-04-14 10:57:58 -07:00
321db4674d
feat: invalid hostname and password error messages (Redshift) ( #14111 )
...
* custom errors for redshift
* added unit tests and custom errors
2021-04-13 21:20:47 -07:00
b77477a9dd
feat: invalid hostname and password error messages (MySQL) ( #14089 )
...
* custom errors for mySQL
* initial custom errors and tests for MySQL
* revisions
2021-04-13 14:42:31 -07:00
4b23d0ecca
fix: logs table - user_id is NULL ( #14057 )
...
* add user back to session
* add test for logging None on exceptions
* fix this updated test
* reformat
* reformat
* Update log.py
2021-04-13 10:08:34 -04:00
8c5b6b1263
feat(dashboard_rbac): provide data access based on dashboard access ( #13992 )
...
* feat: provide data access based onb dashboard access
* chore: adjust code after CR comments
* fix: add brackets
* fix: type
* chore: add tests
* fix: pre-commit
* fix: pre-commit and lint
* fix: fix test
* fix: pre-commit
* fix: fix local pylint warnings
* revert: birth_names pylint change bc it affects tests
* Update superset/security/manager.py
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
* Update superset/security/manager.py
* Update tests/utils_tests.py
* fix: after CR
* fix: after CR from ville
* chore: update roles description
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2021-04-13 16:23:31 +03:00
15ac075b78
fix(sqla): labels_expected contains mutated label ( #14095 )
2021-04-13 16:19:52 +03:00
9c5264af0d
feat(can_share): can share chart and dashboard ( #14076 )
...
* feat: share chart - can_share_chart
share dashboard can_share_dashboard
* fix: pre-commit
* fix: userCanShare tests
* fix: after hugh CR
* fix: adjust after spa refactor
2021-04-13 13:54:14 +03:00
4bb29b6f04
chore(spa refactor): refactoring dashboard to use api's instead of bootstrapdata ( #13306 )
...
* add hook for future async api calls
* test to see conflict
* add async middleware and update reducers
* working async dashboard load
* implement getcharts api
* add user permissions to explore and dashboard bootstrap data
* integrate api calls with getinitial state
* update namings
* accept an id or a slug in the dashboard charts api
* add permissions function
* fix merge
* update state
* get dashboard charts by id or slug
* fix undefined states
* variable names
* stop using some more bootstrap data
* fix metadata reference
* remove unused bootstrap from the template
* add errorboundry to dashboard
* refactoring, fixing
* update permissions
* add just roles
* id is supposed to be a string
* unused vars
* get datasources from api
* make onError optional
* use resource hooks, better error boundary
* add loading state for dashboardroute
* remove console
* add conditional
* more conditionals
* testing out a possible fix for cypress
* convert edit/standalone test to cypress
* remove bootstrappy assertions
* lint
* fix dashboard edit history issue
* rename stuff
* address recent native filters schema change
* remove unused getInitialState
* remove .only from test
* hooksy redux usage
* Revert "more conditionals"
This reverts commit 25c8ed61b477dea1915b
2021-04-12 16:10:29 -07:00
786dadc836
feat: invalid password error message (Postgres) ( #14038 )
2021-04-12 14:03:21 -07:00
c563ea091e
fix: flacky test in test_update_dataset_item_w_override_columns ( #14082 )
...
* fix flack test
* fix flack test
2021-04-12 16:45:50 -04:00
7980b767c0
feat: Implement Celery SoftTimeLimit handling ( #13740 )
...
* log soft time limit error
* lint
* update test
2021-04-12 13:18:17 -07:00
911462a148
feat: only send alert error emails to owners of the alert ( #13862 )
...
* only send alert error emails to owners of the alert
* reformat long lines
* fix send to owners and add tests
* fix pylint errors
* fix formatting
2021-04-12 08:51:32 -07:00
a4fd6b8f33
fix: Use superset generic db to catch external_metadata queries ( #13974 )
2021-04-10 10:15:03 -04:00
3d357c661c
feat: handle chart/data API errors ( #14040 )
2021-04-09 09:39:02 -07:00
a3b41e2bac
fix: Issue 13956 ( #13980 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2021-04-09 15:21:58 +12:00
c60a93db9c
feat: add extract_errors to Postgres ( #13997 )
...
* feat: add extract_errors to Postgres
* Add unit tests
* Fix lint
* Fix unit tests
2021-04-08 13:24:54 -07:00
b5e5b3aa62
feat: create backend routes and API for importing saved queries ( #13893 )
...
* initial commit
* revisions
* started tests
* added unit tests
* revisions
* tests passing
* fixed api test
* Update superset/queries/saved_queries/commands/importers/v1/utils.py
Co-authored-by: Hugh A. Miles II <hughmil3s@gmail.com>
* Revert "Update superset/queries/saved_queries/commands/importers/v1/utils.py"
This reverts commit 18580aad1e
2021-04-08 14:20:11 -04:00
6a81a7961c
feat: Support feature flag overrides in ephemeral test envs ( #14008 )
...
* Add support for feature flag overrides in ephemeral env cmd
* update docs to reference correct config
* Update ephemeral env docs
2021-04-08 11:05:59 -07:00
89817d4cee
fix(alerts/reports): working timeout with celery kill and logic fix ( #13911 )
...
* fix: working timeout with celery kill and logic fix
* add config flags
* fix typo
* fix python lint
* log query time for alerts
* add tests
* fix lint
2021-04-08 11:23:31 +01:00
a82d72fef6
feat: initial work to make v1 API compatible with SIP-40 and SIP-41 ( #13960 )
...
* WIP
* Use errorhandler
* Add response schema
* Fix status on HTTPException
* s/found/encountered/g
* Fix test
* Fix lint
* Fix lint and test
2021-04-06 22:06:32 -07:00
3b11654c5a
fix: import dataset/dashboard empty keys ( #13979 )
2021-04-06 20:55:15 -07:00
34991f5fab
fix(explore): strip semicolons in virtual table SQL ( #13801 )
...
* add method to strip semicolon
* address comments
* test the test
* Update tests/sqla_models_tests.py
Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>
* Update tests/sqla_models_tests.py
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
* fix test
* add suggestion
* fix trailing space
* remove logger
* fix unit test
Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2021-04-06 13:40:34 -07:00
f291ba05c6
fix: SQL -> Explore Overwrite flow ( #13946 )
2021-04-05 14:52:04 -04:00
4789074309
fix(sqla-query): order by aggregations in Presto and Hive ( #13739 )
2021-04-01 18:10:17 -07:00
762101018b
feat(alert/report): add ALERTS_ATTACH_REPORTS feature flags + feature ( #13894 )
...
* Add a feature flag ALERTS_ATTACH_REPORTS
* update test
* update feature flag
* add comment for feature flag
* add unit tests for alerts with attachments disabled
* fix lint
Co-authored-by: samtfm <sam@preset.io>
2021-04-01 13:06:45 -07:00
ca506e9396
fix( #13378 ): Ensure g.user is set for impersonation ( #13878 )
2021-03-31 11:22:56 -07:00
304e3b36eb
feat(alerts & reports): Easier to read execution logs ( #13752 )
...
* Prep for migration
* Migration for execution id column
* Generate execution ids for alerts and reports
* Change execution id range
* Add execution id to API endpoint
* Add execution id to execution log view
* Change execution id range
* Change execution id to a uuid
* Fix execution id type
* Switch state and exec. id columns
* Change db column to UUIDType
* Python lint
* Fix failing frontend tests
* execution_id -> uuid
* Fix migration head
* lint
* Use celery task id as the execution id
* lint
* lint for real
* Fix tests
2021-03-30 08:46:16 -07:00
55ba47ec2e
fix( #13734 ): Properly escape special characters in CSV output ( #13735 )
...
* fix: Escape csv content during downloads
* Reuse CsvResponse object
* Use correct mimetype for csv responses
* Ensure that headers are also escaped
* Update escaping logic
2021-03-26 15:22:00 -07:00
Beto Dealmeida
Jesse Yang
John Bodley
Yongjie Zhao
Elizabeth Thompson
Hugh A. Miles II
Erik Ritter
AAfghahi
u-aiaa
Peter Kosztolanyi
Amit Miran
ofekisr
Ville Brofeldt
Kamil Gabryjelski
Ben Reinhart
Daniel Wood
Daniel Vaz Gaspar
rijojoseph07
cccs-jc
Ajay M
David Aaron Suddjian
Duy Nguyen Hoang
Đặng Minh Dũng
Craig Rueda
Lily Kuang
simcha90
Phillip Kelley-Dotson
Sam Faber-Manning
Rob DiCiuccio
Jack Fragassi