Commit Graph

146 Commits

Author SHA1 Message Date
Michael S. Molina bb7e979142
chore: Moves spec files to the src folder - iteration 9 (#17901) 2022-01-07 15:23:57 -03:00
Michael S. Molina e6ef7da758
chore: Moves spec files to the src folder - iteration 8 (#17899)
* chore: Moves spec files to the src folder - iteration 8

* Fixes tests
2022-01-07 09:25:45 -03:00
Phillip Kelley-Dotson cfd851aa13
fix: replace datamask with key from new key value api (#17680)
* afirst stage to ccheck to get initial datamask

* clean up code and update typescript

* remove consoles

* fix ts and update copy dashboard url

* use key when one doesn't exists

* lint clean up

* fix errors

* add suggested changes

* remove line

* add tests and add changes for copydashboard

* fix lint

* fix lint

* fix lint

* Update superset-frontend/src/dashboard/components/Header/index.jsx

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* add timeout

* fix test

* fix test, add qs to cypress and add suggestions

* add suggestions

* fix lint

* more suggested changes for backwards comapat

* fix lint

* cleanup naming and add qs parse to tests

* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/index.tsx

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/index.tsx

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* more changes and fix lint

* remove nativefiler param

* fix path

* remove con

* simplify logic

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2021-12-21 09:08:48 -08:00
Geido 12bd1fcde5
fix: Save properties after applying changes in Dashboard (#17570)
* Refactor PropertiesModal

* Update json_metadata fully

* Clean up

* Verify values

* Catch changed to metadata

* Always updated dashboard info on update

* Avoid unnecessary fetches

* Formt

* Fix copy dashboards

* Fixes onUpdate onCopy handlers

* Pylint

* Update tests

* Clean up

* Handle data on show

* Change Save to Apply

* Update Cypress save test

* Update Cypress edit prop test

* Update PropertiesModal test

* Fix duplicate request with cross filters

* Improve code style

* Fix typo

* Lint
2021-12-09 10:03:07 -07:00
Ajay M 9576478a5d
feat(dashboard): Add divider component in native filters (#17410)
* Tests are working, type errors are fixed

* Fix filterset

* add license header to the new file

* fix test

* PR comments

* Linting

* test fix

* small fix
2021-11-23 16:13:56 -08:00
Yongjie Zhao 9070b6b19c
refactor(monorepo): stage 1 (#17427)
* skip geojson in pre-commit

update prettier

* update package.json

update package.json

u package

pkg

pkg2

* lint main repo 2

lint main repo

lint

* lintrc

lintrc 2

lintrc2

lintrc 3

lintrc

* fix import

* refresh lock file

* fix break line make @ts-ignore invalid

* update rat-excludes

rat-excludes

update rat-excludes

* update eslintrc.js

* lint lint lint
2021-11-17 15:31:36 +08:00
Elizabeth Thompson 71e3fa1bf3
use full resultType with csv download on chart in dashboard (#17431) 2021-11-15 09:57:05 -08:00
Geido ee7c34b5b3
Make color scheme optional (#17357) 2021-11-05 19:09:59 +02:00
Geido 59a6502efe
fix: Color consistency (#17089)
* Update label colors on the fly

* Clean up

* Improve getFormDataWithExtraFilters

* Improve code structure

* Remove labelColors from formData

* Exclude label_colors from URL

* Refactor color scheme implementation

* Clean up

* Refactor and simplify

* Fix lint

* Remove unnecessary ColorMapControl

* Lint

* Give json color scheme precedence

* Add label_colors prop in metadata

* Separate owners and dashboard meta requests

* Remove label_colors control

* bump superset-ui 0.18.19

* Fix end of file

* Update tests

* Fix lint

* Update Cypress

* Update setColorScheme method

* Use Antd modal body
2021-11-03 19:22:38 +02:00
Ajay M 65f1644208
feat(dashboard): Add description to the native filter (#17025)
* Adding description works

* Add some tests

* Fix tests

* Styled look good

* Tests successful

* Address PR comments

* fix a test
2021-10-27 11:45:31 -07:00
simcha90 37944e18d6
feat(Filter-sets): connect to api (#17055)
* fix:fix get permission function

* feat: filtersets new

* feat: connect filter sets to api

* lint: fix lint

* doc: add comment
2021-10-17 09:56:54 +03:00
Ajay M 9e6d5fc775
feat(dashboard): Let users re-arrange native filters (#16154)
* feat. flag: ON

* refactor filter tabs

* WIP

* Drag and Rearrange, styling

* refactoring dnd code

* Add apache license header

* Fix bug reported during PR review

* Minor fix on remove

* turn off filters

* Fix status

* Fix a test

* Address PR comments

* iSort fixes

* Add type key to the new filters

* Fix wrong attribute

* indent

* PR comments

* PR comments

* Fix failing tests

* Styling

* Fix remove filter

* Fix the drag issue

* Save works

* fix

* Write tests

* Style changes

* New Icon

* Grab & Grabbing Cursor

* Commented out code

* Fix tests, fix CI

* Fix failing tests

* Fix test

* Style fixes

* portal nodes dependency

* More style fixes

* PR comments

* add unique ids to collapse panels

* Filter removal bug fixed

* PR comments

* Fix test warnings

* delete filter tabs

* Fix the breaking test

* Fix warnings

* Fix the weird bug on cancel

* refactor

* Fix broken scope
2021-10-15 16:56:33 -07:00
Hugh A. Miles II 959fd763a8
fix: Owners selection in dataset edit UX (#17063)
* boilerplate

* update owner select component

* this is working

* update onchange

* refactorig

* you need to useMemo or things break

* update test

* prettier

* move logic into bootstrap data endpoint

* address concerns

* oops

* oops

* fix test
2021-10-12 20:27:56 -04:00
Elizabeth Thompson 5866d5ebb0
fix: Revert "fix: RBAC hide right menu (#16902)" (#16968)
* Revert "fix: RBAC hide right menu (#16902)"

This reverts commit 87baac7650.

* fix failing test
2021-10-04 19:18:12 -07:00
Michael S. Molina 1ab36c94f3
chore: Moves spec files to the src folder - iteration 7 (#16943) 2021-10-04 10:56:49 -03:00
Ville Brofeldt a07c9d591b
fix(dashboard): recursive parent on dashboard components (#16933)
* fix(dashboard): don't add recursive parents on wrapper component

* add test

* refine logic and add new test
2021-10-01 08:13:38 -07:00
Ville Brofeldt a3413197de
chore: upgrade to Node 16 (#16809)
* chore: upgrade to Node 16

* add docs

* fix test
2021-09-25 07:26:35 +02:00
Lyndsi Kay Williams 63aadd3fe4
test: RTL overhaul - hackathon (#16626)
* CachedLabel_spec fully converted to RTL

* ColumnTypeLabel_spec fully converted to RTL

* MissingChart_spec fully converted to RTL

* RefreshIntervalModal_spec mostly converted to RTL

* HoverMenu_spec mostly converted to RTL

* ResizableContainer_spec fully converted to RTL

* ResizableHandle_spec fully converted to RTL

* AggregateOption_spec fully converted to RTL

* CheckboxControl_spec fully converted to RTL

* ColorPickerControl_spec to RTL

* Finished converting ColorPickerControl_spec to RTL/TS, also converted RefreshIntervalModal_spec to TS

* Added unknown type to ColumnTypeLabelProps

* Fixed ColumnTypeLabel_spec
2021-09-22 11:37:35 -07:00
Michael S. Molina 9b17e86b44
chore: Moves messageToasts to the components folder (#14431)
* chore: Moves messageToasts to the components folder

* Rebases
2021-09-22 07:44:54 -03:00
simcha90 668ae23f28
feat: Tabs in column (#16593)
* fix:fix get permission function

* feat: add tabs inside column

* lint: fix lint

* test: fix test

* test: fix tests

* test: fix tests

* fix: pass onChangeTab function through layout
2021-09-13 09:02:29 +03:00
Ajay M 4b70d46355
feat(dashboard): Native filters - add type to native filter configuration (#16549)
* iSort fixes

* Add type key to the new filters

* Fix wrong attribute

* PR comments

* PR comments

* Fix failing tests
2021-09-09 09:46:44 -07:00
Kamil Gabryjelski f422f1ea49
perf(dashboard): decouple redux props from dashboard components (#16421)
* perf(dashboard): decouple redux props from dashboard components

* Lint fix

* Dont make copy of filters object

* Remove unnecessary exports
2021-08-26 21:54:11 +02:00
Michael S. Molina e59f318ef9
chore: Changes the RefreshIntervalModal component to use the new select component (#16048) 2021-08-06 07:58:53 -03:00
Michael S. Molina cc704dd53a
fix: Cancel alert is not appearing to all native filters modal fields (#15925) 2021-07-30 11:59:36 -03:00
Michael S. Molina 5be0a89625
fix: Charts sort by in edit mode gets cut off (#15896) 2021-07-26 16:38:38 -03:00
Michael S. Molina e6bbca3f61
chore: Preserve native filters selection after refresh (#15583) 2021-07-13 15:14:18 -03:00
Ville Brofeldt f286647140
chore(native-filters): remove instant filtering option (#15365)
* chore(native-filters): remove instant filtering option

* fix test
2021-07-01 13:38:56 +03:00
Ville Brofeldt 4630abb5a8
feat(native-filters): add support for preselect filters (#15427)
* feat(native-filters): add support for sharing preselected filters

* abc

* add serialization
2021-06-29 18:57:49 +03:00
Kamil Gabryjelski f109da479d
perf(dashboard): Improve perf of highlighting charts in scope of active filter (#15424)
* perf(dashboard): Improve perf of highlighting charts in scope of active filter

* More optimizations

* fix tests

* Fix lint

* bug fix
2021-06-29 12:55:53 +02:00
Michael S. Molina bdb9b0a9be
chore: Rewrites dashboard IconButton component (#14174) 2021-06-25 15:15:20 -03:00
Kamil Gabryjelski f0b64190b5
feat(native-filters): Set default scope by filters' and charts' datasets (#15302)
* feat(native-filters): Set default scope by filter's and charts datasets

* Fix undefined error

* Use JSON.stringify in dependency array

* Fix lint issue

* Lock scope after switching radio buttons

* Fix weird eslint issue

* Change prop names

* Implement useComponentDidUpdate

* Fix lint

* Refactor useComponentDidUpdate

* Remove screen.debug()
2021-06-24 09:23:35 +02:00
Michael S. Molina 0c22266041
chore: Improves the native filters bar layout (#15115) 2021-06-16 14:17:14 +03:00
Ajay M 045fa1bc7a
feat(dashboard): Let users download full CSV of a table (#15046)
* - Convert SliceHeader to TSX in progress
- Add menu option to download full CSV. Probably will change it

* Add Download Full CSV feature, and tests

* Added more tests, more TS fixes

* Added feature flag

* Update @superset-ui package versions

* Update @superset-ui packages versions

* use backend config instead of hardcoding number of rows

* Update tests

* front end test fix

* Lint fixes and test fixes
2021-06-14 14:26:18 -07:00
Kamil Gabryjelski 51f0d4fd98
feat(native-filters): Hide filters which don't affect any visible charts (#15063)
* feat(native-filters): Hide filters which don't affect any visible charts

* Fix lint errors

* Add comments

* Code review fix

* Fix tests

* Refactor logic in FilterControls
2021-06-11 13:41:08 +02:00
Kamil Gabryjelski 405f95b6af
feat(dashboard/native-filters): Hide filters out of scope of current tab (#14933)
* Optimize finding charts and tabs in scope

* Put filters out of scope in Collapse

* Use lastFocusedTabId instead of directPathToChild

* Fix tests

* Fix cypress test

* Uncomment e2e test
2021-06-02 20:38:18 +02:00
Michael S. Molina 0c0eccb81a
chore: Improves the native filters UI/UX - iteration 3 (#14824) 2021-05-26 10:49:00 +03:00
Kamil Gabryjelski c831655913
feat(native-filters): Highlight charts affected by focused native filter (#14693)
* Highlight charts affected by focused native filter

* Remove tabs animation on dashboard

* Remove a test that checks for "animated={true}" prop on tabs

* Move hooks types to a separate interface
2021-05-21 15:54:33 +02:00
Michael S. Molina be8c176df2
chore: Removes less from SliceAdder (#14448) 2021-05-19 00:16:44 -07:00
Phillip Kelley-Dotson e4e23ea487
fix: fix adhocpopovers tab animate. (#14478)
* fix popover

* addd tabs default css

* fix lint

* fix tests

* address comments

* lint fix

* fix test

* lint
2021-05-13 20:30:27 -07:00
Michael S. Molina e7a4734742
chore: Removes tabs animation by default (#14496) 2021-05-08 14:22:16 -07:00
simcha90 582900c170
perf(native-filters): Load native filters after charts (#14443)
* fix:fix get permission function

* refactor: filter default value

* refactor: update default value loading

* refactor: apply defaultValues

* lint: fix lint

* lint: fix lint

* test: fix test

* refactor: use extraFormData for reload charts

* feat: load native filters after after charts

* feat: load filters after charts

* fix: revert changes

* test: fix timers

* test: fix tests
2021-05-04 16:07:40 +03:00
simcha90 bbb1f2d757
perf(native-filters): avoid unnecessary reloading of charts (#14408)
* fix:fix get permission function

* refactor: filter default value

* refactor: update default value loading

* refactor: apply defaultValues

* lint: fix lint

* lint: fix lint

* test: fix test

* refactor: use extraFormData for reload charts

* test: fix tests

* test: fix tests

* test: fix tests
2021-05-03 14:56:41 +03:00
Geido 545e257537
feat: Dynamic imports for the Icons component (#14318)
* Add aria-label and twotone

* Enhance LazyIcon

* Fix tests and solve ject warnings

* Add new line

* Revert package-lock to master

* Fix failing test

* Implement icon overrides

* Fix failing storybook

* Clean up

* Improve var name
2021-04-29 11:49:39 -07:00
Michael S. Molina 1d6a746a09
refactor: Boostrap to AntD - Tabs (#14048) 2021-04-28 23:49:50 -07:00
Michael S. Molina d0be1ff79e
chore: Moves Tabs to the components folder (#14136) 2021-04-27 00:15:21 -07:00
simcha90 7ff35dfdfb
fix(native-filters): Fix indicators (#14334)
* fix:fix get permission function

* fix: hide featured filters

* test: fix FF in tests

* test: fix FF in tests

* fix: fix unset cross filters
2021-04-26 13:22:11 +03:00
simcha90 3e8bf96642
fix(native-filters): Fix first loading of charts (#14332)
* fix:fix get permission function

* fix: fix unnecessary loading for native filters

* test: fix mocks
2021-04-25 13:58:53 +03:00
simcha90 d386e66f59
test(native-filters): add integration tests for filter bar (#14098)
* test: add tests for filter bar

* test: merge filter bar tests with master

* test: add test for filter set

* test: filter set tests

* test: merge with master

* test: fix tests for filter bar

* fix: fix CR notes

* fix: fix CR notes
2021-04-20 12:24:12 +03:00
Michael S. Molina b83ee46d0f
chore: Moves Modal to the components folder (#14130) 2021-04-16 15:49:53 -07:00
simcha90 8ef572a412
refactor(native-filters): update dataMask and ExtraFormData schema (#13983)
* refactor: updates usage of `ownFilters` to `ownState`

* refactor: update dataMask (final)

* lint: fix lint

* refactor: revert feat

* fix: fix missed chart configuration

* add filter set migration

* apply new changes

* fix migration revision

* update migration

* fix jest mock

* js lint

* fix test types

* update tests and types

* remove append_form_data from tests

* fix findExistingFilterSet tests

* add migration test

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
2021-04-15 17:43:29 +03:00