Commit Graph

2165 Commits

Author SHA1 Message Date
John Bodley
1c12167d8d
fix: Revert default series sort-by metric and enforce non-xor with series limit (#17236)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2021-11-03 13:59:38 -07:00
Geido
59a6502efe
fix: Color consistency (#17089)
* Update label colors on the fly

* Clean up

* Improve getFormDataWithExtraFilters

* Improve code structure

* Remove labelColors from formData

* Exclude label_colors from URL

* Refactor color scheme implementation

* Clean up

* Refactor and simplify

* Fix lint

* Remove unnecessary ColorMapControl

* Lint

* Give json color scheme precedence

* Add label_colors prop in metadata

* Separate owners and dashboard meta requests

* Remove label_colors control

* bump superset-ui 0.18.19

* Fix end of file

* Update tests

* Fix lint

* Update Cypress

* Update setColorScheme method

* Use Antd modal body
2021-11-03 19:22:38 +02:00
Michael S. Molina
85a19a9cc2
fix: Unable to select None for Alert's log retention (#17268) 2021-11-03 08:48:30 -03:00
Phillip Kelley-Dotson
9a4ab1026e
fix: remove variables from styled component (#17228)
* remove variables

* fix hovermenu styles
2021-11-02 16:25:48 -07:00
Erik Ritter
7c6d6f47bf
Revert "fix(native-filters): Fix update ownState (#17181)" (#17311)
This reverts commit cf284ba3c7.
2021-11-02 13:17:29 -07:00
Daman Arora
28b494c597
chore: migrate HiddenControl component from jsx to tsx (#17315)
* migrate HiddenControl component from jsx to tsx

* Update superset-frontend/src/explore/components/controls/HiddenControl.tsx

Co-authored-by: Erik Ritter <erik.ritter@airbnb.com>

* updating the type of value in the interface

* Update superset-frontend/src/explore/components/controls/HiddenControl.tsx

Co-authored-by: Erik Ritter <erik.ritter@airbnb.com>

Co-authored-by: Erik Ritter <erik.ritter@airbnb.com>
2021-11-02 11:51:16 -07:00
Geido
a2a457b7ef
fix(Dashboard): Sidepanel positioning (#17200)
* Refactor

* Adjust top offset

* Calculate padding chart list

* Check for standalone mode

* Rename standaloneMode
2021-11-02 19:28:16 +02:00
Geido
5491a4d13c
fix(Explore): Remove changes to the properties on cancel (#17184)
* Remove on close

* Fix lint

* Add tests
2021-11-02 19:27:56 +02:00
Ville Brofeldt
9515ba68dc
chore: bump superset-ui to 0.18.17 (#17310) 2021-11-02 09:13:33 +02:00
Elizabeth Thompson
bea8502ebd
run npm install to fix a bad package version (#17314) 2021-11-01 13:57:28 -07:00
Yongjie Zhao
1f2a7a40c4
fix: datatable crash when column is empty string (#17303)
* fix: datatable crash when column is empty string

* typo
2021-11-01 23:58:31 +08:00
jinghua-qa
abf24bbb5d
test: add native filter part2 (#17283)
* add native filter part2

* fix lint

* remove unused code

* fix lint after modified
2021-11-01 11:36:47 -03:00
AAfghahi
5948a9fd02
fix(AlertReportModal): Text Area Change (#17176)
* Text Area Change

* added unique key to component

* tests passing

* changed css

* data flow and naming convention
2021-10-29 15:30:20 -07:00
Hugh A. Miles II
d0bad96b1a
fix: Allow users to update database in Dataset Edit Modal (#17265)
* add condition to fix save

* remove console.log
2021-10-29 14:19:37 -07:00
Lyndsi Kay Williams
456efc0c20
fix(reports): Owners no longer showing undefined in reports (#17223)
* Owners no longer showing undefined

* Reverted owners change

* removed print

* Owners now defined - frontend only solution!

* Remove arbitrary space
2021-10-29 10:17:47 -07:00
Kamil Gabryjelski
fa44325a36
fix(explore): Metrics disappearing after removing metric from dataset (#17201)
* fix(explore): Metrics disappearing after removing metric from dataset

* fix test

* Apply fix to non-dnd controls

* Make adhoc metrics pick up changes from dataset columns

* Remove console log

* Fix bug in nondnd controls
2021-10-29 16:15:19 +02:00
jinghua-qa
9ef9adfd78
test: added some sanity test for native filter (#17231)
* add sanity native filter cypress e2e test

* add liscense

* fix front-end lint

* fix fail

* remove unuse import
2021-10-29 11:08:18 +08:00
John Bodley
ce558e0764
chore: bump superset-ui to 0.18.17 (#17270)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2021-10-28 14:44:57 -07:00
Yongjie Zhao
be6cca561d
chore: bump deckgl 0.4.13 (#17266) 2021-10-28 16:24:15 +08:00
Phillip Kelley-Dotson
93f59e055e
chore: remove supersetTheme with withTheme (#17069)
* remove supersettheme

* migrate Datasourceeditor to rtl

* lint fix

* remove file

* fix import

* fix test

* fix lint

* spread tests and remove unused code

* fix lint
2021-10-27 12:42:56 -07:00
Ajay M
65f1644208
feat(dashboard): Add description to the native filter (#17025)
* Adding description works

* Add some tests

* Fix tests

* Styled look good

* Tests successful

* Address PR comments

* fix a test
2021-10-27 11:45:31 -07:00
Yongjie Zhao
faf7c74e44
chore: bump superset-ui v0.18.16 (#17251)
* chore: import ES module from chart-controls

* chore: bump superset-ui v0.18.16
2021-10-27 23:35:48 +08:00
Ville Brofeldt
4316fe6ae6
fix(annotataion): handle required fields properly (#17234) 2021-10-27 08:42:28 +03:00
Ajay M
743f4b6512
Fix resetting does not clear form (#17217) 2021-10-26 19:13:47 -07:00
Michael S. Molina
dd71035e58
chore: Removes the ChartIcon component (#17216) 2021-10-26 09:02:31 -03:00
Yongjie Zhao
dbf5225e1f
chore: bump to superset-ui 0.18.15 (#17232)
* bump 0.18.15

* prettier and update lock file
2021-10-26 19:25:34 +08:00
Geido
5f8f67e679
Fix tools position (#17221) 2021-10-26 13:00:33 +03:00
Ben Elgren
3641093a44
allow owners to edit chart title (#17047) 2021-10-26 12:58:07 +03:00
Geido
48fd3c185c
chore: Add docs to the Select component props (#17171)
* Add docs

* Add overall description

* Remove trailing space
2021-10-26 12:50:23 +03:00
simcha90
cf284ba3c7
fix(native-filters): Fix update ownState (#17181)
* fix:fix get permission function

* fix: fix own state update

* refactor: fix CR notes
2021-10-26 11:39:16 +03:00
Evan Rusackas
ef01cbb625
fix: reenabling terser plugin for webpack (#17205)
* fix: reenabling terser plugin

* undoing accidental commit inclusion

* prettier 

* moving the dots.
2021-10-25 15:47:09 -06:00
Elizabeth Thompson
08aab3b399
use full results as csv type (#17194) 2021-10-25 09:36:10 -07:00
Michael S. Molina
4c96ae76e3
chore: Breaks the dataViewCommon folder into TableCollection and Pagination (#17132) 2021-10-25 08:47:24 -03:00
Michael S. Molina
55be249870
fix: Order of Select items when unselecting (#17169)
* fix: Order of Select items when unselecting

* Adds a property comparator that supports strings and numbers

* Uses a named export for propertyComparator
2021-10-25 08:47:01 -03:00
Shiva Raisinghani
ef3afbde82
refactor: Repeated boilerplate code between upload to database forms (#16756)
* abstract boilerplate code into class and rename csv to file

* add db migration

* fix some stuff

* more renaming of csv to file

* rename in translations

* update down revision

* update down revision

* bump chart version

* switch to alter column name approach in db migration

* fix db migration for MySQL

* db migration conflict
2021-10-25 13:53:06 +03:00
Hugh A. Miles II
b5246b29df
feat: Hide nav create with RBAC (#17157)
* recommit

* Update MenuRight.tsx
2021-10-23 03:47:56 -04:00
David Aaron Suddjian
a63a01f158
small changes to dashboard->explore code (#17145) 2021-10-22 10:53:01 -07:00
Youkyoung Cha
35cbcc4643
fix: auto refresh interval won't be updated (#17112)
* fix: auto refresh interval won't be updated

* leave only cirtical changes
2021-10-22 12:23:46 +03:00
Phillip Kelley-Dotson
824e62bd1f
fix: dropdown placement for cascading filters popover (#17046)
* inital fix

* remove content wrapper

* allow dropdown to overflow in long chart

* only pass through filtercontrol

* change to auto

* add ref and pass to child

* fix bug

* fix lint

* add type

* remove code

* add currrent param
2021-10-21 21:25:25 -06:00
Erik Ritter
80a459f43b
feat: support disabling domain sharding with a query param (#17177) 2021-10-21 12:49:59 -07:00
Geido
91199c30d8
Handle undefined (#17183) 2021-10-21 19:34:32 +03:00
Kamil Gabryjelski
860e481a97
fix(explore): timestamp format when copy datatable to clipboard (#17166)
* fix(explore): timestamp format when copy datatable to clipboard

* Fix test

* Fix test

* Use translation for aria label

* Memoize stringified cells

* Fix test
2021-10-21 16:05:14 +02:00
Geido
e5a03423f9
chore(Dashboard): Disable save button in Native Filters when an error is present (#17037)
* Disable save on error

* Remove removed erroredFilter

* Fix cdisabled check
2021-10-21 16:43:58 +03:00
Hugh A. Miles II
cd9e99402d
feat: Add prettier to pre-commit workflow (#17134)
* save

* fix

* fix pre-commit
2021-10-20 20:53:52 -04:00
Geido
f580f6bcba
fix(Explore): Undefined owners (#17167)
* Reconcile owners data

* Fix on save
2021-10-20 09:45:58 -06:00
Michael S. Molina
e32acd22fd
chore: Moves the datasource components to the components folder (#17130) 2021-10-20 08:13:24 -03:00
Phillip Kelley-Dotson
4cc095c10a
update ui packages to 18.14 (#17151) 2021-10-19 08:36:58 -07:00
AAfghahi
dacf79719e
remove title from cancel svg (#17147) 2021-10-18 17:03:55 -04:00
Grace Guo
96f4421961
fix: sql lab crash caused by invalid template (#17133) 2021-10-18 11:09:23 -07:00
Elizabeth Thompson
ae4ced8da6
fix: update values for default timezone selector (#17124)
* update values for default timezone selector

* fix casing and comment

* Update TimezoneSelector.test.tsx
2021-10-18 09:39:20 -07:00