pt
/
superset
mirror of https://github.com/apache/superset.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

chore(Embedded): Avoid creating a filter key for guest users (#26312) 

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
This commit is contained in:
Vitor Avila 2023-12-26 23:31:51 -03:00 committed by GitHub
parent 5f5a656835
commit fe9fbadade
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx
View File

@ -47,6 +47,7 @@ import { useTabId } from 'src/hooks/useTabId';
import { logEvent } from 'src/logger/actions';
import { LOG_ACTIONS_CHANGE_DASHBOARD_FILTER } from 'src/logger/LogUtils';
import { FilterBarOrientation, RootState } from 'src/dashboard/types';
import { UserWithPermissionsAndRoles } from 'src/types/bootstrapTypes';
import { checkIsApplyDisabled } from './utils';
import { FiltersBarProps } from './types';
import {
@ -149,6 +150,10 @@ const FilterBar: React.FC<FiltersBarProps> = ({
const canEdit = useSelector<RootState, boolean>(
({ dashboardInfo }) => dashboardInfo.dash_edit_perm,
);
const user: UserWithPermissionsAndRoles = useSelector<
RootState,
UserWithPermissionsAndRoles
>(state => state.user);
const [filtersInScope] = useSelectFiltersInScope(nativeFilterValues);
@ -220,7 +225,10 @@ const FilterBar: React.FC<FiltersBarProps> = ({
}, [dataMaskAppliedText, setDataMaskSelected]);
useEffect(() => {
publishDataMask(history, dashboardId, updateKey, dataMaskApplied, tabId);
// embedded users can't persist filter combinations
if (user?.userId) {
publishDataMask(history, dashboardId, updateKey, dataMaskApplied, tabId);
}
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [dashboardId, dataMaskAppliedText, history, updateKey, tabId]);