diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx index 25284126d0..61014a6e0f 100644 --- a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx +++ b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx @@ -47,6 +47,7 @@ import { useTabId } from 'src/hooks/useTabId'; import { logEvent } from 'src/logger/actions'; import { LOG_ACTIONS_CHANGE_DASHBOARD_FILTER } from 'src/logger/LogUtils'; import { FilterBarOrientation, RootState } from 'src/dashboard/types'; +import { UserWithPermissionsAndRoles } from 'src/types/bootstrapTypes'; import { checkIsApplyDisabled } from './utils'; import { FiltersBarProps } from './types'; import { @@ -149,6 +150,10 @@ const FilterBar: React.FC = ({ const canEdit = useSelector( ({ dashboardInfo }) => dashboardInfo.dash_edit_perm, ); + const user: UserWithPermissionsAndRoles = useSelector< + RootState, + UserWithPermissionsAndRoles + >(state => state.user); const [filtersInScope] = useSelectFiltersInScope(nativeFilterValues); @@ -220,7 +225,10 @@ const FilterBar: React.FC = ({ }, [dataMaskAppliedText, setDataMaskSelected]); useEffect(() => { - publishDataMask(history, dashboardId, updateKey, dataMaskApplied, tabId); + // embedded users can't persist filter combinations + if (user?.userId) { + publishDataMask(history, dashboardId, updateKey, dataMaskApplied, tabId); + } // eslint-disable-next-line react-hooks/exhaustive-deps }, [dashboardId, dataMaskAppliedText, history, updateKey, tabId]);