pt
/
superset
mirror of https://github.com/apache/superset.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

feat: supporting jinja templating in saved metrics (#15502) 

* feat: supporting jinja templating in saved metrics

* cutting the line length to fit requirements

* follwing PR I should have not created a new insance method

* running precommit locally and fixing the issue

Co-authored-by: Guy <guy@nexite.io>
This commit is contained in:
Guy Doulberg 2021-07-05 19:00:13 +03:00 committed by GitHub
parent 15796ea4ac
commit bee386e643
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
superset/connectors/sqla/models.py
View File

@ -413,7 +413,8 @@ class SqlMetric(Model, BaseMetric):
def get_sqla_col(self, label: Optional[str] = None) -> Column:
label = label or self.metric_name
sqla_col: ColumnClause = literal_column(self.expression)
tp = self.table.get_template_processor()
sqla_col: ColumnClause = literal_column(tp.process_template(self.expression))
return self.table.make_sqla_column_compatible(sqla_col, label)
@property