From bee386e643a202f182a5cffd03c460fc27efe959 Mon Sep 17 00:00:00 2001 From: Guy Doulberg Date: Mon, 5 Jul 2021 19:00:13 +0300 Subject: [PATCH] feat: supporting jinja templating in saved metrics (#15502) * feat: supporting jinja templating in saved metrics * cutting the line length to fit requirements * follwing PR I should have not created a new insance method * running precommit locally and fixing the issue Co-authored-by: Guy --- superset/connectors/sqla/models.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/superset/connectors/sqla/models.py b/superset/connectors/sqla/models.py index 7e3811a953..a6aeabfb51 100644 --- a/superset/connectors/sqla/models.py +++ b/superset/connectors/sqla/models.py @@ -413,7 +413,8 @@ class SqlMetric(Model, BaseMetric): def get_sqla_col(self, label: Optional[str] = None) -> Column: label = label or self.metric_name - sqla_col: ColumnClause = literal_column(self.expression) + tp = self.table.get_template_processor() + sqla_col: ColumnClause = literal_column(tp.process_template(self.expression)) return self.table.make_sqla_column_compatible(sqla_col, label) @property