pt/superset
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2024-09-12 00:29:39 -04:00
Code Issues Packages Projects Releases Wiki Activity

Explore update button labels (#3534)

Browse Source 
* resolve ui ambiguity

* resolve button name ambiguity

* update test
This commit is contained in:
timifasubaa 2017-09-28 14:40:11 -07:00 committed by Maxime Beauchemin
parent 17c7ca239a
commit 82b85d1d6c
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
superset/assets/javascripts/explore/components/DisplayQueryButton.jsx
View File

@ -93,7 +93,7 @@ export default class DisplayQueryButton extends React.PureComponent {
<ModalTrigger <ModalTrigger
animation={this.props.animation} animation={this.props.animation}
isButton isButton
triggerNode={<span>Query</span>} triggerNode={<span>View Query</span>}
modalTitle={t('Query')} modalTitle={t('Query')}
bsSize="large" bsSize="large"
beforeOpen={this.beforeOpen} beforeOpen={this.beforeOpen}

2
superset/assets/javascripts/explore/components/QueryAndSaveBtns.jsx
View File

@ -41,7 +41,7 @@ export default function QueryAndSaveBtns(
bsStyle={qryButtonStyle} bsStyle={qryButtonStyle}
disabled={!!errorMessage} disabled={!!errorMessage}
> >
<i className="fa fa-bolt" /> Query <i className="fa fa-bolt" /> Run Query
</Button> </Button>
); );

2
superset/assets/spec/javascripts/explore/components/QueryAndSaveBtns_spec.jsx
View File

@ -31,7 +31,7 @@ describe('QueryAndSaveButtons', () => {
}); });
it('renders buttons with correct text', () => { it('renders buttons with correct text', () => {
expect(wrapper.find(Button).contains(' Query')).to.eql(true); expect(wrapper.find(Button).contains(' Run Query')).to.eql(true);
expect(wrapper.find(Button).contains(' Save')).to.eql(true); expect(wrapper.find(Button).contains(' Save')).to.eql(true);
}); });