From 82b85d1d6cee4a10dd70b7b1146530799ca6f0c9 Mon Sep 17 00:00:00 2001 From: timifasubaa <30888507+timifasubaa@users.noreply.github.com> Date: Thu, 28 Sep 2017 14:40:11 -0700 Subject: [PATCH] Explore update button labels (#3534) * resolve ui ambiguity * resolve button name ambiguity * update test --- .../javascripts/explore/components/DisplayQueryButton.jsx | 2 +- .../assets/javascripts/explore/components/QueryAndSaveBtns.jsx | 2 +- .../javascripts/explore/components/QueryAndSaveBtns_spec.jsx | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/superset/assets/javascripts/explore/components/DisplayQueryButton.jsx b/superset/assets/javascripts/explore/components/DisplayQueryButton.jsx index 6c0a73a74e..da578cd65f 100644 --- a/superset/assets/javascripts/explore/components/DisplayQueryButton.jsx +++ b/superset/assets/javascripts/explore/components/DisplayQueryButton.jsx @@ -93,7 +93,7 @@ export default class DisplayQueryButton extends React.PureComponent { Query} + triggerNode={View Query} modalTitle={t('Query')} bsSize="large" beforeOpen={this.beforeOpen} diff --git a/superset/assets/javascripts/explore/components/QueryAndSaveBtns.jsx b/superset/assets/javascripts/explore/components/QueryAndSaveBtns.jsx index 8fe95fcba6..6926e16fc4 100644 --- a/superset/assets/javascripts/explore/components/QueryAndSaveBtns.jsx +++ b/superset/assets/javascripts/explore/components/QueryAndSaveBtns.jsx @@ -41,7 +41,7 @@ export default function QueryAndSaveBtns( bsStyle={qryButtonStyle} disabled={!!errorMessage} > - Query + Run Query ); diff --git a/superset/assets/spec/javascripts/explore/components/QueryAndSaveBtns_spec.jsx b/superset/assets/spec/javascripts/explore/components/QueryAndSaveBtns_spec.jsx index 4f7d4e1b05..fcb6371896 100644 --- a/superset/assets/spec/javascripts/explore/components/QueryAndSaveBtns_spec.jsx +++ b/superset/assets/spec/javascripts/explore/components/QueryAndSaveBtns_spec.jsx @@ -31,7 +31,7 @@ describe('QueryAndSaveButtons', () => { }); it('renders buttons with correct text', () => { - expect(wrapper.find(Button).contains(' Query')).to.eql(true); + expect(wrapper.find(Button).contains(' Run Query')).to.eql(true); expect(wrapper.find(Button).contains(' Save')).to.eql(true); });