mirror of https://github.com/apache/superset.git
fix: Add min-height for loading indicator to show up (#12288)
* Add min-height for loading indicator to show up * Remove unnecessary height
This commit is contained in:
parent
230c0c2357
commit
66349d86a4
|
@ -81,8 +81,9 @@ const defaultProps = {
|
||||||
};
|
};
|
||||||
|
|
||||||
const Styles = styled.div`
|
const Styles = styled.div`
|
||||||
|
min-height: ${p => p.height}px;
|
||||||
position: relative;
|
position: relative;
|
||||||
height: 100%;
|
|
||||||
.chart-tooltip {
|
.chart-tooltip {
|
||||||
opacity: 0.75;
|
opacity: 0.75;
|
||||||
font-size: ${({ theme }) => theme.typography.sizes.s}px;
|
font-size: ${({ theme }) => theme.typography.sizes.s}px;
|
||||||
|
@ -197,12 +198,17 @@ class Chart extends React.PureComponent {
|
||||||
</Alert>
|
</Alert>
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<ErrorBoundary
|
<ErrorBoundary
|
||||||
onError={this.handleRenderContainerFailure}
|
onError={this.handleRenderContainerFailure}
|
||||||
showMessage={false}
|
showMessage={false}
|
||||||
>
|
>
|
||||||
<Styles className="chart-container" data-test="chart-container">
|
<Styles
|
||||||
|
className="chart-container"
|
||||||
|
data-test="chart-container"
|
||||||
|
height={height}
|
||||||
|
>
|
||||||
<div
|
<div
|
||||||
className={`slice_container ${isFaded ? ' faded' : ''}`}
|
className={`slice_container ${isFaded ? ' faded' : ''}`}
|
||||||
data-test="slice-container"
|
data-test="slice-container"
|
||||||
|
|
Loading…
Reference in New Issue