From 66349d86a4ae8a9f3597a1b59a19e29c21d1b16a Mon Sep 17 00:00:00 2001
From: Geido <60598000+geido@users.noreply.github.com>
Date: Wed, 6 Jan 2021 00:36:17 +0100
Subject: [PATCH] fix: Add min-height for loading indicator to show up (#12288)

* Add min-height for loading indicator to show up

* Remove unnecessary height
---
 superset-frontend/src/chart/Chart.jsx | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/superset-frontend/src/chart/Chart.jsx b/superset-frontend/src/chart/Chart.jsx
index 20b3b982d5..3f1596cc45 100644
--- a/superset-frontend/src/chart/Chart.jsx
+++ b/superset-frontend/src/chart/Chart.jsx
@@ -81,8 +81,9 @@ const defaultProps = {
 };
 
 const Styles = styled.div`
+  min-height: ${p => p.height}px;
   position: relative;
-  height: 100%;
+
   .chart-tooltip {
     opacity: 0.75;
     font-size: ${({ theme }) => theme.typography.sizes.s}px;
@@ -197,12 +198,17 @@ class Chart extends React.PureComponent {
         </Alert>
       );
     }
+
     return (
       <ErrorBoundary
         onError={this.handleRenderContainerFailure}
         showMessage={false}
       >
-        <Styles className="chart-container" data-test="chart-container">
+        <Styles
+          className="chart-container"
+          data-test="chart-container"
+          height={height}
+        >
           <div
             className={`slice_container ${isFaded ? ' faded' : ''}`}
             data-test="slice-container"