pt
/
superset
mirror of https://github.com/apache/superset.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: Add min-height for loading indicator to show up (#12288) 

* Add min-height for loading indicator to show up

* Remove unnecessary height
This commit is contained in:
Geido 2021-01-06 00:36:17 +01:00 committed by GitHub
parent 230c0c2357
commit 66349d86a4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
superset-frontend/src/chart/Chart.jsx
View File

@ -81,8 +81,9 @@ const defaultProps = {
};
const Styles = styled.div`
min-height: ${p => p.height}px;
position: relative;
height: 100%;
.chart-tooltip {
opacity: 0.75;
font-size: ${({ theme }) => theme.typography.sizes.s}px;
@ -197,12 +198,17 @@ class Chart extends React.PureComponent {
</Alert>
);
}
return (
<ErrorBoundary
onError={this.handleRenderContainerFailure}
showMessage={false}
>
<Styles className="chart-container" data-test="chart-container">
<Styles
className="chart-container"
data-test="chart-container"
height={height}
>
<div
className={`slice_container ${isFaded ? ' faded' : ''}`}
data-test="slice-container"