pt/superset
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2024-09-06 13:57:40 -04:00
Code Issues Packages Projects Releases Wiki Activity

temp: remove possibly expensive computations from ChartHolder

Browse Source
This commit is contained in:
David Aaron Suddjian 2020-10-15 18:22:03 -07:00
parent 64c88b2cba
commit 37ce0214f0
1 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
superset-frontend/src/dashboard/components/gridComponents/ChartHolder.jsx
View File

@ -211,15 +211,15 @@ class ChartHolder extends React.Component {
} }
// figure out if this chart is in the focused filter's scope // figure out if this chart is in the focused filter's scope
const { chartId } = component.meta; // const { chartId } = component.meta;
const isFocusedFilterChart = // const isFocusedFilterChart =
focusedFilterScope && chartId === focusedFilterScope.chartId; // focusedFilterScope && chartId === focusedFilterScope.chartId;
const includedInFilterScope = // const includedInFilterScope =
focusedFilterScope && // focusedFilterScope &&
!isFocusedFilterChart && // !isFocusedFilterChart &&
getChartIdsInFilterScope({ // getChartIdsInFilterScope({
filterScope: focusedFilterScope.scope, // filterScope: focusedFilterScope.scope,
}).includes(chartId); // }).includes(chartId);
return ( return (
<DragDroppable <DragDroppable