pt
/
superset
mirror of https://github.com/apache/superset.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

chore: pylint reenable bad-option-value (#15775) 

Co-authored-by: John Bodley <john.bodley@airbnb.com>
This commit is contained in:
John Bodley 2021-07-21 09:34:08 -07:00 committed by GitHub
parent 5bce2538a2
commit 32a5680510
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
.pylintrc
View File

@ -88,7 +88,6 @@ disable=
import-outside-toplevel,
raise-missing-from,
super-with-arguments,
bad-option-value,
too-few-public-methods,
too-many-locals,

2
superset/commands/importers/v1/examples.py
View File

@ -135,5 +135,5 @@ class ImportExamplesCommand(ImportModelsCommand):
{"dashboard_id": dashboard_id, "slice_id": chart_id}
for (dashboard_id, chart_id) in dashboard_chart_ids
]
# pylint: disable=no-value-for-parameter (sqlalchemy/issues/4656)
# pylint: disable=no-value-for-parameter # sqlalchemy/issues/4656
session.execute(dashboard_slices.insert(), values)

2
superset/dashboards/commands/importers/v1/__init__.py
View File

@ -135,5 +135,5 @@ class ImportDashboardsCommand(ImportModelsCommand):
{"dashboard_id": dashboard_id, "slice_id": chart_id}
for (dashboard_id, chart_id) in dashboard_chart_ids
]
# pylint: disable=no-value-for-parameter (sqlalchemy/issues/4656)
# pylint: disable=no-value-for-parameter # sqlalchemy/issues/4656
session.execute(dashboard_slices.insert(), values)

2
superset/datasets/dao.py
View File

@ -143,7 +143,7 @@ class DatasetDAO(BaseDAO): # pylint: disable=too-many-public-methods
return len(dataset_query) == 0
@classmethod
def update( # pylint: disable=W:279
def update( # pylint: disable=arguments-differ
cls,
model: SqlaTable,
properties: Dict[str, Any],

4
superset/utils/mock_data.py
View File

@ -202,11 +202,11 @@ def add_data(
metadata.create_all(engine)
if not append:
# pylint: disable=no-value-for-parameter (sqlalchemy/issues/4656)
# pylint: disable=no-value-for-parameter # sqlalchemy/issues/4656
engine.execute(table.delete())
data = generate_data(columns, num_rows)
# pylint: disable=no-value-for-parameter (sqlalchemy/issues/4656)
# pylint: disable=no-value-for-parameter # sqlalchemy/issues/4656
engine.execute(table.insert(), data)