diff --git a/.pylintrc b/.pylintrc index 2a9b087514..aeb3371082 100644 --- a/.pylintrc +++ b/.pylintrc @@ -88,7 +88,6 @@ disable= import-outside-toplevel, raise-missing-from, super-with-arguments, - bad-option-value, too-few-public-methods, too-many-locals, diff --git a/superset/commands/importers/v1/examples.py b/superset/commands/importers/v1/examples.py index 2b56ee080d..e5f4a37175 100644 --- a/superset/commands/importers/v1/examples.py +++ b/superset/commands/importers/v1/examples.py @@ -135,5 +135,5 @@ class ImportExamplesCommand(ImportModelsCommand): {"dashboard_id": dashboard_id, "slice_id": chart_id} for (dashboard_id, chart_id) in dashboard_chart_ids ] - # pylint: disable=no-value-for-parameter (sqlalchemy/issues/4656) + # pylint: disable=no-value-for-parameter # sqlalchemy/issues/4656 session.execute(dashboard_slices.insert(), values) diff --git a/superset/dashboards/commands/importers/v1/__init__.py b/superset/dashboards/commands/importers/v1/__init__.py index c698e89af6..57c5087b79 100644 --- a/superset/dashboards/commands/importers/v1/__init__.py +++ b/superset/dashboards/commands/importers/v1/__init__.py @@ -135,5 +135,5 @@ class ImportDashboardsCommand(ImportModelsCommand): {"dashboard_id": dashboard_id, "slice_id": chart_id} for (dashboard_id, chart_id) in dashboard_chart_ids ] - # pylint: disable=no-value-for-parameter (sqlalchemy/issues/4656) + # pylint: disable=no-value-for-parameter # sqlalchemy/issues/4656 session.execute(dashboard_slices.insert(), values) diff --git a/superset/datasets/dao.py b/superset/datasets/dao.py index 68315be3b1..db7bbe04f5 100644 --- a/superset/datasets/dao.py +++ b/superset/datasets/dao.py @@ -143,7 +143,7 @@ class DatasetDAO(BaseDAO): # pylint: disable=too-many-public-methods return len(dataset_query) == 0 @classmethod - def update( # pylint: disable=W:279 + def update( # pylint: disable=arguments-differ cls, model: SqlaTable, properties: Dict[str, Any], diff --git a/superset/utils/mock_data.py b/superset/utils/mock_data.py index ce03553715..87278d2f15 100644 --- a/superset/utils/mock_data.py +++ b/superset/utils/mock_data.py @@ -202,11 +202,11 @@ def add_data( metadata.create_all(engine) if not append: - # pylint: disable=no-value-for-parameter (sqlalchemy/issues/4656) + # pylint: disable=no-value-for-parameter # sqlalchemy/issues/4656 engine.execute(table.delete()) data = generate_data(columns, num_rows) - # pylint: disable=no-value-for-parameter (sqlalchemy/issues/4656) + # pylint: disable=no-value-for-parameter # sqlalchemy/issues/4656 engine.execute(table.insert(), data)