mirror of https://github.com/apache/superset.git
feat: Adds chart ID option to migrate-viz
This commit is contained in:
parent
fe3ba12801
commit
2fe65a86e8
|
@ -14,10 +14,11 @@
|
|||
# KIND, either express or implied. See the License for the
|
||||
# specific language governing permissions and limitations
|
||||
# under the License.
|
||||
from __future__ import annotations
|
||||
|
||||
from enum import Enum
|
||||
|
||||
import click
|
||||
from click_option_group import optgroup, RequiredMutuallyExclusiveOptionGroup
|
||||
from flask.cli import with_appcontext
|
||||
|
||||
from superset import db
|
||||
|
@ -46,37 +47,43 @@ def migrate_viz() -> None:
|
|||
|
||||
@migrate_viz.command()
|
||||
@with_appcontext
|
||||
@optgroup.group(
|
||||
"Grouped options",
|
||||
cls=RequiredMutuallyExclusiveOptionGroup,
|
||||
)
|
||||
@optgroup.option(
|
||||
@click.option(
|
||||
"--viz_type",
|
||||
"-t",
|
||||
help=f"The viz type to migrate: {', '.join(list(VizType))}",
|
||||
help=f"The viz type to upgrade: {', '.join(list(VizType))}",
|
||||
required=True,
|
||||
)
|
||||
def upgrade(viz_type: str) -> None:
|
||||
@click.option(
|
||||
"--chart_id",
|
||||
help="The chart ID to upgrade",
|
||||
type=int,
|
||||
)
|
||||
def upgrade(viz_type: str, chart_id: int | None = None) -> None:
|
||||
"""Upgrade a viz to the latest version."""
|
||||
migrate(VizType(viz_type))
|
||||
migrate(VizType(viz_type), chart_id)
|
||||
|
||||
|
||||
@migrate_viz.command()
|
||||
@with_appcontext
|
||||
@optgroup.group(
|
||||
"Grouped options",
|
||||
cls=RequiredMutuallyExclusiveOptionGroup,
|
||||
)
|
||||
@optgroup.option(
|
||||
@click.option(
|
||||
"--viz_type",
|
||||
"-t",
|
||||
help=f"The viz type to migrate: {', '.join(list(VizType))}",
|
||||
help=f"The viz type to downgrade: {', '.join(list(VizType))}",
|
||||
required=True,
|
||||
)
|
||||
def downgrade(viz_type: str) -> None:
|
||||
@click.option(
|
||||
"--chart_id",
|
||||
help="The chart ID to downgrade",
|
||||
type=int,
|
||||
)
|
||||
def downgrade(viz_type: str, chart_id: int | None = None) -> None:
|
||||
"""Downgrade a viz to the previous version."""
|
||||
migrate(VizType(viz_type), is_downgrade=True)
|
||||
migrate(VizType(viz_type), chart_id, is_downgrade=True)
|
||||
|
||||
|
||||
def migrate(viz_type: VizType, is_downgrade: bool = False) -> None:
|
||||
def migrate(
|
||||
viz_type: VizType, chart_id: int | None = None, is_downgrade: bool = False
|
||||
) -> None:
|
||||
"""Migrate a viz from one type to another."""
|
||||
# pylint: disable=import-outside-toplevel
|
||||
from superset.migrations.shared.migrate_viz.processors import (
|
||||
|
@ -107,6 +114,6 @@ def migrate(viz_type: VizType, is_downgrade: bool = False) -> None:
|
|||
VizType.TREEMAP: MigrateTreeMap,
|
||||
}
|
||||
if is_downgrade:
|
||||
migrations[viz_type].downgrade(db.session)
|
||||
migrations[viz_type].downgrade(db.session, chart_id)
|
||||
else:
|
||||
migrations[viz_type].upgrade(db.session)
|
||||
migrations[viz_type].upgrade(db.session, chart_id)
|
||||
|
|
|
@ -153,8 +153,13 @@ class MigrateViz:
|
|||
slc.query_context = json.dumps(query_context)
|
||||
|
||||
@classmethod
|
||||
def upgrade(cls, session: Session) -> None:
|
||||
slices = session.query(Slice).filter(Slice.viz_type == cls.source_viz_type)
|
||||
def upgrade(cls, session: Session, chart_id: int | None = None) -> None:
|
||||
slices = session.query(Slice).filter(
|
||||
and_(
|
||||
Slice.viz_type == cls.source_viz_type,
|
||||
Slice.id == chart_id if chart_id is not None else True,
|
||||
)
|
||||
)
|
||||
for slc in paginated_update(
|
||||
slices,
|
||||
lambda current, total: print(f"Upgraded {current}/{total} charts"),
|
||||
|
@ -162,11 +167,12 @@ class MigrateViz:
|
|||
cls.upgrade_slice(slc)
|
||||
|
||||
@classmethod
|
||||
def downgrade(cls, session: Session) -> None:
|
||||
def downgrade(cls, session: Session, chart_id: int | None = None) -> None:
|
||||
slices = session.query(Slice).filter(
|
||||
and_(
|
||||
Slice.viz_type == cls.target_viz_type,
|
||||
Slice.params.like(f"%{FORM_DATA_BAK_FIELD_NAME}%"),
|
||||
Slice.id == chart_id if chart_id is not None else True,
|
||||
)
|
||||
)
|
||||
for slc in paginated_update(
|
||||
|
|
Loading…
Reference in New Issue