pt
/
superset
mirror of https://github.com/apache/superset.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

refactor: Adds the sort_by_metric control to sharedControls (#29325)

This commit is contained in:
Michael S. Molina 2024-06-21 14:10:33 -03:00 committed by GitHub
parent 79d84f30f5
commit fe3ba12801
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
11 changed files with 20 additions and 106 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/sharedControls.tsx
View File

@ -362,6 +362,14 @@ const temporal_columns_lookup: SharedControlConfig<'HiddenControl'> = {
),
};
const sort_by_metric: SharedControlConfig<'CheckboxControl'> = {
type: 'CheckboxControl',
label: t('Sort by metric'),
description: t(
'Whether to sort results by the selected metric in descending order.',
),
};
export default {
metrics: dndAdhocMetricsControl,
metric: dndAdhocMetricControl,
@ -400,4 +408,5 @@ export default {
show_empty_columns,
temporal_columns_lookup,
currency_format,
sort_by_metric,
};

13
superset-frontend/plugins/legacy-plugin-chart-chord/src/controlPanel.ts
View File

@ -33,18 +33,7 @@ const config: ControlPanelConfig = {
['metric'],
['adhoc_filters'],
['row_limit'],
[
{
name: 'sort_by_metric',
config: {
type: 'CheckboxControl',
label: t('Sort by metric'),
description: t(
'Whether to sort results by the selected metric in descending order.',
),
},
},
],
['sort_by_metric'],
],
},
{

13
superset-frontend/plugins/legacy-plugin-chart-heatmap/src/controlPanel.tsx
View File

@ -64,18 +64,7 @@ const config: ControlPanelConfig = {
['metric'],
['adhoc_filters'],
['row_limit'],
[
{
name: 'sort_by_metric',
config: {
type: 'CheckboxControl',
label: t('Sort by metric'),
description: t(
'Whether to sort results by the selected metric in descending order.',
),
},
},
],
['sort_by_metric'],
],
},
{

13
superset-frontend/plugins/legacy-plugin-chart-sankey/src/controlPanel.ts
View File

@ -49,18 +49,7 @@ const config: ControlPanelConfig = {
},
},
],
[
{
name: 'sort_by_metric',
config: {
type: 'CheckboxControl',
label: t('Sort by metric'),
description: t(
'Whether to sort results by the selected metric in descending order.',
),
},
},
],
['sort_by_metric'],
],
},
{

13
superset-frontend/plugins/legacy-plugin-chart-world-map/src/controlPanel.ts
View File

@ -54,18 +54,7 @@ const config: ControlPanelConfig = {
['metric'],
['adhoc_filters'],
['row_limit'],
[
{
name: 'sort_by_metric',
config: {
type: 'CheckboxControl',
label: t('Sort by metric'),
description: t(
'Whether to sort results by the selected metric in descending order.',
),
},
},
],
['sort_by_metric'],
],
},
{

6
superset-frontend/plugins/plugin-chart-echarts/src/Funnel/controlPanel.tsx
View File

@ -62,12 +62,8 @@ const config: ControlPanelConfig = {
{
name: 'sort_by_metric',
config: {
...sharedControls.sort_by_metric,
default: true,
type: 'CheckboxControl',
label: t('Sort by metric'),
description: t(
'Whether to sort results by the selected metric in descending order.',
),
},
},
],

13
superset-frontend/plugins/plugin-chart-echarts/src/Gauge/controlPanel.tsx
View File

@ -53,18 +53,7 @@ const config: ControlPanelConfig = {
},
},
],
[
{
name: 'sort_by_metric',
config: {
type: 'CheckboxControl',
label: t('Sort by metric'),
description: t(
'Whether to sort results by the selected metric in descending order.',
),
},
},
],
['sort_by_metric'],
],
},
{

7
superset-frontend/plugins/plugin-chart-echarts/src/Pie/controlPanel.tsx
View File

@ -26,6 +26,7 @@ import {
D3_FORMAT_OPTIONS,
D3_TIME_FORMAT_OPTIONS,
getStandardizedControls,
sharedControls,
} from '@superset-ui/chart-controls';
import { DEFAULT_FORM_DATA } from './types';
import { legendSection } from '../controls';
@ -56,12 +57,8 @@ const config: ControlPanelConfig = {
{
name: 'sort_by_metric',
config: {
...sharedControls.sort_by_metric,
default: true,
type: 'CheckboxControl',
label: t('Sort by metric'),
description: t(
'Whether to sort results by the selected metric in descending order.',
),
},
},
],

13
superset-frontend/plugins/plugin-chart-echarts/src/Sunburst/controlPanel.tsx
View File

@ -42,18 +42,7 @@ const config: ControlPanelConfig = {
['secondary_metric'],
['adhoc_filters'],
['row_limit'],
[
{
name: 'sort_by_metric',
config: {
type: 'CheckboxControl',
label: t('Sort by metric'),
description: t(
'Whether to sort results by the selected metric in descending order.',
),
},
},
],
['sort_by_metric'],
],
},
{

13
superset-frontend/plugins/plugin-chart-echarts/src/Treemap/controlPanel.tsx
View File

@ -40,18 +40,7 @@ const config: ControlPanelConfig = {
['groupby'],
['metric'],
['row_limit'],
[
{
name: 'sort_by_metric',
config: {
type: 'CheckboxControl',
label: t('Sort by metric'),
description: t(
'Whether to sort results by the selected metric in descending order.',
),
},
},
],
['sort_by_metric'],
['adhoc_filters'],
],
},

13
superset-frontend/plugins/plugin-chart-word-cloud/src/plugin/controlPanel.ts
View File

@ -32,18 +32,7 @@ const config: ControlPanelConfig = {
['metric'],
['adhoc_filters'],
['row_limit'],
[
{
name: 'sort_by_metric',
config: {
type: 'CheckboxControl',
label: t('Sort by metric'),
description: t(
'Whether to sort results by the selected metric in descending order.',
),
},
},
],
['sort_by_metric'],
],
},
{