mirror of
https://github.com/apache/superset.git
synced 2024-09-19 20:19:37 -04:00
9fe30ab71e
* getting rid of weird focus/active outline ring
* Buttons... buttons _everywhere_
* linting
* Nixing views/CRUD/dataset/Button component
* fixing 2 typing errors
* fixing more TS errors
* prefer src path for include
* one more real button, one less CSS class
* one more "button" to "Button"
* Published Status is now a proper clickable Label
* nixing the CRUD button again
* touching up stories, with SupersetButton story
* SIP-34 button colors
* adding polished package to mix colors
* updating button colors to match Superset theme
* abstracting away from bootstrap-specific props (might pivot libraries soon!)
* more abstraction from bsStyle/bsSize props
* exchanging styles for a prop
* linting
* restoring feature flag to stock
* using src alias
* last <button> replacement
* this classname would never be applied
* more linting action
* fixing unsupported bsSize 'medium', and cta typing error
* more cta action
* unnecessary styles
* errant bsSize prop
* cleanup
* tweaks to make new New button work
* Linting
* fixing a couple tests
* fixing theme based test failure
* margin tweak for NEW button
* another fixed test
* another fixed test
* fixing two more tests
* fixing last broken tests.
* always be linting
* Adding tertiary/dashed buttons
* cleaning up QueryAndSave buttons
* fixing "link" button styles
* fixing/updating link button styles
* cta buttons on Modal component
* linting.
* exporting button story knobs, making ALL knobs safe for export.
* capitalizing a file... no big whoop
* Basic button tests
* renaming button - temporarily
* renaming file to fix capitalization issue
* passing theme through to a difficult popover.
* fixin' a newly busted unit test
* lint fixin'
* oops, shouldn't have changed this prop!
* adding a dive() to themedShallow, and fixing a cypress/jest test
* addressing lint stuff
* touching up stories, with SupersetButton story
* SIP-34 button colors
* updating button colors to match Superset theme
* abstracting away from bootstrap-specific props (might pivot libraries soon!)
* linting
* restoring feature flag to stock
* cleanup
* Linting
* renaming button - temporarily
* renaming file to fix capitalization issue
* oops, shouldn't have changed this prop!
* adding a dive() to themedShallow, and fixing a cypress/jest test
* addressing lint stuff
* nixing new modal button
* Fixing another popover/button issue that should break cypress
* lint ✨
* passing classNames through to new button (should fix some tests)
* cleaning unused classes, making cypress tests use data attrs
* fixin' the test
* fixing another class-based test with data-test attr
* no longer passing theme as prop to buttons in popovers... themeprovider is better
* outline/border tweaks!
67 lines
2.2 KiB
JavaScript
67 lines
2.2 KiB
JavaScript
/**
|
|
* Licensed to the Apache Software Foundation (ASF) under one
|
|
* or more contributor license agreements. See the NOTICE file
|
|
* distributed with this work for additional information
|
|
* regarding copyright ownership. The ASF licenses this file
|
|
* to you under the Apache License, Version 2.0 (the
|
|
* "License"); you may not use this file except in compliance
|
|
* with the License. You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing,
|
|
* software distributed under the License is distributed on an
|
|
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
* KIND, either express or implied. See the License for the
|
|
* specific language governing permissions and limitations
|
|
* under the License.
|
|
*/
|
|
/* eslint-disable no-unused-expressions */
|
|
import React from 'react';
|
|
import sinon from 'sinon';
|
|
import { styledShallow as shallow } from 'spec/helpers/theming';
|
|
import { OverlayTrigger } from 'react-bootstrap';
|
|
|
|
import Label from 'src/components/Label';
|
|
import AdhocMetric from 'src/explore/AdhocMetric';
|
|
import AdhocMetricOption from 'src/explore/components/AdhocMetricOption';
|
|
import { AGGREGATES } from 'src/explore/constants';
|
|
|
|
const columns = [
|
|
{ type: 'VARCHAR(255)', column_name: 'source' },
|
|
{ type: 'VARCHAR(255)', column_name: 'target' },
|
|
{ type: 'DOUBLE', column_name: 'value' },
|
|
];
|
|
|
|
const sumValueAdhocMetric = new AdhocMetric({
|
|
column: columns[2],
|
|
aggregate: AGGREGATES.SUM,
|
|
});
|
|
|
|
function setup(overrides) {
|
|
const onMetricEdit = sinon.spy();
|
|
const props = {
|
|
adhocMetric: sumValueAdhocMetric,
|
|
onMetricEdit,
|
|
columns,
|
|
...overrides,
|
|
};
|
|
const wrapper = shallow(<AdhocMetricOption {...props} />).dive();
|
|
return { wrapper, onMetricEdit };
|
|
}
|
|
|
|
describe('AdhocMetricOption', () => {
|
|
it('renders an overlay trigger wrapper for the label', () => {
|
|
const { wrapper } = setup();
|
|
expect(wrapper.find(OverlayTrigger)).toExist();
|
|
expect(wrapper.find(Label)).toExist();
|
|
});
|
|
|
|
it('overlay should open if metric is new', () => {
|
|
const { wrapper } = setup({
|
|
adhocMetric: sumValueAdhocMetric.duplicateWith({ isNew: true }),
|
|
});
|
|
expect(wrapper.find(OverlayTrigger).props().defaultOverlayShown).toBe(true);
|
|
});
|
|
});
|