mirror of
https://github.com/apache/superset.git
synced 2024-09-12 00:29:39 -04:00
97718daea3
Fixes a series of unexpected things around control validation. * when a chart opens in a state where a control is invalid, it still runs the query, and sometimes gets stuck in what appears to be a 'running' state. After this change, no query is run, and a warning is displayed in the chart panel body, just like any other error would * validation used to be done in the <Control> component and alter the redux store as it went. Clearly this is not the right approach, now validation occurs on loading the initial redux state, as well as in the reducer when controls are changed * currently, when going from a invalid control state to a valid one (user addresses what is needed), it auto-triggers a query which can be unexpected. After this change, the error message disappears, and the "Run Query" overlay gets displayed * when changing viz type, it's common to get new validation errors, and currently when that occurs it will still go ahead and run a query with invalid inputs, which often results in errors that are not well handled, since much of the logic assumes control-validated input. * prettier control validation messages (cherry picked from commit a3212eba5df95bca834d8d6d98c11d522d9172f3)
83 lines
1.6 KiB
Plaintext
83 lines
1.6 KiB
Plaintext
#
|
|
# Licensed to the Apache Software Foundation (ASF) under one or more
|
|
# contributor license agreements. See the NOTICE file distributed with
|
|
# this work for additional information regarding copyright ownership.
|
|
# The ASF licenses this file to You under the Apache License, Version 2.0
|
|
# (the "License"); you may not use this file except in compliance with
|
|
# the License. You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
#
|
|
*.bak
|
|
*.db
|
|
*.pyc
|
|
*.sqllite
|
|
*.swp
|
|
.cache-loader
|
|
.coverage
|
|
.DS_Store
|
|
.eggs
|
|
.idea
|
|
.python-version
|
|
.tox
|
|
.vscode
|
|
_build
|
|
_images
|
|
_modules
|
|
_static
|
|
build
|
|
app.db
|
|
apache_superset.egg-info/
|
|
changelog.sh
|
|
dist
|
|
dump.rdb
|
|
env
|
|
env_py3
|
|
envpy3
|
|
env36
|
|
local_config.py
|
|
superset_config.py
|
|
superset.egg-info/
|
|
superset/bin/supersetc
|
|
tmp
|
|
|
|
# Node.js, webpack artifacts
|
|
*.entry.js
|
|
*.js.map
|
|
node_modules
|
|
npm-debug.log*
|
|
superset/assets/coverage/*
|
|
superset/assets/cypress/screenshots
|
|
superset/assets/cypress/videos
|
|
superset/assets/version_info.json
|
|
yarn-error.log
|
|
|
|
# IntelliJ
|
|
*.iml
|
|
venv
|
|
@eaDir/
|
|
|
|
# Docker
|
|
./Dockerfile
|
|
./docker-build.sh
|
|
./docker-compose.yml
|
|
./docker-entrypoint.sh
|
|
./docker-init.sh
|
|
|
|
# Test data
|
|
celery_results.sqlite
|
|
celerybeat-schedule
|
|
celerydb.sqlite
|
|
celerybeat.pid
|
|
geckodriver.log
|
|
ghostdriver.log
|
|
testCSV.csv
|
|
.terser-plugin-cache/
|
|
apache-superset-*.tar.gz*
|