superset/superset-frontend
Maxime Beauchemin 98a71be80b
feat: [explore] don't save filters inherited from a dashboard (#9340)
* feat: [explore] don't save filters inherited from a dashboard

When navigating to explore from a dashboard context, the current
dashboard filter(s) are passed along to explore so that the context is
kept. So say you're filtering on "country=Romania", in your dashboard
and pivot to explore, that filter is still there and keep on exploring.

Now a common issue is that you'll want to make some tweak to your chart
that are unrelated to the filter, say toggling the legend off for
instance, and then save it. Now you back to your dashboard and even
though you started with an "all countries" dashboard, with a global
filter on country, now that one chart is stuck on "Romania". Typically
you notice this when filtering on something else, say "Italy" and then
that one chart now has two mutually exclusive filters, and show "No data".

Now, the fix is to flag the filter as "extra" (that's the not-so-good internal
name we use for these inherited filters) and make it clear that that
specific filter is special and won't be saved when saving the chart.

* fix build
2020-03-23 23:05:00 -07:00
..
branding SIP-32: Moving frontend code to the base of the repo (#9098) 2020-02-09 17:53:56 -08:00
cypress-base [log] Add dashboard_id param to explore_json request (#9243) 2020-03-08 19:51:08 -07:00
images SIP-32: Moving frontend code to the base of the repo (#9098) 2020-02-09 17:53:56 -08:00
spec feat: [explore] don't save filters inherited from a dashboard (#9340) 2020-03-23 23:05:00 -07:00
src feat: [explore] don't save filters inherited from a dashboard (#9340) 2020-03-23 23:05:00 -07:00
stylesheets Introducing Inter UI & Fira typefaces (#9207) 2020-03-04 17:32:08 -08:00
.eslintignore Upgrade typescript to 3.8.2 (#9189) 2020-02-25 08:44:26 -08:00
.eslintrc.js chore: allow webpack-dev-server proxy to any destination (#9296) 2020-03-17 15:37:07 -07:00
.gitignore Upgrade typescript to 3.8.2 (#9189) 2020-02-25 08:44:26 -08:00
.prettierrc SIP-32: Moving frontend code to the base of the repo (#9098) 2020-02-09 17:53:56 -08:00
babel.config.js Build: optimize frontend build configs to improve superset-ui-plugin dev experience (#9326) 2020-03-19 14:57:39 -07:00
cypress_build.sh SIP-32: Moving frontend code to the base of the repo (#9098) 2020-02-09 17:53:56 -08:00
jest.config.js Build: optimize frontend build configs to improve superset-ui-plugin dev experience (#9326) 2020-03-19 14:57:39 -07:00
js_build.sh SIP-32: Moving frontend code to the base of the repo (#9098) 2020-02-09 17:53:56 -08:00
package-lock.json feat: bump deckgl plugin version (#9325) 2020-03-19 17:51:09 -07:00
package.json feat: bump deckgl plugin version (#9325) 2020-03-19 17:51:09 -07:00
tsconfig.json Build: optimize frontend build configs to improve superset-ui-plugin dev experience (#9326) 2020-03-19 14:57:39 -07:00
webpack.config.js Build: optimize frontend build configs to improve superset-ui-plugin dev experience (#9326) 2020-03-19 14:57:39 -07:00
webpack.proxy-config.js Build: optimize frontend build configs to improve superset-ui-plugin dev experience (#9326) 2020-03-19 14:57:39 -07:00