mirror of
https://github.com/apache/superset.git
synced 2024-09-12 08:39:45 -04:00
5a1c68177e
* fix(elasticsearch): cast does not take effect for time zone settings * test(elasticsearch): add test * fix(test): fix typo * docs(elasticsearch): add annotation * docs(elasticsearch): add time_zone desc * docs(elasticsearch): fix typo * refactor(db_engine): change convert_dttm signature * fix(test): fix test * fix(es): add try catch * fix(test): fix caplog * fix(test): fix typo
105 lines
3.5 KiB
Python
105 lines
3.5 KiB
Python
# Licensed to the Apache Software Foundation (ASF) under one
|
|
# or more contributor license agreements. See the NOTICE file
|
|
# distributed with this work for additional information
|
|
# regarding copyright ownership. The ASF licenses this file
|
|
# to you under the Apache License, Version 2.0 (the
|
|
# "License"); you may not use this file except in compliance
|
|
# with the License. You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing,
|
|
# software distributed under the License is distributed on an
|
|
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
# KIND, either express or implied. See the License for the
|
|
# specific language governing permissions and limitations
|
|
# under the License.
|
|
from unittest.mock import MagicMock
|
|
|
|
import pytest
|
|
from sqlalchemy import column
|
|
|
|
from superset.db_engine_specs.elasticsearch import (
|
|
ElasticSearchEngineSpec,
|
|
OpenDistroEngineSpec,
|
|
)
|
|
from tests.integration_tests.db_engine_specs.base_tests import TestDbEngineSpec
|
|
|
|
|
|
class TestElasticSearchDbEngineSpec(TestDbEngineSpec):
|
|
@pytest.fixture(autouse=True)
|
|
def inject_fixtures(self, caplog):
|
|
self._caplog = caplog
|
|
|
|
def test_convert_dttm(self):
|
|
dttm = self.get_dttm()
|
|
|
|
self.assertEqual(
|
|
ElasticSearchEngineSpec.convert_dttm("DATETIME", dttm, db_extra=None),
|
|
"CAST('2019-01-02T03:04:05' AS DATETIME)",
|
|
)
|
|
|
|
def test_convert_dttm2(self):
|
|
"""
|
|
ES 7.8 and above versions need to use the DATETIME_PARSE function to
|
|
solve the time zone problem
|
|
"""
|
|
dttm = self.get_dttm()
|
|
db_extra = {"version": "7.8"}
|
|
|
|
self.assertEqual(
|
|
ElasticSearchEngineSpec.convert_dttm("DATETIME", dttm, db_extra=db_extra),
|
|
"DATETIME_PARSE('2019-01-02 03:04:05', 'yyyy-MM-dd HH:mm:ss')",
|
|
)
|
|
|
|
def test_convert_dttm3(self):
|
|
dttm = self.get_dttm()
|
|
db_extra = {"version": 7.8}
|
|
|
|
self.assertEqual(
|
|
ElasticSearchEngineSpec.convert_dttm("DATETIME", dttm, db_extra=db_extra),
|
|
"CAST('2019-01-02T03:04:05' AS DATETIME)",
|
|
)
|
|
|
|
self.assertNotEqual(
|
|
ElasticSearchEngineSpec.convert_dttm("DATETIME", dttm, db_extra=db_extra),
|
|
"DATETIME_PARSE('2019-01-02 03:04:05', 'yyyy-MM-dd HH:mm:ss')",
|
|
)
|
|
|
|
self.assertIn("Unexpected error while convert es_version", self._caplog.text)
|
|
|
|
def test_opendistro_convert_dttm(self):
|
|
"""
|
|
DB Eng Specs (opendistro): Test convert_dttm
|
|
"""
|
|
dttm = self.get_dttm()
|
|
|
|
self.assertEqual(
|
|
OpenDistroEngineSpec.convert_dttm("DATETIME", dttm, db_extra=None),
|
|
"'2019-01-02T03:04:05'",
|
|
)
|
|
|
|
def test_opendistro_sqla_column_label(self):
|
|
"""
|
|
DB Eng Specs (opendistro): Test column label
|
|
"""
|
|
test_cases = {
|
|
"Col": "Col",
|
|
"Col.keyword": "Col_keyword",
|
|
}
|
|
for original, expected in test_cases.items():
|
|
actual = OpenDistroEngineSpec.make_label_compatible(column(original).name)
|
|
self.assertEqual(actual, expected)
|
|
|
|
def test_opendistro_strip_comments(self):
|
|
"""
|
|
DB Eng Specs (opendistro): Test execute sql strip comments
|
|
"""
|
|
mock_cursor = MagicMock()
|
|
mock_cursor.execute.return_value = []
|
|
|
|
OpenDistroEngineSpec.execute(
|
|
mock_cursor, "-- some comment \nSELECT 1\n --other comment"
|
|
)
|
|
mock_cursor.execute.assert_called_once_with("SELECT 1\n")
|