mirror of https://github.com/apache/superset.git
60 lines
1.7 KiB
YAML
60 lines
1.7 KiB
YAML
name: Prefer Typescript
|
|
|
|
on:
|
|
push:
|
|
branches-ignore:
|
|
- "dependabot/**"
|
|
pull_request:
|
|
|
|
jobs:
|
|
prefer_typescript:
|
|
if: github.ref == 'ref/heads/master' && github.event_name == 'pull_request'
|
|
name: Prefer Typescript
|
|
runs-on: ubuntu-latest
|
|
permissions:
|
|
contents: read
|
|
pull-requests: write
|
|
steps:
|
|
- name: "Checkout ${{ github.ref }} ( ${{ github.sha }} )"
|
|
uses: actions/checkout@v3
|
|
with:
|
|
persist-credentials: false
|
|
submodules: recursive
|
|
- name: Get changed files
|
|
id: changed
|
|
uses: ./.github/actions/file-changes-action
|
|
with:
|
|
githubToken: ${{ github.token }}
|
|
|
|
- name: Determine if a .js or .jsx file was added
|
|
id: check
|
|
run: |
|
|
js_files_added() {
|
|
jq -r '
|
|
map(
|
|
select(
|
|
endswith(".js") or endswith(".jsx")
|
|
)
|
|
) | join("\n")
|
|
' ${HOME}/files_added.json
|
|
}
|
|
echo ::set-output name=js_files_added::$(js_files_added)
|
|
|
|
- if: steps.check.outputs.js_files_added
|
|
name: Add Comment to PR
|
|
uses: ./.github/actions/comment-on-pr
|
|
continue-on-error: true
|
|
env:
|
|
GITHUB_TOKEN: ${{ github.token }}
|
|
with:
|
|
msg: |
|
|
### WARNING: Prefer TypeScript
|
|
|
|
Looks like your PR contains new `.js` or `.jsx` files:
|
|
|
|
```
|
|
${{steps.check.outputs.js_files_added}}
|
|
```
|
|
|
|
As decided in [SIP-36](https://github.com/apache/superset/issues/9101), all new frontend code should be written in TypeScript. Please convert above files to TypeScript then re-request review.
|