mirror of
https://github.com/apache/superset.git
synced 2024-09-19 12:09:42 -04:00
9fe30ab71e
* getting rid of weird focus/active outline ring
* Buttons... buttons _everywhere_
* linting
* Nixing views/CRUD/dataset/Button component
* fixing 2 typing errors
* fixing more TS errors
* prefer src path for include
* one more real button, one less CSS class
* one more "button" to "Button"
* Published Status is now a proper clickable Label
* nixing the CRUD button again
* touching up stories, with SupersetButton story
* SIP-34 button colors
* adding polished package to mix colors
* updating button colors to match Superset theme
* abstracting away from bootstrap-specific props (might pivot libraries soon!)
* more abstraction from bsStyle/bsSize props
* exchanging styles for a prop
* linting
* restoring feature flag to stock
* using src alias
* last <button> replacement
* this classname would never be applied
* more linting action
* fixing unsupported bsSize 'medium', and cta typing error
* more cta action
* unnecessary styles
* errant bsSize prop
* cleanup
* tweaks to make new New button work
* Linting
* fixing a couple tests
* fixing theme based test failure
* margin tweak for NEW button
* another fixed test
* another fixed test
* fixing two more tests
* fixing last broken tests.
* always be linting
* Adding tertiary/dashed buttons
* cleaning up QueryAndSave buttons
* fixing "link" button styles
* fixing/updating link button styles
* cta buttons on Modal component
* linting.
* exporting button story knobs, making ALL knobs safe for export.
* capitalizing a file... no big whoop
* Basic button tests
* renaming button - temporarily
* renaming file to fix capitalization issue
* passing theme through to a difficult popover.
* fixin' a newly busted unit test
* lint fixin'
* oops, shouldn't have changed this prop!
* adding a dive() to themedShallow, and fixing a cypress/jest test
* addressing lint stuff
* touching up stories, with SupersetButton story
* SIP-34 button colors
* updating button colors to match Superset theme
* abstracting away from bootstrap-specific props (might pivot libraries soon!)
* linting
* restoring feature flag to stock
* cleanup
* Linting
* renaming button - temporarily
* renaming file to fix capitalization issue
* oops, shouldn't have changed this prop!
* adding a dive() to themedShallow, and fixing a cypress/jest test
* addressing lint stuff
* nixing new modal button
* Fixing another popover/button issue that should break cypress
* lint ✨
* passing classNames through to new button (should fix some tests)
* cleaning unused classes, making cypress tests use data attrs
* fixin' the test
* fixing another class-based test with data-test attr
* no longer passing theme as prop to buttons in popovers... themeprovider is better
* outline/border tweaks!
143 lines
5.0 KiB
JavaScript
143 lines
5.0 KiB
JavaScript
/**
|
|
* Licensed to the Apache Software Foundation (ASF) under one
|
|
* or more contributor license agreements. See the NOTICE file
|
|
* distributed with this work for additional information
|
|
* regarding copyright ownership. The ASF licenses this file
|
|
* to you under the Apache License, Version 2.0 (the
|
|
* "License"); you may not use this file except in compliance
|
|
* with the License. You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing,
|
|
* software distributed under the License is distributed on an
|
|
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
* KIND, either express or implied. See the License for the
|
|
* specific language governing permissions and limitations
|
|
* under the License.
|
|
*/
|
|
import { Provider } from 'react-redux';
|
|
import React from 'react';
|
|
import { styledMount as mount } from 'spec/helpers/theming';
|
|
import sinon from 'sinon';
|
|
|
|
import DashboardComponent from 'src/dashboard/containers/DashboardComponent';
|
|
import DeleteComponentModal from 'src/dashboard/components/DeleteComponentModal';
|
|
import DragDroppable from 'src/dashboard/components/dnd/DragDroppable';
|
|
import EditableTitle from 'src/components/EditableTitle';
|
|
import WithPopoverMenu from 'src/dashboard/components/menu/WithPopoverMenu';
|
|
import Tab, {
|
|
RENDER_TAB,
|
|
RENDER_TAB_CONTENT,
|
|
} from 'src/dashboard/components/gridComponents/Tab';
|
|
import WithDragDropContext from '../../helpers/WithDragDropContext';
|
|
import { dashboardLayoutWithTabs } from '../../fixtures/mockDashboardLayout';
|
|
import { mockStoreWithTabs } from '../../fixtures/mockStore';
|
|
|
|
describe('Tabs', () => {
|
|
const props = {
|
|
id: 'TAB_ID',
|
|
parentId: 'TABS_ID',
|
|
component: dashboardLayoutWithTabs.present.TAB_ID,
|
|
parentComponent: dashboardLayoutWithTabs.present.TABS_ID,
|
|
index: 0,
|
|
depth: 1,
|
|
editMode: false,
|
|
renderType: RENDER_TAB,
|
|
onDropOnTab() {},
|
|
onDeleteTab() {},
|
|
availableColumnCount: 12,
|
|
columnWidth: 50,
|
|
onResizeStart() {},
|
|
onResize() {},
|
|
onResizeStop() {},
|
|
createComponent() {},
|
|
handleComponentDrop() {},
|
|
onChangeTab() {},
|
|
deleteComponent() {},
|
|
updateComponents() {},
|
|
};
|
|
|
|
function setup(overrideProps) {
|
|
// We have to wrap provide DragDropContext for the underlying DragDroppable
|
|
// otherwise we cannot assert on DragDroppable children
|
|
const wrapper = mount(
|
|
<Provider store={mockStoreWithTabs}>
|
|
<WithDragDropContext>
|
|
<Tab {...props} {...overrideProps} />
|
|
</WithDragDropContext>
|
|
</Provider>,
|
|
);
|
|
return wrapper;
|
|
}
|
|
|
|
describe('renderType=RENDER_TAB', () => {
|
|
it('should render a DragDroppable', () => {
|
|
const wrapper = setup();
|
|
expect(wrapper.find(DragDroppable)).toExist();
|
|
});
|
|
|
|
it('should render an EditableTitle with meta.text', () => {
|
|
const wrapper = setup();
|
|
const title = wrapper.find(EditableTitle);
|
|
expect(title).toHaveLength(1);
|
|
expect(title.find('input').prop('value')).toBe(props.component.meta.text);
|
|
});
|
|
|
|
it('should call updateComponents when EditableTitle changes', () => {
|
|
const updateComponents = sinon.spy();
|
|
const wrapper = setup({ editMode: true, updateComponents });
|
|
wrapper.find(EditableTitle).prop('onSaveTitle')('New title');
|
|
|
|
expect(updateComponents.callCount).toBe(1);
|
|
expect(updateComponents.getCall(0).args[0].TAB_ID.meta.text).toBe(
|
|
'New title',
|
|
);
|
|
});
|
|
|
|
it('should render a WithPopoverMenu', () => {
|
|
const wrapper = setup();
|
|
expect(wrapper.find(WithPopoverMenu)).toExist();
|
|
});
|
|
|
|
it('should render a DeleteComponentModal when focused if its not the only tab', () => {
|
|
let wrapper = setup();
|
|
wrapper.find(WithPopoverMenu).simulate('click'); // focus
|
|
expect(wrapper.find(DeleteComponentModal)).not.toExist();
|
|
|
|
wrapper = setup({ editMode: true });
|
|
wrapper.find(WithPopoverMenu).simulate('click');
|
|
expect(wrapper.find(DeleteComponentModal)).toExist();
|
|
|
|
wrapper = setup({
|
|
editMode: true,
|
|
parentComponent: {
|
|
...props.parentComponent,
|
|
children: props.parentComponent.children.slice(0, 1),
|
|
},
|
|
});
|
|
wrapper.find(WithPopoverMenu).simulate('click');
|
|
expect(wrapper.find(DeleteComponentModal)).not.toExist();
|
|
});
|
|
|
|
it('should show modal when clicked delete icon', () => {
|
|
const deleteComponent = sinon.spy();
|
|
const wrapper = setup({ editMode: true, deleteComponent });
|
|
wrapper.find(WithPopoverMenu).simulate('click'); // focus
|
|
wrapper.find('.icon-button').simulate('click');
|
|
|
|
const modal = document.getElementsByClassName('modal');
|
|
expect(modal).toHaveLength(1);
|
|
expect(deleteComponent.callCount).toBe(0);
|
|
});
|
|
});
|
|
|
|
describe('renderType=RENDER_TAB_CONTENT', () => {
|
|
it('should render a DashboardComponent', () => {
|
|
const wrapper = setup({ renderType: RENDER_TAB_CONTENT });
|
|
// We expect 2 because this Tab has a Row child and the row has a Chart
|
|
expect(wrapper.find(DashboardComponent)).toHaveLength(2);
|
|
});
|
|
});
|
|
});
|