mirror of
https://github.com/apache/superset.git
synced 2024-09-20 04:29:47 -04:00
865beae3d8
* wip: filter create modal * add a feature flag * automatic changes to package lock * wip * filter sidebar and basic state management * move create button to the sidebar * first step for edit filterconfig * partially fix tests... * edits to types and comments * respect feature flag on the filter sidebar * add filterconfig form * get input state working * feat: tree filter scopes UI * fix: turn on flag * sticky filter bar * stop preferring default export * feat: finish filter scoping * fix: under toggle * fix: title * fix: add licence * refactor: update TS * fix: fix on reopen modal + validation * new filter bar menu * adding, but commenting out, bulk scoping action * adding some placeholder buttons and styles therefor * feat: add filter chart * add relative path to package.json * update modal * a little input styling... just getting warmed up * Revert "feat: add filter chart" This reverts commitb1302d35b6
. * Revert "add relative path to package.json" This reverts commit26a7b40e18
. * https package lock idk * feat: add filter chart * add relative path to package.json * flexboxes all the way down * dynamically generate groupby and datasource in select control * big wip * fix target column name * no importing nonexistent things * styles and name editing * Add hook for retrieval of all filter states * start with a new filter when clicking add filter * handle removed filters gracefully * fix incorrect default filter configuration * add fields to useAllFilterState * add redux for filterconfigs * add support for native_filters * remove consoles * improve filter removal * unbreak infinite loop * basic sidebar toggling working! * collapsing and menu working more smoothly * linting * make dataset and column inputs work * save filter values properly * add dashboard event for filter updates * guarded * apply filters properly * fix schema * making New Filter button a link * gridunits ftw * centering modal * tis not a button anymore! nixing type. * plus and collapse buttons instead of "more" menu * updating full size filter icons * adding icons to filter collapsing/expanding * turning off animation, but leaving class-based animation css * fix linting error * fix native filters for legacy charts * updates test * no individual apply buttons * fix bugs with filter config modal * remove redundant code * switch to the filter with validation errors on submit * separate form validation * switch config button from add to edit * update tests * oops forgot to add the fancy new useChangeEffect hook * comments and code reorganization * rename native_filters to extr_form_data and move hook * disable native filters in viz selector * add cascading * implement new extra form data api * cleanup * updates tests * bump npm packages * fix bad merge on package.json + lock * lint * replace in and not in with uppercase * lint * lint * lint * lint * bulk test fix * Sort select input alphabetically * Change type for sorting elements * fix rest of unit tests * make filter operators all uppercase * Hide Filter bar when there are no filters * Show edit button for dashboard owners only * Add visible argument to filters toggle function to avoid future regression * Improve Toggle filters bar function * lint * fix js lint + set createNewOnOpen * Handle setting extra form data in Filter Bar instead of Filter Control * Add Handle apply filter function to Apply button * Allow applying changes instantly * Fix types * remove console logs * Add Error Boundary component to Filter bar and Filter Config Modal * fix jest tests * update native filters tests to pass * reset cypress baseUrl * remove unnecessary field * cleanup: remove unused state fields * move unrelated types to an appropriate location * remove misplaced resource fetch error logic * fix cascadeParentIds error * fix cypress password * initial attempt at fixing scope issue * fix bad merge * fix lint * trying out makeApi for saving filters * remove unused import * fix test * silence bad test * add native-filter feat flag config * oops fix here * remove space * Update superset-frontend/src/common/components/index.tsx Co-authored-by: Evan Rusackas <evan@preset.io> * Update superset-frontend/cypress-base/cypress/integration/dashboard/nativeFilters.test.ts Co-authored-by: Evan Rusackas <evan@preset.io> * use styledMount in tests * comment Co-authored-by: Evan Rusackas <evan@preset.io> * Update superset-frontend/src/dashboard/components/nativeFilters/FilterBar.tsx Co-authored-by: Evan Rusackas <evan@preset.io> * Update superset-frontend/src/dashboard/components/nativeFilters/FilterConfigForm.tsx Co-authored-by: Evan Rusackas <evan@preset.io> * Update superset-frontend/src/dashboard/components/nativeFilters/FilterConfigModal.tsx Co-authored-by: Evan Rusackas <evan@preset.io> * Update superset-frontend/src/dashboard/components/nativeFilters/FilterConfigurationLink.tsx Co-authored-by: Evan Rusackas <evan@preset.io> * address PR feedback * fix package lock * null guards * Fix charts resizing * fix cypress tests * add in nativefilters to form data * fix lint and test Co-authored-by: Phillip Kelley-Dotson <pkelleydotson@yahoo.com> Co-authored-by: Simcha Shats <simcha.shats@nielsen.com> Co-authored-by: amitNielsen <amit.miran@nielsen.com> Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com> Co-authored-by: Evan Rusackas <evan@preset.io> Co-authored-by: Agata Stawarz-Pastewska <agata.stawarz-pastewska@polidea.com> Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
115 lines
3.3 KiB
JavaScript
115 lines
3.3 KiB
JavaScript
/**
|
|
* Licensed to the Apache Software Foundation (ASF) under one
|
|
* or more contributor license agreements. See the NOTICE file
|
|
* distributed with this work for additional information
|
|
* regarding copyright ownership. The ASF licenses this file
|
|
* to you under the Apache License, Version 2.0 (the
|
|
* "License"); you may not use this file except in compliance
|
|
* with the License. You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing,
|
|
* software distributed under the License is distributed on an
|
|
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
* KIND, either express or implied. See the License for the
|
|
* specific language governing permissions and limitations
|
|
* under the License.
|
|
*/
|
|
import readResponseBlob from '../../../utils/readResponseBlob';
|
|
|
|
describe('Visualization > Area', () => {
|
|
const AREA_FORM_DATA = {
|
|
datasource: '2__table',
|
|
viz_type: 'area',
|
|
slice_id: 48,
|
|
granularity_sqla: 'year',
|
|
time_grain_sqla: 'P1D',
|
|
time_range: '1960-01-01 : now',
|
|
metrics: ['sum__SP_POP_TOTL'],
|
|
adhoc_filters: [],
|
|
groupby: [],
|
|
limit: '25',
|
|
order_desc: true,
|
|
contribution: false,
|
|
row_limit: 50000,
|
|
show_brush: 'auto',
|
|
show_legend: true,
|
|
line_interpolation: 'linear',
|
|
stacked_style: 'stack',
|
|
color_scheme: 'bnbColors',
|
|
rich_tooltip: true,
|
|
show_controls: false,
|
|
x_axis_label: '',
|
|
bottom_margin: 'auto',
|
|
x_ticks_layout: 'auto',
|
|
x_axis_format: 'smart_date',
|
|
x_axis_showminmax: false,
|
|
y_axis_format: '.3s',
|
|
y_log_scale: false,
|
|
rolling_type: 'None',
|
|
comparison_type: 'values',
|
|
annotation_layers: [],
|
|
};
|
|
|
|
function verify(formData) {
|
|
cy.visitChartByParams(JSON.stringify(formData));
|
|
cy.verifySliceSuccess({ waitAlias: '@getJson', chartSelector: 'svg' });
|
|
}
|
|
|
|
beforeEach(() => {
|
|
cy.server();
|
|
cy.login();
|
|
cy.route('POST', '/superset/explore_json/**').as('getJson');
|
|
});
|
|
|
|
it('should work without groupby', () => {
|
|
verify(AREA_FORM_DATA);
|
|
cy.get('.nv-area').should('have.length', 1);
|
|
});
|
|
|
|
it('should work with group by', () => {
|
|
verify({
|
|
...AREA_FORM_DATA,
|
|
groupby: ['region'],
|
|
});
|
|
|
|
cy.get('.nv-area').should('have.length', 7);
|
|
});
|
|
|
|
it('should work with groupby and filter', () => {
|
|
cy.visitChartByParams(
|
|
JSON.stringify({
|
|
...AREA_FORM_DATA,
|
|
groupby: ['region'],
|
|
adhoc_filters: [
|
|
{
|
|
expressionType: 'SIMPLE',
|
|
subject: 'region',
|
|
operator: 'IN',
|
|
comparator: ['South Asia', 'North America'],
|
|
clause: 'WHERE',
|
|
sqlExpression: null,
|
|
filterOptionName: 'filter_txje2ikiv6_wxmn0qwd1xo',
|
|
},
|
|
],
|
|
}),
|
|
);
|
|
|
|
cy.wait('@getJson').then(async xhr => {
|
|
cy.verifyResponseCodes(xhr);
|
|
|
|
const responseBody = await readResponseBlob(xhr.response.body);
|
|
|
|
// Make sure data is sorted correctly
|
|
const firstRow = responseBody.data[0].values;
|
|
const secondRow = responseBody.data[1].values;
|
|
expect(firstRow[firstRow.length - 1].y).to.be.greaterThan(
|
|
secondRow[secondRow.length - 1].y,
|
|
);
|
|
cy.verifySliceContainer('svg');
|
|
});
|
|
cy.get('.nv-area').should('have.length', 2);
|
|
});
|
|
});
|