mirror of
https://github.com/apache/superset.git
synced 2024-09-19 12:09:42 -04:00
45efcb381c
* Added time filter to query search page * Added start date * Updated python endpoint test * changed spec * Added specs and tests * Modified python/js tests and some function/file names based on code review comments * Resolved conflicts in DashboardSelect_spec and QuerySearch_spec * Break python tests for separate functions, Move sql queries to setUp() * Get around eslint error for spec * Small changes based on comments
525 lines
20 KiB
Python
525 lines
20 KiB
Python
"""Unit tests for Caravel"""
|
|
from __future__ import absolute_import
|
|
from __future__ import division
|
|
from __future__ import print_function
|
|
from __future__ import unicode_literals
|
|
|
|
import csv
|
|
import doctest
|
|
import json
|
|
import io
|
|
import random
|
|
import unittest
|
|
from datetime import datetime
|
|
|
|
from flask import escape
|
|
from flask_appbuilder.security.sqla import models as ab_models
|
|
|
|
from caravel import db, models, utils, appbuilder, sm, jinja_context
|
|
from caravel.views import DatabaseView
|
|
|
|
from .base_tests import CaravelTestCase
|
|
|
|
|
|
class CoreTests(CaravelTestCase):
|
|
|
|
requires_examples = True
|
|
|
|
def __init__(self, *args, **kwargs):
|
|
# Load examples first, so that we setup proper permission-view
|
|
# relations for all example data sources.
|
|
super(CoreTests, self).__init__(*args, **kwargs)
|
|
|
|
@classmethod
|
|
def setUpClass(cls):
|
|
cls.table_ids = {tbl.table_name: tbl.id for tbl in (
|
|
db.session
|
|
.query(models.SqlaTable)
|
|
.all()
|
|
)}
|
|
|
|
def setUp(self):
|
|
db.session.query(models.Query).delete()
|
|
db.session.query(models.DatasourceAccessRequest).delete()
|
|
self.login('admin')
|
|
self.run_sql("SELECT * FROM ab_user", 'admin', client_id='client_id_1')
|
|
self.run_sql("SELECT * FROM NO_TABLE", 'admin', client_id='client_id_3')
|
|
self.logout()
|
|
|
|
self.login('gamma')
|
|
self.run_sql("SELECT * FROM ab_permission", 'gamma', client_id='client_id_2')
|
|
self.logout()
|
|
|
|
def tearDown(self):
|
|
pass
|
|
|
|
def test_welcome(self):
|
|
self.login()
|
|
resp = self.client.get('/caravel/welcome')
|
|
assert 'Welcome' in resp.data.decode('utf-8')
|
|
|
|
def test_slice_endpoint(self):
|
|
self.login(username='admin')
|
|
slc = self.get_slice("Girls", db.session)
|
|
resp = self.get_resp('/caravel/slice/{}/'.format(slc.id))
|
|
assert 'Time Column' in resp
|
|
assert 'List Roles' in resp
|
|
|
|
# Testing overrides
|
|
resp = self.get_resp(
|
|
'/caravel/slice/{}/?standalone=true'.format(slc.id))
|
|
assert 'List Roles' not in resp
|
|
|
|
def test_endpoints_for_a_slice(self):
|
|
self.login(username='admin')
|
|
slc = self.get_slice("Girls", db.session)
|
|
|
|
resp = self.get_resp(slc.viz.csv_endpoint)
|
|
assert 'Jennifer,' in resp
|
|
|
|
resp = self.get_resp(slc.viz.json_endpoint)
|
|
assert '"Jennifer"' in resp
|
|
|
|
def test_admin_only_permissions(self):
|
|
def assert_admin_permission_in(role_name, assert_func):
|
|
role = sm.find_role(role_name)
|
|
permissions = [p.permission.name for p in role.permissions]
|
|
assert_func('can_sync_druid_source', permissions)
|
|
assert_func('can_approve', permissions)
|
|
|
|
assert_admin_permission_in('Admin', self.assertIn)
|
|
assert_admin_permission_in('Alpha', self.assertNotIn)
|
|
assert_admin_permission_in('Gamma', self.assertNotIn)
|
|
|
|
def test_admin_only_menu_views(self):
|
|
def assert_admin_view_menus_in(role_name, assert_func):
|
|
role = sm.find_role(role_name)
|
|
view_menus = [p.view_menu.name for p in role.permissions]
|
|
assert_func('ResetPasswordView', view_menus)
|
|
assert_func('RoleModelView', view_menus)
|
|
assert_func('Security', view_menus)
|
|
assert_func('UserDBModelView', view_menus)
|
|
assert_func('SQL Lab',
|
|
view_menus)
|
|
assert_func('AccessRequestsModelView', view_menus)
|
|
|
|
assert_admin_view_menus_in('Admin', self.assertIn)
|
|
assert_admin_view_menus_in('Alpha', self.assertNotIn)
|
|
assert_admin_view_menus_in('Gamma', self.assertNotIn)
|
|
|
|
def test_save_slice(self):
|
|
self.login(username='admin')
|
|
slice_id = self.get_slice("Energy Sankey", db.session).id
|
|
copy_name = "Test Sankey Save"
|
|
tbl_id = self.table_ids.get('energy_usage')
|
|
url = (
|
|
"/caravel/explore/table/{}/?viz_type=sankey&groupby=source&"
|
|
"groupby=target&metric=sum__value&row_limit=5000&where=&having=&"
|
|
"flt_col_0=source&flt_op_0=in&flt_eq_0=&slice_id={}&slice_name={}&"
|
|
"collapsed_fieldsets=&action={}&datasource_name=energy_usage&"
|
|
"datasource_id=1&datasource_type=table&previous_viz_type=sankey")
|
|
|
|
db.session.commit()
|
|
resp = self.get_resp(url.format(tbl_id, slice_id, copy_name, 'save'))
|
|
assert copy_name in resp
|
|
assert 'Energy' in self.get_resp(
|
|
url.format(tbl_id, slice_id, copy_name, 'overwrite'))
|
|
|
|
def test_slices(self):
|
|
# Testing by hitting the two supported end points for all slices
|
|
self.login(username='admin')
|
|
Slc = models.Slice
|
|
urls = []
|
|
for slc in db.session.query(Slc).all():
|
|
urls += [
|
|
(slc.slice_name, 'slice_url', slc.slice_url),
|
|
(slc.slice_name, 'json_endpoint', slc.viz.json_endpoint),
|
|
(slc.slice_name, 'csv_endpoint', slc.viz.csv_endpoint),
|
|
(slc.slice_name, 'slice_id_url', slc.slice_id_url),
|
|
]
|
|
for name, method, url in urls:
|
|
print("[{name}]/[{method}]: {url}".format(**locals()))
|
|
self.client.get(url)
|
|
|
|
def test_dashboard(self):
|
|
self.login(username='admin')
|
|
urls = {}
|
|
for dash in db.session.query(models.Dashboard).all():
|
|
urls[dash.dashboard_title] = dash.url
|
|
for title, url in urls.items():
|
|
assert escape(title) in self.client.get(url).data.decode('utf-8')
|
|
|
|
def test_doctests(self):
|
|
modules = [utils, models]
|
|
for mod in modules:
|
|
failed, tests = doctest.testmod(mod)
|
|
if failed:
|
|
raise Exception("Failed a doctest")
|
|
|
|
def test_misc(self):
|
|
assert self.get_resp('/health') == "OK"
|
|
assert self.get_resp('/ping') == "OK"
|
|
|
|
def test_testconn(self):
|
|
database = self.get_main_database(db.session)
|
|
|
|
# validate that the endpoint works with the password-masked sqlalchemy uri
|
|
data = json.dumps({
|
|
'uri': database.safe_sqlalchemy_uri(),
|
|
'name': 'main'
|
|
})
|
|
response = self.client.post('/caravel/testconn', data=data, content_type='application/json')
|
|
assert response.status_code == 200
|
|
|
|
# validate that the endpoint works with the decrypted sqlalchemy uri
|
|
data = json.dumps({
|
|
'uri': database.sqlalchemy_uri_decrypted,
|
|
'name': 'main'
|
|
})
|
|
response = self.client.post('/caravel/testconn', data=data, content_type='application/json')
|
|
assert response.status_code == 200
|
|
|
|
def test_databaseview_edit(self, username='admin'):
|
|
# validate that sending a password-masked uri does not over-write the decrypted uri
|
|
self.login(username=username)
|
|
database = self.get_main_database(db.session)
|
|
sqlalchemy_uri_decrypted = database.sqlalchemy_uri_decrypted
|
|
url = 'databaseview/edit/{}'.format(database.id)
|
|
data = {k: database.__getattribute__(k) for k in DatabaseView.add_columns}
|
|
data['sqlalchemy_uri'] = database.safe_sqlalchemy_uri()
|
|
self.client.post(url, data=data)
|
|
database = self.get_main_database(db.session)
|
|
self.assertEqual(sqlalchemy_uri_decrypted, database.sqlalchemy_uri_decrypted)
|
|
|
|
def test_warm_up_cache(self):
|
|
slice = db.session.query(models.Slice).first()
|
|
data = self.get_json_resp(
|
|
'/caravel/warm_up_cache?slice_id={}'.format(slice.id))
|
|
assert data == [{'slice_id': slice.id, 'slice_name': slice.slice_name}]
|
|
|
|
data = self.get_json_resp(
|
|
'/caravel/warm_up_cache?table_name=energy_usage&db_name=main')
|
|
assert len(data) == 3
|
|
|
|
def test_shortner(self):
|
|
self.login(username='admin')
|
|
data = (
|
|
"//caravel/explore/table/1/?viz_type=sankey&groupby=source&"
|
|
"groupby=target&metric=sum__value&row_limit=5000&where=&having=&"
|
|
"flt_col_0=source&flt_op_0=in&flt_eq_0=&slice_id=78&slice_name="
|
|
"Energy+Sankey&collapsed_fieldsets=&action=&datasource_name="
|
|
"energy_usage&datasource_id=1&datasource_type=table&"
|
|
"previous_viz_type=sankey"
|
|
)
|
|
resp = self.client.post('/r/shortner/', data=data)
|
|
assert '/r/' in resp.data.decode('utf-8')
|
|
|
|
def test_save_dash(self, username='admin'):
|
|
self.login(username=username)
|
|
dash = db.session.query(models.Dashboard).filter_by(
|
|
slug="births").first()
|
|
positions = []
|
|
for i, slc in enumerate(dash.slices):
|
|
d = {
|
|
'col': 0,
|
|
'row': i * 4,
|
|
'size_x': 4,
|
|
'size_y': 4,
|
|
'slice_id': '{}'.format(slc.id)}
|
|
positions.append(d)
|
|
data = {
|
|
'css': '',
|
|
'expanded_slices': {},
|
|
'positions': positions,
|
|
}
|
|
url = '/caravel/save_dash/{}/'.format(dash.id)
|
|
resp = self.client.post(url, data=dict(data=json.dumps(data)))
|
|
assert "SUCCESS" in resp.data.decode('utf-8')
|
|
|
|
def test_add_slices(self, username='admin'):
|
|
self.login(username=username)
|
|
dash = db.session.query(models.Dashboard).filter_by(
|
|
slug="births").first()
|
|
new_slice = db.session.query(models.Slice).filter_by(
|
|
slice_name="Mapbox Long/Lat").first()
|
|
existing_slice = db.session.query(models.Slice).filter_by(
|
|
slice_name="Name Cloud").first()
|
|
data = {
|
|
"slice_ids": [new_slice.data["slice_id"],
|
|
existing_slice.data["slice_id"]]
|
|
}
|
|
url = '/caravel/add_slices/{}/'.format(dash.id)
|
|
resp = self.client.post(url, data=dict(data=json.dumps(data)))
|
|
assert "SLICES ADDED" in resp.data.decode('utf-8')
|
|
|
|
dash = db.session.query(models.Dashboard).filter_by(
|
|
slug="births").first()
|
|
new_slice = db.session.query(models.Slice).filter_by(
|
|
slice_name="Mapbox Long/Lat").first()
|
|
assert new_slice in dash.slices
|
|
assert len(set(dash.slices)) == len(dash.slices)
|
|
|
|
# cleaning up
|
|
dash = db.session.query(models.Dashboard).filter_by(
|
|
slug="births").first()
|
|
dash.slices = [
|
|
o for o in dash.slices if o.slice_name != "Mapbox Long/Lat"]
|
|
db.session.commit()
|
|
|
|
def test_gamma(self):
|
|
self.login(username='gamma')
|
|
assert "List Slice" in self.get_resp('/slicemodelview/list/')
|
|
assert "List Dashboard" in self.get_resp('/dashboardmodelview/list/')
|
|
|
|
def run_sql(self, sql, user_name, client_id):
|
|
self.login(username=user_name)
|
|
dbid = self.get_main_database(db.session).id
|
|
resp = self.client.post(
|
|
'/caravel/sql_json/',
|
|
data=dict(database_id=dbid, sql=sql, select_as_create_as=False,
|
|
client_id=client_id),
|
|
)
|
|
self.logout()
|
|
return json.loads(resp.data.decode('utf-8'))
|
|
|
|
def test_sql_json(self):
|
|
data = self.run_sql('SELECT * FROM ab_user', 'admin', "1")
|
|
assert len(data['data']) > 0
|
|
|
|
data = self.run_sql('SELECT * FROM unexistant_table', 'admin', "2")
|
|
assert len(data['error']) > 0
|
|
|
|
def test_sql_json_has_access(self):
|
|
main_db = self.get_main_database(db.session)
|
|
utils.merge_perm(sm, 'database_access', main_db.perm)
|
|
db.session.commit()
|
|
main_db_permission_view = (
|
|
db.session.query(ab_models.PermissionView)
|
|
.join(ab_models.ViewMenu)
|
|
.filter(ab_models.ViewMenu.name == '[main].(id:1)')
|
|
.first()
|
|
)
|
|
astronaut = sm.add_role("Astronaut")
|
|
sm.add_permission_role(astronaut, main_db_permission_view)
|
|
# Astronaut role is Gamma + main db permissions
|
|
for gamma_perm in sm.find_role('Gamma').permissions:
|
|
sm.add_permission_role(astronaut, gamma_perm)
|
|
|
|
gagarin = appbuilder.sm.find_user('gagarin')
|
|
if not gagarin:
|
|
appbuilder.sm.add_user(
|
|
'gagarin', 'Iurii', 'Gagarin', 'gagarin@cosmos.ussr',
|
|
appbuilder.sm.find_role('Astronaut'),
|
|
password='general')
|
|
data = self.run_sql('SELECT * FROM ab_user', 'gagarin', "3")
|
|
db.session.query(models.Query).delete()
|
|
db.session.commit()
|
|
assert len(data['data']) > 0
|
|
|
|
def test_csv_endpoint(self):
|
|
sql = """
|
|
SELECT first_name, last_name
|
|
FROM ab_user
|
|
WHERE first_name='admin'
|
|
"""
|
|
client_id = "{}".format(random.getrandbits(64))[:10]
|
|
self.run_sql(sql, 'admin', client_id)
|
|
|
|
self.login('admin')
|
|
resp = self.get_resp('/caravel/csv/{}'.format(client_id))
|
|
data = csv.reader(io.StringIO(resp))
|
|
expected_data = csv.reader(
|
|
io.StringIO("first_name,last_name\nadmin, user\n"))
|
|
|
|
self.assertEqual(list(expected_data), list(data))
|
|
self.logout()
|
|
|
|
def test_queries_endpoint(self):
|
|
resp = self.client.get('/caravel/queries/{}'.format(0))
|
|
self.assertEquals(403, resp.status_code)
|
|
|
|
self.login('admin')
|
|
data = self.get_json_resp('/caravel/queries/{}'.format(0))
|
|
self.assertEquals(2, len(data))
|
|
self.logout()
|
|
|
|
self.run_sql("SELECT * FROM ab_user1", 'admin', client_id='client_id_4')
|
|
self.run_sql("SELECT * FROM ab_user2", 'admin', client_id='client_id_5')
|
|
self.login('admin')
|
|
data = self.get_json_resp('/caravel/queries/{}'.format(0))
|
|
self.assertEquals(4, len(data))
|
|
|
|
query = db.session.query(models.Query).filter_by(
|
|
sql='SELECT * FROM ab_user1').first()
|
|
query.changed_on = utils.EPOCH
|
|
db.session.commit()
|
|
|
|
data = self.get_json_resp('/caravel/queries/{}'.format(123456000))
|
|
self.assertEquals(3, len(data))
|
|
|
|
self.logout()
|
|
resp = self.client.get('/caravel/queries/{}'.format(0))
|
|
self.assertEquals(403, resp.status_code)
|
|
|
|
def test_search_query_on_db_id(self):
|
|
self.login('admin')
|
|
# Test search queries on database Id
|
|
resp = self.get_resp('/caravel/search_queries?database_id=1')
|
|
data = json.loads(resp)
|
|
self.assertEquals(3, len(data))
|
|
db_ids = [data[k]['dbId'] for k in data]
|
|
self.assertEquals([1, 1, 1], db_ids)
|
|
|
|
resp = self.get_resp('/caravel/search_queries?database_id=-1')
|
|
data = json.loads(resp)
|
|
self.assertEquals(0, len(data))
|
|
self.logout()
|
|
|
|
def test_search_query_on_user(self):
|
|
self.login('admin')
|
|
# Test search queries on user Id
|
|
user = appbuilder.sm.find_user('admin')
|
|
resp = self.get_resp('/caravel/search_queries?user_id={}'.format(user.id))
|
|
data = json.loads(resp)
|
|
self.assertEquals(2, len(data))
|
|
user_ids = [data[k]['userId'] for k in data]
|
|
self.assertEquals([user.id, user.id], user_ids)
|
|
|
|
user = appbuilder.sm.find_user('gamma')
|
|
resp = self.get_resp('/caravel/search_queries?user_id={}'.format(user.id))
|
|
data = json.loads(resp)
|
|
self.assertEquals(1, len(data))
|
|
self.assertEquals(list(data.values())[0]['userId'] , user.id)
|
|
self.logout()
|
|
|
|
def test_search_query_on_status(self):
|
|
self.login('admin')
|
|
# Test search queries on status
|
|
resp = self.get_resp('/caravel/search_queries?status=success')
|
|
data = json.loads(resp)
|
|
self.assertEquals(2, len(data))
|
|
states = [data[k]['state'] for k in data]
|
|
self.assertEquals(['success', 'success'], states)
|
|
|
|
resp = self.get_resp('/caravel/search_queries?status=failed')
|
|
data = json.loads(resp)
|
|
self.assertEquals(1, len(data))
|
|
self.assertEquals(list(data.values())[0]['state'], 'failed')
|
|
self.logout()
|
|
|
|
def test_search_query_on_text(self):
|
|
self.login('admin')
|
|
resp = self.get_resp('/caravel/search_queries?search_text=permission')
|
|
data = json.loads(resp)
|
|
self.assertEquals(1, len(data))
|
|
self.assertIn('permission', list(data.values())[0]['sql'])
|
|
self.logout()
|
|
|
|
def test_search_query_on_time(self):
|
|
self.login('admin')
|
|
first_query_time = db.session.query(models.Query).filter_by(
|
|
sql='SELECT * FROM ab_user').first().start_time
|
|
second_query_time = db.session.query(models.Query).filter_by(
|
|
sql='SELECT * FROM ab_permission').first().start_time
|
|
# Test search queries on time filter
|
|
from_time = 'from={}'.format(int(first_query_time))
|
|
to_time = 'to={}'.format(int(second_query_time))
|
|
params = [from_time, to_time]
|
|
resp = self.get_resp('/caravel/search_queries?'+'&'.join(params))
|
|
data = json.loads(resp)
|
|
self.assertEquals(2, len(data))
|
|
for _, v in data.items():
|
|
self.assertLess(int(first_query_time), v['startDttm'])
|
|
self.assertLess(v['startDttm'], int(second_query_time))
|
|
self.logout()
|
|
|
|
def test_public_user_dashboard_access(self):
|
|
# Try access before adding appropriate permissions.
|
|
self.revoke_public_access('birth_names')
|
|
self.logout()
|
|
|
|
resp = self.get_resp('/slicemodelview/list/')
|
|
assert 'birth_names</a>' not in resp
|
|
|
|
resp = self.get_resp('/dashboardmodelview/list/')
|
|
assert '/caravel/dashboard/births/' not in resp
|
|
|
|
self.setup_public_access_for_dashboard('birth_names')
|
|
|
|
# Try access after adding appropriate permissions.
|
|
assert 'birth_names' in self.get_resp('/slicemodelview/list/')
|
|
|
|
resp = self.get_resp('/dashboardmodelview/list/')
|
|
assert "/caravel/dashboard/births/" in resp
|
|
|
|
assert 'Births' in self.get_resp('/caravel/dashboard/births/')
|
|
|
|
# Confirm that public doesn't have access to other datasets.
|
|
resp = self.get_resp('/slicemodelview/list/')
|
|
assert 'wb_health_population</a>' not in resp
|
|
|
|
resp = self.get_resp('/dashboardmodelview/list/')
|
|
assert "/caravel/dashboard/world_health/" not in resp
|
|
|
|
def test_dashboard_with_created_by_can_be_accessed_by_public_users(self):
|
|
self.logout()
|
|
self.setup_public_access_for_dashboard('birth_names')
|
|
|
|
dash = db.session.query(models.Dashboard).filter_by(dashboard_title="Births").first()
|
|
dash.owners = [appbuilder.sm.find_user('admin')]
|
|
dash.created_by = appbuilder.sm.find_user('admin')
|
|
db.session.merge(dash)
|
|
db.session.commit()
|
|
|
|
assert 'Births' in self.get_resp('/caravel/dashboard/births/')
|
|
|
|
def test_only_owners_can_save(self):
|
|
dash = (
|
|
db.session
|
|
.query(models.Dashboard)
|
|
.filter_by(slug="births")
|
|
.first()
|
|
)
|
|
dash.owners = []
|
|
db.session.merge(dash)
|
|
db.session.commit()
|
|
self.test_save_dash('admin')
|
|
|
|
self.logout()
|
|
self.assertRaises(
|
|
AssertionError, self.test_save_dash, 'alpha')
|
|
|
|
alpha = appbuilder.sm.find_user('alpha')
|
|
|
|
dash = (
|
|
db.session
|
|
.query(models.Dashboard)
|
|
.filter_by(slug="births")
|
|
.first()
|
|
)
|
|
dash.owners = [alpha]
|
|
db.session.merge(dash)
|
|
db.session.commit()
|
|
self.test_save_dash('alpha')
|
|
|
|
def test_extra_table_metadata(self):
|
|
self.login('admin')
|
|
dbid = self.get_main_database(db.session).id
|
|
self.get_json_resp(
|
|
'/caravel/extra_table_metadata/{dbid}/'
|
|
'ab_permission_view/panoramix/'.format(**locals()))
|
|
|
|
def test_process_template(self):
|
|
sql = "SELECT '{{ datetime(2017, 1, 1).isoformat() }}'"
|
|
rendered = jinja_context.process_template(sql)
|
|
self.assertEqual("SELECT '2017-01-01T00:00:00'", rendered)
|
|
|
|
def test_templated_sql_json(self):
|
|
sql = "SELECT '{{ datetime(2017, 1, 1).isoformat() }}' as test"
|
|
data = self.run_sql(sql, "admin", "fdaklj3ws")
|
|
self.assertEqual(data['data'][0]['test'], "2017-01-01T00:00:00")
|
|
|
|
if __name__ == '__main__':
|
|
unittest.main()
|
|
|