mirror of
https://github.com/apache/superset.git
synced 2024-09-19 20:19:37 -04:00
b7ae7f976a
* chore: convert feature flag tests to unit tests * Fix test
66 lines
2.3 KiB
Python
66 lines
2.3 KiB
Python
# Licensed to the Apache Software Foundation (ASF) under one
|
|
# or more contributor license agreements. See the NOTICE file
|
|
# distributed with this work for additional information
|
|
# regarding copyright ownership. The ASF licenses this file
|
|
# to you under the Apache License, Version 2.0 (the
|
|
# "License"); you may not use this file except in compliance
|
|
# with the License. You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing,
|
|
# software distributed under the License is distributed on an
|
|
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
# KIND, either express or implied. See the License for the
|
|
# specific language governing permissions and limitations
|
|
# under the License.
|
|
from pytest_mock import MockFixture
|
|
|
|
from superset import is_feature_enabled
|
|
|
|
|
|
def dummy_is_feature_enabled(feature_flag_name: str, default: bool = True) -> bool:
|
|
return True if feature_flag_name.startswith("True_") else default
|
|
|
|
|
|
def test_existing_feature_flags(mocker: MockFixture) -> None:
|
|
"""
|
|
Test that ``is_feature_enabled`` reads flags correctly.
|
|
"""
|
|
mocker.patch.dict(
|
|
"superset.extensions.feature_flag_manager._feature_flags",
|
|
{"FOO": True},
|
|
clear=True,
|
|
)
|
|
assert is_feature_enabled("FOO") is True
|
|
|
|
|
|
def test_nonexistent_feature_flags(mocker: MockFixture) -> None:
|
|
"""
|
|
Test that ``is_feature_enabled`` returns ``False`` when flag not set.
|
|
"""
|
|
mocker.patch.dict(
|
|
"superset.extensions.feature_flag_manager._feature_flags", {}, clear=True
|
|
)
|
|
assert is_feature_enabled("FOO") is False
|
|
|
|
|
|
def test_is_feature_enabled(mocker: MockFixture) -> None:
|
|
"""
|
|
Test ``_is_feature_enabled_func``.
|
|
"""
|
|
mocker.patch.dict(
|
|
"superset.extensions.feature_flag_manager._feature_flags",
|
|
{"True_Flag1": False, "True_Flag2": True, "Flag3": False, "Flag4": True},
|
|
clear=True,
|
|
)
|
|
mocker.patch(
|
|
"superset.extensions.feature_flag_manager._is_feature_enabled_func",
|
|
dummy_is_feature_enabled,
|
|
)
|
|
|
|
assert is_feature_enabled("True_Flag1") is True
|
|
assert is_feature_enabled("True_Flag2") is True
|
|
assert is_feature_enabled("Flag3") is False
|
|
assert is_feature_enabled("Flag4") is True
|