Commit Graph

4334 Commits

Author SHA1 Message Date
Kamil Gabryjelski 830f2e71d3
feat(explore): Allow using time formatter on temporal columns in data table (#18569)
* feat(explore): Allow using time formatter on temporal columns in data table

* Fix data table loading

* Return colnames and coltypes from results request

* Fix types

* Fix tests

* Fix copy button

* Fix df is none

* Fix test

* Address comments

* Move useTimeFormattedColumns out of useTableColumns

* Make reducer more readable
2022-02-09 10:29:11 +01:00
Hoàng Minh Quân 28e729b835
fix(histogram): display correct percentile value instead of formula (#18084)
Co-authored-by: quanhm <quanhm@vng.com.vn>
2022-02-08 20:30:20 -08:00
Christopher C Fleming 51f716f573
refactor(ExploreCtasResultsButton): convert to functional component (#17939)
* chore: fix misspelling of button

* Feat: Update ExploreCtasResultsButton to functional component

* Fix pull request

* Fix index.tsx

* Fix prettier issues and actions

* Streamline the onClick so it calls visualize directly

* Update MSP and MDP to arrow functions

* Test destructured props

* Fix props destructuring error

* Simplify with optional chaining on line 94 and clean up buildVizOptions

Co-authored-by: David Woolner <davidwoolner@gmail.com>
Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
2022-02-08 13:23:45 -08:00
Michael S. Molina fdf57cc22a
chore: Rename and reposition native filter modal fields (#18558)
* chore: Rename and reposition native filter modal fields

* Fixes collapse initial state

* Changes the button to sentence case
2022-02-08 16:36:40 -03:00
Phillip Kelley-Dotson 9c08bc0ffc
fix: change database database selector (#18609)
* fix: change database selector

* fix lint
2022-02-08 12:22:20 -05:00
EugeneTorap cdfcbbaf30
refactor: migrate ExploreResultsButton component to FC & tsx (#18143)
* Move ExploreResultsButton to FC & tsx

* Refactoring

* Refactoring

* Refactoring

* Refactoring

* Refactoring

* Refactoring

* Refactoring

* Fix test
2022-02-08 10:57:08 -05:00
Adam Dobrawy fa8c81e1b1
chore: upgrade BoundsControl to TS (#18200)
* chore: upgrade BoundsControl to TS,FC, add storybook

* chore: improve React import reference consistency
2022-02-08 14:45:10 +02:00
Phillip Kelley-Dotson 4e2bdd49c4
chore: allow sqla docs to use supersettext (#18585)
* chore: allow sqla docs to use supersettext

* Update SqlAlchemyForm.tsx
2022-02-07 12:45:42 -08:00
EugeneTorap 85c8d0183b
refactor: remove redundant propTypes in ColumnElement (#18144)
* Remove redundant propTypes

* Refactoring

* Refactoring
2022-02-07 13:25:07 -05:00
Ville Brofeldt cebff83d0c
fix(jest): add superset-frontend to testRegex (#18601) 2022-02-07 19:11:48 +02:00
Yongjie Zhao aa21a963a6
feat: smart tooltip in datasourcepanel (#18080) 2022-02-07 22:48:23 +08:00
Phillip Kelley-Dotson 151d30bea4
fix: sqllab schema select error msg (#18564)
* fix: sqllab schema select error msg

* remove console logs

* fix lint
2022-02-04 10:21:18 -08:00
Kamil Gabryjelski 6cad7b1d05
chore(explore): make adhoc columns available without UX BETA ff (#17921)
* chore(explore): make adhoc columns available without UX BETA ff

* Remove redundant imports
2022-02-04 14:01:16 +01:00
Ville Brofeldt 8b0634c9ed
fix(listview): add nowrap to view mode container (#18246) 2022-02-04 07:42:10 +02:00
Grace Guo a80efa609c
fix: new alert should have force_screenshot be true (#18182)
* fix: new alert should have force_screenshot be true

* fix comments
2022-02-02 17:00:05 -08:00
Kamil Gabryjelski 70969821de
feat(explore): Keep or reset chart config after datasource change (#18215)
* feat(explore): Keep or reset chart config after datasource change

* Update copy

* Remove useDispatch

* fix test

* Fix bugs

* Remove ts ignore

* Scroll top when datasource changes

* Fix crashing when switching viz type
2022-02-02 21:28:35 +01:00
Ville Brofeldt 2929bb1680
fix(plugin-chart-echarts): fix forecasts on verbose metrics (#18252)
* fix(plugin-chart-echarts): fix forecasts on verbose metrics

* oops! 🙊

* check for DTTM_ALIAS
2022-02-02 13:51:51 +02:00
Adam Dobrawy 341d85589c
refactor: upgrade ControlHeader to TSX & FC and add storybook (#18188)
* refactor: upgrade ControlHeader to TSX & FC and add storybook

* fix: Add story for error in ControlHeader

* apply review comments
2022-01-31 10:03:39 -08:00
Lyndsi Kay Williams c40b337978
feat: Added success toasts for database, dataset, chart, dashboard, and query imports (#18190)
* Added imports toasts

* Removed generic import toast

* Remove addSuccessToast from props

* Added addSuccessToast back to prop type

* Made success toast strings translatable
2022-01-28 15:29:44 -06:00
Erik Ritter 7f3453f3ea
fix: Add mexico back to country map (#18219) 2022-01-28 13:04:53 -08:00
Michael S. Molina 4b61c76742
fix: Explore long URL problem (#18181)
* fix: Explore long URL problem

* Fixes lint problems

* Fixes default value

* Removes duplicated test

* Fixes share menu items

* Fixes tests

* Debounces form_data updates

* Rewrites debounce function

* Moves history update outside the functional component

* Mocks lodash function in tests

* Fixes Cypress test

* Fixes Cypress test #2
2022-01-28 17:42:16 -03:00
Josue Lugaro a06e043d7f
refactor: sqleditorleftbar to typescript (#17926)
* Creating draft PR to address bug

* Still working on solving re rendering bug

* Cleaning up in preparation for push

* Starting conversion to TypeScript

* Working on conversion

* Continued working on typescript conversion, referenced other files for different types, still a rough version of final product

* Added type assertion to actions in props, and added types to some component functions

* Progress on typescript conversion

* Fixed typing issue on collapseStyles

* Fixed styling on div, child of StyledScrollbarContainer

* Attempting to address issues with the actions passed into the TableElement

* Resolved typescript warning on actions of the TableElement component

* Made changes suggested by Arash

* Tested the component without dbId, cleaned up lingering comments

* Made more changes suggested by Arash, removed offline from the SqlEditorLeftBarProps interface

* Made change suggested by Hugh

* Changed the expanded type from any to boolean
2022-01-28 12:07:32 -08:00
Ville Brofeldt cec4677971
fix(plugin-chart-echarts): use verbose x-axis name when defined (#18217) 2022-01-28 16:45:57 +02:00
Kamil Gabryjelski 37430d4044
fix(explore): Pie chart label formatting when series is temporal (#18216) 2022-01-28 15:14:40 +01:00
Yongjie Zhao ea2d6681dd
chore: move controlPanel into time_table (#18160) 2022-01-28 12:13:12 +08:00
Stephen Liu 7c937ca182
fix(native-filters): values is not sorted when setting sort option (#18145)
* fix(native-filters): values is not sorted when setting sort option

* fix: revert

* pass sortComparator
2022-01-27 19:15:53 -07:00
Geido a4e93afdbf
Fix default value (#18180) 2022-01-27 17:40:32 +01:00
Yongjie Zhao 20b4ae1ef9
fix: null value and empty string in filter (#18171) 2022-01-27 22:58:06 +08:00
Ville Brofeldt dbe0a8b519
chore: bump echarts to 5.3.0 (#18162)
* chore: bump echarts to 5.3.0

* change to official 5.3.0 and reintroduce bold effect
2022-01-27 11:26:00 +02:00
Stephen Liu a2bad7551e
fix(dashboard): support input undo when editing chart title (#18137) 2022-01-27 14:53:46 +08:00
Hugh A. Miles II e6bb0fc7ad
feat: Add toast for successful table or schema refreshes in Sqllab (#18169)
* save

* add use redux to test

* update test for db selector

* add condition for refresh only
2022-01-26 20:26:50 -05:00
Phillip Kelley-Dotson ac564ea6b7
feat: add success message for database modal (#18183) 2022-01-26 15:52:15 -08:00
David Aaron Suddjian 4ad5ad045a
feat: embedded dashboard core (#17530)
* feat(dashboard): embedded dashboard UI configuration (#17175) (#17450)

* setup embedded provider

* update ui configuration

* fix test

* feat: Guest token (for embedded dashboard auth) (#17517)

* generate an embed token

* improve existing tests

* add some auth setup, and rename token

* fix the stuff for compatibility with external request loaders

* docs, standard jwt claims, tweaks

* black

* lint

* tests, and safer token decoding

* linting

* type annotation

* prettier

* add feature flag

* quiet pylint

* apparently typing is a problem again

* Make guest role name configurable

* fake being a non-anonymous user

* just one log entry

* customizable algo

* lint

* lint again

* 403 works now!

* get guest token from header instead of cookie

* Revert "403 works now!"

This reverts commit df2f49a6d4.

* fix tests

* Revert "Revert "403 works now!""

This reverts commit 883dff38f1.

* rename method

* correct import

* feat: entry for embedded dashboard (#17529)

* create entry for embedded dashboard in webpack

* add cookies

* lint

* token message handshake

* guestTokenHeaderName

* use setupClient instead of calling configure

* rename the webpack chunk

* simplified handshake

* embedded entrypoint: render a proper app

* make the embedded page accept anonymous connections

* format

* lint

* fix test
# Conflicts:
#	superset-frontend/src/embedded/index.tsx
#	superset/views/core.py

* lint

* Update superset-frontend/src/embedded/index.tsx

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>

* comment out origins checks

* move embedded for core to dashboard

* pylint

* isort

Co-authored-by: David Aaron Suddjian <aasuddjian@gmail.com>
Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>

* feat: Authorizing guest access to embedded dashboards (#17757)

* helper methods and dashboard access

* guest token dashboard authz

* adjust csrf exempt list

* eums don't work that way

* Remove unnecessary import

* move row level security tests to their own file

* a bit of refactoring

* add guest token security tests

* refactor tests

* clean imports

* variable names can be too long apparently

* missing argument to get_user_roles

* don't redefine builtins

* remove unused imports

* fix test import

* default to global user when getting roles

* missing import

* mock it

* test get_user_roles

* infer g.user for ease of tests

* remove redundant check

* tests for guest user security manager fns

* use algo to get rid of warning messages

* tweaking access checks

* fix guest token security tests

* missing imports

* more tests

* more testing and also some small refactoring

* move validation out of parsing

* fix dashboard access check again

* add more test

Co-authored-by: Lily Kuang <lily@preset.io>

* feat: Row Level Security rules for guest tokens (#17836)

* helper methods and dashboard access

* guest token dashboard authz

* adjust csrf exempt list

* eums don't work that way

* Remove unnecessary import

* move row level security tests to their own file

* a bit of refactoring

* add guest token security tests

* refactor tests

* clean imports

* variable names can be too long apparently

* missing argument to get_user_roles

* don't redefine builtins

* remove unused imports

* fix test import

* default to global user when getting roles

* missing import

* mock it

* test get_user_roles

* infer g.user for ease of tests

* remove redundant check

* tests for guest user security manager fns

* use algo to get rid of warning messages

* tweaking access checks

* fix guest token security tests

* missing imports

* more tests

* more testing and also some small refactoring

* move validation out of parsing

* fix dashboard access check again

* rls rules for guest tokens

* test guest token rls rules

* more flexible rls rules

* lint

* fix tests

* fix test

* defaults

* fix some tests

* fix some tests

* lint

Co-authored-by: Lily Kuang <lily@preset.io>

* SupersetClient guest token test

* Apply suggestions from code review

Co-authored-by: Lily Kuang <lily@preset.io>

Co-authored-by: Lily Kuang <lily@preset.io>
2022-01-25 16:41:32 -08:00
Lyndsi Kay Williams 2491b89f29
Columns tab name field no longer editable, calculated columns rows now vertically aligned (#18164) 2022-01-25 14:34:56 -06:00
Stephen Liu 7bb867407a
fix(textarea-control): ace editor input exception (#18146) 2022-01-25 16:57:12 +01:00
Kamil Gabryjelski c77d24cda3
fix: undefined error when adding extra sequential color scheme (#18152) 2022-01-24 19:20:49 +01:00
Kamil Gabryjelski e632193eb0
feat(explore): more toast feedback on user actions in Explore (#18108)
* feat(explore): add toasts feedback when user copies chart url

* Show toast message when updating chart properties

* Change toast type to success when saving chart

* Use success toast from props

* Fix tests

* Use withToasts instead of dispatch

* Use PropertiesModalProps instead of any
2022-01-24 11:42:24 +01:00
Kamil Gabryjelski d9eef8ec2f
feat(dashboard): add toast feedback to dashboard actions (#18114) 2022-01-24 11:42:12 +01:00
Kamil Gabryjelski 9fa2812343
feat(annotation): add toast feedback to annotation templates (#18116) 2022-01-24 11:41:39 +01:00
jayakrishnankk 4b89ac7447
chore: migrating storybook jsx to typescript #18100 (#18133)
* Migrating storybook jsx to typescript #18100

* Migrating storybook jsx to typescript

Co-authored-by: Jayakrishnan Karolil <jayakrishnan.karolil@nielsen.com>
2022-01-24 14:32:18 +08:00
Hammad-Raza 0cec0c9a68
feat(country-map): added new countries in country-chart-map (#18081) 2022-01-22 12:05:20 +08:00
Ville Brofeldt e9651ea52f
feat(plugin-chart-echarts): support non-timeseries x-axis (#17917)
* feat(plugin-chart-echarts): support non-timeseries x-axis

* fix tests

* change formula return type from Date to number

* add x_axis test coverage

* rename func and improve coverage

* add x-axis control to bar chart

* remove redundant console.log

* fix description

* make x-axis control mandatory

* 🙃

* fix x-axis formatter

* fix showValues

* fix implicit rDTTM_ALIAS references in postProcessing

* replace TIME_COLUMN with DTTM_ALIAS

* fix remaining implicit indexes

* fix: Disable filtering on wide result sets (#18021)

* fix: handle null values in time-series table (#18039)

* cleanup column_type_mappings (#17569)

Signed-off-by: Đặng Minh Dũng <dungdm93@live.com>

* important change to MakeFile (#18037)

* add missing is_timeseries to pivot op

Co-authored-by: Erik Ritter <erik.ritter@airbnb.com>
Co-authored-by: Grace Guo <grace.guo@airbnb.com>
Co-authored-by: Đặng Minh Dũng <dungdm93@live.com>
Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
2022-01-21 21:23:23 +02:00
Stephen Liu b083b3421f
fix(explore): fix chart embed code modal glitch (#17843) 2022-01-21 09:11:33 -07:00
Adam Dobrawy a5e805ef2a
refactor: migrate RowCountLabel to TypeScript & added story (#18105)
* enable superbook for explore component

* migrate RowCountLabel to TypeScript

* add storybook for RowCountLabel
2022-01-20 15:35:09 +01:00
Adam Dobrawy c3a17a7228
Migrate Checkbox story to tsx - see #18100 (#18101)
Looks good!
2022-01-20 15:33:45 +01:00
Josue Lugaro 035638c958
refactor: sqleditorleftbar to functional (#17807)
* Working on converting sqleditorleftbar to functional component

* Creating draft PR to address bug

* Still working on solving re rendering bug

* infinite rerender fix

* Creating draft PR to address bug

* Cleaning up in preparation for push

* Made changes suggested by Elizabeth

* Fixed issues as per Lindsey's comment

Co-authored-by: Arash <arash.afghahi@gmail.com>
2022-01-19 15:06:28 -06:00
Stephen Liu 22896f2803
feat: add chart description in info tooltip (#17207)
* feat: add chart list description

* fix: text overflow

* fix: text-overflow with line-height
2022-01-19 21:24:17 +08:00
AAfghahi 88db2cc0ab
refactor(sql_lab): SQL Lab Persistent Saved State (#17771)
* a lot of console logs

* testing

* test

* added saved_query to remoteId

* created useEffect so that title properly changes in modal

* Update superset-frontend/src/SqlLab/actions/sqlLab.js

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
2022-01-18 13:10:31 -05:00
Ville Brofeldt 5bfe2d47b0
fix(generator): add lockfile and fix styling issues (#18073)
* fix(generator): add lockfile and fix styling issues

* fix margins and remove redundant scroll

* update tutorial
2022-01-18 12:37:09 +02:00
Stephen Liu 3b64563f3f
fix(dashboard): scope of nativefilter not update (#18048) 2022-01-18 16:51:51 +08:00