Commit Graph

11342 Commits

Author SHA1 Message Date
Hugh A. Miles II
e6bb0fc7ad
feat: Add toast for successful table or schema refreshes in Sqllab (#18169)
* save

* add use redux to test

* update test for db selector

* add condition for refresh only
2022-01-26 20:26:50 -05:00
Phillip Kelley-Dotson
ac564ea6b7
feat: add success message for database modal (#18183) 2022-01-26 15:52:15 -08:00
AAfghahi
fa11a97585
fix: remove standalone (#18157)
* removed standalone

* Update tests/integration_tests/reports/commands_tests.py

* changed standalone

* added tests

* made function more generic

* Update superset/reports/notifications/email.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2022-01-26 13:04:26 -05:00
David Aaron Suddjian
4ad5ad045a
feat: embedded dashboard core (#17530)
* feat(dashboard): embedded dashboard UI configuration (#17175) (#17450)

* setup embedded provider

* update ui configuration

* fix test

* feat: Guest token (for embedded dashboard auth) (#17517)

* generate an embed token

* improve existing tests

* add some auth setup, and rename token

* fix the stuff for compatibility with external request loaders

* docs, standard jwt claims, tweaks

* black

* lint

* tests, and safer token decoding

* linting

* type annotation

* prettier

* add feature flag

* quiet pylint

* apparently typing is a problem again

* Make guest role name configurable

* fake being a non-anonymous user

* just one log entry

* customizable algo

* lint

* lint again

* 403 works now!

* get guest token from header instead of cookie

* Revert "403 works now!"

This reverts commit df2f49a6d4.

* fix tests

* Revert "Revert "403 works now!""

This reverts commit 883dff38f1.

* rename method

* correct import

* feat: entry for embedded dashboard (#17529)

* create entry for embedded dashboard in webpack

* add cookies

* lint

* token message handshake

* guestTokenHeaderName

* use setupClient instead of calling configure

* rename the webpack chunk

* simplified handshake

* embedded entrypoint: render a proper app

* make the embedded page accept anonymous connections

* format

* lint

* fix test
# Conflicts:
#	superset-frontend/src/embedded/index.tsx
#	superset/views/core.py

* lint

* Update superset-frontend/src/embedded/index.tsx

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>

* comment out origins checks

* move embedded for core to dashboard

* pylint

* isort

Co-authored-by: David Aaron Suddjian <aasuddjian@gmail.com>
Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>

* feat: Authorizing guest access to embedded dashboards (#17757)

* helper methods and dashboard access

* guest token dashboard authz

* adjust csrf exempt list

* eums don't work that way

* Remove unnecessary import

* move row level security tests to their own file

* a bit of refactoring

* add guest token security tests

* refactor tests

* clean imports

* variable names can be too long apparently

* missing argument to get_user_roles

* don't redefine builtins

* remove unused imports

* fix test import

* default to global user when getting roles

* missing import

* mock it

* test get_user_roles

* infer g.user for ease of tests

* remove redundant check

* tests for guest user security manager fns

* use algo to get rid of warning messages

* tweaking access checks

* fix guest token security tests

* missing imports

* more tests

* more testing and also some small refactoring

* move validation out of parsing

* fix dashboard access check again

* add more test

Co-authored-by: Lily Kuang <lily@preset.io>

* feat: Row Level Security rules for guest tokens (#17836)

* helper methods and dashboard access

* guest token dashboard authz

* adjust csrf exempt list

* eums don't work that way

* Remove unnecessary import

* move row level security tests to their own file

* a bit of refactoring

* add guest token security tests

* refactor tests

* clean imports

* variable names can be too long apparently

* missing argument to get_user_roles

* don't redefine builtins

* remove unused imports

* fix test import

* default to global user when getting roles

* missing import

* mock it

* test get_user_roles

* infer g.user for ease of tests

* remove redundant check

* tests for guest user security manager fns

* use algo to get rid of warning messages

* tweaking access checks

* fix guest token security tests

* missing imports

* more tests

* more testing and also some small refactoring

* move validation out of parsing

* fix dashboard access check again

* rls rules for guest tokens

* test guest token rls rules

* more flexible rls rules

* lint

* fix tests

* fix test

* defaults

* fix some tests

* fix some tests

* lint

Co-authored-by: Lily Kuang <lily@preset.io>

* SupersetClient guest token test

* Apply suggestions from code review

Co-authored-by: Lily Kuang <lily@preset.io>

Co-authored-by: Lily Kuang <lily@preset.io>
2022-01-25 16:41:32 -08:00
Adam Dobrawy
62009773a6
feat(helm): Add schema of values in Helm Chart (#18161)
* Add schema of values in Helm Chart

* chore(helm): bump our Chart version

* Fix schema values in Helm Chart

* fix(helm): fix relax required parameters for postgres & redis password, apply review comments
2022-01-25 15:33:39 -08:00
Lyndsi Kay Williams
2491b89f29
Columns tab name field no longer editable, calculated columns rows now vertically aligned (#18164) 2022-01-25 14:34:56 -06:00
Erik Ritter
9900e5a689
fix: exclude node_modules from ts tracking (#18117) 2022-01-25 10:14:25 -08:00
Elizabeth Thompson
60db35cb4d
chore: bump pillow to major version (#18134)
* bump pillow to major version

* make a wider range for pillow dependency versions
2022-01-25 09:51:14 -08:00
Stephen Liu
7bb867407a
fix(textarea-control): ace editor input exception (#18146) 2022-01-25 16:57:12 +01:00
cccs-Dustin
2dd64f9a93
fix(import_datasources): --sync flag works correctly (#18046)
* Added code that properly accepts the -s flag on the import-datasources cli command. Also added unit tests for all of the edge cases (with both metrics & columns, with just columns, and with just metrics)

* Files were reformated using the 'pre-commit run --all-files' command

* added '*args: Any' back into v0.py as it did not need to be removed. Removing it might cause headaches for someone trying to work on this particular piece of code in the future

* Fixed the merge conflict as the cli.py was moved to another directory

* Modified my created unit tests to work with the new format of uni tests since the merge

* Modified my created unit tests to work with the new format of uni tests since the merge

* Fixed errors which were encountered while using the unit tests
2022-01-25 15:53:44 +01:00
Michael S. Molina
f018c826b8
refactor: Moves the Explore form_data endpoint (#18151)
* refactor: Moves the Explore form_data endpoint

* Removes unused imports

* Fixes openapi schema error

* Fixes typo

* Renames and UPDATING.md
2022-01-25 11:14:50 -03:00
Beto Dealmeida
fa104fee9a
chore: use pkg_resources for cleaner config (#18130) 2022-01-24 11:44:15 -08:00
Beto Dealmeida
1c0b141e2d
feat: allow assets to be managed externally (#18093)
* feat: allow assets to be managed externally

* Use server_default
2022-01-24 11:03:01 -08:00
Kamil Gabryjelski
c77d24cda3
fix: undefined error when adding extra sequential color scheme (#18152) 2022-01-24 19:20:49 +01:00
Farid Rener
350da92f98
Docs: fix typo (#18125) 2022-01-24 09:19:37 -08:00
Kamil Gabryjelski
e632193eb0
feat(explore): more toast feedback on user actions in Explore (#18108)
* feat(explore): add toasts feedback when user copies chart url

* Show toast message when updating chart properties

* Change toast type to success when saving chart

* Use success toast from props

* Fix tests

* Use withToasts instead of dispatch

* Use PropertiesModalProps instead of any
2022-01-24 11:42:24 +01:00
Kamil Gabryjelski
d9eef8ec2f
feat(dashboard): add toast feedback to dashboard actions (#18114) 2022-01-24 11:42:12 +01:00
Kamil Gabryjelski
9fa2812343
feat(annotation): add toast feedback to annotation templates (#18116) 2022-01-24 11:41:39 +01:00
jayakrishnankk
4b89ac7447
chore: migrating storybook jsx to typescript #18100 (#18133)
* Migrating storybook jsx to typescript #18100

* Migrating storybook jsx to typescript

Co-authored-by: Jayakrishnan Karolil <jayakrishnan.karolil@nielsen.com>
2022-01-24 14:32:18 +08:00
Hammad-Raza
0cec0c9a68
feat(country-map): added new countries in country-chart-map (#18081) 2022-01-22 12:05:20 +08:00
Ville Brofeldt
e9651ea52f
feat(plugin-chart-echarts): support non-timeseries x-axis (#17917)
* feat(plugin-chart-echarts): support non-timeseries x-axis

* fix tests

* change formula return type from Date to number

* add x_axis test coverage

* rename func and improve coverage

* add x-axis control to bar chart

* remove redundant console.log

* fix description

* make x-axis control mandatory

* 🙃

* fix x-axis formatter

* fix showValues

* fix implicit rDTTM_ALIAS references in postProcessing

* replace TIME_COLUMN with DTTM_ALIAS

* fix remaining implicit indexes

* fix: Disable filtering on wide result sets (#18021)

* fix: handle null values in time-series table (#18039)

* cleanup column_type_mappings (#17569)

Signed-off-by: Đặng Minh Dũng <dungdm93@live.com>

* important change to MakeFile (#18037)

* add missing is_timeseries to pivot op

Co-authored-by: Erik Ritter <erik.ritter@airbnb.com>
Co-authored-by: Grace Guo <grace.guo@airbnb.com>
Co-authored-by: Đặng Minh Dũng <dungdm93@live.com>
Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
2022-01-21 21:23:23 +02:00
Stephen Liu
b083b3421f
fix(explore): fix chart embed code modal glitch (#17843) 2022-01-21 09:11:33 -07:00
Michael S. Molina
959b15eeca
feat: Adds a key-value endpoint to store charts form data (#17882)
* feat: Adds a key-value endpoint to store charts form data

* Fixes linting problems

* Removes the query_params from the endpoints

* Refactors the commands

* Removes unused imports

* Changes the parameters to use dataclass

* Adds more access tests

* Gets the first dataset while testing

* Adds unit tests for the check_access function

* Changes the can_access check

* Always check for dataset access
2022-01-20 16:27:57 -03:00
Elizabeth Thompson
1f8129241b
update changelog and updating for 1.4.0 (#18083) 2022-01-20 09:38:43 -08:00
Daniel Vaz Gaspar
5fb8b0a13a
fix: logging warning on dataframe (don't use python's warnings) (#18111)
* fix: logging warning on dataframe (don't use python's warnings)

* lint
2022-01-20 16:24:30 +00:00
Adam Dobrawy
a5e805ef2a
refactor: migrate RowCountLabel to TypeScript & added story (#18105)
* enable superbook for explore component

* migrate RowCountLabel to TypeScript

* add storybook for RowCountLabel
2022-01-20 15:35:09 +01:00
Adam Dobrawy
c3a17a7228
Migrate Checkbox story to tsx - see #18100 (#18101)
Looks good!
2022-01-20 15:33:45 +01:00
Adam Dobrawy
5ce79ff856
fix(docs): fix path of image for "Create New Chart" (#18089) 2022-01-20 15:33:12 +01:00
Josue Lugaro
035638c958
refactor: sqleditorleftbar to functional (#17807)
* Working on converting sqleditorleftbar to functional component

* Creating draft PR to address bug

* Still working on solving re rendering bug

* infinite rerender fix

* Creating draft PR to address bug

* Cleaning up in preparation for push

* Made changes suggested by Elizabeth

* Fixed issues as per Lindsey's comment

Co-authored-by: Arash <arash.afghahi@gmail.com>
2022-01-19 15:06:28 -06:00
Emily Wu
f505094835
fix misspelling (#18097) 2022-01-19 15:56:52 -05:00
Beto Dealmeida
9e2bc72fb9
chore: split CLI into multiple files (#18082)
* chore: split CLI into multiple files

* Update tests

* Who fixes the fixtures?

* Add subcommands dynamically

* Rebase
2022-01-19 11:27:16 -08:00
ofekisr
810cfc13db
fix can't use examples helpers on non app context based environment (#18086) 2022-01-19 20:16:15 +02:00
Adam Dobrawy
f53a267ffb
Correction of proper names format in README (#18087) 2022-01-19 09:20:40 -05:00
Stephen Liu
22896f2803
feat: add chart description in info tooltip (#17207)
* feat: add chart list description

* fix: text overflow

* fix: text-overflow with line-height
2022-01-19 21:24:17 +08:00
ofekisr
4675ca31c5
refactor(example_data): replace the way the birth_names data is loaded to DB (#18060)
* refactor: replace the way the birth_names data is loaded to DB

* fix failed unit test

* fix failed unit test

* fix failed tests

* fix pass wrong flag of support datetime type

* remove unused fixture
2022-01-18 23:21:04 +02:00
AAfghahi
88db2cc0ab
refactor(sql_lab): SQL Lab Persistent Saved State (#17771)
* a lot of console logs

* testing

* test

* added saved_query to remoteId

* created useEffect so that title properly changes in modal

* Update superset-frontend/src/SqlLab/actions/sqlLab.js

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
2022-01-18 13:10:31 -05:00
Ville Brofeldt
5bfe2d47b0
fix(generator): add lockfile and fix styling issues (#18073)
* fix(generator): add lockfile and fix styling issues

* fix margins and remove redundant scroll

* update tutorial
2022-01-18 12:37:09 +02:00
Stephen Liu
3b64563f3f
fix(dashboard): scope of nativefilter not update (#18048) 2022-01-18 16:51:51 +08:00
Yongjie Zhao
0c7f7288d8
feat(advanced analytics): support groupby in resample (#18045) 2022-01-17 18:42:59 +08:00
Ville Brofeldt
8dea7f500b
fix(generator): more cleanup to plugin framework (#18027)
* fix(generator): more cleanup to plugin framework

* fix typo and package name

* add docs

* fix typo

* Update superset-frontend/webpack.config.js

Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>

* fix generator reference

* add steps to tutorial and fix package version

* refine docs/readme

Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
2022-01-17 10:23:35 +02:00
Ville Brofeldt
de8a1fa9c6
chore(plugin-chart-echarts): add types to controls (#18059) 2022-01-16 14:21:47 +02:00
ofekisr
e53a50a155
chore(supeset.utils.core): move all database utils to database utils module (#18058) 2022-01-16 08:32:50 +02:00
Đặng Minh Dũng
0b67fe1beb
feat: Trino Authentications (#17593)
* feat: support Trino Authentications

Signed-off-by: Đặng Minh Dũng <dungdm93@live.com>

* docs: Trino Authentications

Signed-off-by: Đặng Minh Dũng <dungdm93@live.com>
2022-01-14 21:02:47 -08:00
Hugh A. Miles II
5da3c45fc6
Revert "Update superset-e2e.yml (#18041)" (#18051)
This reverts commit b5652739c9.
2022-01-14 14:40:02 -05:00
Hugh A. Miles II
b5652739c9
Update superset-e2e.yml (#18041) 2022-01-14 13:32:39 -05:00
AAfghahi
7728db7410
important change to MakeFile (#18037) 2022-01-14 10:22:30 -05:00
Đặng Minh Dũng
5a740901d6
cleanup column_type_mappings (#17569)
Signed-off-by: Đặng Minh Dũng <dungdm93@live.com>
2022-01-14 11:07:17 +02:00
Grace Guo
26dc600aff
fix: handle null values in time-series table (#18039) 2022-01-13 21:47:07 -08:00
Erik Ritter
343d3f8f7a
fix: Disable filtering on wide result sets (#18021) 2022-01-13 10:11:18 -08:00
Erik Ritter
14b9298ef7
fix: revert #17654 to fix subselect table name parsing (#18017) 2022-01-12 21:28:23 -08:00