Commit Graph

134 Commits

Author SHA1 Message Date
Ville Brofeldt f369ab35d6
chore: move bullet string manipulation to frontend (#9773) 2020-05-11 11:49:27 -07:00
Phillip Kelley-Dotson b6df5da195
fix bug where error at import dashboard fails to show toast in "welcome" app (#9714)
* fix bug where error at import dashboard fails

* fix: make reusable component for messages and bring to app level

* fix: add liscence

* fix: lint errors and tests

* fix

* fix: lint

* fix: lint error

* add suggestions

* add suggestions

Co-authored-by: Phillip Kelley-Dotson <pkd@pkd.lan>
2020-05-08 10:50:55 -07:00
David Aaron Suddjian 3a213916c4
use the builtin calendar control panel (#9771) 2020-05-07 21:15:03 -07:00
David Aaron Suddjian 8a49c69f38
use word cloud's built in control panel (#9770) 2020-05-07 18:28:48 -07:00
Jesse Yang 13c5b133a9
test(frontend): use absolute path for src imports (#9761)
* test(frontend): use absolute path for src imports

* Upgrade prettier, fix eslint
2020-05-07 14:18:10 -07:00
Ville Brofeldt 5b430ead42
fix: implement force refresh in chart data request (#9762)
* fix: implement force refresh in chart data request

* unrelated lint
2020-05-07 09:33:41 -07:00
David Aaron Suddjian 80f8349018
Query the new chart data api for charts that support it (#9710)
* calling new chart api (mostly working)

* can't .then when the promise has already been await-ed

* Add handling for v1 API response

* comment

* update word cloud plugin & dependencies

* testing

* try just waiting

* Revert "try just waiting"

This reverts commit 10c092effd.

* tweaking bootstrap types

* Bumping word cloud package version

* new package lock

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
Co-authored-by: Evan Rusackas <evan@preset.io>
2020-05-07 01:09:28 -07:00
Evan Rusackas b93bf05bbd
fix: removing controls from incubator-superset that are now in the plugin (#9758) 2020-05-06 17:29:49 -07:00
Krist Wongsuphasawat 52de32b9d7
build: bump superset-ui to 0.13 (#9757)
* chore: bump superset-ui

* build: bump superset-ui to 0.13

* docs: remove comment
2020-05-06 15:44:18 -07:00
Grace Guo 83b4165e61
[perf logging] Add extra logging for new/editMode dash (#9745)
* [perf logging] Add extra logging for new/editMode dash

* fix review comments
2020-05-06 09:03:04 -07:00
Maxime Beauchemin 9aabafe9fe
fix: adhoc filter 'equals' doesn't let you save (#9652)
When altering a filter, when using `equals` or `does not equals`,
the save button is disabled even when it should be enalbed.
2020-05-06 08:38:10 -07:00
Bogdan 292704fec9
Use monospace (#9709)
Update superset-frontend/src/SqlLab/main.less

Co-authored-by: Evan Rusackas <evan@preset.io>

Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
Co-authored-by: Evan Rusackas <evan@preset.io>
2020-05-06 08:37:16 -07:00
Ville Brofeldt 5485eb993c
feat: Add controlGroups to formData (#9740) 2020-05-06 14:53:13 +03:00
Maxime Beauchemin 67d8b634b8
fix: autocomplete search in AdhocFilter operator dropdown (#9654)
Searching for 'equ' in AdhocFilter's operator dropdown doesn't find the
options who's label contain that substring.

I'd write a unit test but it's pretty tricky.
2020-05-05 21:43:33 -07:00
Erik Ritter 821e7e53a9
chore: update README screenshots (#9728) 2020-05-05 13:02:10 -07:00
Grace Guo 0b963bdbb6
[perf logging] Add timing event when browser tab is hidden (#9733)
* [perf logging] Add timing event when browser tab is hidden

* fix review comment
2020-05-05 10:17:22 -07:00
David Aaron Suddjian d65d29c810
fix: css prop is now overwhelmed with emotion (#9742) 2020-05-05 10:10:56 -07:00
David Aaron Suddjian 9d3da79c4b
migrate bignumber to use builtin controls (#9707)
* migrate bignumber to use builtin controls

* install @babel/compat-data
2020-04-30 19:27:44 -07:00
Grace Guo 43eec67291
[table editor] hide Edit Datasource option when no onDatasourceSave (#9706)
* [table editor] hide Edit Datasource option when no onDatasourceSave

* add !! operator to get truthiness
2020-04-30 17:32:01 -07:00
Erik Ritter 5fb883e279
chore(ts): type getClientErrorObject (#9693) 2020-04-30 17:03:31 -07:00
ʈᵃᵢ f7f60cc75d
[Chart & Dashboard] improve listview filter ui and add expandable list support (#9651)
* better styling for select filters and search input

* add emotion babel plugin

* add spec for search input

* fix async select, add beeter error messages

* add error boundary around views

* cleanup and lint

* add expandable list to dashboards

* fix emotion babel config

* fix specs

* remove commented out code

* add selected style

* DRY up styles

* add icons

* fix type

* add apache license

* fix svgs

* fix ExpandableList type

* reduce custom css

* lint
2020-04-29 21:54:07 -07:00
Erik Ritter 5d7b13507e
feat(errors): add client scaffolding for custom error messages (#9677) 2020-04-29 17:20:31 -07:00
Grace Guo 52a0afe241
[fix] reduce table metadata fetch for latest_partition check (#9685)
* [fix] reduce table metadata fetch for latest_partition check

* fix review comment
2020-04-29 11:40:29 -07:00
Grace Guo 735dcd2002
[explore view] add partition as adhoc filter option (#9637)
* [explore view] add partition as adhoc option

* use adhocFilter Simple Tab

* simplify conditional check for custom adhoc filter operator

* add simple unit tests
2020-04-28 23:09:44 -07:00
Natalie Ruhe 9d755bc1ad
[fix] Support APP_ICON_WIDTH configuration parameter in SPA menu (#9666)
* Expose additional APP_ICON_WIDTH python config variable to ui via app bootstrap for use in Menu

* Update base.py to inclue APP_ICON_WIDTH via bracket notation instead of .get and adjust Menu proptypes to be required.

Co-authored-by: Natalie Ruhe <nruhe@nruhe.attlocal.net>
Co-authored-by: Natalie Ruhe <natalie@preset.io>
2020-04-28 12:59:03 -07:00
Lily Kuang c474ea848a
[fix] Push browser history on pagination in react listviews (#9624)
* improve history for query params

* fix: push browser history on pagination in react listviews

* fix spec

Co-authored-by: Tai Dupree <tdupreetan@gmail.com>
2020-04-27 21:37:22 -07:00
Erik Ritter e8c3803336
chore(ts): refactor and migrate StackTraceMessage to TypeScript (#9663) 2020-04-27 13:24:21 -07:00
Evan Rusackas 5e4c291913
Controls cleanup pass (#9578)
* migrating date_filter

* normalized control

* filter_configs control

* column_collection control

* time_range_endpoints control

* time_range_fixed control

* url_params control

* cache_timeout control

* annotation_layers control

* color control unused?

* linters rule 🤘

* this should have been deleted earlier

* global_opacity, mapbox_label, mapbox_style, viewport_zoom

* linting

* comparison_type

* contribution control

* log_scale

* show_values

* table_filter

* pandas_aggfunc

* code control

* formatSelectOptions import

* lint

* markup_type control

* lintage

* date_time_format control, linting

* url control, test mods

* min_periods control

* rolling_periods

* rolling_type

* missing lib

* order_desc

* number_format

* link_length

* all_columns_y

* all_columns_x

* normalize_across, select_country, all_columns

* fixing test

* linter-caught dependencies

* waiting

* wait longer!

* utilizing tabOverride for Analytics

* tabOverride for Annotations and Layers
2020-04-24 16:12:26 -07:00
Grace Guo 29dd989483
[dashboard] increase tab count limit (#9640) 2020-04-24 13:41:33 -07:00
David Aaron Suddjian f8adfc8fbf
use new @superset-ui/style package for theming (#9605)
* use new @superset-ui/style package for theming

* fix tests to reference theme

* try adding a wait
2020-04-22 13:13:40 -07:00
Jesse Yang 7b33d5457b
fix: change number format to original value to "~g" (#9608)
Originally it uses " ", which do give the original value, but will
not work when the `getNumberFormatter` in `superset-ui/number-format`
is called for the second time. Because the format will successfully
register as "" [1], but cannot be obtained again via `registry.get()`[2].

[1]: 44ad062dd0/packages/superset-ui-number-format/src/NumberFormatterRegistry.ts (L30)
[2]: dc804b7a70/packages/superset-ui-core/src/models/RegistryWithDefaultKey.ts (L36)
2020-04-22 10:07:37 -07:00
Erik Ritter dcbffed9bb
[SQL Lab] Lock result set controls to be always visible (#9587) 2020-04-21 12:09:33 -07:00
ʈᵃᵢ 0b999e3b91
[charts] adds new filters ui (#9530)
* [charts] adds new filters ui

* move null check to be more visible

* better filter lists and async filter functionality
2020-04-21 12:04:11 -07:00
Erik Ritter ba691d3a27
Bump superset-ui-connection to 0.12.22 (#9602) 2020-04-21 11:36:01 -07:00
Jesse Yang 2b957a2c1e
Add raw number/integer option to d3 number formats (#9562) 2020-04-20 21:31:47 -07:00
ʈᵃᵢ cb51d7833f
[Build] moves prettier check to separate script (#9591)
* [Build] moves prettier check to separate script

* rename step: eslint -> lint
2020-04-20 15:06:33 -07:00
Evan Rusackas ea27e68ee1
Migrating shared NVD3 controls to new module (#9525)
* proto module

* caught a missed 'freq' unique control

* line_interpolation

* linting

* showLegend

* show_controls

* xAxisLabel

* bottomMargin

* x_ticks_layout

* missed one

* x_axis_format

* yLogScale

* y_axis_bounds

* linting

* nixing yarn lock

* x_axis_showminmax

* xAxisShowminmax control

* richTooltip

* linting, syntax fix

* show_bar_value, bar_stacked

* reduceXticks, yaxislabel

* left_margin, max_bubble_size, y_axis_showminmax

* show_labels

* send_time_range, y_axis_2_format, show_markers, order_bars

* nixing commented imports

* fake controls

* looking up actual controls for comparison.

* adding key to test setup

* controls inventory

* apache junk

* lint 

* ignore null controls

* fixing goofed up spread operation for xAxisFormat config

* lint 

* fixes for errors caused by <hr> element in filterbox controls

* fixing filter controls for 'druid_time_origin', 'granularity', 'granularity_sqla', 'time_grain_sqla'

* getControlsInventory -> getControlsForVizType

* further renaming of chartControlsInventory - > getControlsForVizType

Co-authored-by: David Aaron Suddjian <aasuddjian@gmail.com>
2020-04-17 11:40:50 -07:00
Ville Brofeldt 427d2a05e5
chore: Migrate unique FilterBox controls from controls.jsx (#9566)
* Migrate FilterBox controls from controls.jsx

* Linting
2020-04-17 12:20:32 +03:00
Jesse Yang d8de540e0c
[Build] Collect frontend code coverage from Cypress tests (#9555)
* build: collect code coverage from Cypress

Collect frontend code coverage reports from Cypress tests and add
proper tagging for all tests.

* Fix bash script lint error from shellcheck

* Revert Cypress to 4.3.0 to see if it fixes a failing test
2020-04-16 23:35:01 -07:00
Grace Guo 4a55e1ea3a
[fix] dashboard filter scope bug (#9550) 2020-04-16 15:44:03 -07:00
Jesse Yang d9ebd32485
Bump @superset-ui/legacy-plugin-chart-table to 0.12.14 (#9549) 2020-04-15 14:41:36 -07:00
ʈᵃᵢ 1ccda920fe
[list views] add work-break css for table layouts (#9537) 2020-04-14 22:04:24 -07:00
Jianchao Yang 7b4b0d1c61
[Build] Add Github workflows (#9517)
As an replacement to Travis CI.
2020-04-14 13:38:09 -07:00
Evan Rusackas 6270f7dc24
Importing validators module from superset-ui (#9465)
* importing... this is going to break CI, but there it is.

* adding validator package.

* pluralization - maybe it should be plural, but whatevs

* updating validators to match new exports

* removing old validators

* lintage 

* validateNumeric -> validateNumber

* using legacyValidateInteger, legacyValidateNumber

* linting 

* removing extraneous package lock file
2020-04-14 12:00:25 -07:00
Evan Rusackas f29d0fd9f2
control to turn off table bar-chart backgrounds (#9500)
* control to turn off table bar-chart backgrounds

* flipping enable to disable, to support existing charts

* lint 

* Turn ON to enable (reversing logic)

* bumping big number chart

* ling 
2020-04-13 16:53:50 -07:00
ʈᵃᵢ f90824fa17
[Dashboard] new listview filters & emotion infra (#9462)
* [Dashboard] listview filters to match new design

* use title_or_slug filter

* use ?. operator

* move components to components folder
2020-04-13 13:39:55 -07:00
Bogdan 02b3fb1d63
Add visualization flow to the CTA queries (#9370)
* Visualize after running Ctas query (#4)

* Visualize after running Ctas query.

Stub for table viz

Work on the viz

Add JS functionality for Ctas viz

Add test for the table viz flow

Fix test

Add js test for the ctas viz

* Fix tests

* Resolve comments

* Leverate tmpSchema in the query object

* Fix i18n string

Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
2020-04-11 00:46:46 +03:00
Ville Brofeldt 5ec0192bcc
fix: add lineWidth to Shared_DeckGL.jsx (#9496)
* fix: add lineWidth to Shared_DeckGL.jsx

* linting
2020-04-09 12:47:50 -07:00
Jianchao Yang 5565895819
fix: add explore control tabOverride at the section level (#9495) 2020-04-08 18:26:53 -07:00
Jianchao Yang 36cd5411d0
feat: change default time range in sql lab explore (#9486)
Change from "100 years go" to "no filter".

100 years ago is basically equivalent to no filter, but has
implications on how x-axis is plotted on certain charts (e.g. Big
Number).
2020-04-08 17:39:14 -07:00