Commit Graph

153 Commits

Author SHA1 Message Date
Yongjie Zhao
7c252d7524
feat: adding truncate metric control on timeseries charts (#20373) 2022-06-15 20:55:10 +08:00
Yongjie Zhao
d04357c47b
fix: superset-ui/core codes coverage (#20324) 2022-06-09 17:43:42 +08:00
Stephen Liu
eab0009101
feat(plugin-chart-echarts): [feature-parity] support extra control for the area chart V2 (#16493)
* feat(echarts): [feature-parity] support extra control

* add extra control for plugin

* refactor: extract ExtraControl

* fix: lint

* fix some problems
2022-06-09 00:59:10 +08:00
Stephen Liu
9f02ff656d
fix(plugin-chart-echarts): [feature-parity] apply button of annotation layer doesn't work as expected (#19761)
* fix(plugin-chart-echarts): [feature-parity] apply button of annotation layer does't work

* fix: lint

* fix: test
2022-06-08 17:06:24 +08:00
Lyndsi Kay Williams
ba0c37d3df
feat(explore): Frontend implementation of dataset creation from infobox (#19855)
* Frontend implementation of create dataset from infobox

* Fixed sl_dataset type

* Fix test

* Fixed sl_dataset type (forgot to save)

* RTL testing

* Adjusted styling/text on infobox and save dataset modal

* Appease lint

* Make infobox invisible and fix tests

* Remove unnecessary placeholder

* Move types to sql lab

* Moved logic into save dataset modal

* Change DatasourceMeta type to Dataset

* Add ExploreDatasource union type to save dataset modal

* Get user info from redux inside save dataset modal

* Addressed comments

* Adjusting to new query type

* Fixed save dataset in explore and union type

* Added testing

* Defined d for queries

* Remove dataset from SaveDatasetModal

* Clarify useSelector parameter

* Fix dndControls union type

* Fix shared-controls union type

* Fix controlPanel union type

* Move ExploreRootState to explore type file

* Remove unnecessary testing playground

* Move datasource type check in DatasourcePanel to a function

* Make all sqllab Query imports reference @superset-ui/core Query type

* Deconstruct query props in ResultSet

* Fix union type in /legacy-plugin-chart-heatmap/src/controlPanel

* Change SaveDatasetModal tests to RTL

* Cleaned datasourceTypeCheck

* Fix infobox styling

* Fix SaveDatasetModal test

* Fix query fixture in sqllab and Query type in SaveDatasetModal test

* Fix Query type and make test query fixture

* Added columns to Query type, separated results property, created QueryResponse union type, and fixed all types affected

* Fixed a couple missed broken types

* Added ExploreDatasource to SqlLab type file

* Removed unneeded Query import from DatasourcePanel

* Address PR comments

* Fix columnChoices

* Fix all incorrect column property checks

* Fix logic on dndGroupByControl

* Dry up savedMetrics type check

* Fixed TIME_COLUMN_OPTION

* Dried savedMetrics type check even further

* Change savedMetricsTypeCheck to defineSavedMetrics

* Change datasourceTypeCheck to isValidDatasourceType

* Fix Query path in groupByControl

* dnd_granularity_sqla now sorts Query types with is_dttm at the top

* Fixed/cleaned query sort

* Add sortedQueryColumns and proper optional chaining to granularity_sqla

* Move testQuery to core-ui, add test coverage for Queries in columnChoices

* Moved DEFAULT_METRICS to core-ui and wrote a test for defineSavedMetrics

* Add license and clean dataset test object

* Change DatasourceType.Dataset to dataset
2022-06-07 15:03:45 -05:00
Yongjie Zhao
7faf874c1b
feat: derived metrics use different line style (#20242) 2022-06-05 21:17:31 +08:00
Yongjie Zhao
dd4b581fb5
feat: standardized form_data (#20010) 2022-06-05 21:05:01 +08:00
Stephen Liu
766f737728
feat(world-map): support color by metric or country column (#19881)
* feat(world-map): support color by metric or country column

* fix lint

* Update superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/components/RadioButtonControl.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/plugins/legacy-plugin-chart-world-map/src/controlPanel.ts

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/plugins/legacy-plugin-chart-world-map/src/controlPanel.ts

Co-authored-by: Evan Rusackas <evan@preset.io>

* fix lint

Co-authored-by: Evan Rusackas <evan@preset.io>
2022-06-03 21:31:22 +08:00
Ville Brofeldt
d5c5e58583
feat(plugin-chart-echarts): add support for generic axis to mixed chart (#20097)
* feat(plugin-chart-echarts): add support for generic axis to mixed chart

* fix tests + add new tests

* address review comments

* simplify control panel

* fix types and tests
2022-05-19 13:51:52 +03:00
Stephen Liu
9854d2d0e8
feat(plugin-chart-echarts): support horizontal bar chart (#19918)
* feat(plugin-chart-echarts): support horizontal bar chart

* Update superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Regular/Bar/controlPanel.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* Update superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* Update superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Regular/Bar/controlPanel.tsx

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* improve controlpanel

* default value

* fix ut

Co-authored-by: Evan Rusackas <evan@preset.io>
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2022-05-16 21:48:36 +08:00
Kamil Gabryjelski
0f68deedf1
perf(plugin-chart-table): Add memoization to avoid rerenders (#19976)
* perf(plugin-chart-table): Add memoization to avoid rerenders

* Fix typing
2022-05-13 18:10:48 +02:00
Ville Brofeldt
b53daa91ec
fix(plugin-chart-echarts): support adhoc x-axis (#20055)
* fix(plugin-chart-echarts): support adhoc x-axis

* simplify code
2022-05-13 16:29:51 +03:00
Hugh A. Miles II
8b15b68979
fix: Alpha should not be able to edit datasets that they don't own (#19854)
* fix api for checking owners

* fix styles for disabling

* fix styles for disabling

* fix lint

* fix lint

* add owners key

* plzz

* remove

* update test

* add tooltip

* add type

* fix test

* fix user reference

* lit

* fix test

* work
2022-04-29 14:21:05 -07:00
Diego Medina
e4fca89217
fix: Cannot re-order metrics by drag and drop (#19876)
* fix: cannot-re-order-metrics-by-drag-and-drop

* add tests
2022-04-27 20:37:12 -06:00
Yongjie Zhao
f5e9f0eb3b
feat: add Advanced Analytics into mixed time series chart (#19851) 2022-04-27 23:36:19 +08:00
Kamil Gabryjelski
12bc30e2c7
Fix display of column config in table chart (#19806) 2022-04-21 19:08:04 +02:00
Stephen Liu
e3a54aa3c1
feat(explore): improve UI in the control panel (#19748)
* feat(explore): improve section header of control panel

* fix checkbox control color and radio button color
2022-04-20 15:06:33 +02:00
Yongjie Zhao
4f997cd9ac
chore: fix grammar error (#19740) 2022-04-20 21:02:14 +08:00
Yongjie Zhao
3c28cd4625
feat: add renameOperator (#19776) 2022-04-20 19:48:12 +08:00
Yongjie Zhao
9425dd2cac
fix: drop the first level of MultiIndex (#19716) 2022-04-14 23:40:38 +08:00
Kamil Gabryjelski
de9fb2109d
chore(explore): Change labels "Group by"/"Series" to "Dimensions" (#19647) 2022-04-13 15:16:03 +02:00
Kamil Gabryjelski
4a5dddf52d
fix(explore): Change copy of cross filters checkbox (#19646) 2022-04-13 13:19:02 +02:00
Stephen Liu
0e29871493
fix(explore): clean data when hidding control (#19039) 2022-04-06 20:25:32 +08:00
Kamil Gabryjelski
60dcd651f4
feat(explore): SQL popover in datasource panel (#19308)
* feat(explore): SQL popover in datasource panel

* Fix acequire not defined

* Rebase and fix tests

* Disable highlighting gutter

* Use ace-build acequire instead of brace
2022-04-03 13:26:56 +02:00
Kamil Gabryjelski
a076ae6d99
feat(explore): UI changes in dataset panel on Explore page (#19394)
* feat(explore): Implement new design for dataset panel

* Fixes

* Replace drag handle in dashboard builder

* Add missing types

* Type fix

* Fix tests

* Fix non-dnd version

* Fix test

* Replace margin with height
2022-03-29 21:11:08 +02:00
Yongjie Zhao
a39dd4493e
feat: linear imputation in Resample (#19393) 2022-03-28 22:30:45 +08:00
Kamil Gabryjelski
45c28c8046
feat(explore): Dataset panel option tooltips (#19259)
* feat(explore): Add description to column/metric tooltips in dataset panel

* Fix tests

* Address code review comments
2022-03-25 07:55:11 +01:00
Yongjie Zhao
e15573d445
fix: number format should editable when AA in time comparison (#19351) 2022-03-25 07:58:53 +08:00
Kasia
dc769a9a34
fix: Adaptive formatting spelling (#19359)
Co-authored-by: Kasia Zajac <kasiazajac@Kasias-MacBook-Pro-2.local>
2022-03-24 20:51:06 +01:00
Stephen Liu
b0397beb8e
chore: add type checking in package tests directory (#19320) 2022-03-23 18:57:35 +08:00
Yongjie Zhao
375c03e084
feat(advanced analysis): support MultiIndex column in post processing stage (#19116) 2022-03-23 13:46:28 +08:00
Stephen Liu
dc575080d7
feat: improve color consistency (save all labels) (#19038) 2022-03-21 15:20:04 +08:00
smileydev
e7355b9610
fix(explore comma): make that the comma can be added by removing it from token separators… (#18926)
* make that the comma can be added by removing it from token separators in select component.

* fix(explore comma): add the allowTokenSeperators props into Select

* fix(explore comma): make to allow to customize the token separators in Select.

* fix(explore comma): make to add the unit test and story book.

* fix(explore comma): make to fix the lint

* fix(explore comma): make to fix the spell  & add tokenSeparatprs props to PickedSelectProps

* Update Select.tsx

* fix(explore comma): make to run lint fix
2022-03-18 11:39:26 -03:00
Stephen Liu
10eb6c77a4
chore: use order_desc shared control consistently (#19172) 2022-03-18 21:28:47 +08:00
smileydev
d099f5ed4a
fix(select): make to consider the case sensitive in case of d3 format selector (#19159) 2022-03-17 10:04:03 -07:00
Jesse Yang
ae13d8313b
feat(select): keep options order when in single mode (#19085) 2022-03-11 13:01:38 -08:00
Diego Medina
0e0beceac1
fix: Pivot Table Conditional Formatting Doesn't Show All Options (#19071)
* fix: Pivot Table Conditional Formatting Doesn't Show All Options

* PR comments

* PR comments
2022-03-09 15:04:04 -07:00
Geido
f53f86f796
Control sortby based on series limit (#18950) 2022-03-09 20:12:45 +02:00
Kamil Gabryjelski
9f834e8317
fix(plugin-chart-echarts): Apply temporary filters to Query B in explore (#18998)
* fix(explore): Extra filters not applied to query b in mixed timeseries

* Add return type

* Apply review comment

* Fix non-dnd filters
2022-03-04 17:48:41 +01:00
John Bodley
26486d01c1
chore: Remove legacy SIP-15 interim logic/flags (#18936)
* chore: Remove legacy SIP-15 logic

* Update ab9a9d86e695_deprecate_time_range_endpoints.py

* Update UPDATING.md

* Update UPDATING.md

* Update UPDATING.md

Co-authored-by: John Bodley <john.bodley@airbnb.com>
2022-03-04 09:15:36 +13:00
Kamil Gabryjelski
c56dc8eace
feat(legacy-preset-chart-deckgl): Add ,.1f and ,.2f value formats to deckgl charts (#18945)
* Add ,.1f and ,.2f value formats to deckgl charts

* Remove duplicated code
2022-02-28 14:07:55 +01:00
Kamil Gabryjelski
c1205b5279
feat(explore): Implement metrics and columns popovers empty states (#18681)
* feat(explore): Implement empty states for column and metrics popovers

* Fix test

* Change copy
2022-02-14 15:26:56 +01:00
Yongjie Zhao
aa21a963a6
feat: smart tooltip in datasourcepanel (#18080) 2022-02-07 22:48:23 +08:00
Ville Brofeldt
2929bb1680
fix(plugin-chart-echarts): fix forecasts on verbose metrics (#18252)
* fix(plugin-chart-echarts): fix forecasts on verbose metrics

* oops! 🙊

* check for DTTM_ALIAS
2022-02-02 13:51:51 +02:00
Ville Brofeldt
e9651ea52f
feat(plugin-chart-echarts): support non-timeseries x-axis (#17917)
* feat(plugin-chart-echarts): support non-timeseries x-axis

* fix tests

* change formula return type from Date to number

* add x_axis test coverage

* rename func and improve coverage

* add x-axis control to bar chart

* remove redundant console.log

* fix description

* make x-axis control mandatory

* 🙃

* fix x-axis formatter

* fix showValues

* fix implicit rDTTM_ALIAS references in postProcessing

* replace TIME_COLUMN with DTTM_ALIAS

* fix remaining implicit indexes

* fix: Disable filtering on wide result sets (#18021)

* fix: handle null values in time-series table (#18039)

* cleanup column_type_mappings (#17569)

Signed-off-by: Đặng Minh Dũng <dungdm93@live.com>

* important change to MakeFile (#18037)

* add missing is_timeseries to pivot op

Co-authored-by: Erik Ritter <erik.ritter@airbnb.com>
Co-authored-by: Grace Guo <grace.guo@airbnb.com>
Co-authored-by: Đặng Minh Dũng <dungdm93@live.com>
Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
2022-01-21 21:23:23 +02:00
Yongjie Zhao
0c7f7288d8
feat(advanced analytics): support groupby in resample (#18045) 2022-01-17 18:42:59 +08:00
Yongjie Zhao
e91b9a678f
refactor: move superset-ui dependencies to peerDependencies (#17965)
* chore: add commit message

* update learn

* update superset-ui-demo

* move superset-ui into peerDeps

* add --no-private argument in lerna version

* fix conflicts

* refresh lock file
2022-01-11 13:53:37 +08:00
serenajiang
05d9cde203
feat: update time comparison choices (again) (#17968) 2022-01-10 10:08:15 -08:00
Yongjie Zhao
cb97e37a92
refactor: import value name from root of superset-ui/core (#17947)
* chart

* index and number-format

* char-composition and color

* connection

* dimension and math-expression

* models

* query

* time-format

* residual modules

* change config of jest and eslint

config

* wip

update package.json

* fix lint

* WithLegend import from superset-ui/core
2022-01-08 09:16:24 +08:00
Stephen Liu
142b5bc506
fix: local warning in the frontend development (#17727) 2021-12-15 09:52:42 +02:00
Corbin Robb
f476ba23a2
fix(select): select component sort functionality on certain options (#17638)
* fix: Select component sort function sorting by label instead of value on numbers

* fix: change select component default sorting to sort by the initial index rather than a property like value or label

* fix: select sorting add sortOptions to select components using sortByProperty

* fix: change select component back, add order to options coming in from SelectControl

* fix: select component options intitial sort bug

* fix: add test cases for select fix

Co-authored-by: Corbin Robb <corbin@Corbins-MacBook-Pro.local>
2021-12-09 11:40:25 -05:00
Yongjie Zhao
04e3cfa607
refactor(monorepo): relocate deckgl to Superset (#17596) 2021-12-09 08:45:18 +08:00
Yongjie Zhao
3c41ff68a4
refactor(monorepo): move superset-ui to superset(stage 2) (#17552) 2021-11-30 08:29:57 +08:00