Commit Graph

681 Commits

Author SHA1 Message Date
Ville Brofeldt
db2135109a
fix(dataset): avoid crash if database missing (#19582) 2022-04-07 13:43:17 +03:00
Kamil Gabryjelski
bb96029c9d
fix(explore): Chart header icon paddings (#19534) 2022-04-06 06:50:16 +02:00
Kamil Gabryjelski
602afbaa31
feat(explore): Move chart header to top of the page (#19529)
* Move chart header to top of the page

* Implement truncating and dynamic input

* fix typing

* Prevent cmd+z undoing changes when not in edit mode

* Fix tests, add missing types

* Show changed title in altered
2022-04-05 15:20:29 +02:00
Geido
7914296d8a
chore: Remove FilterbaleTableStyles.less (#19442)
* Remove FilterbaleTablesStyles less

* Add theme top level
2022-04-04 17:11:22 +03:00
dudasaron
b8891acf4a
fix(dashboard list): do not show favorite star for anonymous users #18210 (#19409)
* fix: Only show favorite star on dashboard list if user is logged in #18210

* Fix linter errors
2022-04-04 10:38:44 +03:00
Kamil Gabryjelski
60dcd651f4
feat(explore): SQL popover in datasource panel (#19308)
* feat(explore): SQL popover in datasource panel

* Fix acequire not defined

* Rebase and fix tests

* Disable highlighting gutter

* Use ace-build acequire instead of brace
2022-04-03 13:26:56 +02:00
Kamil Gabryjelski
fc8cb22376
feat(dashboard): Implement empty states for empty tabs (#19408)
* feat(dashboard): Implement empty states in empty tabs

* Change button to in text link

* Add edit dashboard button to dashboard empty state

* Add tests

* Fix test
2022-04-01 15:23:00 +02:00
Diego Medina
eab9388f7c
feat(sql lab): enable ACE editor search in SQL editors (#19328) 2022-03-31 16:05:00 -07:00
Kamil Gabryjelski
1a1322d3d9
feat(explore): Move chart actions into dropdown (#19446)
* feat(explore): Move chart actions to a dropdown menu

* Fix tests and add some new ones

* Add background color to embed code button

* Fix cypress tests

* Move copy permalink to actions menu

* Remove unused function

* Move share by email above embed code

* Fix test

* Fix test

* Fix test

* Fix test

* Fix test
2022-03-31 20:41:15 +02:00
Michael S. Molina
816a2c3e1e
chore: Removes direct theme imports (#19368) 2022-03-29 10:15:07 -03:00
Beto Dealmeida
d304849b46
feat: disable edits on external assets (#19344)
* feat: disable edits on external assets

* Update tests
2022-03-28 16:32:57 -07:00
smileydev
cb0357005e
fix(report-add): make to add error toast message when already attached report is added again into dashboard or chart (#19122)
* fix(report-add): make to add error toast message when already attached report is added again into dashboard or chart

* fix(export-add): make to setup the default error message

* fix(report-add): make to allow the errorMessage undefined in LabeledErrorBoundInput component
2022-03-24 17:18:34 -06:00
Michael S. Molina
65c204b288
fix: Null values on Explore filter (#19341) 2022-03-23 17:23:57 -04:00
Kamil Gabryjelski
a08f83bc60
fix(dashboard): Chart stuck in loading state when when datasets request and chart request fail (#19327) 2022-03-23 15:43:32 +01:00
Diego Medina
9e58916d93
fix: regression on Select component when handling null values (#19326) 2022-03-23 10:31:38 -03:00
Ville Brofeldt
b7ecb14230
fix(dashboard): fix default filter bar visibility + add docs (#18741)
* fix(dashboard): fix default filter tab visibility + add tests

* fix types

* lint

* rename docs + add double bang to length
2022-03-23 08:55:03 +02:00
Michael S. Molina
d3ce398448
fix: Don't allow duplicated tag values in the Select (#19283)
* fix: Don't allow duplicated tag values in the Select

* Addresses comments and adds test
2022-03-22 09:05:22 -03:00
Kamil Gabryjelski
a8a48af7fa
chore: Make font-weights themable, fix font faces (#19236)
* fix(fonts): Import all necessary font packages

* Make html tags themable

* Set bold font weight to 600, add medium font weight to theme

* Replace hard coded font weights with theme variables

* Change some font weight light elements to normal

* Fix tests

* Fix bug in pivot table

* Address code review comments
2022-03-22 09:36:15 +01:00
David Aaron Suddjian
35b8a72dae
Update ToastPresenter.tsx (#19296) 2022-03-22 10:10:43 +02:00
David Aaron Suddjian
96a123f553
feat: SupersetClient config to override 401 behavior (#19144)
* wip

* feat: make 401 responses configurable in SupersetClient

* sort

* guest unauthorized handler

* add toast container to embedded app

* add option for toast presenter to go at the top

* remove confusing comms logging

* lint

* Update superset-frontend/src/embedded/index.tsx

* type correction
2022-03-21 10:19:21 -07:00
Stephen Liu
dc575080d7
feat: improve color consistency (save all labels) (#19038) 2022-03-21 15:20:04 +08:00
David Aaron Suddjian
97abc28a1f
chore!: remove ENABLE_REACT_CRUD_VIEWS feature flag (permanently enable) (#19231)
* remove ENABLE_REACT_CRUD_VIEWS feature flag

* docs

* deal with problematic tests

* empty test suite

* skip test

* test conditions changed

* removing the tests instead of skipping
2022-03-18 14:00:23 -07:00
Grace Guo
d41f9b23a4
chore(superset 2.0): remove front-end deprecated code (#19241) 2022-03-18 11:23:00 -07:00
smileydev
e7355b9610
fix(explore comma): make that the comma can be added by removing it from token separators… (#18926)
* make that the comma can be added by removing it from token separators in select component.

* fix(explore comma): add the allowTokenSeperators props into Select

* fix(explore comma): make to allow to customize the token separators in Select.

* fix(explore comma): make to add the unit test and story book.

* fix(explore comma): make to fix the lint

* fix(explore comma): make to fix the spell  & add tokenSeparatprs props to PickedSelectProps

* Update Select.tsx

* fix(explore comma): make to run lint fix
2022-03-18 11:39:26 -03:00
Jesse Yang
f6291545fb
chore: turn on SQLLAB_BACKEND_PERSISTENCE by default (#19107)
* chore: turn on SQLLAB_BACKEND_PERSISTENCE by default

* Rewrite SQL tabs test to make it more rerunnable
2022-03-17 21:51:47 -07:00
Diego Medina
19fcd03c89
fix: allow to select <NULL> in a native filter single mode (#19076)
* fix: allow to select <NULL> in a native filter single mode

* fix lint issue

* Update superset-frontend/src/components/Select/utils.ts

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* fix

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2022-03-17 14:05:32 -03:00
cccs-Dustin
02ef9ca4cd
feat(sqllab): Add a configuration option to disable data preview (#19104) 2022-03-17 15:22:57 +02:00
Diego Medina
0277ebc225
fix: Popovers in Explore not attached to the fields they are triggered by (#19139)
* fix: Popovers in Explore not attached to the fields they are triggered by

* fix

* PR comment

* remove unused import
2022-03-16 20:46:52 -06:00
Diego Medina
3b427b2029
fix: auto-complete of tables and names are not working in SQL lab (#19152) 2022-03-16 20:46:06 -06:00
Ville Brofeldt
b7a0559aaf
feat: add permalink to dashboard and explore (#19078)
* rename key_value to temporary_cache

* add migration

* create new key_value package

* add commands

* lots of new stuff

* fix schema reference

* remove redundant filter state from bootstrap data

* add missing license headers

* fix pylint

* fix dashboard permalink access

* use valid json mocks for filter state tests

* fix temporary cache tests

* add anchors to dashboard state

* lint

* fix util test

* fix url shortlink button tests

* remove legacy shortner

* remove unused imports

* fix js tests

* fix test

* add native filter state to anchor link

* add UPDATING.md section

* address comments

* address comments

* lint

* fix test

* add utils tests + other test stubs

* add key_value integration tests

* add filter box state to permalink state

* fully support persisting url parameters

* lint, add redirects and a few integration tests

* fix test + clean up trailing comma

* fix anchor bug

* change value to LargeBinary to support persisting binary values

* fix urlParams type and simplify urlencode

* lint

* add optional entry expiration

* fix incorrect chart id + add test
2022-03-17 01:15:52 +02:00
Jesse Yang
8d53db1db6
test: fix TimezoneSelector tests on daylight saving time (#19156) 2022-03-16 14:47:41 -07:00
David Aaron Suddjian
3d66912d89
fix: clean up chart metadata config (#19143)
* fix: clean up chart metadata config

* missed a spot

* missed another spot

* fix failing time-specific test

* can't call translation functions here

* Revert "fix failing time-specific test"

This reverts commit 3eeb8ab9cc.

* skip problematic test

* extra import
2022-03-16 09:59:56 -07:00
Jesse Yang
ae13d8313b
feat(select): keep options order when in single mode (#19085) 2022-03-11 13:01:38 -08:00
Jesse Yang
3a78165d13
refactor(TimezoneSelector): simplify override logics and tests (#19090) 2022-03-10 18:09:20 -08:00
Kamil Gabryjelski
70081a698f
fix(dashboard): Empty states overflowing small chart containers (#19095)
* fix(dashboard): Empty states overflowing small chart containers

* Fix test
2022-03-10 15:54:07 +01:00
smileydev
220c46131e
fix(altered-modal): make specified text fields wrap in table (#18822)
* fix(altered-modal): make all text fields wrap

* fix(altered-modal): limit the wrap text in particular column

* fix(altered-modal): make to update the unit test

* fix(altered-modal): make to fix the type of columnsForWrapText

* fix(alerted-modal): make to fix the type of columnsForWrapTest with string type
2022-03-09 12:43:16 -07:00
Michael S. Molina
79a7a5d1b1
fix: Select clear and loading icons overlap (#19070) 2022-03-09 10:03:30 -03:00
Jesse Yang
c75f233109
feat(select): sort exact and startsWith match to first (#18856) 2022-03-08 07:08:40 -08:00
Michael S. Molina
04a36d5c92
chore: Moves Chart to the components folder (#19029) 2022-03-08 08:57:29 -03:00
Michael S. Molina
71b8d31e77
chore: Moves CRUD components to the Datasource component (#19032)
* chore: Moves CRUD components to the Datasource component

* Fixes imports

* Fixes less import
2022-03-07 09:02:18 -03:00
Michael S. Molina
329855170e
refactor: Deletes the common/components folder (#18999) 2022-03-04 14:19:14 -03:00
Michael S. Molina
06e1e4285e
feat: Adds support to multiple dependencies to the native filters (#18793)
* chore(native-filters): Remove cascading popovers from filter bar

Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
2022-03-04 13:06:10 -03:00
Jesse Yang
5a8eb09afb
feat: remove loading indicator when typing in select (#18799) 2022-03-03 09:40:49 -08:00
smileydev
ca93d63bbb
fix(tooltip-not-dissapeared): make the tooltip disappear when mouse away (#18892)
* fix(tooltip-not-dissapeared): make the tooltip disappear when mouse away

* fix(tooltip-not-dissapeared): change css props instead of sytles props
2022-03-01 08:05:11 -07:00
Michael S. Molina
fd4bd1edbc
chore: Moves components out of the commons folder (#18931)
* refactor: Moves components out of the commons folder

* Fixes tests
2022-02-25 10:17:32 -03:00
Kamil Gabryjelski
9d5c0505cf
feat(native-filters): Re-arrange controls in FilterBar (#18784)
* feat(native-filters): Re-arrange controls in FilterBar

* Typo fix

* Add tests

* Fix tests

* Address PR reviews

* Add 1px bottom padding to icon

* Fix test

* Tiny refactor

* Change buttons background

* Add hover state to Clear all button

* Fix Clear All button logic so it clears all selections

* Remove redundant useEffect

* Set zindex higher than loading icon

* Fix scrolling issue
2022-02-22 17:45:53 +01:00
smileydev
3c17c609c9
fix(altered-modal): displayed the metric value in altered modal correctly (#18813)
Co-authored-by: Evan Rusackas <evan@preset.io>
2022-02-20 16:27:46 -08:00
smileydev
91236a5225
fix(sqllab): Removed the tooltip from CopyToClipboard button in sqllab (#18749)
* fix(15849): Removed the tooltip from CopyToClipboard button in sqllab

* chore(sqllab): added props for tooltip in CopyToClipboard component

* fix(sqllab): Added arg to storybook and refactor the component

* fix(sqllab): added a test case for hideTooltip
2022-02-18 16:22:21 -07:00
smileydev
2d67d2f14e
fix(delete-modal): Changed the color of the help text with grayScale.dark1 in DeleteModal (#18786)
* fix(delete-modal): Changed the color of the help text with grayScale.dark1 in DeleteModal

* Update superset-frontend/src/components/DeleteModal/index.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>
2022-02-17 11:45:04 -07:00
Corbin Robb
c8df84985c
fix(CRUD/listviews): Errors with rison and search strings using special characters (#18056)
* fix errors with rison and useQueryParams

* add test for encode/decode

* add rison link and make test case more readable

Co-authored-by: Corbin Robb <corbin@Corbins-MacBook-Pro.local>
2022-02-15 16:08:36 -06:00