Commit Graph

9741 Commits

Author SHA1 Message Date
Krist Wongsuphasawat
5532c5ee1d v0.11.20 2021-11-26 11:46:02 +08:00
Jianchao Yang
f45ab69462 fix(legacy-table): adjust sort icon position (#399) 2021-11-26 11:46:02 +08:00
Krist Wongsuphasawat
c41297827b v0.11.19 2021-11-26 11:46:01 +08:00
Jianchao Yang
182d112d86 fix(legacy-table): container height on tall headers (#398)
* fix(legacy-table): container height on tall headers

* fix(legacy-table): possible undefined lint error
2021-11-26 11:46:01 +08:00
Krist Wongsuphasawat
2571d516eb v0.11.18 2021-11-26 11:46:01 +08:00
Jianchao Yang
b51674e172 fix(legacy-table-chart): when data is empty (#397) 2021-11-26 11:46:01 +08:00
Krist Wongsuphasawat
d831f3fcd1 v0.11.17 2021-11-26 11:46:01 +08:00
dependabot-preview[bot]
093df00361 build(deps): bump @vx/scale from 0.0.194 to 0.0.195 (#394)
Bumps [@vx/scale](https://github.com/hshoff/vx) from 0.0.194 to 0.0.195.
- [Release notes](https://github.com/hshoff/vx/releases)
- [Changelog](https://github.com/hshoff/vx/blob/master/CHANGELOG.md)
- [Commits](https://github.com/hshoff/vx/compare/v0.0.194...v0.0.195)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2021-11-26 11:46:01 +08:00
Jianchao Yang
51f7667e83 fix(legacy-table): avoid React DOM (#392)
* fix(legacy-table): avoid React DOM

`jquery.datatables` will manipulate DOMs, sometimes remove them. In case
of component being reloaded with updated props, React will not be able
to find those removed nodes, causing a `cannot removeChild` error.

Because of the the way to assign row keys, if table shape changes (add
or remove columns), React may also have difficulty match the cached
nodes via keys.

In general it's a bad idea to directly manipulate React rendered DOM
nodes, so we better just let `jquery.datatables` handle everything.

In the future, once we removed `jquery.datatables`, a pure React
component will not have such issues.

* fix(legacy-table): handle the case when percentMetrics is null

* fix(legacy-table): linting errors

* refactor: use nimbus build

* test(legacy-table): add React component tests

* test(legacy-table): more sophisticated cases

* fix: address PR #392 comments

* chore(legacy-table): clean up tests case setups

Not seeing the console.warn errors anymore. So cleaning it up.

Previously it was from `<SuperChart />` component, but since we have
updated the test case to not use <SuperChart>, we are good now.

* fix(legacy-table): misleading comment
2021-11-26 11:46:01 +08:00
dependabot-preview[bot]
1fb0e40c5d build(deps): bump @vx/responsive from 0.0.194 to 0.0.195 (#386)
Bumps [@vx/responsive](https://github.com/hshoff/vx) from 0.0.194 to 0.0.195.
- [Release notes](https://github.com/hshoff/vx/releases)
- [Changelog](https://github.com/hshoff/vx/blob/master/CHANGELOG.md)
- [Commits](https://github.com/hshoff/vx/compare/v0.0.194...v0.0.195)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2021-11-26 11:46:01 +08:00
Krist Wongsuphasawat
a8b5ffc1cc v0.11.16 2021-11-26 11:46:01 +08:00
Krist Wongsuphasawat
43494f2f41 build: update yarn.lock 2021-11-26 11:46:01 +08:00
Krist Wongsuphasawat
2973c10197 perf: faster legacy table chart (#385)
* feat: faster legacy table chart

This commit tries to optimize the performance of the legacy data table.

1. Converting everything to Typescript.
2. Create a native React component instead of `reactify` (although all
   DOM operaions still happen in the jQuery.DataTables plugin.
3. Remove dependency on d3, optimize how bars are rendered.

Plus some minor changes to fix linting and building.

Also added a script to build only specific plugin for faster
development.

* feat(legacy-table-chart): use React to render DOM

Unfortunately jquery.datatables uses innerHTML to create cell content,
and all rows are created even with pagination.

83657a29e3/media/js/jquery.dataTables.js (L3113-L3117)

This is slow and insecure. We are reverting to DOM data source as in
previous implementation, but instead of using D3 to create the table rows,
we use React. This also renders `dompurify.sanitize` unnecessary since
React will take care of it.

* feat(legacy-table-chart): support html in data cells

Also

1. improve height adjustment
2. add page size control to storybook
3. hide rows from later pages at initial rendering

* fix(legacy-data-table): minor formatting fixes

* chore(legacy-table): add xss dependency

Plus minor variable name and comment update

* fix(legacy-table): linting errors

* refactor(legacy-table): more predictable metric labels

* feat(legacy-table): also display title for percent metric

* fix(legacy-table): typos, var names, etc

* docs: update notes for metric.label

* refactor(legacy-table): upgrade number-format

* fix(legacy-table): upgrade dependency for storybook and yarn
2021-11-26 11:46:00 +08:00
dependabot-preview[bot]
6ae268add2 build(deps): bump csstype from 2.6.8 to 2.6.9 (#374)
Bumps [csstype](https://github.com/frenic/csstype) from 2.6.8 to 2.6.9.
- [Release notes](https://github.com/frenic/csstype/releases)
- [Commits](https://github.com/frenic/csstype/compare/v2.6.8...v2.6.9)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-11-26 11:46:00 +08:00
dependabot-preview[bot]
fb5cc38243 build(deps-dev): bump lint-staged from 10.0.7 to 10.0.8 (#377)
Bumps [lint-staged](https://github.com/okonet/lint-staged) from 10.0.7 to 10.0.8.
- [Release notes](https://github.com/okonet/lint-staged/releases)
- [Commits](https://github.com/okonet/lint-staged/compare/v10.0.7...v10.0.8)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-11-26 11:46:00 +08:00
dependabot-preview[bot]
ac313a8c2e build(deps): bump @vx/axis from 0.0.194 to 0.0.195 (#380)
Bumps [@vx/axis](https://github.com/hshoff/vx) from 0.0.194 to 0.0.195.
- [Release notes](https://github.com/hshoff/vx/releases)
- [Changelog](https://github.com/hshoff/vx/blob/master/CHANGELOG.md)
- [Commits](https://github.com/hshoff/vx/compare/v0.0.194...v0.0.195)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-11-26 11:46:00 +08:00
Krist Wongsuphasawat
3297bdce53 v0.11.15 2021-11-26 11:46:00 +08:00
dependabot-preview[bot]
bb671af906 build(deps): bump dompurify from 2.0.7 to 2.0.8 (#382)
Bumps [dompurify](https://github.com/cure53/DOMPurify) from 2.0.7 to 2.0.8.
- [Release notes](https://github.com/cure53/DOMPurify/releases)
- [Commits](https://github.com/cure53/DOMPurify/compare/2.0.7...2.0.8)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-11-26 11:46:00 +08:00
Krist Wongsuphasawat
751a2c2358 v0.11.14 2021-11-26 11:46:00 +08:00
Krist Wongsuphasawat
00ce00abe2 build: update yarn.lock 2021-11-26 11:46:00 +08:00
Grace Guo
2277583557 fix: add container css for interval type annotation (#372)
* fix: add container css for interval type annotation

* fix undefined case

* make down arrow smaller
2021-11-26 11:46:00 +08:00
dependabot-preview[bot]
4f41e3dfad build(deps-dev): bump fast-glob from 3.1.1 to 3.2.2 (#371)
Bumps [fast-glob](https://github.com/mrmlnc/fast-glob) from 3.1.1 to 3.2.2.
- [Release notes](https://github.com/mrmlnc/fast-glob/releases)
- [Commits](https://github.com/mrmlnc/fast-glob/compare/3.1.1...3.2.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-11-26 11:45:59 +08:00
dependabot-preview[bot]
bca21dd58e build(deps-dev): bump @airbnb/config-eslint from 2.5.1 to 2.5.2 (#365)
Bumps [@airbnb/config-eslint](https://github.com/airbnb/nimbus) from 2.5.1 to 2.5.2.
- [Release notes](https://github.com/airbnb/nimbus/releases)
- [Changelog](https://github.com/airbnb/nimbus/blob/master/CHANGELOG.md)
- [Commits](https://github.com/airbnb/nimbus/compare/@airbnb/config-eslint@2.5.1...@airbnb/config-eslint@2.5.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-11-26 11:45:59 +08:00
dependabot-preview[bot]
f8263c4c1d build(deps): bump @airbnb/lunar from 2.63.1 to 2.64.0 (#367)
Bumps [@airbnb/lunar](https://github.com/airbnb/lunar) from 2.63.1 to 2.64.0.
- [Release notes](https://github.com/airbnb/lunar/releases)
- [Commits](https://github.com/airbnb/lunar/compare/@airbnb/lunar@2.63.1...@airbnb/lunar@2.64.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-11-26 11:45:59 +08:00
dependabot-preview[bot]
86084df4a5 build(deps): bump encodable from 0.2.0 to 0.2.6 (#370)
Bumps [encodable](https://github.com/apache-superset/encodable) from 0.2.0 to 0.2.6.
- [Release notes](https://github.com/apache-superset/encodable/releases)
- [Changelog](https://github.com/apache-superset/encodable/blob/master/CHANGELOG.md)
- [Commits](https://github.com/apache-superset/encodable/compare/v0.2.0...v0.2.6)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-11-26 11:45:59 +08:00
dependabot-preview[bot]
6630d26d18 build(deps-dev): bump terser-webpack-plugin from 2.3.4 to 2.3.5 (#364)
Bumps [terser-webpack-plugin](https://github.com/webpack-contrib/terser-webpack-plugin) from 2.3.4 to 2.3.5.
- [Release notes](https://github.com/webpack-contrib/terser-webpack-plugin/releases)
- [Changelog](https://github.com/webpack-contrib/terser-webpack-plugin/blob/master/CHANGELOG.md)
- [Commits](https://github.com/webpack-contrib/terser-webpack-plugin/compare/v2.3.4...v2.3.5)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-11-26 11:45:59 +08:00
dependabot-preview[bot]
d5059568d2 build(deps): bump @vx/axis from 0.0.193 to 0.0.194 (#363)
Bumps [@vx/axis](https://github.com/hshoff/vx) from 0.0.193 to 0.0.194.
- [Release notes](https://github.com/hshoff/vx/releases)
- [Changelog](https://github.com/hshoff/vx/blob/master/CHANGELOG.md)
- [Commits](https://github.com/hshoff/vx/compare/v0.0.193...v0.0.194)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-11-26 11:45:59 +08:00
dependabot-preview[bot]
cf6fc18735 build(deps): bump @vx/legend from 0.0.193 to 0.0.194 (#357)
Bumps [@vx/legend](https://github.com/hshoff/vx) from 0.0.193 to 0.0.194.
- [Release notes](https://github.com/hshoff/vx/releases)
- [Changelog](https://github.com/hshoff/vx/blob/master/CHANGELOG.md)
- [Commits](https://github.com/hshoff/vx/compare/v0.0.193...v0.0.194)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-11-26 11:45:59 +08:00
dependabot-preview[bot]
37e70f7abe build(deps-dev): bump husky from 4.2.1 to 4.2.3 (#369)
Bumps [husky](https://github.com/typicode/husky) from 4.2.1 to 4.2.3.
- [Release notes](https://github.com/typicode/husky/releases)
- [Changelog](https://github.com/typicode/husky/blob/master/CHANGELOG.md)
- [Commits](https://github.com/typicode/husky/compare/v4.2.1...v4.2.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-11-26 11:45:59 +08:00
dependabot-preview[bot]
ad64d0fb1c build(deps): bump @vx/scale from 0.0.192 to 0.0.194 (#358)
Bumps [@vx/scale](https://github.com/hshoff/vx) from 0.0.192 to 0.0.194.
- [Release notes](https://github.com/hshoff/vx/releases)
- [Changelog](https://github.com/hshoff/vx/blob/master/CHANGELOG.md)
- [Commits](https://github.com/hshoff/vx/compare/v0.0.192...v0.0.194)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-11-26 11:45:59 +08:00
dependabot-preview[bot]
543647a9c1 build(deps-dev): bump @types/jest from 24.9.1 to 25.1.3 (#362)
Bumps [@types/jest](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jest) from 24.9.1 to 25.1.3.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/jest)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-11-26 11:45:59 +08:00
dependabot-preview[bot]
05316a1390 build(deps): bump storybook-addon-jsx from 7.1.2 to 7.1.14 (#352)
Bumps [storybook-addon-jsx](https://github.com/storybookjs/addon-jsx) from 7.1.2 to 7.1.14.
- [Release notes](https://github.com/storybookjs/addon-jsx/releases)
- [Changelog](https://github.com/storybookjs/addon-jsx/blob/master/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/addon-jsx/compare/v7.1.2...v7.1.14)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-11-26 11:45:58 +08:00
dependabot-preview[bot]
a759e1d391 build(deps): [security] bump serialize-javascript from 1.7.0 to 2.1.2 (#347)
Bumps [serialize-javascript](https://github.com/yahoo/serialize-javascript) from 1.7.0 to 2.1.2. **This update includes a security fix.**
- [Release notes](https://github.com/yahoo/serialize-javascript/releases)
- [Commits](https://github.com/yahoo/serialize-javascript/compare/v1.7.0...v2.1.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-11-26 11:45:58 +08:00
dependabot-preview[bot]
b2986c0be5 build(deps): bump @data-ui/theme from 0.0.82 to 0.0.84 (#361)
Bumps [@data-ui/theme](https://github.com/williaster/data-ui) from 0.0.82 to 0.0.84.
- [Release notes](https://github.com/williaster/data-ui/releases)
- [Changelog](https://github.com/williaster/data-ui/blob/master/CHANGELOG.md)
- [Commits](https://github.com/williaster/data-ui/compare/v0.0.82...v0.0.84)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-11-26 11:45:58 +08:00
dependabot-preview[bot]
06067e2cc0 build(deps): bump @vx/group from 0.0.193 to 0.0.194 (#350)
Bumps [@vx/group](https://github.com/hshoff/vx) from 0.0.193 to 0.0.194.
- [Release notes](https://github.com/hshoff/vx/releases)
- [Changelog](https://github.com/hshoff/vx/blob/master/CHANGELOG.md)
- [Commits](https://github.com/hshoff/vx/compare/v0.0.193...v0.0.194)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-11-26 11:45:58 +08:00
dependabot-preview[bot]
30d6a047e3 build(deps): bump @vx/responsive from 0.0.193 to 0.0.194 (#360)
Bumps [@vx/responsive](https://github.com/hshoff/vx) from 0.0.193 to 0.0.194.
- [Release notes](https://github.com/hshoff/vx/releases)
- [Changelog](https://github.com/hshoff/vx/blob/master/CHANGELOG.md)
- [Commits](https://github.com/hshoff/vx/compare/v0.0.193...v0.0.194)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-11-26 11:45:58 +08:00
dependabot-preview[bot]
fe8578c015 build(deps-dev): bump enzyme-to-json from 3.4.3 to 3.4.4 (#348)
Bumps [enzyme-to-json](https://github.com/adriantoine/enzyme-to-json) from 3.4.3 to 3.4.4.
- [Release notes](https://github.com/adriantoine/enzyme-to-json/releases)
- [Changelog](https://github.com/adriantoine/enzyme-to-json/blob/master/CHANGELOG.md)
- [Commits](https://github.com/adriantoine/enzyme-to-json/compare/v3.4.3...v3.4.4)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-11-26 11:45:58 +08:00
dependabot-preview[bot]
c00a8524e7 build(deps): bump @airbnb/lunar from 2.60.1 to 2.63.1 (#356)
Bumps [@airbnb/lunar](https://github.com/airbnb/lunar) from 2.60.1 to 2.63.1.
- [Release notes](https://github.com/airbnb/lunar/releases)
- [Commits](https://github.com/airbnb/lunar/compare/@airbnb/lunar@2.60.1...@airbnb/lunar@2.63.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-11-26 11:45:58 +08:00
dependabot-preview[bot]
9298f9dc21 build(deps-dev): bump @airbnb/config-jest from 2.2.2 to 2.2.3 (#355)
Bumps [@airbnb/config-jest](https://github.com/airbnb/nimbus) from 2.2.2 to 2.2.3.
- [Release notes](https://github.com/airbnb/nimbus/releases)
- [Changelog](https://github.com/airbnb/nimbus/blob/master/CHANGELOG.md)
- [Commits](https://github.com/airbnb/nimbus/compare/@airbnb/config-jest@2.2.2...@airbnb/config-jest@2.2.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-11-26 11:45:58 +08:00
dependabot-preview[bot]
2d509e50b8 build(deps-dev): bump @airbnb/config-prettier from 2.1.1 to 2.1.2 (#354)
Bumps [@airbnb/config-prettier](https://github.com/airbnb/nimbus) from 2.1.1 to 2.1.2.
- [Release notes](https://github.com/airbnb/nimbus/releases)
- [Changelog](https://github.com/airbnb/nimbus/blob/master/CHANGELOG.md)
- [Commits](https://github.com/airbnb/nimbus/compare/@airbnb/config-prettier@2.1.1...@airbnb/config-prettier@2.1.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-11-26 11:45:58 +08:00
dependabot-preview[bot]
55d5fb2e85 build(deps): bump @vx/shape from 0.0.193 to 0.0.194 (#353)
Bumps [@vx/shape](https://github.com/hshoff/vx) from 0.0.193 to 0.0.194.
- [Release notes](https://github.com/hshoff/vx/releases)
- [Changelog](https://github.com/hshoff/vx/blob/master/CHANGELOG.md)
- [Commits](https://github.com/hshoff/vx/compare/v0.0.193...v0.0.194)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-11-26 11:45:58 +08:00
Krist Wongsuphasawat
d3f7ef513a v0.11.13 2021-11-26 11:45:57 +08:00
Krist Wongsuphasawat
aae6e1b643 build: update yarn.lock 2021-11-26 11:45:57 +08:00
Krist Wongsuphasawat
35935d0832 build: fix target browser (#346) 2021-11-26 11:45:57 +08:00
Evan Rusackas
bce43cb1f9 fix: Replace unsafe lifecycle methods (#285)
* fix: rename unsafe lifecycle methods

* fix: use componentDidMount instead of componentWillMount

* fix: refactor multi line chart to use safe lifecycle methods

* style: proper camel case

* style: nixing random commented line
2021-11-26 11:45:57 +08:00
dependabot-preview[bot]
f8cec4dacb build(deps-dev): bump @airbnb/nimbus from 2.2.3 to 2.2.4 (#345)
Bumps [@airbnb/nimbus](https://github.com/airbnb/nimbus) from 2.2.3 to 2.2.4.
- [Release notes](https://github.com/airbnb/nimbus/releases)
- [Changelog](https://github.com/airbnb/nimbus/blob/master/CHANGELOG.md)
- [Commits](https://github.com/airbnb/nimbus/compare/@airbnb/nimbus@2.2.3...@airbnb/nimbus@2.2.4)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-11-26 11:45:57 +08:00
dependabot-preview[bot]
2f665b9bc8 build(deps): bump @storybook/addon-links from 5.0.11 to 5.3.13 (#340)
Bumps [@storybook/addon-links](https://github.com/storybookjs/storybook/tree/HEAD/addons/links) from 5.0.11 to 5.3.13.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v5.3.13/addons/links)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-11-26 11:45:57 +08:00
dependabot-preview[bot]
91602a2d1b build(deps): [security] bump set-value from 0.4.3 to 2.0.1 (#337)
Bumps [set-value](https://github.com/jonschlinkert/set-value) from 0.4.3 to 2.0.1. **This update includes a security fix.**
- [Release notes](https://github.com/jonschlinkert/set-value/releases)
- [Commits](https://github.com/jonschlinkert/set-value/compare/0.4.3...2.0.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-11-26 11:45:57 +08:00
dependabot-preview[bot]
84088cef6b build(deps-dev): bump @types/enzyme from 3.10.4 to 3.10.5 (#338)
Bumps [@types/enzyme](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/enzyme) from 3.10.4 to 3.10.5.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/enzyme)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-11-26 11:45:57 +08:00
dependabot-preview[bot]
ab25b3e4ce build(deps): bump @airbnb/lunar-icons from 2.7.1 to 2.8.1 (#339)
Bumps [@airbnb/lunar-icons](https://github.com/airbnb/lunar) from 2.7.1 to 2.8.1.
- [Release notes](https://github.com/airbnb/lunar/releases)
- [Commits](https://github.com/airbnb/lunar/compare/@airbnb/lunar-icons@2.7.1...@airbnb/lunar-icons@2.8.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-11-26 11:45:57 +08:00