Commit Graph

103 Commits

Author SHA1 Message Date
Erik Ritter dcbffed9bb
[SQL Lab] Lock result set controls to be always visible (#9587) 2020-04-21 12:09:33 -07:00
ʈᵃᵢ 0b999e3b91
[charts] adds new filters ui (#9530)
* [charts] adds new filters ui

* move null check to be more visible

* better filter lists and async filter functionality
2020-04-21 12:04:11 -07:00
Erik Ritter ba691d3a27
Bump superset-ui-connection to 0.12.22 (#9602) 2020-04-21 11:36:01 -07:00
Jesse Yang 2b957a2c1e
Add raw number/integer option to d3 number formats (#9562) 2020-04-20 21:31:47 -07:00
ʈᵃᵢ cb51d7833f
[Build] moves prettier check to separate script (#9591)
* [Build] moves prettier check to separate script

* rename step: eslint -> lint
2020-04-20 15:06:33 -07:00
Evan Rusackas ea27e68ee1
Migrating shared NVD3 controls to new module (#9525)
* proto module

* caught a missed 'freq' unique control

* line_interpolation

* linting

* showLegend

* show_controls

* xAxisLabel

* bottomMargin

* x_ticks_layout

* missed one

* x_axis_format

* yLogScale

* y_axis_bounds

* linting

* nixing yarn lock

* x_axis_showminmax

* xAxisShowminmax control

* richTooltip

* linting, syntax fix

* show_bar_value, bar_stacked

* reduceXticks, yaxislabel

* left_margin, max_bubble_size, y_axis_showminmax

* show_labels

* send_time_range, y_axis_2_format, show_markers, order_bars

* nixing commented imports

* fake controls

* looking up actual controls for comparison.

* adding key to test setup

* controls inventory

* apache junk

* lint 

* ignore null controls

* fixing goofed up spread operation for xAxisFormat config

* lint 

* fixes for errors caused by <hr> element in filterbox controls

* fixing filter controls for 'druid_time_origin', 'granularity', 'granularity_sqla', 'time_grain_sqla'

* getControlsInventory -> getControlsForVizType

* further renaming of chartControlsInventory - > getControlsForVizType

Co-authored-by: David Aaron Suddjian <aasuddjian@gmail.com>
2020-04-17 11:40:50 -07:00
Ville Brofeldt 427d2a05e5
chore: Migrate unique FilterBox controls from controls.jsx (#9566)
* Migrate FilterBox controls from controls.jsx

* Linting
2020-04-17 12:20:32 +03:00
Jesse Yang d8de540e0c
[Build] Collect frontend code coverage from Cypress tests (#9555)
* build: collect code coverage from Cypress

Collect frontend code coverage reports from Cypress tests and add
proper tagging for all tests.

* Fix bash script lint error from shellcheck

* Revert Cypress to 4.3.0 to see if it fixes a failing test
2020-04-16 23:35:01 -07:00
Grace Guo 4a55e1ea3a
[fix] dashboard filter scope bug (#9550) 2020-04-16 15:44:03 -07:00
Jesse Yang d9ebd32485
Bump @superset-ui/legacy-plugin-chart-table to 0.12.14 (#9549) 2020-04-15 14:41:36 -07:00
ʈᵃᵢ 1ccda920fe
[list views] add work-break css for table layouts (#9537) 2020-04-14 22:04:24 -07:00
Jianchao Yang 7b4b0d1c61
[Build] Add Github workflows (#9517)
As an replacement to Travis CI.
2020-04-14 13:38:09 -07:00
Evan Rusackas 6270f7dc24
Importing validators module from superset-ui (#9465)
* importing... this is going to break CI, but there it is.

* adding validator package.

* pluralization - maybe it should be plural, but whatevs

* updating validators to match new exports

* removing old validators

* lintage 

* validateNumeric -> validateNumber

* using legacyValidateInteger, legacyValidateNumber

* linting 

* removing extraneous package lock file
2020-04-14 12:00:25 -07:00
Evan Rusackas f29d0fd9f2
control to turn off table bar-chart backgrounds (#9500)
* control to turn off table bar-chart backgrounds

* flipping enable to disable, to support existing charts

* lint 

* Turn ON to enable (reversing logic)

* bumping big number chart

* ling 
2020-04-13 16:53:50 -07:00
ʈᵃᵢ f90824fa17
[Dashboard] new listview filters & emotion infra (#9462)
* [Dashboard] listview filters to match new design

* use title_or_slug filter

* use ?. operator

* move components to components folder
2020-04-13 13:39:55 -07:00
Bogdan 02b3fb1d63
Add visualization flow to the CTA queries (#9370)
* Visualize after running Ctas query (#4)

* Visualize after running Ctas query.

Stub for table viz

Work on the viz

Add JS functionality for Ctas viz

Add test for the table viz flow

Fix test

Add js test for the ctas viz

* Fix tests

* Resolve comments

* Leverate tmpSchema in the query object

* Fix i18n string

Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
2020-04-11 00:46:46 +03:00
Ville Brofeldt 5ec0192bcc
fix: add lineWidth to Shared_DeckGL.jsx (#9496)
* fix: add lineWidth to Shared_DeckGL.jsx

* linting
2020-04-09 12:47:50 -07:00
Jianchao Yang 5565895819
fix: add explore control tabOverride at the section level (#9495) 2020-04-08 18:26:53 -07:00
Jianchao Yang 36cd5411d0
feat: change default time range in sql lab explore (#9486)
Change from "100 years go" to "no filter".

100 years ago is basically equivalent to no filter, but has
implications on how x-axis is plotted on certain charts (e.g. Big
Number).
2020-04-08 17:39:14 -07:00
Jianchao Yang fd85696378
Upgrade table chart plugin to 0.12.13 (#9493) 2020-04-08 17:30:47 -07:00
David Aaron Suddjian 5e535062da
Filter owners select by text input (#9337)
* filter owners select by text input

* use rison

* fix backend owners filter logic

* use fullname, not username on owners inputs

* fix some tests

* fixing tests

* deterministic tests

* appease linter

* add back search by username

* more comprehensive filter test

* add clarifying text

* formatting...
2020-04-07 09:09:02 -07:00
Evan Rusackas b6bca9f137
Migrating shared DeckGL controls (#9455)
* Missed a couple unique controls!

* new shared module, with filter_nulls export.

* autozoom

* dimension

* nixing unneeded import

* stroke_width

* js_columns

* remaining js_* controls

* cleaning up unused stuff

* legend_format

* exports for prior commit

* legend_position

* line_column

* fill_color_picker

* filled, stroked, stroke_color_picker

* grid_size, extruded

* ... more gridsize

* viewport

* point_radius_fixed, spatial

* multiplier, line_type, line_width

* reverse_long_lat

* lint 
2020-04-06 18:37:25 -07:00
Evan Rusackas 1cdfb829d7
Eslint prefer-object-spread (#9466)
* The rule.

* The result
2020-04-03 17:05:16 -07:00
Evan Rusackas 265a2feb29
Migrating NVD3 Area's stacked_style config (#9454)
* Migrating NVD3 Area's stacked_style config

* test mods

* lint

* nonsense change

* undoing nonsense. Come on GitHub, WORK.
2020-04-03 12:50:28 -07:00
Evan Rusackas cd572334c9
Migrating unique NVD3 viz controls (#9445)
* donut control

* labels outside

* linting

* x_log_scale, pie_label_type

* linting

* line_charts, line_charts_2

* marker_labels

* marker_line_labels, marker_lines, markers

* prefix_metric_with_slice_name, range_labels, ranges

* stacked_style

* Revert "stacked_style"

This reverts commit aae2d418b8f1950fbe32248b62e50a12fbf186bd.

* stacked_style take 2...

* Revert "stacked_style take 2..."

This reverts commit 38b7155f50143684c92a67b2a9fa16f65c269d35.
2020-04-03 12:50:07 -07:00
Evan Rusackas 9e79cf37f8
Migrating unique bigNumber(total) controls (#9440)
* migrating options controls

* lint 

* baby steps...

* shared BigNumber controls file

* capitalization matters
2020-04-02 10:52:32 -07:00
Evan Rusackas c53bc4ddf9
Enforcing linting of LESS (#9356)
* linting some LESS

* enforce linting

* moving font binaries out of stylesheets to fonts folder.

* renaming font specimen sheet directory.
2020-04-02 10:10:10 -07:00
Evan Rusackas c003189d0d
migrating unique controls (#9446) 2020-04-02 09:26:52 -07:00
Jianchao Yang f0f4f7e91d
feat(visualization): add timeRangeFixed to Big Number w/ Trendlines (#9341)
* feat: add timeRangeFixed and increase font size for Big Number chart

* Update package-lock.json
2020-04-01 12:38:56 -07:00
ʈᵃᵢ 893c95521b
fix pagination for list views (#9425) 2020-04-01 09:20:17 -07:00
Grace Guo a9ff51bd61
[fix] dashboard filter indicator no showing single number value (#9401) 2020-03-30 15:05:04 -07:00
Grace Guo ce3031b925
[fix] allow force refresh for No Results chart (#9408) 2020-03-30 15:00:58 -07:00
Jianchao Yang 3d8a2b859e
Build: fix hot reload for charts (#9400)
* Fix hot reload for charts

* Override tsc options for plugins

Plugins will sometimes have their own `tsconfig.json`, which will
interfere with the dev server config if configured inappropriately.

This change makes sure `tsc` (and `ts-loader`) always compiles to
`esnext` modules, so we don't get "Uncaught ReferenceError: exports
is not defined" error.
2020-03-30 09:31:46 -07:00
Evan Rusackas fd227888b6
Mirgrating unique Partition chart controls (#9385)
* mirgrating controls

* specific import
2020-03-27 09:16:36 -07:00
Evan Rusackas 98a26c4f2c
migrating controls (#9373) 2020-03-26 21:32:23 -07:00
Jianchao Yang 77fcc4b6aa
build: use manifest hooks for dev server proxy and fix hot reload for charts (#9333)
* Use manifest hooks for dev server proxy

* Rewrite dashboard/App.jsx to supress Redux error in hot reload

* Update ChartRenderer to allow hot realod in Explore

* Fix hot reload in dashboars as well

* Revert changes to ChartRenderer.jsx

Will submit in another PR.

* Clean up
2020-03-26 16:55:22 -07:00
Evan Rusackas 9fcdc93c06
Migrating horizon controls (#9368)
* migrating unique controls

* linting 
2020-03-26 15:16:07 -07:00
Evan Rusackas b12188ec80
migrating unique controls (#9374) 2020-03-26 15:15:47 -07:00
David Aaron Suddjian cfa786850f
upgrade to react-bootstrap v0.33.1 (#9372)
* upgrade to react-bootstrap v0.33.1

* fix test

* simplify proptypes

Co-Authored-By: Evan Rusackas <evan@preset.io>

* simplify more proptypes

Co-Authored-By: Evan Rusackas <evan@preset.io>

Co-authored-by: Evan Rusackas <evan@preset.io>
2020-03-26 11:16:49 -07:00
Evan Rusackas ccff6be969
Migrating unique BoxPlot controls (#9392) 2020-03-26 09:29:17 -07:00
Evan Rusackas 7e86e38dab
Migrating unique Table controls (#9388) 2020-03-26 09:28:51 -07:00
Evan Rusackas bf0fa84bbc
migrating controls 🎛 (#9386) 2020-03-26 09:28:09 -07:00
Grace Guo 5b07c8d229
[dashboard] handle markdown error (#9350)
* [dashboard] handle markdown error

* localize error message, fix review comments.
2020-03-26 09:06:23 -07:00
ʈᵃᵢ f5cc0ef906
fix: [dashboard] add row padding (#9381) 2020-03-26 08:18:53 -07:00
Evan Rusackas 0061a3ebaf
Migrating unique DirectedForce controls (#9359)
* migrating controls

* Linting 

* oops... meant to pull this out in a conflict resolution.
2020-03-25 19:20:52 -07:00
Grace Guo 4fd5ac9be6
fix a typo in set prop value (#9383) 2020-03-25 16:08:22 -07:00
Grace Guo 6b0f62a36e
[explore view] fix long query issue from Run in SQL LAB Button (#9345)
* [explore view] fix long query issue from Run in SQL LAB Button

* SQL Lab page needs to take the post form data, too

* fix variable names

* updated payload dict, rename hidden form

Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>
2020-03-25 13:15:52 -07:00
Evan Rusackas 634b440c56
fix: don't parseFloat when the *already numeric* value ends in a decimal point (#9351) 2020-03-24 15:34:09 -07:00
Ville Brofeldt fe53555fc2
Migrate unique Heatmap controls (#9360)
* Migrate Heatmap controls

* Lint
2020-03-24 21:43:20 +02:00
Maxime Beauchemin 98a71be80b
feat: [explore] don't save filters inherited from a dashboard (#9340)
* feat: [explore] don't save filters inherited from a dashboard

When navigating to explore from a dashboard context, the current
dashboard filter(s) are passed along to explore so that the context is
kept. So say you're filtering on "country=Romania", in your dashboard
and pivot to explore, that filter is still there and keep on exploring.

Now a common issue is that you'll want to make some tweak to your chart
that are unrelated to the filter, say toggling the legend off for
instance, and then save it. Now you back to your dashboard and even
though you started with an "all countries" dashboard, with a global
filter on country, now that one chart is stuck on "Romania". Typically
you notice this when filtering on something else, say "Italy" and then
that one chart now has two mutually exclusive filters, and show "No data".

Now, the fix is to flag the filter as "extra" (that's the not-so-good internal
name we use for these inherited filters) and make it clear that that
specific filter is special and won't be saved when saving the chart.

* fix build
2020-03-23 23:05:00 -07:00