Commit Graph

4839 Commits

Author SHA1 Message Date
Yongjie Zhao
c79b0d62d0
refactor: create echarts query section (#20445) 2022-06-21 11:38:07 +08:00
Sam Firke
b7eb235440
style(typo): occured -> occurred (#20116)
* Occured -> Occurred

* Occured -> Occurred

* Occured -> Occurred

* Occured - > Occurred

* Update FallbackComponent.tsx

* Update FallbackComponent.tsx

Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com>
2022-06-20 08:49:45 -07:00
Yongjie Zhao
111affdb02
chore: move xaxis to superset-ui (#20438) 2022-06-20 22:36:27 +08:00
Diego Medina
c2f01a676c
fix(dashboard): new created chart did not have high lighted effect when using the permalink of chart share in dashboard (#20411) 2022-06-19 08:17:06 -06:00
Lily Kuang
ab9f72f1a1
fix(embedded): CSV download for chart (#20261)
* move postForm to superset client

* lint

* fix lint

* fix type

* update tests

* add tests

* add test for form submit

* add test for request form

* lint

* fix test

* fix tests

* more tests

* more tests

* test

* lint

* more test for postForm

* lint

* Update superset-frontend/packages/superset-ui-core/test/connection/SupersetClientClass.test.ts

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>

* update tests

* remove useless test

* make test cover happy

* make test cover happy

* make test cover happy

* make codecov happy

* make codecov happy

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
2022-06-17 20:01:08 -07:00
Cody Leff
9f74fb7a84
Skip flaky Cypress test. (#20417) 2022-06-17 10:24:58 -06:00
jiAng
f6f93aad37
fix(cosmetic): cannot find m-r-10 class in superset.less (#20276)
* fix(cosmetic): cannot find m-r-10 class in superset.less

* fix: remove .m-r-10 class and use emotion instead

* Update superset-frontend/src/components/Datasource/CollectionTable.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/components/Datasource/DatasourceEditor.jsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2022-06-17 08:54:27 -03:00
Stephen Liu
fa7f144a68
fix: rm eslint-plugin-translation-vars engine requirement (#20420) 2022-06-17 14:29:57 +08:00
Stephen Liu
b32288fddf
fix(bar-chart-v2): remove marker from bar chart V2 (#20409) 2022-06-17 10:52:26 +08:00
Smart-Codi
a8a6b732e9
adding extra metrics after chart configuration (#20410) 2022-06-16 12:55:14 -06:00
Kamil Gabryjelski
c959d92dd1
feat(plugin-chart-echarts): Support stacking negative and positive values (#20408) 2022-06-16 13:58:58 +02:00
Stephen Liu
1665403484
fix(plugin-chart-pivot-table): color weight of Conditional formatting metrics not work (#20396)
* fix(plugin-chart-pivot-table): color weight of Conditional formatting metrics not work

* fix: test
2022-06-16 12:22:09 +08:00
Reese
498987a1a0
Prevent dataset edit modal closing on click-away in edit mode (#20278) 2022-06-15 14:28:13 -06:00
Michael S. Molina
d6f9fb5af1
chore: Removes unused vars (#20194)
* chore: Removes unused vars

* Fixes lint

* Disables no-unused-vars for the operators
2022-06-15 11:01:45 -03:00
Yongjie Zhao
0a50a9b380
feat: setting limit value when Pie chart switches (#20392) 2022-06-15 21:49:00 +08:00
Yongjie Zhao
7c252d7524
feat: adding truncate metric control on timeseries charts (#20373) 2022-06-15 20:55:10 +08:00
smileydev
df8bb46ee2
fix(fonts): Show the all the A's in our workspace correctly, not funky (#20361)
* fix(fonts): make to fix the issue of broking the Inter font char A

* fix(css & fonts): make to install from npmjs.org
2022-06-15 00:28:54 -06:00
Diego Medina
ead10401e7
fix: A newly connected database doesn't appear in the databases list if user connected database using the 'plus' button (#20363)
* fix: A newly connected database doesn't appear in the databases list if user connected database using the 'plus' button

* PR comments
2022-06-14 17:47:37 -06:00
Phillip Kelley-Dotson
160e674b90
fix: update connection modal to use existing catalog (#20372)
* fix: update connection modal to use existing catalog

* remove console
2022-06-14 15:10:01 -04:00
Kamil Gabryjelski
86f146e217
feat(explore): Implement viz switcher redesign (#20248)
* add icons

* Implement fast viz switcher component

* Remove unnecessary keys from ControlsPanelContainer

* Rename icons

* Add unit tests

* Add licenses

* Fix test

* Change BigNumberWithTrendline to BigNumber

* fix test

* fix test

* Add currently rendered viz tile

* Move View all charts to the right side

* Add license

* Fix imports

* Fix e2e test
2022-06-14 15:20:54 +02:00
John Bodley
c3fdd52697
fix(VERSIONED_EXPORTS): Ensure dashboards and charts adher to the VERSIONED_EXPORTS feature flag (#20368)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2022-06-13 18:39:15 -07:00
Diego Medina
e1532f63ac
fix: query execution time is not fully displayed in bubble icon (#20364) 2022-06-13 14:30:00 -06:00
Michael S. Molina
cb2ffa530f
chore: Removes no-use-before-define warnings (#20298) 2022-06-13 07:44:34 -03:00
Diego Medina
8345eb4644
fix: A newly connected database doesn't appear in the databases list if user connected database using the 'plus' button (#19967)
* fix: A newly connected database doesn't appear in the databases list if user connected database using the 'plus' button

* include onDatabaseAdd on successful import
2022-06-12 22:21:30 +08:00
Lyndsi Kay Williams
c842c9e2d8
feat(explore): Dataset Panel Options when Source = Query II (#20299)
* Created/tested query dataset dropdown

* Add isValidDatasourceType to @superset-ui/core and hide query dropdown

* Removed isValidDatasourceType check

* Remove the rest of isValidDatasourceType check
2022-06-10 09:55:52 -07:00
Cody Leff
d0165b617b
chore(dashboard): update Edit Dashboard side panel tabs (#20337)
* Reorder Dashboard Edit tabs and rename 'Components' tab to 'Layout Elements'.

* Add tests for BuilderComponentPane.

* Fix Cypress tests, capitalization, test nesting.
2022-06-10 12:57:32 -03:00
Stephen Liu
07b4a7159d
fix(chart): chart gets cut off on the dashboard (#20315)
* fix(chart): chart gets cut off on the dashboard

* add some failsafe

* address comment
2022-06-09 22:59:58 +08:00
Kamil Gabryjelski
354a89950c
feat(explore): Denormalize form data in echarts, world map and nvd3 bar and line charts (#20313)
* feat(explore): Apply denormalize form data function to echarts and world map

* Denormalize form data in mixed timeseries

* Add dist bar chart
2022-06-09 11:54:09 +02:00
Yongjie Zhao
d04357c47b
fix: superset-ui/core codes coverage (#20324) 2022-06-09 17:43:42 +08:00
Yongjie Zhao
fd129873ce
feat: multiple results pane on explore and dashboard (#20277) 2022-06-09 09:11:34 +08:00
smileydev
1e5cacda8f
fix(explore): make to fix the issue of explore error broken when see more/less (#20282) 2022-06-08 17:00:08 -06:00
Diego Medina
5bfc95e79e
feat: When editing the label/title in the Metrics popover, hitting Enter should save what you've typed (#19898)
* feature: When editing the label/title in the Metrics popover, hitting Enter should save what you've typed

* Apply emotion templating to input/input labels
2022-06-08 16:52:53 -06:00
Stephen Liu
eab0009101
feat(plugin-chart-echarts): [feature-parity] support extra control for the area chart V2 (#16493)
* feat(echarts): [feature-parity] support extra control

* add extra control for plugin

* refactor: extract ExtraControl

* fix: lint

* fix some problems
2022-06-09 00:59:10 +08:00
Hugh A. Miles II
b6c11f2b97
fix: Alpha are unable to perform a second modification to a Dataset when in Explore (#20296)
* handle payload coming back from save

* address concerns
2022-06-08 16:24:36 +02:00
Reese
a57ed76e72
Fix faulty datetime parser regex (#20290) 2022-06-08 22:02:58 +08:00
Stephen Liu
9f02ff656d
fix(plugin-chart-echarts): [feature-parity] apply button of annotation layer doesn't work as expected (#19761)
* fix(plugin-chart-echarts): [feature-parity] apply button of annotation layer does't work

* fix: lint

* fix: test
2022-06-08 17:06:24 +08:00
Yongjie Zhao
8e46ae5c6a
chore: superset-ui/core code coverage (#20304) 2022-06-08 16:54:30 +08:00
Lyndsi Kay Williams
ba0c37d3df
feat(explore): Frontend implementation of dataset creation from infobox (#19855)
* Frontend implementation of create dataset from infobox

* Fixed sl_dataset type

* Fix test

* Fixed sl_dataset type (forgot to save)

* RTL testing

* Adjusted styling/text on infobox and save dataset modal

* Appease lint

* Make infobox invisible and fix tests

* Remove unnecessary placeholder

* Move types to sql lab

* Moved logic into save dataset modal

* Change DatasourceMeta type to Dataset

* Add ExploreDatasource union type to save dataset modal

* Get user info from redux inside save dataset modal

* Addressed comments

* Adjusting to new query type

* Fixed save dataset in explore and union type

* Added testing

* Defined d for queries

* Remove dataset from SaveDatasetModal

* Clarify useSelector parameter

* Fix dndControls union type

* Fix shared-controls union type

* Fix controlPanel union type

* Move ExploreRootState to explore type file

* Remove unnecessary testing playground

* Move datasource type check in DatasourcePanel to a function

* Make all sqllab Query imports reference @superset-ui/core Query type

* Deconstruct query props in ResultSet

* Fix union type in /legacy-plugin-chart-heatmap/src/controlPanel

* Change SaveDatasetModal tests to RTL

* Cleaned datasourceTypeCheck

* Fix infobox styling

* Fix SaveDatasetModal test

* Fix query fixture in sqllab and Query type in SaveDatasetModal test

* Fix Query type and make test query fixture

* Added columns to Query type, separated results property, created QueryResponse union type, and fixed all types affected

* Fixed a couple missed broken types

* Added ExploreDatasource to SqlLab type file

* Removed unneeded Query import from DatasourcePanel

* Address PR comments

* Fix columnChoices

* Fix all incorrect column property checks

* Fix logic on dndGroupByControl

* Dry up savedMetrics type check

* Fixed TIME_COLUMN_OPTION

* Dried savedMetrics type check even further

* Change savedMetricsTypeCheck to defineSavedMetrics

* Change datasourceTypeCheck to isValidDatasourceType

* Fix Query path in groupByControl

* dnd_granularity_sqla now sorts Query types with is_dttm at the top

* Fixed/cleaned query sort

* Add sortedQueryColumns and proper optional chaining to granularity_sqla

* Move testQuery to core-ui, add test coverage for Queries in columnChoices

* Moved DEFAULT_METRICS to core-ui and wrote a test for defineSavedMetrics

* Add license and clean dataset test object

* Change DatasourceType.Dataset to dataset
2022-06-07 15:03:45 -05:00
Yongjie Zhao
27c3ef1ed5
chore: remove unused codes for samples (#20272) 2022-06-07 21:54:15 +08:00
Phillip Kelley-Dotson
6f0d53eed8
feat: add modfied col and timezone info to schedule col (#20165)
* feat: add modfied and timezone to to schedule col

* test if test works

* udpate test

* fix test
2022-06-06 09:41:06 -07:00
Stephen Liu
5425504231
fix(codecov): improve core code coverage (#20274) 2022-06-06 17:21:23 +08:00
Yongjie Zhao
41f33a38bc
feat: showing results pane in dashboard (#20144) 2022-06-05 23:18:42 +08:00
Yongjie Zhao
7faf874c1b
feat: derived metrics use different line style (#20242) 2022-06-05 21:17:31 +08:00
Yongjie Zhao
dd4b581fb5
feat: standardized form_data (#20010) 2022-06-05 21:05:01 +08:00
jiAng
5c02ab7aaf
fix(cosmetic): Fix Datasource Modal Out Of Box (#20237) 2022-06-03 07:58:32 -06:00
Stephen Liu
80b5578680
feat(superset-ui-core): add feature flag for the analogous colors (#19987)
* feat(superset-ui-core): add feature flag for the color analogous generator

* fix: test
2022-06-03 21:32:32 +08:00
Stephen Liu
766f737728
feat(world-map): support color by metric or country column (#19881)
* feat(world-map): support color by metric or country column

* fix lint

* Update superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/components/RadioButtonControl.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/plugins/legacy-plugin-chart-world-map/src/controlPanel.ts

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/plugins/legacy-plugin-chart-world-map/src/controlPanel.ts

Co-authored-by: Evan Rusackas <evan@preset.io>

* fix lint

Co-authored-by: Evan Rusackas <evan@preset.io>
2022-06-03 21:31:22 +08:00
Diego Medina
0e38c686c6
fix: Support the Clipboard API in modern browsers (#20058)
* fix: Support the Clipboard API in modern browsers

* fix tests

* PR comment

* Improvements
2022-06-03 19:34:00 +08:00
Diego Medina
92057858c2
fix(sql lab): View result button is not showing consistently (#20164) 2022-06-02 22:53:59 -06:00
Yongjie Zhao
a020f75a97
refactor: decouple DataTableControl (#20226) 2022-06-03 09:52:58 +08:00