Antonio Rivero Martinez
07ce33d142
Reports: ( #20753 )
...
- dashboardInfo might be an empty object, in which case we must use the chart info instead so the resourceId is not undefined
2022-07-27 12:33:13 -06:00
AAfghahi
fd611d7653
refactor: Refactor reports for Charts and Dashboards ( #19130 )
...
* bumping shillelagh
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* code dry (#16358 )
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* code dry (#16358 )
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* refactor: Arash/new state report (#16987 )
* code dry (#16358 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* refactor(reports): Arash/refactor reports (#16855 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* code dry (#16358 )
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* refactor: Reports - ReportModal (#16622 )
* refactoring progress
* removed consoles
* Working, but with 2 fetches
* report pickup
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* refactor(reports): Arash/again refactor reports (#16872 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* code dry (#16358 )
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* refactor: Reports - ReportModal (#16622 )
* refactoring progress
* removed consoles
* Working, but with 2 fetches
* it is still not working
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* next changes
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* refactor: Reports code clean 10-29 (#17424 )
* Add delete functionality
* Report schema restructure progress
* Fix lint
* Removed console.log
* fix(Explore): Remove changes to the properties on cancel (#17184 )
* Remove on close
* Fix lint
* Add tests
* fix(dashboard): don't show report modal for anonymous user (#17106 )
* Added sunburst echart
* fix(dashboard):Hide reports modal for anonymous users
* Address comments
* Make prettier happy
Co-authored-by: Mayur <mayurp@kpmg.com>
* fix(explore): Metric control breaks when saved metric deleted from dataset (#17503 )
* Add functionality is now working (#17578 )
* Preset io ch28954 refactor reports (#19129 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* code dry (#16358 )
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* code dry (#16358 )
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* refactor: Arash/new state report (#16987 )
* code dry (#16358 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* refactor(reports): Arash/refactor reports (#16855 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* code dry (#16358 )
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* refactor: Reports - ReportModal (#16622 )
* refactoring progress
* removed consoles
* Working, but with 2 fetches
* report pickup
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* refactor(reports): Arash/again refactor reports (#16872 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* code dry (#16358 )
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* refactor: Reports - ReportModal (#16622 )
* refactoring progress
* removed consoles
* Working, but with 2 fetches
* it is still not working
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* next changes
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* refactor: Reports code clean 10-29 (#17424 )
* Add delete functionality
* Report schema restructure progress
* Fix lint
* Removed console.log
* fix(Explore): Remove changes to the properties on cancel (#17184 )
* Remove on close
* Fix lint
* Add tests
* fix(dashboard): don't show report modal for anonymous user (#17106 )
* Added sunburst echart
* fix(dashboard):Hide reports modal for anonymous users
* Address comments
* Make prettier happy
Co-authored-by: Mayur <mayurp@kpmg.com>
* fix(explore): Metric control breaks when saved metric deleted from dataset (#17503 )
* Add functionality is now working (#17578 )
* refactoring reports
* ready for review
* added testing
* removed user reducer
* elizabeth suggestions
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
Co-authored-by: Mayur <mayurnewase111@gmail.com>
Co-authored-by: Mayur <mayurp@kpmg.com>
Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
* deleted additional folder
* fixing tests
* all but styling
* bumping shillelagh
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* code dry (#16358 )
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* code dry (#16358 )
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* refactor: Arash/new state report (#16987 )
* code dry (#16358 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* refactor(reports): Arash/refactor reports (#16855 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* code dry (#16358 )
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* refactor: Reports - ReportModal (#16622 )
* refactoring progress
* removed consoles
* Working, but with 2 fetches
* report pickup
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* refactor(reports): Arash/again refactor reports (#16872 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* code dry (#16358 )
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* refactor: Reports - ReportModal (#16622 )
* refactoring progress
* removed consoles
* Working, but with 2 fetches
* it is still not working
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* next changes
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* refactor: Reports code clean 10-29 (#17424 )
* Add delete functionality
* Report schema restructure progress
* Fix lint
* Removed console.log
* fix(Explore): Remove changes to the properties on cancel (#17184 )
* Remove on close
* Fix lint
* Add tests
* fix(dashboard): don't show report modal for anonymous user (#17106 )
* Added sunburst echart
* fix(dashboard):Hide reports modal for anonymous users
* Address comments
* Make prettier happy
Co-authored-by: Mayur <mayurp@kpmg.com>
* fix(explore): Metric control breaks when saved metric deleted from dataset (#17503 )
* Add functionality is now working (#17578 )
* Preset io ch28954 refactor reports (#19129 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* code dry (#16358 )
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* code dry (#16358 )
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* refactor: Arash/new state report (#16987 )
* code dry (#16358 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* refactor(reports): Arash/refactor reports (#16855 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* code dry (#16358 )
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* refactor: Reports - ReportModal (#16622 )
* refactoring progress
* removed consoles
* Working, but with 2 fetches
* report pickup
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* refactor(reports): Arash/again refactor reports (#16872 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* code dry (#16358 )
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* refactor: Reports - ReportModal (#16622 )
* refactoring progress
* removed consoles
* Working, but with 2 fetches
* it is still not working
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* next changes
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* refactor: Reports code clean 10-29 (#17424 )
* Add delete functionality
* Report schema restructure progress
* Fix lint
* Removed console.log
* fix(Explore): Remove changes to the properties on cancel (#17184 )
* Remove on close
* Fix lint
* Add tests
* fix(dashboard): don't show report modal for anonymous user (#17106 )
* Added sunburst echart
* fix(dashboard):Hide reports modal for anonymous users
* Address comments
* Make prettier happy
Co-authored-by: Mayur <mayurp@kpmg.com>
* fix(explore): Metric control breaks when saved metric deleted from dataset (#17503 )
* Add functionality is now working (#17578 )
* refactoring reports
* ready for review
* added testing
* removed user reducer
* elizabeth suggestions
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
Co-authored-by: Mayur <mayurnewase111@gmail.com>
Co-authored-by: Mayur <mayurp@kpmg.com>
Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
* deleted additional folder
* fixing tests
* all but styling
* fixed tests
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
Co-authored-by: Mayur <mayurnewase111@gmail.com>
Co-authored-by: Mayur <mayurp@kpmg.com>
Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
2022-05-11 14:19:51 -04:00
Jesse Yang
7b88ec7e25
refactor(ReportModal): simplify state reducer and improve error handling ( #19942 )
2022-05-05 10:06:40 -07:00
Lyndsi Kay Williams
f7add546ad
Fixed error handling in Report modal ( #17988 )
2022-01-10 17:01:08 -06:00
Michael S. Molina
9b17e86b44
chore: Moves messageToasts to the components folder ( #14431 )
...
* chore: Moves messageToasts to the components folder
* Rebases
2021-09-22 07:44:54 -03:00
Lyndsi Kay Williams
518c3c9ae0
test: Functional RTL for email report modal II ( #16148 )
...
* Email Report Modal validation testing
* Starting RTL testing for email report
* Calendar icon now rendering!
* Create report testing in dashboard
* make linter happy
* Fixing weird error
* Removed ExploreChartHeader_spec
* Fixed dashboard header test
* revert changes from merge
* Fix tests
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
2021-08-20 10:08:36 -07:00
Hugh A. Miles II
50d896f1b7
fix: Fix parsing onSaving reports toast when user hasn't saved chart ( #16330 )
...
* don't maniuplate error message
* remove extra idx reference
* u
* change print
* update with test
* add case for dashboards
* fix test
2021-08-19 14:04:23 -04:00
AAfghahi
5ce38839e7
feat: better errors for report in charts and dashboard ( #16131 )
...
* added google alert
* better errors and report actions
2021-08-09 13:32:52 -07:00
AAfghahi
4359650b7d
fix: Adding report bug ( #16065 )
...
* report add fix
* added theme
2021-08-04 11:37:46 -07:00
Elizabeth Thompson
5031a67597
feat: Self subscribe reports ( #16027 )
...
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
2021-08-02 09:12:09 -07:00
