1e88408418
fix: better handle datasource exceptions ( #13578 )
...
* fix: handle datasource injected security exception
* add tests
* fix error text on create update dbs
* fix lint
* revert create update message
* fix test
* add sqlalchemy exceptions
2021-03-15 22:46:51 +00:00
375797f649
feat(native-filters): add timegrain and column filter ( #13484 )
...
* feat(native-filters): add timegrain and column filter
* add fetch values predicate
* bump deps
* lint
* fix test
* add python test for legacy merge
* fix default value and isInitialized to not check strict equality
* Address comments
* add FilterValue type
* address review comments
2021-03-09 17:27:46 +02:00
c3c73763d0
fix: url shortener invalid input ( #13461 )
...
* fix: url shortner invalid input
* fix lint
2021-03-04 20:46:45 +00:00
9e2455aab7
refactor(api): csrf token on the new REST API ( #13212 )
...
* refactor(api): csrf token on the new REST API
* improve OpenAPI spec description
* fix test
* remove public role like has default for all tests
* fix test
2021-02-23 09:50:22 +00:00
3d23adec5e
chore: use shillelagh instead of gsheetsdb ( #13185 )
...
* chore: use shillelagh instead of gsheetsdb
* Fix tests
* Clean up code and remove duplication
* Fix test
* Tighten dep
2021-02-18 09:48:18 -08:00
f2b802978d
fix: bar chart data order ( #12665 )
...
* fix bar chart order
* fix test_explore_json_dist_bar_order
* fix quotes
2021-01-22 12:38:33 +02:00
ad63823d6f
fix: Added message flash when chart with missing dataset is accessed. ( #12468 )
2021-01-18 22:42:03 -08:00
241f380e2e
test: World bank examples ( #12161 )
...
* add world bank data fixture
* fix fixture cleanup, add fixture to dashboard_tests
* apply world bank fixtures, fix tests
* fix fixture typo, dashboard ids
* fix export dashboard metadata
* fix test_export_dashboard_command_key_order
* fix export dash tests, not add row when no orphans
* debug timeout
* fixes after merge
* fix lint
* run pre-commit
* comment test for debug
* fix save.test.js
Co-authored-by: Karol Kostrzewa <karol.kostrzewa@polidea.com>
2021-01-13 14:20:05 -08:00
2ab490a101
test: birth names ( #12226 )
...
* add birth names fixture
* fix birth names related tests
* fix test_import_v0_dataset_cli_export columns order
* fix celery tests drop table
* fix mysql datetime type
* fix mysql typo in charts/api_tests
* refactor
* add licence
* fix use fixture for presto
* fix presto, hive query
* fix flaky metadata
* fix mysql bigint type
* fix run query
* fix hive datatype in metadata
* fix slice owner for cypress
* refactor num_boys num_girls
* fix is_dttm column
* debug logging
* fix query offset
* fix presto ds type in metadata
* fix presto ds type
* clean up debug logging
2021-01-11 05:57:55 -08:00
d2da25a621
refactor: remove queryFields in QueryObject and update chart control configs ( #12091 )
...
* Clean up queryFields
* Clean up unused vars
* Bump chart plugins
* Bringing changes in #12147
2020-12-22 17:10:19 -08:00
4d329071a1
feat(SIP-39): Async query support for charts ( #11499 )
...
* Generate JWT in Flask app
* Refactor chart data API query logic, add JWT validation and async worker
* Add redis stream implementation, refactoring
* Add chart data cache endpoint, refactor QueryContext caching
* Typing, linting, refactoring
* pytest fixes and openapi schema update
* Enforce caching be configured for async query init
* Async query processing for explore_json endpoint
* Add /api/v1/async_event endpoint
* Async frontend for dashboards [WIP]
* Chart async error message support, refactoring
* Abstract asyncEvent middleware
* Async chart loading for Explore
* Pylint fixes
* asyncEvent middleware -> TypeScript, JS linting
* Chart data API: enforce forced_cache, add tests
* Add tests for explore_json endpoints
* Add test for chart data cache enpoint (no login)
* Consolidate set_and_log_cache and add STORE_CACHE_KEYS_IN_METADATA_DB flag
* Add tests for tasks/async_queries and address PR comments
* Bypass non-JSON result formats for async queries
* Add tests for redux middleware
* Remove debug statement
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
* Skip force_cached if no queryObj
* SunburstViz: don't modify self.form_data
* Fix failing annotation test
* Resolve merge/lint issues
* Reduce polling delay
* Fix new getClientErrorObject reference
* Fix flakey unit tests
* /api/v1/async_event: increment redis stream ID, add tests
* PR feedback: refactoring, configuration
* Fixup: remove debugging
* Fix typescript errors due to redux upgrade
* Update UPDATING.md
* Fix failing py tests
* asyncEvent_spec.js -> asyncEvent_spec.ts
* Refactor flakey Python 3.7 mock assertions
* Fix another shared state issue in Py tests
* Use 'sub' claim in JWT for user_id
* Refactor async middleware config
* Fixup: restore FeatureFlag boolean type
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2020-12-10 20:21:56 -08:00
4da47f1635
tests: added fixture with energy usage instead of example ( #11308 )
...
* Added energy usage fixture. Updated dashboard utils and unicode fixture with new method parameters.
* Add energy fixture to tests/access_tests.py
* Add energy fixture to tests/core_tests.py
* Add energy fixture to tests/dashboard_tests.py
* Add energy fixture to tests/datasets/api_tests.py
* Add energy fixture to tests/db_engine_specs/base_engine_spec_tests.py
* Add energy fixture to tests/import_export_tests.py
* Add energy fixture to tests/model_tests.py
* Add energy fixture to tests/query_context_tests.py
* Add energy fixture to tests/security_tests.py
* Add energy fixture to tests/charts/api_tests.py
* Changed formatting of slices' parameters in energy usage fixture
* Removed loading energy udage data from test conf file
* Add energy fixture to tests/databases/api_tests.py
* Fixes after review: removed isort:skip, load_charts->load_energy_charts, removed unused import.
* Added energy fixture to tests/charts/commands_tests.py and retrieving proper Slice by name
* Fixed charts/api_tests.py to use energy_usage from fixtures
* Fixed datasets/commands_tests.py to retrieve dataset by name and use energy_usage fixture
* Changed energy usage data to generated data and fixed chart tests which was checking energy usage data
2020-12-09 12:02:29 -08:00
0396c705d4
chore: Support SET & SHOW commands as read only SQL commands ( #11868 )
...
* Support SET & SHOW commands as read only SQL commands
* Move is_readonly definition into the engine spec
* Rename & use super()
Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
2020-12-03 10:44:11 -08:00
c0224aa928
feat: add certification info to table selector ( #11785 )
2020-11-24 12:13:52 -08:00
01d15f5368
feat(templating): Safer Jinja template processing ( #11704 )
...
* Enable safer Jinja template processing
* Allow JINJA_CONTEXT_ADDONS with SAFE_JINJA_PROCESSING
* Make template processor initialization less magical, refactor classes
* Consolidat Jinja logic, remove config flag in favor of sane defaults
* Restore previous ENABLE_TEMPLATE_PROCESSING default
* Add recursive type checking, update tests
* remove erroneous config file
* Remove TableColumn models from template context
* pylint refactoring
* Add entry to UPDATING.md
* Resolve botched merge conflict
* Update docs on running single python test
* Refactor template context checking to support engine-specific methods
2020-11-17 11:55:47 -08:00
6f69212f28
feat: annotations REST API ( #11344 )
...
* feat(api): annotations and layers CRUD REST API
* lint
* annotations API and tests
* fix openapi spec
* fix openapi spec
* fix openapi spec
* annotations bulk delete
* fix openapi spec
* fix older tests
* fix older tests
* small lint fixes
* layer_id to pk to keep broad coherence on openapi spec
* fix openapi spec
* one more test and validation
* fix test name
* fix test
* fix bulk delete
* add name validation
* annotation uniqueness validation
* lint
* add sorting reqs and tests
* add statsd metrics
* Update superset/annotation_layers/annotations/dao.py
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
* Update tests/core_tests.py
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
* address comments
* address my comment :)
* fix, address comments
* lint
Co-authored-by: riahk <moar.riah@gmail.com>
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2020-10-23 09:41:17 +01:00
d93b1afe79
test: test_cache_logging is not depending on other dashboard ( #11213 )
...
* Changed test_cache_logging to be idempotent and not depending on other data than tested one
* Changed cache uid to be depending on table, not datashource
2020-10-09 09:00:41 -07:00
7b2200437e
fix(test): missing auth on tests ( #10842 )
...
* fix(test): missing auth on tests
* fix mock
* make test login more inline with other tests
2020-09-11 14:28:41 +01:00
4572ebb600
chore: log cache keys to the logs ( #10678 )
...
* Log cache keys to the logs
* Add tests
* Use separate table for the cache keys
* Add migration for the cache lookup table
Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
2020-09-01 09:41:25 -07:00
6ed36552e6
Use test name for the custom macros testing: ( #10695 )
...
:
Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
2020-08-27 13:12:24 -07:00
19a9bcc9c5
chore: ci Initial hive support ( #10593 )
...
* Initial hive support
* Clone hive setup
* Make hive tests work locally
* Debugging presto failure
* sleep in dataset test
* Address comments
* Address comments
* Pin ipython, exclude new pylint rules
Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
2020-08-27 09:49:18 -07:00
502f4db6f9
feature: Adding extra_filters to warm_up_cache ( #10675 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2020-08-25 15:19:34 -07:00
acb00f509c
fix(chart-data-api): assert referenced columns are present in datasource ( #10451 )
...
* fix(chart-data-api): assert requested columns are present in datasource
* add filter tests
* add column_names to AnnotationDatasource
* add assertion for simple metrics
* lint
2020-08-14 20:58:24 +03:00
0071d374da
chore: move load examples to the fixture ( #10545 )
...
* Move load examples to the fixture
* Update tests/celery_tests.py
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
* Address feedback
Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2020-08-10 13:20:19 -07:00
101e5b670b
chore: clean up csv tests ( #10556 )
...
* Clean up csv tests
* Update tests/base_tests.py
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
* Update tests/base_tests.py
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
* import optional
* Fix mypy error
Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2020-08-10 11:22:38 -07:00
fd2d1c58c5
Revert "chore: Cleanup database sessions ( #10427 )" ( #10537 )
...
This reverts commit 7645fc85c3
2020-08-06 15:33:48 -07:00
62b873e3da
feat: welcome presto to the suite of tested databases ( #10498 )
...
* Add presto to the CI
Sample test data
Datetime conversion
Sample test data
Fix tests
* TODO to switch to timestamps
* Address feedback
* Update requirements
* Add TODOs
Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
2020-08-06 12:07:22 -07:00
7645fc85c3
chore: Cleanup database sessions ( #10427 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2020-07-30 23:07:56 -07:00
259a344fd1
test: upload excel ( #10467 )
2020-07-29 12:50:39 -07:00
5fa4680447
feat: update timeout error UX ( #10274 )
2020-07-20 15:32:17 -07:00
84f8a51458
feat: support nulls in the csv uploads ( #10208 )
...
* Support more table properties for the hive upload
Refactor
Add tests, and refactor them to be pytest friendly
Use lowercase table names
Ignore isort
* Use sql params
Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
2020-07-06 13:26:43 -07:00
77b36783e7
s/assertEqual/assertEquals ( #10195 )
...
Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
2020-06-29 16:38:06 -07:00
4e340c8368
feat: Switch from nosetest to pytest ( #10177 )
...
* Switch from nosetest to pytest
Fix schedule tests
Collect pytest coverage
Move pytest config into pytest.ini
Move cov to the pytest.ini
* Append coverage for the 2nd run
* Add coverage to all commands
* Coverage only for tests
* Get coverage from 1 place
* Rename classes to be pytest compatible
* Test coverage for examples and tests
* Max diff to -1
* Explain how to run pytest for the whole project
* Do not append code coverage for the main run
* Do not run coverage on examples
Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
2020-06-29 15:36:06 -07:00
72fc581b15
added explore database for ctas/cvas ( #10174 )
...
Co-authored-by: Jason Davis <@dropbox.com>
2020-06-29 11:13:54 -07:00
9de9e1c19d
feat: Added configuration to SQL Lab results "Explore" button ( #10164 )
...
* added configuration to virtual table explore button
* added description to mixin
* fixed unit tests
Co-authored-by: Jason Davis <@dropbox.com>
2020-06-26 09:54:55 -07:00
410c5be2f8
fix: return slice owners for /user_slices ep ( #10171 )
...
* fix: return slice wowners for /user_slices ep
* put back created_by and changed_by
* improve comment
2020-06-26 18:10:56 +03:00
c544ebd876
fix: Fixed Attribute Error when running core_tests.py ( #10154 )
...
* fix: changed import order to fix core-test error
* reformatted using black
Co-authored-by: Jason Davis <@dropbox.com>
2020-06-24 12:46:38 -07:00
01aede0652
refactor: Break up superset/views/core.py ( #10078 )
...
* Remove unreferenced function from views/core.py
* Remove excess constants from views/core.py
* Extract CssTemplate-related views to their own file from core.py
* Remove duplicate constant declaration and make the constant less racist
* Move free-floating functions in views/core.py to views/utils.py
* Move AccessRequestsModelView out of views/core.py into its own module
* Move health checks and KV ModelView out of core.py and into their own modules
* Move R model view to its own module
* Move after-request header setting to views/base.py from views/core.py
* black
* mypy
* isort
* Fix reference to imported app
* pylint
* Fix some imports
* Add some missing view imports
* Fix a missing import
2020-06-17 13:42:13 -07:00
7504b1cf20
fix: caching on viz with relative time ranges and time compare ( #10061 )
2020-06-16 08:47:35 -07:00
a3393c1bc4
fix: native annotations ( #10037 )
...
* fix: native annotations
* Add test
* Add comment to test
2020-06-12 21:53:26 +03:00
9532bff48f
chore(security): Renaming access methods ( #10031 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2020-06-11 13:12:23 -07:00
54c6ddbdb7
chore(security): Renaming schemas_accessible_by_user ( #10030 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2020-06-11 11:29:43 -07:00
5c4d4f16b3
feat: finalize Word Cloud move to new chart data endpoint ( #9975 )
...
* remove word cloud from viz.py
* Fix Run in SQL Lab
* remove deprecated python tests
* break out legacy endpoint type into function
* Break out exploreChart from exportChart and implement results type
* Fix jest tests and refactor accordingly
* lint
* Rename v1 payload function
* Add dashboard id to v1 chart data request url params
* Add support for domain sharding to v1 chart data request
2020-06-05 14:08:46 +03:00
c4040a2ae0
fix: annotation layer json ( #9915 )
...
* fix: annotation layer json
* attempt to add a test
* [tests] Fixing test
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2020-05-27 09:02:03 -07:00
3e8e441bfc
feat: implement csv upload configuration func for the schema enforcement ( #9734 )
...
* Implement csv upload func for schema enforcement
Implement function controlled csv upload schema
Refactor + fix tests
Fixing hive as well
* Add explore_db to the extras
Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
2020-05-21 13:49:53 -07:00
c7c76c6a99
build: Add python 3.8 to the build matrix ( #9827 )
2020-05-17 14:49:51 -07:00
d02f2d1fa7
feat: return security errors in the SIP-40 format ( #9796 )
2020-05-13 17:10:37 -07:00
83ec7365a7
feat: convert backend chart errors to the new error type ( #9753 )
2020-05-12 18:15:53 -07:00
f07ca7d836
fix(database): test connection error message for module not found ( #9634 )
2020-04-27 09:24:41 +01:00
955a4fe792
[fix] Automatically add relevant Jinja methods to cache key if present ( #9572 )
...
* [fix] Adding URL params to cache key if present
* [cache] Wrapping Jinja methods
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2020-04-24 08:18:22 -07:00
Daniel Vaz Gaspar
Ville Brofeldt
Beto Dealmeida
Karol Kostrzewa
Kasia Kucharczyk
Jesse Yang
Rob DiCiuccio
Bogdan
Erik Ritter
John Bodley
Hossein Torabi
Jason Davis
Will Barrett