Commit Graph

3524 Commits

Author SHA1 Message Date
Grace Guo
a9ef0aeaf5
Revert #5991 (#6035) 2018-10-04 13:43:01 -07:00
timifasubaa
e12d00ae71
log query fetch time (#6033) 2018-10-04 11:13:32 -07:00
yamyamyuo
ab5c910801 [bugfix] Fix Tableviz metrics column disorder (#5566)
* fix metrics disorder

* add tableviz metric order tests

* lint code

* use OrderedDict to avoid metrics disorder

* fix unit test
2018-10-04 08:53:26 -07:00
Krist Wongsuphasawat
df64ecaa18 [cypress] Add integration test for area, pie, pivot_table, world_map, dual_line, sunburst, sankey, big_number, bubble, box_plot, treemap (#5924)
* Add integration test for world map

* add pie chart

* add area

* use should for assertion

* update area test

* update it message

* remove null params

* add pivot tests

* remove urlparams

* add dual_line

* add sunburst test

* add big number

* add sankey

* add bubble

* add box plot

* add treemap tests

* combine all vis under single test
2018-10-03 11:44:38 -07:00
Krist Wongsuphasawat
5c2a7880cc [SIP-6] Migrate visualizations to new directory structure (part 3 - nvd3) (#6006)
* migrate nvd3

* update basicchartinput
2018-10-03 10:18:04 -07:00
Krist Wongsuphasawat
f9344f13df [cypress] Combine multiple tests under visualizations into single test to save running time (#6019)
* add histogram test

* add compare test

* merge all vis tests under single test
2018-10-02 11:31:29 -07:00
Arpit
73882945bf feat: import/export dashboards via cli (#5991)
* feat: import/export dashboards via cli

* style: fixed lint error

* test: added test for import and export util

* test: removing import test as it is causing integrity issues

Import is a wrapper around exist functionality so we can go ahead without a test or mock the actual db operation using https://docs.python.org/3/library/unittest.mock.html

And validate the wrapper operations only.

* test: remove test data file

* test: removed usage of reserved keyword id
2018-10-01 14:02:16 -07:00
Christine Chambers
604524b671 [feat] Feature flag system via config (#5960)
* [feat] Feature flag system via config

Adding a feature flag system that is driven by superset_config.py. This change includes:
- Server side changes to specify a dedicated FEATURE_FLAG dictionary for listing feature flags. E.g.
```
FEATURE_FLAGS = { 'SCOPED_FILTER': true }
```
- Pass the new feature flags to client via bootstrap-data
- Client side changes to inject feature flags into the redux state tree for dashboard, explore view and SqlLab
- Client side refactor/clean up so the feature flags can be properly tested. Also avoid modifying incoming bootstrap data when creating initial state for the redux state tree
- Re-enable tests that were previously disabled for ExploreViewContainer

* Fix lint errors.

* Remove the partial attempt to get reference to src working in tests (so we don't have to write ../../../src and such in tests). This will in a separate PR.
2018-10-01 11:47:06 -07:00
michellethomas
414a4bfc6f Removing the key from cypress build and removing parallel flag (#6005) 2018-09-28 17:24:48 -07:00
Krist Wongsuphasawat
36e2ddd8bf disable dashboard test (#6008) 2018-09-28 16:57:52 -07:00
Krist Wongsuphasawat
4868c00d6d wait and verify one-by-one (#5995) 2018-09-27 14:46:52 -07:00
Krist Wongsuphasawat
2cd9407a50 [SIP-6] Migrate visualizations to new directory structure. (#5949)
* Migrate Chord, Calendar

* Migrate CountryMap

* Add display name and rename Chord.jsx to Chord.js

* migrate Histogram

* add force-directed

* migrate Heatmap

* add horizon

* migrate parallel coordinates

* migrate partition

* migrate pivot table

* migrate rose

* remove react-dom

* migrate Sankey

* migrate sunburst

* migrate table

* migrate treemap

* migrate filterbox

* migrate wordcloud

* add paired t-test

* fix unit test

* remove renaming

* rename fields
2018-09-27 14:39:56 -07:00
Krist Wongsuphasawat
bf9a102d1a Update webpack bundle configuration (#5983)
* add configuration for optimizing webpack

* resolve webpack cli issue

* Update outdated packages

* extract brace as its own chunk

* update comments

* add list of libs to skip parsing

* remove some libs from list

* remove noParse
2018-09-27 12:49:05 -07:00
Krist Wongsuphasawat
0cc0996e92 [cypress] Update dashboard test to remove 10s timeout (#5957)
* Fix dashboard test instead of using fixed 10s timeout

* resolve lint issues
2018-09-27 11:04:55 -07:00
Mạnh Tài
458b2b5970 Explicit set markdown version to >= 3.0 (#5959)
* Explicit set markdown version to >= 3.0

* Pinning
2018-09-26 23:48:13 -07:00
Krist Wongsuphasawat
4c21c65824 Remove lodash.throttle and replace underscore calls with lodash (#5946)
* remove lodash.throttle from dependency

* add babel-plugin-lodash'

* use lodash instead of underscore for isFunction

* switch underscore to lodash

* switch from underscore to lodash flatten

* Remove slugify and use kebabCase from lodash instead
2018-09-26 23:28:57 -07:00
michellethomas
52033cbf2a Pinning a version of click to fix travis (#5975) 2018-09-26 10:04:43 -07:00
Renkai
569f221d9b Add fordeal to superset user list (#5970) 2018-09-25 11:20:29 -07:00
Victor Noël
5811a26101 Constrain the max version of markdown (#5967)
Closes #5958
2018-09-24 11:41:16 -07:00
Krist Wongsuphasawat
6b89b7f8b5 Deprecate getColorFromSchem (#5937) 2018-09-23 12:47:32 -07:00
Junda Yang
4c62494dff fix sqllab querysearch typeahead permission error (#5906) 2018-09-21 13:48:41 -07:00
Krist Wongsuphasawat
0886870cd6 ensure npm run build is in production mode (#5934) 2018-09-21 13:30:16 -07:00
Maxime Beauchemin
70c095b1c0 [deck_polyline] show metric in geohash (#5952)
Also improved security a bit by calling `dompurify.sanitize` down the
stack.
2018-09-21 11:23:21 -07:00
Maxime Beauchemin
a1fa4bc606
[deck_polygon] implement null locations flag (#5948)
* [deck_polygon] implement null locations flag

* Fix unrelated JS test issue
2018-09-20 22:02:28 -07:00
Maxime Beauchemin
f94bda01b4 [bugfix] metrics issue in 'Periodicity Pivot' (#5931) 2018-09-20 21:42:40 -07:00
Maxime Beauchemin
73d1e4596d
[explore] add "View samples" modal to action buttons (#5770)
* [explore] add "View samples" modal to action buttons

Also broke down the `View query` and `View results` as different
request so that viewing the query does not require fetching the results
anymore

* fix js tests

* lint
2018-09-20 13:51:39 -07:00
Maxime Beauchemin
896c2608aa
[docs] iterating to get to ASF compliance on project site (#5923)
* [docs] iterating to get to ASF compliance on project site

https://whimsy.apache.org/pods/project/superset is a place to check on
whether we match the ASF's requirements

* Minor adjustments
2018-09-20 13:51:06 -07:00
Chris Williams
4e788034df
[eslint] add no-only-tests (#5945) 2018-09-20 12:30:39 -07:00
michellethomas
15b10373b9 Adding configuration to cypress to enable dashboard (#5926) 2018-09-20 11:27:28 -07:00
Junda Yang
b6d7d57c40 Add schema level access control on csv upload (#5787)
* Add schema level access control on csv upload

* add db migrate merge point

* fix flake 8

* fix test

* remove unnecessary db migration

* fix flake

* nit

* fix test for test_schemas_access_for_csv_upload_endpoint

* fix test_csv_import test

* use security_manager to check whether schema is allowed to be accessed

* bring security manager to the party

* flake8 & repush to retrigger test

* address comments

* remove trailing comma
2018-09-20 11:21:11 -07:00
Junda Yang
a0e7c176e9 fix sqlab progress bar and status inconsistency (#5848) 2018-09-20 11:20:36 -07:00
Krist Wongsuphasawat
8c83b72ce2 remove .only (#5943) 2018-09-20 10:42:22 -07:00
timifasubaa
00c4c7ec4b
fix csv upload bugs (#5940) 2018-09-20 10:34:15 -05:00
Krist Wongsuphasawat
1e5a02a42d use es6 import (#5938) 2018-09-20 08:12:29 -07:00
Maxime Beauchemin
5b97fe5c0c
Some linting (#5790) 2018-09-20 08:11:43 -07:00
Beto Dealmeida
71f014e9b6
Allow removing legend (#5932) 2018-09-19 13:32:07 -07:00
Maxime Beauchemin
b9e3159f7c
Fix regression around low row limit for CSV exports (#5866)
* Fix regression around low row limit for CSV exports

* fix tests

* Still trying to fix tests
2018-09-19 13:30:25 -07:00
Alek Storm
549328f8f0 Clean up CONTRIBUTING.md: (#5911)
- Reorganize sections for better navigability
- Add table of contents
- Rework frontend assets section for clarity and DRY
- Rework translating section for clarity, add "Add Translations" contribution type
- Move release docs only useful for maintainers to RELEASING.md
- Other miscellaneous improvements
2018-09-19 10:01:51 -07:00
Krist Wongsuphasawat
8fff0d9e8f [SIP-6] Add reactify function and convert world map to new directory structure. (#5893)
* reactify world map

* add createAdaptor

* fix typo

* add schema

* move directory

* remove unnecessary lines

* make setRef a function

* convert keys to camelcase

* add unit test

* update formatting

* add check for displayName

* pass width and height as separate inputs
2018-09-18 23:35:36 -07:00
Maxime Beauchemin
75bc501146
[explore flow] handling duplicated column aliases (#5778)
* [explore flow] handling duplicated column aliases

closes #5739

* lint
2018-09-18 23:17:38 -07:00
Maxime Beauchemin
7448d07e54
[bugfix] ignore history.pushState errors (#5905)
Ignoring history.pushState handling errors as they are impredictable and
crash the application hard.

I'm thinking this may be because the payload object is too big and the
browser is unhappy about it. I'm not sure if the payload/state is ever
used (when hitting back?). The error seem to stop when replacing payload
by an empty object.
2018-09-18 21:52:30 -07:00
Krist Wongsuphasawat
325e7c03b8 [bugfix] De-dup <script> tags. #5883 (#5890)
* Fix adding duplicate script tags.

* add more empty lines

* rename function
2018-09-18 17:50:30 -07:00
michellethomas
8cb734d7e0 Table and dist bar tests (#5901)
* Creating commands to verify codes and slices

* Creating tests for table and dist bar
2018-09-18 16:27:45 -07:00
Chris Williams
42ab1754db
[contributing.md] swap cypress command order (#5921) 2018-09-18 14:37:44 -07:00
Christine Chambers
24be6922fd [refactor] Remove dependency on personal fork of supercluster from mapbox visualizations (#5902)
* [refactor] Remove dependency to personal fork of supercluster from mapbox visualizations

- Update dependency to reference the vanilla supercluster
- Clean up backend api call for mapbox vizzes to ensure a boolean is sent to indicate whether the viz includes custom metric for clustering
- Refactor of mapbox and its cluster overlay components to use vanilla supercluster and its recommeded way for handling clustering based on custom aggregations.
- Allow reclustering within the initial bounds on render in mapbox visualizations (stay true to old behaviors).
- Remove the median aggregation from available cluster label aggregators as there is no memory efficient way to implement this and it is unknown how often this feature is used
- Updating doc to mention the backward incompatible change re median

* Perform the check for has_custom_metric through `not None` to produce a boolean and rename the field reflect it is a boolean.
2018-09-18 12:38:17 -07:00
Krist Wongsuphasawat
19a3319acf [bugfix] Fix percent metric display and check for string columns in table (#5917)
* fix percent metric display

* add empty line

* address string or number check
2018-09-18 10:30:47 -07:00
Krist Wongsuphasawat
f2d64492ef Remove unused functions and jquery dependency (#5868)
* remove unused functions and jquery dependency

* rebase and remove more obsolete functions
2018-09-18 09:52:49 -07:00
Krist Wongsuphasawat
14de28a4f2 [bugfix] Fix color scheme picker (#5891)
* Fix color scheme picker

* fix .value
2018-09-18 09:50:14 -07:00
Christine Chambers
74940e6a16 Fixing linting error in macro_tests (#5918) 2018-09-17 20:29:14 -07:00
Krist Wongsuphasawat
39ef77abc5 Remove jquery usage to highlight sql lab menu (#5907)
* Remove jquery hack

* change filter to find
2018-09-17 11:05:22 -07:00