Commit Graph

218 Commits

Author SHA1 Message Date
Étienne Boisseau-Sierra 3a379af1e7
docs: Detail front-end development instructions (#19870)
* chore: Beautify CONTRIBUTING

Automatically done using the Markdown-All-In-One extension for VSCode:
https://open-vsx.org/extension/yzhang/markdown-all-in-one

Signed-off-by: Étienne Boisseau-Sierra <etienne.boisseau-sierra@unipart.io>

* docs: Detail front-end development instructions

Based on the silly error that led to [this
discussion](https://apache-superset.slack.com/archives/C014LS99C1K/p1650969237848999),
we clarify that when modifying the front-end locally, one should access
the Webpack dev servers, rather than Flask directly, to see the latest
changes take effect.

Signed-off-by: Étienne Boisseau-Sierra <etienne.boisseau-sierra@unipart.io>

* docs: Underline typical workflow

Signed-off-by: Étienne Boisseau-Sierra <etienne.boisseau-sierra@unipart.io>
2022-05-11 10:07:48 -06:00
Josh Soref c32c505742
chore(docs): Spelling (#19675)
* spelling: adding

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: aggregate

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: avoid

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: blacklist

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: cached

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: discontinue

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: exhaustive

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: from

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: github

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: hybrid

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: implicit

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: interim

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: introduced

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: javascript

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: logstash

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: metadata

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: password

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: recommended

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: redshift

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: refactored

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: referencing

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: sqlite

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: the

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: thumbnails

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: undoes

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: very

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>
2022-04-26 13:17:15 -03:00
Norman Hooper 3340f05dd3
Use three backticks for code blocks (#19331) 2022-03-23 17:20:08 -04:00
David Aaron Suddjian 97abc28a1f
chore!: remove `ENABLE_REACT_CRUD_VIEWS` feature flag (permanently enable) (#19231)
* remove ENABLE_REACT_CRUD_VIEWS feature flag

* docs

* deal with problematic tests

* empty test suite

* skip test

* test conditions changed

* removing the tests instead of skipping
2022-03-18 14:00:23 -07:00
Venu Vardhan Reddy Tekula 2a89da2ef1
docs: fix broken links in the documentation (#19235) 2022-03-18 09:42:14 -04:00
Evan Rusackas 4001165f55
chore: updating link to newer viz plugin blog post (#18707)
* chore: updating link to newer viz plugin blog post

* adding official docs link as well.

* another teensy text tweak
2022-02-14 10:12:52 -07:00
Emily Wu f505094835
fix misspelling (#18097) 2022-01-19 15:56:52 -05:00
Ville Brofeldt eeaa57372e
chore: unbreak pip-compile-multi (#17963)
* chore: unbreak pip-compile-multi

* add docs
2022-01-07 15:29:13 +02:00
Brian Nguyen cb0b7a2284
corrected misspelling in percent_metrics (#17856) 2021-12-22 14:02:59 -05:00
Yongjie Zhao dc50578f7f
doc: update contribuing docs (#17754) 2021-12-17 10:34:20 -08:00
Christopher C Fleming 4beaa81de3
docs: Fix typo on line 967 (#17785)
* Line 976 was wakeup, now wake up

* Removed package lock to test environment

* Return original package-lock.json
2021-12-16 21:51:06 -05:00
Beto Dealmeida 4fd6df9ef8
fix: running dev-server on a different port (#17775) 2021-12-16 07:24:41 -08:00
Meitong Qu 71e41315a4
fix: miss-spelling on CONTRIBUTING.md line 1351 (#17760)
* fix miss-spelling on CONTRIBUTING.md line 1351

* added superset-frontend/package-lock.json
2021-12-15 16:01:32 -05:00
Josue Lugaro 12d3079355
chore: fixed spelling error on line 1342 of CONTRIBUTING.md (#17737) 2021-12-13 18:32:01 -05:00
Jason Cahela 67fdeffe34
fixed misspelling of apprear to appear (#17735) 2021-12-13 18:14:18 -05:00
Yongjie Zhao 12f1d914bd
chore: update babel doc (#17679)
* chore: update babel doc

* update .po file

* update translation workflow
2021-12-08 16:36:57 +08:00
Elizabeth Thompson f10bc6d8fe
fix: add fallback and validation for report and cron timezones (#17338)
* add fallback and validation for report and cron timezones

* add logging to exception catch

* Run black

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2021-11-12 12:28:17 -08:00
Will Barrett 8f9cea86fe
docs: Reorder install instructions in CONTRIBUTING.md (#17387) 2021-11-10 12:46:08 +00:00
PApostol 6b1de57207
fix: various typo fixes in MD files (#17309)
* Various typo fixes in MD files

* Undo fixes in CHANGELOG.md to match PR titles

* Update CONTRIBUTING.md

Co-authored-by: Geido <60598000+geido@users.noreply.github.com>

Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
2021-11-09 17:44:10 +02:00
David Aaron Suddjian c734035708
docs: add vscode linter instructions to CONTRIBUTING.md (#17045) 2021-10-11 15:16:43 -07:00
John Bodley 9ef2861fbd
Update CONTRIBUTING.md (#17016) 2021-10-07 10:38:40 -07:00
Geido 271ec6ec75
chore: Select component refactoring - SaveModal - Iteration 5 (#16446)
* Refactor Select

* Fix Cypress

* Reconcile with master

* Use onChange over onSelect

* Reconcile with latest changes

* Update Cypress

* Update Cypress test

* Fix lint
2021-09-27 18:14:58 +03:00
Ville Brofeldt a3413197de
chore: upgrade to Node 16 (#16809)
* chore: upgrade to Node 16

* add docs

* fix test
2021-09-25 07:26:35 +02:00
Michael S. Molina 99d15b25b0
chore: Moves the images folder to the assets folder (#14429)
* chore: Moves the images folder to the assets folder

* Rebases
2021-09-22 10:28:51 -03:00
John Bodley ad87ba3724
docs: Add section about updating Python requirements (#15574) 2021-07-14 07:26:29 +12:00
ofekisr b5119b8dff
refactor(tests): decouple unittests from integration tests (#15473)
* refactor move all tests to be under integration_tests package

* refactor decouple unittests from integration tests - commands

* add unit_tests package

* fix celery_tests.py

* fix wrong FIXTURES_DIR value
2021-07-01 18:03:07 +03:00
Étienne Boisseau-Sierra baf42bc2c5
docs: improve docs on running tests locally (#14102)
* Fix missing items in ToC

Thanks to whatever autoformatting tool was running (:

Signed-off-by: Étienne Boisseau-Sierra <etienne.boisseau-sierra@unipart.io>

* Fix minimal Python version required

Currently Python 3.7 is still supported by Superset — cf.
4b23d0ecca/setup.py (L160)

I assue it is thus safe to run the test with Py3.7.

Signed-off-by: Étienne Boisseau-Sierra <etienne.boisseau-sierra@unipart.io>

* List MySQL/MariaDB as OS dependecy for test

As raised in issue #14052, MySQL (or MariaDB) is required for being able
to install the Python requirements.
(I assume due to `mysqlclient` dependency — cf.
https://github.com/apache/superset/blob/master/requirements/development.txt#L23)

Signed-off-by: Étienne Boisseau-Sierra <etienne.boisseau-sierra@unipart.io>

* Fix which dependencies are installed for tests

To install `tox` (for running the test suite), we want to install the…
testing dependencies, rather than “simply” the local ones.

Note that the `requirements/testing` is a superset of the
`requirements/local`:
https://github.com/apache/superset/blob/master/requirements/testing.txt
vs https://github.com/apache/superset/blob/master/requirements/local.txt

Linked to issue #14052

Signed-off-by: Étienne Boisseau-Sierra <etienne.boisseau-sierra@unipart.io>

* Emphasize how to name demo admin user

Related to #14052

Signed-off-by: Étienne Boisseau-Sierra <etienne.boisseau-sierra@unipart.io>

* Fix max Python version required

Indeed, Python 3.9 isn't yet supported (cf. e.g., issue #14159).

Signed-off-by: Étienne Boisseau-Sierra <etienne.boisseau-sierra@unipart.io>
2021-07-01 14:11:03 +03:00
Ville Brofeldt ab7f31fd85
Revert "refactor(feature_flags configurations): remove redundant additional configuration for default vales (#15425)" (#15448) 2021-06-29 16:52:01 +03:00
Ibrahim Bolarinwa 18f3089fb5
Update CONTRIBUTING.md (#14880)
Description of the extra_filters chart parameter, usage ideas and links to source files.

Co-authored-by: Dirzel <78026187+Dirzel@users.noreply.github.com>
2021-06-28 20:07:11 +03:00
ofekisr 486b8d911f
refactor(feature_flags configurations): remove redundant additional configuration for default vales (#15425) 2021-06-28 16:30:13 +03:00
Erik Ritter 6ed0a3a9e0
chore: update documentation for frontend feature flags (#15093) 2021-06-14 10:46:50 -07:00
stellalc7 448c689988
Fix typo in contributing.md (#15152) 2021-06-14 13:23:51 -04:00
Ke Zhu 9967a5f640
refactor: adopt --app as celery global option (#15053) 2021-06-08 20:18:55 -07:00
Rob DiCiuccio 5776dcb61a
Update docs for GLOBAL_ASYNC_QUERIES_TRANSPORT (#14558) 2021-05-18 11:01:43 -04:00
Bonifacio de Oliveira cd899c5652
fix typo on CONTRIBUTING.md (#14536) 2021-05-11 11:15:32 -07:00
Bawantha Mihiran Rajapaksha 809983d32d
Uptate CONTRIBUTING.md (#13095)
add nvm latest tag --lts
2021-05-10 13:28:32 +03:00
Amit Miran 1faaf199ad
chore(docs): remove .py from db migrate -m (#14331)
no need to state the python extension 
before: add_metadata_column_to_annotation_model.py.py
after: add_metadata_column_to_annotation_model.py
2021-04-26 07:02:02 +03:00
Hugh A. Miles II 01de3096b3
chore: starter make file (#13970)
* starter make file

* yea

* update docs

* lit

* remove venv from comamnds

* venv
2021-04-22 17:54:12 -04:00
Ben Reinhart 1c6173c7ee
feat: Make async query JWT cookie domain configurable (#14007) 2021-04-11 20:33:33 -07:00
Hugh A. Miles II fd201fe834
Update CONTRIBUTING.md (#14025) 2021-04-09 11:57:53 -04:00
Rob DiCiuccio 6a81a7961c
feat: Support feature flag overrides in ephemeral test envs (#14008)
* Add support for feature flag overrides in ephemeral env cmd

* update docs to reference correct config

* Update ephemeral env docs
2021-04-08 11:05:59 -07:00
Alex Simoes 8b9c142e2b
updates load_examples to load-examples (#13897) 2021-04-06 15:30:50 +08:00
cccs-jc 507041e93b
docs: Documenting how to debug Flask app (#13813)
Co-authored-by: cccs-jc <cccs-jc@cyber.gc.ca>
2021-03-31 12:12:11 -06:00
Beto Dealmeida fd63ac3687
chore: Update docs for 1.1 (#13732)
* Update docs for 1.1

* Update CONTRIBUTING.md

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update UPDATING.md

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update UPDATING.md

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update UPDATING.md

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-03-24 19:23:56 -07:00
Cemre Mengu c72c5c735b
docs(contributing): fix backend port (#13770)
8080 -> 8088
2021-03-24 09:18:05 -07:00
Kris Stern abf2c87115
Make preliminary suggested changes to CONTRIBUTING.md (#13643) 2021-03-17 14:57:13 -04:00
Elizabeth Thompson bf424e3351
docs: add file for users to see status of feature flags (#13402)
* add file for users to see status of feature flags

* move comment

* update flags per feedback

* move to subfolder and improve docs

* move CODE_OF_CONDUCT to root
2021-03-16 14:11:17 -07:00
Jesse Yang 5fca19da56
build: check potential db migration conflict for open PRs (#13498) 2021-03-10 16:02:52 -08:00
Rob DiCiuccio b21d2cfcac
build(test env): Shutdown test environments on PR close (#13452)
* Ephemeral env PR close cleanup action

* Add documentation for test envs
2021-03-09 10:19:43 -08:00
Elizabeth Thompson ec286f27c4
add more documentation around python testing and linting (#13365) 2021-03-08 16:45:37 -08:00