Grace Guo
a80453d945
fix: dashboard filter scope bug ( #10114 )
...
* fix: dashboard filter scope bug
* add extra comments per review
2020-06-22 10:18:04 -07:00
Erik Ritter
cb1705fdae
chore: type src/addSlice ( #10127 )
2020-06-22 08:14:27 -07:00
Maxime Beauchemin
cf0f1d568d
style: replace broken glyphs with font-awesome ( #10123 )
...
Glyphicons stopped working recently, not sure why, but let's get rid of
them and double down on font-awesome that we use a lot more in the
codebase. There's only a few instances of glyphicons and they all are
broken ATM.
Also a few other minor style tweaks
2020-06-21 21:38:08 -07:00
Will Barrett
961b55cfba
fix: Visualization settings were lost when editing a datasource from Explore ( #10092 )
2020-06-19 12:55:49 -07:00
Erik Ritter
2e76fbb7e5
chore: type FilterableTable ( #10073 )
2020-06-18 21:57:11 -07:00
Maxime Beauchemin
a6390afb89
style: push bootstrap theme towards SIP-34 styles ( #10056 )
...
* feat: cartel theme
* piling
* more tweaks
* Make things look better
* lint
* fix tests
* paint it black
* tweaks
2020-06-18 15:01:58 -07:00
Phillip Kelley-Dotson
02fee35314
chore(metricoption): remove metricoption and columntypelable dependency ( #10077 )
...
* remove columntypeLabel and metricoptions from superset
* fix lint
* remove old test
* update pakage
* add suggestions
* fix merge conflict
2020-06-17 19:55:17 -07:00
ʈᵃᵢ
c914af0bc4
fix: adds pagination/infinite scroll to owners select in DashboardList and ChartList ( #10035 )
2020-06-17 16:27:21 -07:00
Erik Ritter
987cb6e1fe
chore: type src/dashboard/util/charts ( #10068 )
2020-06-17 12:34:04 -07:00
ʈᵃᵢ
8c012f7941
feat: add more columns and icons to dataset listview ( #10043 )
2020-06-16 17:30:10 -07:00
Ville Brofeldt
ee77707532
feat: add deafult buildQuery for V1 chart data requests ( #10048 )
2020-06-12 07:49:13 -07:00
Lily Kuang
5339d31ed1
feat: implement secondary navigation for datasets ( #9982 )
2020-06-10 11:55:51 -07:00
Ville Brofeldt
56397d75cc
fix: raise error in sqllab when using reserved column name ( #9859 )
2020-06-10 16:32:43 +03:00
Ville Brofeldt
5c4d4f16b3
feat: finalize Word Cloud move to new chart data endpoint ( #9975 )
...
* remove word cloud from viz.py
* Fix Run in SQL Lab
* remove deprecated python tests
* break out legacy endpoint type into function
* Break out exploreChart from exportChart and implement results type
* Fix jest tests and refactor accordingly
* lint
* Rename v1 payload function
* Add dashboard id to v1 chart data request url params
* Add support for domain sharding to v1 chart data request
2020-06-05 14:08:46 +03:00
ʈᵃᵢ
d187d2887e
fix: fetch all owners for dashboard, chart listview filters and properties modal ( #9784 )
2020-06-03 19:57:03 -07:00
Grace Guo
dcac860f3e
feat: [dashboard] notification and warning for auto force refresh ( #9886 )
...
* feat: [dashboard] notification and warning for auto force refresh
* fix review comments
2020-06-03 10:20:56 -07:00
Ville Brofeldt
fc92692f49
feat: implement new version of word cloud ( #9962 )
2020-06-02 19:28:58 +03:00
Ville Brofeldt
38a6bd79da
feat: expand new chart data endpoint coverage ( #9903 )
...
* feat: implement new chart API for additional components
* Fix python tests
* Fix tests
* Fix lint
* fix camel case error in requestParams
* lint
* fix samples row limit
* Add samples row limit to config
* remove unnecessary code
* lint
* Address review comments
2020-06-02 10:47:28 +03:00
Jesse Yang
359ea8825d
fix(react-select): FilterBox focus event and adhoc filter popup height ( #9933 )
...
* fix(react-select): FilterBox focus event and adhoc filter popup height
* Fix flacky cypress test
* Use focus instead of click
2020-05-27 15:15:32 -07:00
Ville Brofeldt
1b72907b18
Revert "feat: bump superset-ui and implement queryFields in formData ( #9908 )" ( #9931 )
...
This reverts commit 2c97e72959
2020-05-27 22:50:14 +03:00
Ville Brofeldt
5ff61048c6
feat: bump sinon to latest ( #9926 )
2020-05-27 19:34:40 +03:00
Ville Brofeldt
2c97e72959
feat: bump superset-ui and implement queryFields in formData ( #9908 )
...
* feat: Bump superset-ui packages for queryFields
* feat: Implement queryField in formData
2020-05-26 10:19:33 -07:00
Grace Guo
e6a55d8858
fix: [dashboard] should not trigger chart refresh when filter not applicable ( #9891 )
...
* fix: [dashboard][filter] should not trigger chart refresh when filter is not applicable
* fix comments
2020-05-26 10:14:12 -07:00
Phillip Kelley-Dotson
333dc8529e
feat: tablechart plugin controls migration ( #9847 )
...
* delete controls
* move columnoption to controls
* update package and remove columnoption
* fix: remove console and fix import
* fix: lint
* update version
* fix last rebase
* fix: lint:
2020-05-21 12:15:02 -07:00
Christian Murphy
a262ea7487
refactor(frontend): move utils to TypeScript ( #9820 )
...
* refactor(frontend): move utils to typescript (#9101 )
* refactor(frontend): don't export interfaces
* test(frontend): update types and test for isValidChild
2020-05-20 14:47:40 -07:00
Jesse Yang
81ab8dd8b4
feat: upgrade react-select and make multi-select sortable ( #9628 )
...
* feat: upgrade react-select v1.3.0 to v3.1.0
Upgrade `react-select`, replace `react-virtualized-select` with a custom
solution implemented with `react-window`.
Future plans include deprecate `react-virtualized` used in other places, too.
Migrate all react-select related components to `src/Components/Select`.
* Fix new list view
* Fix tests
* Address PR comments
* Fix a flacky Cypress test
* Adjust styles for Select in CRUD ListView
* Fix loadOptions for owners select in chart PropertiesModal
TODO: add typing support for AsyncSelect props.
* Address PR comments; allow isMulti in SelectControl, too
* Clean up NaN in table filter values
* Fix flacky test
2020-05-19 16:59:49 -07:00
Grace Guo
5ca6ed716f
[explore view] inline edit slice name should not overwrite ( #9817 )
2020-05-18 22:53:29 -07:00
Grace Guo
d96bb874f2
fix: [filter_box] fix 2 issues in single value filter_box ( #9829 )
...
* fix: [filter_box] fix 2 issues in single value filter_box
* add unit test
* add fix per comments
2020-05-18 21:25:10 -07:00
Phillip Kelley-Dotson
38c57f45ac
feat: partitionchart controls migration ( #9768 )
...
* fix lint error
* fix: import lint error
* pull in latests code
* delete control from plugin registry
* fixing again...
* another fix with rebase...
* commit change
* update packages and fix test
* fix: add ignore to lint error
* fix mr
* fix lint
* fix imports
Co-authored-by: Phillip Kelley-Dotson <pkd@pkd.lan>
2020-05-18 12:48:51 -07:00
Erik Ritter
b36738cf56
fix: use snake_case for error_type ( #9835 )
2020-05-18 12:35:55 -07:00
Ville Brofeldt
7a95c52d61
refactor: simplify getExploreUrl functions ( #9831 )
...
* remove payload from return signature
* Rename function and fix tests
* Lint
* fix tests
* Move useLegacyApi inquiry to exploreUtils
2020-05-18 19:19:05 +03:00
Christian Murphy
b8eaa114ed
feat(frontend): add ability to download dashboard and chart as image ( #9819 )
...
* feat(frontend): add ability to export dashboard and chart as image (#6973 )
* refactor: migrate download image as to typescript
* feature(frontend): download as image updates
add toast message if error occurs.
make generate file stem an internal method.
* refactor(frontend): move default background color to a const
* feat(frontend): wrap download image toast in translate function
2020-05-17 14:50:27 -07:00
Erik Ritter
d02f2d1fa7
feat: return security errors in the SIP-40 format ( #9796 )
2020-05-13 17:10:37 -07:00
Erik Ritter
83ec7365a7
feat: convert backend chart errors to the new error type ( #9753 )
2020-05-12 18:15:53 -07:00
Jesse Yang
13c5b133a9
test(frontend): use absolute path for src imports ( #9761 )
...
* test(frontend): use absolute path for src imports
* Upgrade prettier, fix eslint
2020-05-07 14:18:10 -07:00
David Aaron Suddjian
80f8349018
Query the new chart data api for charts that support it ( #9710 )
...
* calling new chart api (mostly working)
* can't .then when the promise has already been await-ed
* Add handling for v1 API response
* comment
* update word cloud plugin & dependencies
* testing
* try just waiting
* Revert "try just waiting"
This reverts commit 10c092effd
2020-05-07 01:09:28 -07:00
Grace Guo
83b4165e61
[perf logging] Add extra logging for new/editMode dash ( #9745 )
...
* [perf logging] Add extra logging for new/editMode dash
* fix review comments
2020-05-06 09:03:04 -07:00
Maxime Beauchemin
9aabafe9fe
fix: adhoc filter 'equals' doesn't let you save ( #9652 )
...
When altering a filter, when using `equals` or `does not equals`,
the save button is disabled even when it should be enalbed.
2020-05-06 08:38:10 -07:00
Ville Brofeldt
5485eb993c
feat: Add controlGroups to formData ( #9740 )
2020-05-06 14:53:13 +03:00
David Aaron Suddjian
d65d29c810
fix: css prop is now overwhelmed with emotion ( #9742 )
2020-05-05 10:10:56 -07:00
Grace Guo
43eec67291
[table editor] hide Edit Datasource option when no onDatasourceSave ( #9706 )
...
* [table editor] hide Edit Datasource option when no onDatasourceSave
* add !! operator to get truthiness
2020-04-30 17:32:01 -07:00
Erik Ritter
5fb883e279
chore(ts): type getClientErrorObject ( #9693 )
2020-04-30 17:03:31 -07:00
ʈᵃᵢ
f7f60cc75d
[Chart & Dashboard] improve listview filter ui and add expandable list support ( #9651 )
...
* better styling for select filters and search input
* add emotion babel plugin
* add spec for search input
* fix async select, add beeter error messages
* add error boundary around views
* cleanup and lint
* add expandable list to dashboards
* fix emotion babel config
* fix specs
* remove commented out code
* add selected style
* DRY up styles
* add icons
* fix type
* add apache license
* fix svgs
* fix ExpandableList type
* reduce custom css
* lint
2020-04-29 21:54:07 -07:00
Erik Ritter
5d7b13507e
feat(errors): add client scaffolding for custom error messages ( #9677 )
2020-04-29 17:20:31 -07:00
Grace Guo
735dcd2002
[explore view] add partition as adhoc filter option ( #9637 )
...
* [explore view] add partition as adhoc option
* use adhocFilter Simple Tab
* simplify conditional check for custom adhoc filter operator
* add simple unit tests
2020-04-28 23:09:44 -07:00
Natalie Ruhe
9d755bc1ad
[fix] Support APP_ICON_WIDTH configuration parameter in SPA menu ( #9666 )
...
* Expose additional APP_ICON_WIDTH python config variable to ui via app bootstrap for use in Menu
* Update base.py to inclue APP_ICON_WIDTH via bracket notation instead of .get and adjust Menu proptypes to be required.
Co-authored-by: Natalie Ruhe <nruhe@nruhe.attlocal.net>
Co-authored-by: Natalie Ruhe <natalie@preset.io>
2020-04-28 12:59:03 -07:00
Lily Kuang
c474ea848a
[fix] Push browser history on pagination in react listviews ( #9624 )
...
* improve history for query params
* fix: push browser history on pagination in react listviews
* fix spec
Co-authored-by: Tai Dupree <tdupreetan@gmail.com>
2020-04-27 21:37:22 -07:00
Evan Rusackas
5e4c291913
Controls cleanup pass ( #9578 )
...
* migrating date_filter
* normalized control
* filter_configs control
* column_collection control
* time_range_endpoints control
* time_range_fixed control
* url_params control
* cache_timeout control
* annotation_layers control
* color control unused?
* linters rule 🤘
* this should have been deleted earlier
* global_opacity, mapbox_label, mapbox_style, viewport_zoom
* linting
* comparison_type
* contribution control
* log_scale
* show_values
* table_filter
* pandas_aggfunc
* code control
* formatSelectOptions import
* lint
* markup_type control
* lintage
* date_time_format control, linting
* url control, test mods
* min_periods control
* rolling_periods
* rolling_type
* missing lib
* order_desc
* number_format
* link_length
* all_columns_y
* all_columns_x
* normalize_across, select_country, all_columns
* fixing test
* linter-caught dependencies
* waiting
* wait longer!
* utilizing tabOverride for Analytics
* tabOverride for Annotations and Layers
2020-04-24 16:12:26 -07:00
David Aaron Suddjian
f8adfc8fbf
use new @superset-ui/style package for theming ( #9605 )
...
* use new @superset-ui/style package for theming
* fix tests to reference theme
* try adding a wait
2020-04-22 13:13:40 -07:00
ʈᵃᵢ
0b999e3b91
[charts] adds new filters ui ( #9530 )
...
* [charts] adds new filters ui
* move null check to be more visible
* better filter lists and async filter functionality
2020-04-21 12:04:11 -07:00
