Commit Graph

3713 Commits

Author SHA1 Message Date
Conglei 10836ce53c fixed modal close issue (#5865)
* fixed modal close issue

* change Children array to Fragment
2018-09-12 21:28:45 -07:00
Conglei ee89a3eb5e [SIP-6] removed get_data for BigNumber (#5861)
* removed get_data for BigNumber

* removed duplicated condition

* fixed typo
2018-09-12 18:34:21 -07:00
Maxime Beauchemin 80faa8df80
Fix CSS theme flickering on FAB pages (#5880)
Since the recent PRs around webpack 4 and reloading, FAB pages have been
flickering on load, where a themeless Superset is shown for a fraction
of a second until the bootstrap theme gets loaded up.

This addresses it by moving the theme JS to the head section of the html
page.
2018-09-12 17:21:24 -07:00
Krist Wongsuphasawat 620beed867 remove getColorFromScheme in favor of CategoricalColorNamespace.getScale() for histogram (#5878) 2018-09-12 15:39:38 -07:00
Arpit 4121d57d32 fix: Pivot table not sorting formatted numeric column properly (#5709)
* fix: Pivot table not sorting formatted numeric column properly

* refactor(lint): fixed lint error
2018-09-12 15:07:44 -07:00
Krist Wongsuphasawat f482a6cf99 Improve categorical color management (#5815)
* Create new classes for handling categorical colors

* verify to pass existing unit tests

* separate logic for forcing color and getting color

* replace getColorFromScheme with CategoricalColorManager

* organize static functions

* migrate to new function

* Remove ALL_COLOR_SCHEMES

* move sequential colors to another file

* extract categorical colors to separate file

* move airbnb and lyft colors to separate files

* fix missing toFunction()

* Rewrite to support local and global force items, plus namespacing.

* fix references

* revert nvd3

* update namespace api

* Update the visualizations

* update usage with static functions

* update unit test

* add unit test

* rename default namespace

* add unit test for color namespace

* add unit test for namespace

* start unit test for colorschememanager

* add unit tests for color scheme manager

* check returns for chaining

* complete unit test for the new classes

* fix color tests

* update unit tests

* update unit tests

* move color scheme registration to common

* update unit test

* rename sharedForcedColors to parentForcedColors

* remove import
2018-09-12 14:10:26 -07:00
Chris Williams bec0b4cc37
[tests] fix sqllab/TableElement_spec (#5874) 2018-09-12 12:32:46 -07:00
Maxime Beauchemin 367dcdaa7d [time table] fix sorting on missing values (#5863) 2018-09-12 11:21:48 -07:00
Hugh A. Miles II 1e35030a90
[Docs] Running DB migration (#5748)
* Add doc to add new columns

* spelling

* spelling
2018-09-12 07:16:58 -10:00
Krist Wongsuphasawat 166058d95f correctly compute slice width in dashboard (#5867) 2018-09-12 10:05:39 -07:00
michellethomas 657993d609 Moving get_main_db out of tests and into superset utils (#5864) 2018-09-11 22:50:14 -07:00
timifasubaa c82cea3c8d
fix sqllab logging (#5862) 2018-09-11 17:23:44 -07:00
Krist Wongsuphasawat 962eb0860c fix Object.assign try to write to read-only option.style (#5860) 2018-09-11 16:57:11 -07:00
timifasubaa 01212c3755
make access request open new tab (#5859)
* make access request open new tab

* trigger build
2018-09-11 16:18:14 -07:00
Christine Chambers 6df720d873 [bugfix] mapbox pan on filter (#5858)
* Pan mapbox map on query

- Modify the backend to send back the bounds of the points to cluster
- Clean up of mapbox component to derive lat, lon and zoom from the mercator that fitsbounds based on the bounds passed from the backend. This and the computation of clusters are now only done on initial load b/c we are not making queries to the backend on pan/zoom
- A minor clean up of unused props and also making the visual properties panel open by default

* Remove default latitude, longitude and zoom props which are unnecessary for computing the viewport now that it is driven by the bounds from the backend.

* a few small tweaks (rename vars to be sneak case and avoid two extra hash lookups)
2018-09-11 13:33:54 -07:00
michellethomas 6ae285b6f7 Adding line and big number total integration tests (#5846)
* Adding line and big number total integration tests

* Breakout visualization tests into multiple files
2018-09-11 11:03:46 -07:00
Chris Williams 1f6e8b31d2
[dev] fix redux devtools (#5855) 2018-09-11 10:35:52 -07:00
Grace Guo 965c838fbb
update dashboard sidepane title (#5850) 2018-09-11 10:27:46 -07:00
timifasubaa 9a4bba485a
[sqllab]More granular sqllab logging (#5736)
* quote hive column names (#5368)

* create db migration

* use stats_logger timing

* trigger build
2018-09-11 08:52:37 -07:00
Krist Wongsuphasawat ce362f0ad6 [bugfix] fix rows not showing on welcome page (retry) (#5849)
* fix rows not showing on welcome page

* remove test code

* bring filter back

* remove empty line

* remove another empty line

* remove comment
2018-09-11 08:06:18 -07:00
Maxime Beauchemin 73cfcccf05 [bugfix] 'No numeric types to aggregate' in NVD3 chart (#5853) 2018-09-10 23:01:34 -07:00
Maxime Beauchemin 039e7c56d8 [sql lab] handle large ints, prevent overflow (#5829)
* [sql lab] handle large ints, prevent overflow

* Fix tests
2018-09-10 22:16:18 -07:00
Maxime Beauchemin 73db918fbe
Upgrade to React==16.4.1 & Enzyme==3.3.0 (#5359)
* Bumping react==16.4.1 &  enzyme==3.3.0

The upgrade was pretty smooth except for a cryptic message coming
out of react-select around running multiple copies of React. It turns
out the `common` bundle had React and was conflicting with explore and
dashboard apps, only in 16.x. This somehow wasn't a problem in 15.x
outside of the wasted resources.

Running 16.4 should bring in all sorts of perf improvements and features
we've all been waiting for.

https://reactjs.org/blog/2017/09/26/react-v16.0.html

TODO: react-bootstrap-datetimepicker isn't compatible with React 16

* Trying to deprecate react-bootstrap-datetime

* Moving forward

* Reintroducing tests
2018-09-10 14:48:06 -07:00
timifasubaa e35bfba308
add timing to stats logger (#5844) 2018-09-10 10:31:58 -07:00
Beto Dealmeida f740974bf7 Handle "ambiguous durations" (#5785)
* WIP

* Update interface

* Fix truncate

* Improve unit tests

* Improve code

* Use moment.js to parse ISO durations

* Fix typo and React props
2018-09-10 10:28:17 -07:00
Beto Dealmeida 6c9be9d67b Update time filter to use `react-datetime` (#5819)
* Update time filter to use react-datetime

* Clean up code

* Many small fixes and improvements

* Fix small things
2018-09-10 10:27:16 -07:00
Krist Wongsuphasawat 6d573724aa Enable hot module replacement for React via react-hot-loader (#5841)
* Install react-hot-loader

* enable react-hot-reload for Explore, Dashboard, Profile and Sqllab

* enable hmr for welcome page

* enable hmr for welcome page

* enable react hot module replacement for addSlice

* fix lint

* fix Welcome test

* remove eslint comment
2018-09-10 10:15:32 -07:00
Maxime Beauchemin 517fea33b6
[docs] suggest using python3.6 in installation docs (#5834) 2018-09-10 08:48:03 -07:00
Beto Dealmeida 299e20a23f
Fix cache for multiple time comparisons (#5828)
* Fix cache for multiple time comparisons

* Remove simple cache

* Improve docstring
2018-09-07 15:45:28 -07:00
Maxime Beauchemin 4a62ef3ae0
Get 'Test Connection' button to take 'engine_params' into account (#5830) 2018-09-07 14:47:01 -07:00
michellethomas 9f4d67b49b Adding instructions on how to run Cypress in Contributing.md (#5840) 2018-09-07 10:26:51 -07:00
Krist Wongsuphasawat 3f8b970a88 [bugfix] Fix bignumber overflow in dashboard (#5839)
* Move BigNumber to directory.

* fix chart margin in dashboard

* Fix margin and be more conservative about width.
2018-09-06 21:48:41 -07:00
Krist Wongsuphasawat 68e7794daf [SIP-5] Refactor Paired t-test (#5762)
* extract TTestTable into another file.

* Move into directory.

* update proptypes
2018-09-06 16:14:27 -07:00
Krist Wongsuphasawat b284788fd8 [SIP-5] Refactor filterbox (#5789)
* reorganize variables

* bring back datasource

* refactor filter box

* rename constants to all caps and update prop types

* bind this.changeFilter

* update event handler
2018-09-06 16:13:50 -07:00
michellethomas d40ded0be8 Adding simple Cypress tests (#5693)
* Adding simple Cypress tests

* Changing visitChart into multiple commands

* Adding Cypress to tox
2018-09-06 14:55:48 -07:00
Grace Guo 0c98ecb6d1
[dashboard] Add alert on user delete root level tab (#5771) 2018-09-06 10:23:56 -07:00
Maxime Beauchemin 5616d7bdd7
[sql_json] allow not specifying client_id (#5730)
* [sql_json] allow not specifying client_id

We're opening the sql_json endpoint at Lyft to other apps leveraging
Superset as a data-access layer that enforces authentication and our data
access policy.

Currently sql_json requires the client to pass a `client_id` parameter
that uniquely identifies the query, that can then be used for polling
when in async mode. This PR makes it such that you don't have to define
a client_id anymore. It just gets generated when not passed.

* adressing comments
2018-09-05 22:34:24 -07:00
Yongjie Zhao f9977afd83 Update Readme that support Apache Kylin (#5818) 2018-09-05 22:33:03 -07:00
Maxime Beauchemin 98d9fb1e7e
Adding 'Resources' section to the docs (#5823)
* Adding 'Resources' section to the docs

* Join slack entry
2018-09-05 22:30:56 -07:00
Krist Wongsuphasawat 8c2dbad803 fix bug with react-syntax-highlighter import (#5826) 2018-09-05 20:48:34 -07:00
Krist Wongsuphasawat 5eff7a8d6c [SIP-5] Refactor pivot table (#5705)
* extract slice and formData

* rename variables

* update proptypes and add comments
2018-09-05 14:14:12 -07:00
Krist Wongsuphasawat a9952bb449 [SIP-5] Remove unused function #easy-review (#5825)
* remove unused function

* remove comment
2018-09-05 13:46:04 -07:00
Krist Wongsuphasawat dafe0b9961 [SIP-5] Refactor parallel coordinates (#5761)
* Extract slice and formData

* organize imports
2018-09-05 12:59:23 -07:00
Krist Wongsuphasawat bebbdb85d2 [SIP-5] Refactor MapBox (#5783)
* Break MapBox into smaller pieces

* Replace React.createElement with regular jsx

* detach setControlValue

* enable render trigger

* Pass explicit props rather than pass all that exists in payload.data. Also use formData when possible.

* Rename sliceWidth, sliceHeight to width, height. Use deconstructor. Extract function.

* use arrow function

* fix linting and remove css
2018-09-05 12:12:30 -07:00
Krist Wongsuphasawat b461287290 [SIP-5] Refactor and improve histogram (#5758)
* Extract slice and formData

* indent

* update data proptype

* enable theme

* remove legacy code

* rename file

* Add legend

* Implement WithLegend

* align legend items to the right for bottom position

* add line at end of file

* fix linting issues
2018-09-05 12:11:37 -07:00
Krist Wongsuphasawat 2811498ec9 [SIP-5] Refactor calendar chart (#5760)
* remove stroke

* update style and annotate data type

* update prop type

* bring back utc code

* add comments
2018-09-05 10:34:44 -07:00
Krist Wongsuphasawat 0c33f80c1d Enable CSS Hot Module Replacement and optimize css output for production (#5813)
* Enable HMR for css. Use style-loader for development

* optimize css output

* remove mini-css-extract when dev

* change double-quote to single-quote
2018-09-05 09:17:18 -07:00
Christine Chambers a411516ff5 bug: don't show query overlay when panning mapbox maps (#5814)
* bug: don't show query overlay when panning mapbox maps

Since we don't want to prompt user to rerun query every time they pan a map, prevent the query overlay from showing by setting dontRefreshOnChange for viewport_latitude and viewport_longitude controls.

* Prevent query overlay on viewport zoom also.
2018-09-04 18:08:00 -07:00
John Bodley cf12ea0f03
[celery] setting default (#5812) 2018-09-04 17:32:01 -07:00
Krist Wongsuphasawat eb41756e5e Configure webpack-dev-server (#5786)
* setup devserver with correct proxy

* dev server wroking with written manifest

* add comments

* Change webpack to default port 9000 and minor js formatting

* Use hash in development.

* write to disk = true

* Take ports as argument for dev-server

* update instructions

* update instructions

* add devtools

* use mode instead of NODE_ENV

* use minicssextract for prod (like before)

* remove empty line
2018-09-04 10:39:05 -07:00